Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/lib
History
Steve Howell a8f5836ee6 tests: Make soft-reactivation tests readable. 
The `expected` flag was incredibly confusing, as you
couldn't tell from the calling code what you were
actually expecting to happen.

I avoid the context manager idiom in order to force
the callers to create simple helper functions, and
I de-duplicate some code in some places.

I also force the caller to explicitly soft-deactivate
the user with one simple line of code, so that the
person reading the test doesn't have to research
the side effects of the helper. (And I make it
very easy for new authors to follow the practice
going forward.)

This is also somewhat of a prep commit to avoid
the obfuscated use of refresh_from_db.
 		2023-09-18 16:55:06 -07:00
..
markdown python: Delete superfluous parens. 2023-09-13 13:40:19 -07:00
upload ruff: Fix PIE808 Unnecessary `start` argument in `range`. 2023-09-01 14:57:01 -07:00
url_preview ruff: Fix UP032 Use f-string instead of `format` call. 2023-07-19 16:14:59 -07:00
webhooks webhooks: Migrate check_send_webhook_message to use @typed_endpoint. 2023-09-08 08:20:17 -07:00
__init__.py
…
addressee.py users: Directly access id of foreign keys instead of full object. 2023-07-20 10:44:39 -07:00
alert_words.py alert_words: Refactor the code to flush alert_words cache. 2023-06-28 18:03:32 -07:00
async_utils.py
…
attachments.py upload: Rename delete_message_image to use word "attachment". 2023-03-02 16:36:19 -08:00
avatar.py settings: Make DEFAULT_LOGO_URI/DEFAULT_AVATAR_URI use staticfiles. 2023-02-14 17:17:06 -05:00
avatar_hash.py utils: Remove make_safe_digest wrapper. 2023-07-19 10:54:05 -07:00
bot_config.py ruff: Fix UP032 Use f-string instead of `format` call. 2023-08-02 15:58:55 -07:00
bot_lib.py black: Reformat with Black 23. 2023-02-02 10:40:13 -08:00
bot_storage.py python: Import F, Q, QuerySet from their canonical module. 2023-03-05 14:46:28 -08:00
bulk_create.py mypy: Upgrade mypy from 1.4.1 to 1.5.1. 2023-09-07 17:51:42 -07:00
cache.py ruff: Fix PERF401 Use a list comprehension to create a transformed list. 2023-08-07 17:23:55 -07:00
cache_helpers.py models: Fetch "recipient" object when along with "Huddle" object. 2023-08-10 17:35:43 -07:00
camo.py
…
ccache.py python: Delete superfluous parens. 2023-09-13 13:40:19 -07:00
compatibility.py ruff: Fix DTZ004 `datetime.datetime.utcfromtimestamp()`. 2023-01-04 16:25:07 -08:00
context_managers.py
…
create_user.py models: Add a unique index on UserProfile.api_key. 2023-05-19 11:11:04 -07:00
data_types.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
db.py python: Annotate type aliases with TypeAlias. 2023-08-07 10:02:49 -07:00
debug.py black: Reformat with Black 23. 2023-02-02 10:40:13 -08:00
default_streams.py streams: Pass stream_weekly_traffic field in stream objects. 2023-08-06 18:06:42 -07:00
dev_ldap_directory.py
…
digest.py digest: Increase size of stream cache. 2023-09-13 13:25:59 -07:00
display_recipient.py mypy: Improve type checks for user display recipients. 2023-08-10 18:13:43 -07:00
domains.py
…
drafts.py drafts: Migrate drafts to use @typed_endpoint. 2023-09-08 08:20:17 -07:00
email_mirror.py mypy: Improve type checks for user display recipients. 2023-08-10 18:13:43 -07:00
email_mirror_helpers.py
…
email_notifications.py email_notifications: Make stream_id_map optional to build_message_list. 2023-09-13 13:25:59 -07:00
email_validation.py black: Reformat with Black 23. 2023-02-02 10:40:13 -08:00
emoji.py python: Convert translated positional {} fields to {named} fields. 2023-07-18 15:19:07 -07:00
emoji_utils.py emoji: Match emoji sequences in markdown. 2023-08-23 16:18:15 -07:00
event_schema.py invite: Add new setting for "Who can create multiuse invite links". 2023-09-07 14:21:01 -07:00
events.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
exceptions.py api: Add new typed_endpoint decorators. 2023-09-08 08:20:17 -07:00
export.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
external_accounts.py ruff: Fix SIM118 Use `k not in d` instead of `k not in d.keys()`. 2023-07-24 10:39:28 -07:00
fix_unreads.py ruff: Fix PERF401 Use a list comprehension to create a transformed list. 2023-08-07 17:23:55 -07:00
generate_test_data.py ruff: Fix PERF401 Use a list comprehension to create a transformed list. 2023-08-07 17:23:55 -07:00
github.py ruff: Fix RSE102 Unnecessary parentheses on raised exception. 2023-02-04 16:34:55 -08:00
home.py models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
hotspots.py ruff: Fix SIM118 Use `key in dict` instead of `key in dict.keys()`. 2023-01-04 16:25:07 -08:00
html_diff.py html_diff: Fix lxml import. 2023-03-05 14:46:28 -08:00
html_to_text.py widgets: Rename confusing attribute name in `tabbed_sections.py`. 2023-08-31 11:55:28 -07:00
i18n.py
…
import_realm.py invite: Add new setting for "Who can create multiuse invite links". 2023-09-07 14:21:01 -07:00
initial_password.py
…
integrations.py integrations: Extract integration event types returning function. 2023-08-30 15:54:13 -07:00
logging_util.py ruff: Fix PLR1714 Consider merging multiple comparisons. 2023-07-23 15:21:33 -07:00
management.py send_email: Use a consistent order when sending custom emails to users. 2023-09-14 17:16:36 -07:00
mdiff.py node_tests: Move to web/tests. 2023-02-23 16:04:17 -08:00
mention.py mention: Determine @topic mention during message rendering. 2023-07-13 11:34:48 -07:00
message.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
migrate.py coverage: Skip zerver.lib.migrate coverage. 2023-09-11 15:00:37 -07:00
mobile_auth_otp.py
…
muted_users.py muted users: Make file naming consistent. 2023-02-10 15:39:57 -08:00
name_restrictions.py name_restrictions: Update disposable_email_domains usage. 2023-07-19 16:14:59 -07:00
narrow.py narrow: Set a realm_id limit on messages in user searches. 2023-09-11 15:00:37 -07:00
narrow_helpers.py narrow: Split out narrow_helpers. 2023-06-30 11:26:23 -07:00
notes.py
…
notification_data.py python: Delete superfluous parens. 2023-09-13 13:40:19 -07:00
onboarding.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
outgoing_http.py
…
outgoing_webhook.py outgoing_webhook: Respect settings.OUTGOING_WEBHOOK_TIMEOUT_SECONDS. 2023-05-16 07:00:37 -07:00
per_request_cache.py per-request caches: Add per_request_cache library. 2023-08-11 11:09:34 -07:00
presence.py presence: Support null values in UserPresence. 2023-04-26 14:26:47 -07:00
profile.py
…
push_notifications.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
pysa.py
…
queue.py bots: Remove private stream subscriptions on changing bot owner. 2023-08-16 15:37:37 -07:00
rate_limiter.py ruff: Fix PERF102 Using only the keys/values of a dict. 2023-08-07 17:23:55 -07:00
realm_description.py
…
realm_icon.py settings: Make DEFAULT_LOGO_URI/DEFAULT_AVATAR_URI use staticfiles. 2023-02-14 17:17:06 -05:00
realm_logo.py settings: Make DEFAULT_LOGO_URI/DEFAULT_AVATAR_URI use staticfiles. 2023-02-14 17:17:06 -05:00
recipient_users.py models: Remove get_huddle_recipient and use get_or_create_huddle. 2023-08-10 17:35:43 -07:00
redis_utils.py
…
remote_server.py python: Convert translated positional {} fields to {named} fields. 2023-07-18 15:19:07 -07:00
request.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
response.py response: Remove "result: partially_completed" for success responses. 2023-09-18 13:18:24 -07:00
rest.py ruff: Fix RSE102 Unnecessary parentheses on raised exception. 2023-02-04 16:34:55 -08:00
retention.py models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
safe_session_cached_db.py
…
scheduled_messages.py models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
scim.py scim: Add supporting for syncing the user role. 2023-09-15 13:15:45 -07:00
scim_filter.py
…
send_email.py django: Use .exists() instead of .count() when possible. 2023-09-11 15:00:37 -07:00
server_initialization.py invite: Add new setting for "Who can create multiuse invite links". 2023-09-07 14:21:01 -07:00
sessions.py
…
singleton_bmemcached.py requirements: Upgrade Python requirements. 2023-04-03 22:39:21 -07:00
soft_deactivation.py models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
sounds.py
…
sqlalchemy_utils.py
…
storage.py ruff: Fix PLE0101 Explicit return in `__init__`. 2023-02-23 11:47:08 -08:00
stream_color.py
…
stream_subscription.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
stream_topic.py message_send: Handle notifications for UNMUTED topic in a muted stream. 2023-03-06 19:15:45 -08:00
stream_traffic.py stream_traffic: Update get_streams_traffic to return None for zephyr realm. 2023-08-21 15:21:58 -07:00
streams.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
string_validation.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
subdomains.py settings: Allow customization of STATIC_URL. 2023-02-14 17:17:06 -05:00
subscription_info.py ruff: Enable B023 Function definition does not bind loop variable. 2023-09-11 18:03:45 -07:00
templates.py requirements: Upgrade Python requirements. 2023-04-03 22:39:21 -07:00
test_classes.py tests: Make soft-reactivation tests readable. 2023-09-18 16:55:06 -07:00
test_console_output.py requirements: Upgrade Python requirements. 2023-04-25 21:20:33 -07:00
test_data.source.txt
…
test_fixtures.py ruff: Fix ANN204 missing return type annotation for __init__. 2022-11-16 09:29:11 -08:00
test_helpers.py api: Rewrite argument type test for clarity. 2023-09-08 08:20:17 -07:00
test_runner.py python: Replace functools.partial with type-safe returns.curry.partial. 2023-09-11 18:03:45 -07:00
tex.py
…
thumbnail.py
…
timeout.py test_timeout: Skip test_timeout_warn on Python 3.11 for coverage issue. 2023-05-18 11:52:22 -07:00
timestamp.py timestamp: Switch to a slightly faster datetime_to_timestamp. 2023-02-23 12:15:13 -08:00
timezone.py
…
topic.py models: Always search Messages with a realm_id or id limit. 2023-09-11 15:00:37 -07:00
transfer.py uploads: Allow uploads to set storage class. 2023-07-19 16:19:34 -07:00
typed_endpoint.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
types.py settings: Disallow everyone group for new setting. 2023-09-07 14:21:01 -07:00
url_encoding.py narrow urls: Avoid complicated optional types. 2023-08-10 18:13:43 -07:00
url_redirects.py help: Rename edit-or-delete-a-message.md and update links. 2023-08-22 14:50:23 -07:00
user_agent.py
…
user_counts.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
user_groups.py settings: Disallow everyone group for new setting. 2023-09-07 14:21:01 -07:00
user_message.py
…
user_status.py black: Reformat with Black 23. 2023-02-02 10:40:13 -08:00
user_topics.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
users.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
utils.py utils: Remove make_safe_digest wrapper. 2023-07-19 10:54:05 -07:00
validator.py python: Elide unnecessary list wrappers. 2023-09-13 12:41:23 -07:00
widget.py widgets: Fix bug where a new line right after /todo broke rendering. 2023-09-08 15:39:07 -07:00
zcommand.py ruff: Fix UP032 Use f-string instead of `format` call. 2023-08-02 15:58:55 -07:00
zephyr.py
…