Commit Graph

24279 Commits

Author SHA1 Message Date
Eric Eslinger bc21344dc6 popovers: Fix memory leak with old popovers.
This change resets the list_of_popovers array to a new empty array after
hide_all has been called. Prior behavior kept it around, and it kept
pointers to orphaned DOM nodes.

Fixes #8416.
2018-02-16 13:33:06 -08:00
Shubham Padia 9802264302 message-editing: Mark message as read before deleting it.
Fixes most of #8411.

Unread counts in the left sidebar were previously not updated
immediately on message delete.
2018-02-16 12:53:20 -08:00
Brock Whittaker 1dbab6496c landing-page: Change "Help Center" => "Why Zulip".
We have a good "Help Center" section in the footer, where a user
may already expect to look for help/support related requests, so
we can replace the navbar spot there with the "Why Zulip" page link.
2018-02-16 12:43:55 -08:00
Brock Whittaker d30a6c64c3 Revert "Make recipient bar styling more compact and clean."
This reverts commit 8e2d9b8f68.

This adds the arrows back to the recipient bars because even though
it's not our end state, it looks better than the boxy design that we
had in between.
2018-02-16 11:55:00 -08:00
Shubham Dhama a32e1eb913 markdown: Require double-asterisk around all mentions.
This enforces `**` around all the mentions including "at-all" and
"at-everyone" mentions. Hence this makes `@all` and `@everyone`
invalid mentions, resulting into proper syntax for these mentions as
`@**all**` and `@**everyone**` respectively.

Note from tabbott: This removes an old feature/syntax, which made
sense back when @Tim was also a way to mention a user with Tim as
their first name.  Given how nice typeahead is now, the user part of
the feature was removed a while ago; this should have gone at the same
time.

Fixes: #8143.
2018-02-16 11:45:08 -08:00
Tim Abbott 55feafb513 unread_ops: Add a quick comment explaining an interface. 2018-02-16 11:44:41 -08:00
Greg Price 424c887a27 Vagrantfile: Test directly for `lxc-ls`.
This avoids giving the same "no such command" error on Linux machines
that don't have LXC installed as we now avoid on non-Linux.
2018-02-16 11:29:29 -08:00
Vishnu Ks 718b3fcd6a Vagrantfile: Check for OS before patching the lxc-config.
Followup of e68b45d089
Without this vagrant up will fail on Windows.
https://chat.zulip.org/#narrow/stream/development.20help/topic/
Vagrant.20up.20error
2018-02-16 11:29:29 -08:00
Shubham Padia b12a5a2da0 stream settings: Use a bulk query when changing all streams.
This avoids hitting Zulip's rate limits when there are more than 100
streams involved.

Manual testing:
- Changed notification settings for all streams from notifications tab of user settings
- Monitored the network tab to make sure 1 query is being sent
- Checked notification settings of individual streams

Fixes #5898.
2018-02-16 11:28:55 -08:00
Shubham Dhama 152da74e73 typeahead: Fix typeahead ordering for user group mentions.
Previously, a user with "ham" anywhere in their email address would be
sorted before a group whose name starts with "ham", which resulted in
a lot of frustrating when trying to mention groups.

Fixes: #8301.
2018-02-16 10:10:39 -08:00
Eeshan Garg 6206647641 bugdown/api_code_examples: Add support for multiple languages.
This commit modifies the Markdown extension in bugdown/api_code_examples.py
to support rendering code examples in multiple languages by specifying
the language like so:

{generate_code_example(python)|doc.md|example}

This makes us one step closer towards adding support for testable
JavaScript code examples.
2018-02-16 10:07:13 -08:00
Eeshan Garg 73a1f8aa3e api docs: Add comment about why the event queue example isn't tested.
This commit simply adds a comment in zerver/lib/api_test_helpers.py
explaining why it isn't worth the effort to explicitly test the
code example in api/get-events-from-queue.md.
2018-02-16 10:07:13 -08:00
Shubham Padia a4b686297a api: Return anchor in get_messages when use_first_unread_anchor=True.
This may be helpful for some API clients, since it avoids them needed
to do somewhat messy post-processing on the results (the data was
always available via scanning for the first unread message in the result).

Fixes #6244.
2018-02-16 10:06:20 -08:00
Greg Price bb5c44aa50 github: Suggest GIFs too in PR template. 2018-02-16 09:59:22 -08:00
Rohitt Vashishtha f215fbe89c dark-mode: Show dark background in popover while avatar loads. 2018-02-16 07:47:56 -08:00
Vishnu Ks a46e21ee3e bankruptcy: Add UI widget to mark all messages as read.
This is the natural analog of the similar streams UI feature.

Fixes #7585.
2018-02-15 18:01:03 -08:00
Brock Whittaker 395d476435 portico: Temporarily fix CSS compilation bug with `calc` property.
This temporarily fixes a CSS compilation bug with `calc`, that is
outlined in Issue #8403 in the Zulip project.
2018-02-15 17:55:33 -08:00
Tim Abbott b3d37b5412 sendfile: Clean up sendfile settings code. 2018-02-16 05:10:19 +05:30
Aditya Bansal efe8545303 local-uploads: Start running authentication checks on file requests.
From here on we start to authenticate uploaded file request before
serving this files in production. This involves allowing NGINX to
pass on these file requests to Django for authentication and then
serve these files by making use on internal redirect requests having
x-accel-redirect field. The redirection on requests and loading
of x-accel-redirect param is handled by django-sendfile.

NOTE: This commit starts to authenticate these requests for Zulip
servers running platforms either Ubuntu Xenial (16.04) or above.

Fixes: #320 and #291 partially.
2018-02-16 05:06:37 +05:30
Aditya Bansal 6fce1d7834 template_parser: Add parsing support for self closing tags as per HTML5.
In this commit we add support for some tags which are also called
void-elements according to
http://w3c.github.io/html/syntax.html#void-elements to be parsed by
our template parser and get tagged as singleton_html_tags.

Fixes: #8387.
2018-02-15 17:47:43 -05:00
Greg Price 271cfd4d7a translation: Try the new `err_` marking on a handful of messages. 2018-02-15 13:38:09 -08:00
Greg Price 76cc6d8352 translation: Add configuration for a `zulip-test` Transifex project.
Because the Transifex API is hilariously bad at namespacing, this will
work for uploading to any project with its "slug" set to `zulip-test`
that you have access to; for me, this is a fresh test project I
created in my own personal Transifex organization.

To use, just follow the command in `tools/push-translations`, but
s/zulip/zulip-test/g.
2018-02-15 13:38:09 -08:00
Greg Price b0b0777cd0 translation: Make new tagmessages script a bit easier to run.
Now executable! Just run `tools/tagmessages`.

Also, get the username and password from a `.transifexrc` file.

And hardcode the project slug to `zulip-test` rather than to `zulip`;
the Transifex API is bad at namespacing, so this makes it possible to
run this script on a test project (the only way we're currently using
it) even for people like me who can also upload to the real Zulip
project on Transifex.
2018-02-15 13:38:09 -08:00
Greg Price c4285ef4a7 gitignore: Ignore a Transifex secrets file.
This makes it easier to keep one's .transifexrc in the Zulip working
tree, instead of (or shadowing one in) one's homedir.
2018-02-15 13:38:09 -08:00
Robert Hönig ebf79427ca translation: Add script to tag strings in Transifex.
For now, tags are only used for backend translations with django.
2018-02-15 13:38:09 -08:00
Robert Hönig b9c6cd19f7 translation: Mark error strings in django.po files.
In `django.po`, strings are marked with comments specifying the
type of string.
2018-02-15 11:12:42 -08:00
Greg Price 8d98ce1648 errors: Note upstream fix for that Django DisallowedHost bug. 2018-02-15 10:37:29 -08:00
Umair Khan e68b45d089 lxc: Fix lxc-config file from vagrant-lxc for LXC 2.1.0.
Fixed by greg to act only on version 2.1.0, not later; and
rewrote comment.

Fixes #7838.
2018-02-14 14:06:37 -08:00
Greg Price 6424b3c7b9 github: Add a short template for pull requests.
Hopefully this will help communicate our expectations right up front
for new contributors, with a minimum of boilerplate or busywork.
2018-02-14 13:38:38 -08:00
Vishnu Ks 2102d962a5 version: Bump version to facilitate dependency upgrade. 2018-02-14 09:44:26 -08:00
Vishnu Ks a1db814e4e requirements: Upgrade python-digital-ocean to 1.13.2. 2018-02-14 09:44:26 -08:00
Vishnu Ks caaa7d1b82 requirements: Upgrade ndg-httpsclient to 0.4.4. 2018-02-14 09:44:26 -08:00
Vishnu Ks 18436c100a requirements: Upgrade google-api-python-client to 1.6.5. 2018-02-14 09:44:25 -08:00
Vishnu Ks f93f1972e9 requirements: Upgrade certifi to 2018.1.18. 2018-02-14 09:41:49 -08:00
Vishnu Ks 026d835d3a requirements: Upgrade twilio to two. 2018-02-14 09:41:49 -08:00
Vishnu Ks 88e73c9677 requirements: Upgrade transifex-client to 0.12.5. 2018-02-14 09:41:49 -08:00
Vishnu Ks adac6c0cf2 requirements: Upgrade tornado to 4.5.3. 2018-02-14 09:41:49 -08:00
Vishnu Ks 9effe27eab requirements: Upgrade typing to 3.6.4. 2018-02-14 09:41:49 -08:00
Vishnu Ks 3f3f876187 requirements: Upgrade stripe to 1.77.2. 2018-02-14 09:41:49 -08:00
Vishnu Ks 416338c9b6 requirements: Upgrade Sphinx to 1.7.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks 351f780ab2 requirements: Upgrade Scrapy to 1.5.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks 48f93a7460 requirements: Upgrade pytz to 2018.3. 2018-02-14 09:41:49 -08:00
Vishnu Ks 0aa6f00cf2 requirements: Upgrade pyasn1 to pyasn1-modules. 2018-02-14 09:41:49 -08:00
Vishnu Ks f1098a77f2 requirements: Upgrade polib to 1.1.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks ab7695879a requirements: Upgrade pip-tools to 1.11.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks 2b081f882a requirements: Upgrade Pillow to 5.0.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks 0e2058ae48 requirements: Upgrade pika to 0.11.2. 2018-02-14 09:41:49 -08:00
Vishnu Ks 31abe1a6f8 requirements: Upgrade moto to 1.2.0. 2018-02-14 09:41:49 -08:00
Vishnu Ks 3780b8ce04 requirements: Upgrade Markdown to 2.6.11. 2018-02-14 09:41:49 -08:00
Vishnu Ks 6ca3f72e6e requirements: Upgrade lxml to 4.1.1. 2018-02-14 09:41:49 -08:00