Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stream settings: Use a bulk query when changing all streams. 

This avoids hitting Zulip's rate limits when there are more than 100
streams involved.

Manual testing:
- Changed notification settings for all streams from notifications tab of user settings
- Monitored the network tab to make sure 1 query is being sent
- Checked notification settings of individual streams

Fixes #5898.
This commit is contained in:
Shubham Padia 2018-02-14 19:23:10 +05:30 committed by Tim Abbott
parent 152da74e73
commit b12a5a2da0
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/stream_edit.js
View File

@ -263,22 +263,31 @@ function stream_home_view_clicked(e) {
}
}
exports.set_stream_property = function (sub, property, value) {
// TODO: Fix backend so it takes a stream id.
var sub_data = {stream_id: sub.stream_id, property: property, value: value};
exports.bulk_set_stream_property = function (sub_data) {
return channel.post({
url: '/json/users/me/subscriptions/properties',
data: {subscription_data: JSON.stringify([sub_data])},
timeout: 10*1000,
data: {subscription_data: JSON.stringify(sub_data)},
timeout: 10*1000,
});
};
exports.set_stream_property = function (sub, property, value) {
var sub_data = {stream_id: sub.stream_id, property: property, value: value};
exports.bulk_set_stream_property([sub_data]);
};
exports.set_notification_setting_for_all_streams = function (notification_type, new_setting) {
var sub_data = [];
_.each(stream_data.subscribed_subs(), function (sub) {
if (sub[notification_type] !== new_setting) {
exports.set_stream_property(sub, notification_type, new_setting);
sub_data.push({
stream_id: sub.stream_id,
property: notification_type,
value: new_setting,
});
}
});
exports.bulk_set_stream_property(sub_data);
};
function redraw_privacy_related_stuff(sub_row, sub) {