7e3735b9ba
node_tests: Don’t read page_params from deprecated global variable.
...
Follow up to commit 89aa3155a9#17262 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 19:46:42 -08:00
be9ae9dac8
js: Don't escape "Last active" in buddy list.
...
This breaks the French translation, and is incorrect in general.
2021-02-22 16:08:25 -08:00
0b736ef4cf
puppet: Remove puppet_ops configuration for separate loadbalancer host.
2021-02-22 16:05:13 -08:00
279c4b0e24
puppeteer_tests: Port to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
cdff4cfe53
dependencies: Add ts-node.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
3869727655
dependencies: Upgrade puppeteer from 7.0.4 to 7.1.0.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
8dec7b9270
puppeteer_lib: Use class fields.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
42f4156b36
test-js-with-puppeteer: Error on unhandled promise rejections.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
912c5a28f2
puppeteer_tests: Replace deprecated jQuery event trigger shorthand.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
87e95f43c9
puppeteer_tests: Prefix selector with missing #.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
ad540dac3a
puppeteer_lib: Supply missing $eval arugment.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
72142273c0
puppeteer_tests: Remove buggy assert_selector_doesnt_exist helper.
...
It was checking whether the selector string is itself null, not
whether it selects anything!
Use page.waitForSelector(…, {hidden: true}) instead.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 16:03:10 -08:00
0ca543396a
zjsunit: Use clear_zulip_refs as the main way to undo zrequire.
...
Move clear_zulip_refs into restore, and rewrite it without lodash. We
no longer need the requires array, and zrequire is now nothing more
than a wrapper around require.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 10:53:49 -08:00
7011f0911d
node_tests: Fix misspelled pm_conversation global.
...
It’s pm_conversations.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-22 10:17:03 -08:00
ff3175f8a2
lightbox: Export method for testing purposes.
...
We weren't exercising this method in any
meaningful way during the tests, and when
do add coverage, we probably want to just
test it directly.
We also kill off stub_selector(), which was
never well-documented.
2021-02-22 12:38:07 -05:00
aed5b65525
node tests: Avoid use of stub_selector.
...
We will eliminate this soon.
2021-02-22 12:38:07 -05:00
d62ef78e9c
node tests: Avoid stub_selector() in activity tests.
2021-02-22 12:38:07 -05:00
42c2c9fb2d
zjquery: Avoid array-related hacks.
...
Callers can either explicitly pass in children,
stub out $(...)[0] as needed, or just
circumvent jQuery complications with override.
Note the reactions test was broken before,
since $(...)[0] was always returning the same
stub.
2021-02-22 12:38:07 -05:00
2b8921bf67
zjquery: Tell user why using tags as selector is invalid.
...
Like using $('input') is too broad a selector and shouldn't
be used in the codebase. With this error messages, contributors
can easily understand that now.
2021-02-22 10:24:59 -05:00
269457c58b
zjquery: Extract func to verify selector.
2021-02-22 10:24:59 -05:00
914533c8bc
zjsunit: Prevent common mistakes with overrides.
...
We only allow you to replace functions with functions,
unless you have used set_global() or are dealing
with $ from zjquery.
2021-02-22 10:04:29 -05:00
5caee967d3
zjquery: Remove bogus after/before functions.
2021-02-22 10:04:29 -05:00
132e67cb28
zjquery: Prohibit extensions to $.fn.
...
We make an exception for the popovers code.
Luckily it's pretty rare that we extend $.fn
in our real code.
2021-02-22 10:04:29 -05:00
89ab76920f
zjquery: Prevent direct patches to $.
...
We prohibit code from making direct patches to
$ unless you use override().
2021-02-22 10:04:29 -05:00
b40d8d5790
node tests: Inline setup for settings_bots.
...
I also use override in more places, and I add
$.validator to zjquery.
In passing I clean up some IIFEs that aren't
really needed.
2021-02-22 10:04:29 -05:00
38e3aa490f
node tests: Use override for $.post.
2021-02-22 10:04:29 -05:00
623500bae1
node tests: Avoid zjquery for channel tests.
...
We create our own stub for $.ajax.
2021-02-22 10:04:29 -05:00
0ffbea8650
node tests: Break up channel tests.
2021-02-22 10:04:29 -05:00
ffe1043bcc
zjsunit: Remove stub_out_jquery.
...
We now either use zjquery or do whatever gross
things we need to do to work past document.trigger(...)
calls or $.now calls explicitly in the tests.
2021-02-21 17:34:55 -05:00
64c7eb67eb
zjquery: Make zjquery a singleton.
...
We no longer export make_zjquery().
We now instead have a singleton zjquery instance
that we attach to global.$ in index.js.
We call $.clear_all_elements() before each module.
(We will soon get even more aggressive about doing
it in run_test.)
Test functions can still override $ with set_global.
A good example of this is copy_and_paste using the
real jquery module.
We no longer exempt $ as a global variable, so
test modules that use the zjquery $ need to do:
const $ = require("../zjsunit/zjquery");
2021-02-21 17:34:55 -05:00
2e3406f0b8
node tests: Eliminate "silent" option for zjquery.
...
The "silent" option was kind of evil, as it had
$(...).find(...) passing back "self" instead of a stub.
Now we just use $(...).set_find_results(...) or
override(...) to simulate/bypass drawing code.
(It turns out hash_util didn't even need this option.)
2021-02-21 15:11:31 -05:00
706e2baf7e
node_test: Avoid make_zjquery.
...
We just use $.clear_all_elements() now.
2021-02-21 15:11:31 -05:00
9938811759
node tests: Avoid $ override for compose test.
...
We just use zjquery now.
2021-02-21 15:11:31 -05:00
895179e8f6
node tests: Make setup for ui_init more local.
2021-02-21 15:11:31 -05:00
b72575d98b
node tests: Fix zjquery leaks in stream_list.
2021-02-21 15:11:31 -05:00
496932bfc6
node tests: Share setup helpers for stream_list.
2021-02-21 15:11:31 -05:00
d207d71753
node tests: Make setup for stream_edit more local.
2021-02-21 15:11:31 -05:00
3829ab0ea9
node tests: Fix zjquery leaks for popovers.
2021-02-21 15:11:31 -05:00
fc29ee02c8
node tests: Fix zjquery leaks in compose_actions.
2021-02-21 15:11:31 -05:00
2fc8e134f5
node tests: Fix zjquery leaks in common.
2021-02-21 15:11:31 -05:00
569b12439d
node tests: Fix zjquery leaks in alert_words_ui.
2021-02-21 15:11:31 -05:00
0124264a9e
node tests: Prevent zjquery leaks in activity tests.
2021-02-20 17:33:51 -05:00
faa1d0d96d
node tests: Fix zjquery leaks in buddy_list test.
2021-02-20 12:00:24 -05:00
5bd73ce190
zjsunit: Show more of the traceback.
...
We still reduce a lot of clutter, but this
shows wrappers around `run_test` now.
2021-02-20 12:00:24 -05:00
490894475e
node tests: Prevent zjquery leaks in pm_list.
...
We weren't leaking anything, but this change
prevents future leaks.
2021-02-20 10:29:30 -05:00
d34723987f
node tests: Make sure we try to find container in pm_list.
2021-02-20 10:29:30 -05:00
7e4d784888
node tests: Use override/with_field in pm_list.
2021-02-20 10:29:30 -05:00
94d6dd5ee5
docs: Update author protocol section of the code-reviewing docs.
2021-02-20 09:17:53 -05:00
04197309ae
docs: Explain the export tool purpose more clearly.
...
The reference to "hardware platforms" was confusing -- we really mean
different logical Zulip database installations.
2021-02-19 10:05:40 -08:00
7c408bc525
node tests: Use override in buddy tests.
2021-02-19 10:06:44 -05:00
Anders Kaseorg
Wesley Aptekar-Cassels
Alex Vandiver
Steve Howell
Aman Agrawal
Sumanth V Rao
Tim Abbott