Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

support: Adjust "has been clicked" phrasing about confirmation links. 

The "clicked" phrasing is not accurate, because e.g. if a user did click
their invitation link but didn't submit the registration form, the
support page will still claim about the link "has never been clicked".

"Used" is a better general phrase. If we want to track whether links
have been specifically *clicked*, we'll need to implement that
separately.
This commit is contained in:
Mateusz Mandera 2022-05-06 21:09:00 +02:00 committed by Tim Abbott
parent cd1e062878
commit 0ffdc96301
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
analytics/tests/test_support_views.py
View File

@ -153,7 +153,7 @@ class TestSupportEndpoint(ZulipTestCase):
self.assert_in_success_response( self.assert_in_success_response(
[ [
"<b>Expires in</b>: 1\xa0week, 3\xa0days", "<b>Expires in</b>: 1\xa0week, 3\xa0days",
"<b>Status</b>: Link has never been clicked", "<b>Status</b>: Link has not been used",
], ],
result, result,
) )
@ -163,7 +163,7 @@ class TestSupportEndpoint(ZulipTestCase):
self.assert_in_success_response( self.assert_in_success_response(
[ [
"<b>Expires in</b>: 1\xa0day", "<b>Expires in</b>: 1\xa0day",
"<b>Status</b>: Link has never been clicked", "<b>Status</b>: Link has not been used",
], ],
result, result,
) )

4
analytics/views/support.py
View File

@ -91,9 +91,9 @@ def get_confirmations(
assert content_object is not None assert content_object is not None
if hasattr(content_object, "status"): if hasattr(content_object, "status"):
if content_object.status == STATUS_ACTIVE: if content_object.status == STATUS_ACTIVE:
link_status = "Link has been clicked" link_status = "Link has been used"
else: else:
link_status = "Link has never been clicked" link_status = "Link has not been used"
else: else:
link_status = "" link_status = ""