From 0ffdc96301e60f1f18472ff651418c0e9d292622 Mon Sep 17 00:00:00 2001 From: Mateusz Mandera Date: Fri, 6 May 2022 21:09:00 +0200 Subject: [PATCH] support: Adjust "has been clicked" phrasing about confirmation links. The "clicked" phrasing is not accurate, because e.g. if a user did click their invitation link but didn't submit the registration form, the support page will still claim about the link "has never been clicked". "Used" is a better general phrase. If we want to track whether links have been specifically *clicked*, we'll need to implement that separately. --- analytics/tests/test_support_views.py | 4 ++-- analytics/views/support.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/analytics/tests/test_support_views.py b/analytics/tests/test_support_views.py index 8cf04462d2..a0a542674b 100644 --- a/analytics/tests/test_support_views.py +++ b/analytics/tests/test_support_views.py @@ -153,7 +153,7 @@ class TestSupportEndpoint(ZulipTestCase): self.assert_in_success_response( [ "Expires in: 1\xa0week, 3\xa0days", - "Status: Link has never been clicked", + "Status: Link has not been used", ], result, ) @@ -163,7 +163,7 @@ class TestSupportEndpoint(ZulipTestCase): self.assert_in_success_response( [ "Expires in: 1\xa0day", - "Status: Link has never been clicked", + "Status: Link has not been used", ], result, ) diff --git a/analytics/views/support.py b/analytics/views/support.py index 471459a8f3..a29b82ac30 100644 --- a/analytics/views/support.py +++ b/analytics/views/support.py @@ -91,9 +91,9 @@ def get_confirmations( assert content_object is not None if hasattr(content_object, "status"): if content_object.status == STATUS_ACTIVE: - link_status = "Link has been clicked" + link_status = "Link has been used" else: - link_status = "Link has never been clicked" + link_status = "Link has not been used" else: link_status = ""