Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/tools/test-js-with-node

492 lines
17 KiB
Plaintext
Raw Normal View History

py3: Switch almost all shebang lines to use `python3`. This causes `upgrade-zulip-from-git`, as well as a no-option run of `tools/build-release-tarball`, to produce a Zulip install running Python 3, rather than Python 2. In particular this means that the virtualenv we create, in which all application code runs, is Python 3. One shebang line, on `zulip-ec2-configure-interfaces`, explicitly keeps Python 2, and at least one external ops script, `wal-e`, also still runs on Python 2. See discussion on the respective previous commits that made those explicit. There may also be some other third-party scripts we use, outside of this source tree and running outside our virtualenv, that still run on Python 2.
2017-08-02 23:15:16 +02:00
#!/usr/bin/env python3
test-js-with-node: Port from optparse to argparse.
2017-11-09 08:41:47 +01:00
import argparse
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
import glob
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
import os
test-js-with-node: Show correct coverage link in color. We figure out the dev host using the same logic as dev_settings.py, so that we don't use wrong things like 127.0.0.1 for droplet users. And we display the link in cyan.
2020-04-11 12:24:10 +02:00
import pwd
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
import subprocess
import sys
node tests: Sort list of exempt files.
2021-12-18 21:49:09 +01:00
from typing import Any, Dict, List, Set
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, os.path.dirname(TOOLS_DIR))
ROOT_DIR = os.path.dirname(TOOLS_DIR)
# check for the venv
from tools.lib import sanity_check
python: Sort imports with isort. Fixes #2665. Regenerated by tabbott with `lint --fix` after a rebase and change in parameters. Note from tabbott: In a few cases, this converts technical debt in the form of unsorted imports into different technical debt in the form of our largest files having very long, ugly import sequences at the start. I expect this change will increase pressure for us to split those files, which isn't a bad thing. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-11 00:54:34 +02:00
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
sanity_check.check_venv(__file__)
test-js-with-node: Fix doing too many imports before sanity_check. This wasn't benefitting from the nice error message.
2017-10-18 07:20:41 +02:00
# Import this after we do the sanity_check so it doesn't crash.
python: Replace ujson with orjson. Fixes #6507. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 01:09:47 +02:00
import orjson
python: Sort imports with isort. Fixes #2665. Regenerated by tabbott with `lint --fix` after a rebase and change in parameters. Note from tabbott: In a few cases, this converts technical debt in the form of unsorted imports into different technical debt in the form of our largest files having very long, ugly import sequences at the start. I expect this change will increase pressure for us to split those files, which isn't a bad thing. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-11 00:54:34 +02:00
from zulint.printer import BOLDRED, CYAN, ENDC, GREEN
node tests: Add some color to output.
2020-02-09 15:09:37 +01:00
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
INDEX_JS = os.path.join(ROOT_DIR, "web/tests/lib/index.js")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
NODE_COVERAGE_PATH = os.path.join(ROOT_DIR, "var/node-coverage/coverage-final.json")
tools: Fix running test-js-with-node from arbitrary paths.
2020-12-15 21:16:10 +01:00
# Ideally, we wouldn't need this line, but it seems to be required to
# avoid problems finding node_modules when running `cd tools; ./test-js-with-node`.
os.chdir(ROOT_DIR)
test-js-with-node: Move constants toward top.
2020-01-26 15:49:01 +01:00
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
USAGE = """
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
tools/test-js-with-node - to run all tests
tools/test-js-with-node util.test.js activity.test.js - to run just a couple tests
tools/test-js-with-node --coverage - to generate coverage report
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
"""
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
node tests: Sort list of exempt files.
2021-12-18 21:49:09 +01:00
def make_set(files: List[str]) -> Set[str]:
for i in range(1, len(files)):
if files[i - 1] > files[i]:
raise Exception(f"Please move {files[i]} so that names are sorted.")
return set(files)
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
# We do not yet require 100% line coverage for these files:
node tests: Sort list of exempt files.
2021-12-18 21:49:09 +01:00
EXEMPT_FILES = make_set(
[
ts: Convert `poll_data` to typescript. Used zod schemas to validate inbound data types and removed some over defensive code.
2023-06-02 09:20:46 +02:00
"web/shared/src/poll_data.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/about_zulip.js",
"web/src/add_subscribers_pill.js",
"web/src/admin.js",
"web/src/alert_popup.ts",
alert_words_ui: Convert module to TypeScript. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 00:28:16 +02:00
"web/src/alert_words_ui.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/archive.js",
"web/src/assets.d.ts",
ts: Migrate `attachments_ui.js` to typescript.
2023-08-30 14:08:17 +02:00
"web/src/attachments_ui.ts",
ts: Migrate `avatar.js` module to TypeScript.
2023-09-01 10:18:48 +02:00
"web/src/avatar.ts",
ts: Convert `web/src/billing` module to TypeScript. Converted all files inside `web/src/billing` to TypeScript.
2023-02-26 11:38:01 +01:00
"web/src/billing/event_status.ts",
"web/src/billing/helpers.ts",
"web/src/billing/upgrade.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/blueslip.ts",
"web/src/blueslip_stacktrace.ts",
"web/src/click_handlers.js",
"web/src/compose.js",
"web/src/compose_actions.js",
"web/src/compose_banner.ts",
"web/src/compose_closed_ui.js",
"web/src/compose_fade.js",
compose: Extract a compose_recipient module. This helps reduce the amount of import cycles we have in the compose code path following the migration to a fancier stream input. `compose_closed_ui.initialize()` was moved further down in the initialization order because it relies on the dropdown widget to be defined.
2023-03-31 06:27:36 +02:00
"web/src/compose_recipient.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/compose_state.js",
ts: Convert `compose_textarea.js` to TypeScript. Added type definitions for `jquery-caret-plugin` third party package and converted `compose_textarea.js` to TypeScript.
2023-05-25 10:34:37 +02:00
"web/src/compose_textarea.ts",
tippyjs: Extract compose_tooltips.js module.
2023-06-07 14:18:18 +02:00
"web/src/compose_tooltips.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/compose_ui.js",
"web/src/compose_validate.js",
"web/src/composebox_typeahead.js",
"web/src/condense.js",
ts: Convert `confirm_dialog` module to TypeScript.
2023-05-18 16:01:57 +02:00
"web/src/confirm_dialog.ts",
copied_tooltip: Convert module to TypeScript. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 00:06:31 +02:00
"web/src/copied_tooltip.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/copy_and_paste.js",
"web/src/csrf.ts",
Revert "ts: Convert css_variables.js to TypeScript." This reverts commit 5f4bdfe6bc33c0280f2a5d4c30e72919cd80960c (#24630). This was causing Webpack to trigger type checking with the TypeScript compiler, which is very expensive. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-04-04 09:19:27 +02:00
"web/src/css_variables.js",
custom_fields: Extract some code in custom_profile_fields_ui.js. This commit moves initialize_custom_pronouns_type_fields, initialize_custom_user_type_fields, initialize_custom_date_type_fields and append_custom_profile_fields functions to the new file custom_profile_fields_ui.js from settings_account.js since they are used for both showing custom profile fields in "Profile" settings panel and "Edit user" form shown in user profile modal. This change also helps us in avoiding import cycles.
2023-09-25 13:16:40 +02:00
"web/src/custom_profile_fields_ui.js",
ts migration: Convert `dark_theme.js` to `dark_theme.ts`. Add `void` type annotation to the return type of functions. The rest of the file is not modified.
2023-03-25 23:50:45 +01:00
"web/src/dark_theme.ts",
ts: Migrate debug.js to TypeScript. TypeScript doesn't understand Array.prototype.slice.call; rather than dealing with the type-checking issues around it, we remove it; it was only necessary for ancient browsers where NodeList isn’t directly iterable.
2023-04-01 20:50:34 +02:00
"web/src/debug.ts",
ts: Convert `deprecated_feature_notice` module to TypeScript.
2023-05-18 16:22:20 +02:00
"web/src/deprecated_feature_notice.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/desktop_integration.js",
ts: Covert `dialog_widget.js` to typescript. Created `WidgetConfig` type which has all the parameter that can be passed launch(). Except html_heading, html_body, and on_click all other fields are optional. Therefore, removed checking of undefined mandatory fields as it will be done by typescript. Co-authored-by: Hardik Dharmani <Ddharmani99@gmail.com>
2023-03-30 18:21:28 +02:00
"web/src/dialog_widget.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/drafts.js",
dropdown_widget: Implement dropdown widget using tippy. This will soon replace DropdownListWidget.
2023-05-07 14:42:54 +02:00
"web/src/dropdown_widget.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/echo.js",
"web/src/emoji_picker.js",
ts: Convert `emojisets` to TypeScript. Declared types for '*.png' modules and '!style-loader?*' modules in `assets.d.ts` and used them in `emojisets.ts`.
2023-05-21 09:15:52 +02:00
"web/src/emojisets.ts",
ts migration: Convert `favicon.js` to `favicon.ts`. Added type annotations to function parameters, function return values and local variables. Added neccessary `if` statements to enforce the objects having proper type before executing the later operations. An error type check in the catch block in `update_favicon` function is added because the statement in the catch block requires error to be a type `Error` in order to access `error.stack`.
2023-03-24 22:02:09 +01:00
"web/src/favicon.ts",
ts: Migrate `feedback_widget` to TypeScript. This commit migrates `feedback_widget` module to TypeScript.
2023-05-04 12:58:14 +02:00
"web/src/feedback_widget.ts",
flatpickr: Convert module to TypeScript. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-09-22 19:42:16 +02:00
"web/src/flatpickr.ts",
ts: Migrate gear_menu.js to TypeScript. Includes adding various missing values to page_params.
2023-03-29 18:36:52 +02:00
"web/src/gear_menu.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/giphy.js",
"web/src/global.d.ts",
ts: Migrate `hash_util.js` module to TypeScript.
2023-08-15 04:19:07 +02:00
"web/src/hash_util.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/hashchange.js",
"web/src/hbs.d.ts",
"web/src/hotkey.js",
"web/src/hotspots.js",
inbox: Add new narrow.
2023-08-09 07:23:30 +02:00
"web/src/inbox_ui.js",
"web/src/inbox_util.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/info_overlay.js",
bots: Extract code for showing integration url modal in new file. This commit creates a new file integration_url_modal.js which now contains the code for showing integration url modal. Since show_generate_integration_url_modal is used in multiple places, this change helps us in avoiding import cycles.
2023-09-25 19:13:40 +02:00
"web/src/integration_url_modal.js",
invite: Convert module to TypeScript. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-09-22 10:32:06 +02:00
"web/src/invite.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/lightbox.js",
"web/src/list_util.ts",
ts: Migrate `list_widget` to TypeScript.
2023-04-28 08:55:36 +02:00
"web/src/list_widget.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/loading.ts",
"web/src/local_message.js",
TS migration: Convert `localstorage.js` to `localstorage.ts`. Added function parameter types, return type, and types of local varaibles. Added a `null` check for `raw_data` before `JSON.parse`. Created a type `FormData` and an export type `LocalStorage` to imporve conciseness and clearity. Type `LocalStorage` is exported because it might be used in other files based on an observation that many files have imported `localstorage`.
2023-03-25 16:54:49 +01:00
"web/src/localstorage.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/message_edit.js",
"web/src/message_edit_history.js",
"web/src/message_events.js",
refactor: Extract `message_feed_loading` module from `message_scroll`. This new module allows us to remove dependency on `message_scroll` in `fetch_status` and hence allowing us to migrate it to TypeScript.
2023-05-10 18:06:57 +02:00
"web/src/message_feed_loading.ts",
message_scroll: Extract module message_feed_top_notices.
2023-06-01 01:57:47 +02:00
"web/src/message_feed_top_notices.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/message_fetch.js",
"web/src/message_list.js",
"web/src/message_list_data.js",
message_list_hover: Extract module for hover/unhover logic. Remove the various message-hover related functions from ui_init.js and put them in a new module.
2023-07-01 20:17:24 +02:00
"web/src/message_list_hover.js",
tippyjs: Extract message_list_tooltips module.
2023-06-01 02:08:40 +02:00
"web/src/message_list_tooltips.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/message_list_view.js",
"web/src/message_lists.js",
"web/src/message_live_update.js",
"web/src/message_scroll.js",
message_scroll: Move state flags to new module message_scroll_state. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-02 23:16:51 +02:00
"web/src/message_scroll_state.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/message_util.js",
"web/src/message_view_header.js",
"web/src/message_viewport.js",
ts: Migrate `message_overlay_ui` to TypeScript.
2023-07-10 11:30:52 +02:00
"web/src/messages_overlay_ui.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/muted_users_ui.js",
"web/src/narrow.js",
narrow: Save blue box position and restore on navigation. This saves the blue box position as state on the location in brower history, with `history.replaceState`. The position is restored when a narrow is activated. Fixes #20066.
2023-08-08 23:59:25 +02:00
"web/src/narrow_history.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/navbar_alerts.js",
"web/src/navigate.js",
"web/src/notifications.js",
ts: Convert `overlays.js` to TypeScript. Refactored some code as well to avoid unneccesaary `undefined` checks in `overlays`. To be exact created an action_overlay object of type `Overlay` such that the `reset_state` is just `action_overlay = undefined` and having attributes like `$element` and `close_handler`. This would ensure that if you have an `active_overlay`, there will be a registered `close handler` attached to it without needing to write additional checks for `close_handler` just to satisfy type checker.
2023-03-29 16:34:02 +02:00
"web/src/overlays.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/padded_widget.ts",
"web/src/page_params.ts",
playground_links: Migrate popover to Tippy. Fixes part of #23632.
2023-09-15 15:58:47 +02:00
"web/src/playground_links_popover.js",
stats: Install @types/plotly.js for type check. This is a prep commit for typescript migration for `stats.js`, which used a third party module `plotly.js` that doesn't come with types.
2023-06-27 17:27:20 +02:00
"web/src/plotly.js.d.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/pm_list.js",
"web/src/pm_list_dom.js",
"web/src/poll_widget.js",
"web/src/popover_menus.js",
"web/src/popover_menus_data.js",
"web/src/popovers.js",
"web/src/read_receipts.js",
"web/src/ready.ts",
ts: Migrate `realm_icon` to TypeScript.
2023-09-09 10:25:05 +02:00
"web/src/realm_icon.ts",
ts: Migrate `realm_logo` to TypeScript.
2023-09-09 10:32:13 +02:00
"web/src/realm_logo.ts",
ts: Migrate `realm_playground` to typescript.
2023-07-11 18:48:37 +02:00
"web/src/realm_playground.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/realm_user_settings_defaults.ts",
recent: Rename recent_topics_ui.
2023-09-06 23:14:37 +02:00
"web/src/recent_view_ui.js",
recent: Rename recent_topics_util.
2023-09-06 23:21:13 +02:00
"web/src/recent_view_util.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/reload.js",
"web/src/reminder.js",
"web/src/resize.js",
"web/src/rows.js",
scheduled_messages: Add overlay to display and edit them. Fixes #20971
2023-04-14 21:35:56 +02:00
"web/src/scheduled_messages.js",
"web/src/scheduled_messages_overlay_ui.js",
ts: Migrate scroll_bar.js to typescript. Remove the winjs specific `getScrollbarWidth` property while we're at it; WinJS isn't relevant anymore. Reorders methods due to TypeScript files enforcing define-before-use when this commit was drafted.
2023-04-01 20:43:58 +02:00
"web/src/scroll_bar.ts",
ts: Migrate `scroll_util.js` to TypeScript. This commit migrates `scroll_util.js` to typescript. I made a helper type `JQueryOrZJQuery` for the argument of `get_scroll_element` instead of adding a `__zjquery` property to the global JQuery object because it isn't being used anywhere outside of this function and hence it makes sense to have a little helper type than to add the property to the global object.
2023-04-27 05:44:27 +02:00
"web/src/scroll_util.ts",
search: Redesign search box. Fixes #21798.
2022-05-16 19:24:49 +02:00
"web/src/search.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/sent_messages.js",
sentry: Add frontend event monitoring. Zulip already has integrations for server-side Sentry integration; however, it has historically used the Zulip-specific `blueslip` library for monitoring browser-side errors. However, the latter sends errors to email, as well optionally to an internal `#errors` stream. While this is sufficient for low volumes of users, and useful in that it does not rely on outside services, at higher volumes it is very difficult to do any analysis or filtering of the errors. Client-side errors are exceptionally noisy, with many false positives due to browser extensions or similar, so determining real real errors from a stream of un-grouped emails or messages in a stream is quite difficult. Add a client-side Javascript sentry integration. To provide useful backtraces, this requires extending the pre-deploy hooks to upload the source-maps to Sentry. Additional keys are added to the non-public API of `page_params` to control the DSN, realm identifier, and sample rates.
2023-02-13 20:50:57 +01:00
"web/src/sentry.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/server_events.js",
"web/src/settings.js",
"web/src/settings_account.js",
"web/src/settings_bots.js",
"web/src/settings_display.js",
ts: Migrate `settings_emoji.js` to TypeScript.
2023-09-02 11:40:52 +02:00
"web/src/settings_emoji.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/settings_exports.js",
"web/src/settings_invites.js",
"web/src/settings_linkifiers.js",
"web/src/settings_muted_users.js",
"web/src/settings_notifications.js",
"web/src/settings_org.js",
"web/src/settings_panel_menu.js",
"web/src/settings_playgrounds.js",
"web/src/settings_profile_fields.js",
"web/src/settings_realm_domains.js",
"web/src/settings_realm_user_settings_defaults.js",
"web/src/settings_sections.js",
"web/src/settings_streams.js",
"web/src/settings_toggle.js",
ts: Migrate `settings_ui.js` to TypeScript.
2023-08-04 09:58:55 +02:00
"web/src/settings_ui.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/settings_user_groups_legacy.js",
user_topics: Rename 'settings_muted_topics.js'. This commit renames 'settings_muted_topics.js' to 'settings_user_topics.js' because the file now supports the settings for topics with any visibility_policy, not just MUTED. It also renames the corresponding test file.
2023-04-16 06:33:06 +02:00
"web/src/settings_user_topics.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/settings_users.js",
ts: Migrate setup.js to typescript. Also added global type definition for `get_offset_to_window` helper function.
2023-05-11 11:44:10 +02:00
"web/src/setup.ts",
right_sidebar_ui: Rename to sidebar_ui.
2023-09-28 11:08:09 +02:00
"web/src/sidebar_ui.js",
ts: Migrate `spectators.js` to typescript.
2023-08-15 04:48:25 +02:00
"web/src/spectators.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/spoilers.ts",
"web/src/starred_messages_ui.js",
"web/src/stream_bar.js",
"web/src/stream_color.js",
"web/src/stream_create.js",
"web/src/stream_create_subscribers.js",
"web/src/stream_edit.js",
"web/src/stream_edit_subscribers.js",
"web/src/stream_list.js",
"web/src/stream_muting.js",
"web/src/stream_popover.js",
ts: Convert `stream_settings_containers.js` to TypeScript. Added assertion to enforce `sub` is not `undefined` and thus type safe for the rest. Added type annotation to function parameter and return value.
2023-06-09 00:48:46 +02:00
"web/src/stream_settings_containers.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/stream_settings_ui.js",
"web/src/stream_ui_updates.js",
"web/src/submessage.js",
"web/src/subscriber_api.js",
"web/src/timerender.ts",
"web/src/tippyjs.js",
"web/src/todo_widget.js",
"web/src/topic_list.js",
"web/src/topic_zoom.js",
"web/src/tutorial.js",
"web/src/types.ts",
"web/src/typing.js",
"web/src/typing_events.js",
"web/src/ui_init.js",
"web/src/ui_report.ts",
"web/src/ui_util.ts",
"web/src/unread.js",
"web/src/unread_ops.js",
"web/src/unread_ui.js",
"web/src/upload.js",
"web/src/upload_widget.ts",
linkifier: Support URL templates for linkifiers. This swaps out url_format_string from all of our APIs and replaces it with url_template. Note that the documentation changes in the following commits will be squashed with this commit. We change the "url_format" key to "url_template" for the realm_linkifiers events in event_schema, along with updating LinkifierDict. "url_template" is the name chosen to normalize mixed usages of "url_format_string" and "url_format" throughout the backend. The markdown processor is updated to stop handling the format string interpolation and delegate the task template expansion to the uri_template library instead. This change affects many test cases. We mostly just replace "%(name)s" with "{name}", "url_format_string" with "url_template" to make sure that they still pass. There are some test cases dedicated for testing "%" escaping, which aren't relevant anymore and are subject to removal. But for now we keep most of them as-is, and make sure that "%" is always escaped since we do not use it for variable substitution any more. Since url_format_string is not populated anymore, a migration is created to remove this field entirely, and make url_template non-nullable since we will always populate it. Note that it is possible to have url_template being null after migration 0422 and before 0424, but in practice, url_template will not be None after backfilling and the backend now is always setting url_template. With the removal of url_format_string, RealmFilter model will now be cleaned with URL template checks, and the old checks for escapes are removed. We also modified RealmFilter.clean to skip the validation when the url_template is invalid. This avoids raising mulitple ValidationError's when calling full_clean on a linkifier. But we might eventually want to have a more centric approach to data validation instead of having the same validation in both the clean method and the validator. Fixes #23124. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
"web/src/url-template.d.ts",
popovers: Extract user info popovers into their own module. The intent behind this commit is to tidy up how we handle user info popovers. The first step is to move everything related to them into its own module. This commit should not have any functional changes.
2023-09-13 10:59:24 +02:00
"web/src/user_card_popover.js",
users: Extract code for showing deactivation modal in new file. This commit creates a new file user_deactivation_ui.js which now contains the code for showing deactivation modal for user and bots. Since confirm_deactivation and confirm_bot_deactivation functions are used in multiple places, this change helps us in avoiding import cycles.
2023-09-25 19:19:40 +02:00
"web/src/user_deactivation_ui.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/user_group_create.js",
"web/src/user_group_create_members.js",
ts: Migrate `user_group_create_members_data.js` to TypeScript.
2023-08-15 09:06:16 +02:00
"web/src/user_group_create_members_data.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/user_group_edit.js",
"web/src/user_group_edit_members.js",
popovers: Extract `user_group_popover` into separate module. This is a preparatory commit before we migrate `user_group_popover` from Bootstrap to Tippy library. The previous implementation was weirdly sharing the logic around `current_message_info_popover_elem` with the user info popovers based on a message; very likely an unfortunate latent bug caused by copy/paste. To address that, we need to add dedicated functions like get_user_group_popover_items to avoid breaking keyboard navigation with this extraction.
2023-09-08 16:44:48 +02:00
"web/src/user_group_popover.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/user_group_ui_updates.js",
user_groups: Refactor get_realm_user_groups_for_dropdown_list_widget. This commit refactors get_realm_user_groups_for_dropdown_list_widget function to use "group_permission_settings" module instead of passing variables like "allow_internet_group", etc. individually for each settings. We lose some test coverage due to this commit, but that would be fixed when we add some more group-based settings and allow groups other than system groups in the group based settings.
2023-04-10 12:56:36 +02:00
"web/src/user_groups.ts",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/user_groups_settings_ui.js",
"web/src/user_profile.js",
"web/src/user_settings.ts",
"web/src/user_status.js",
"web/src/user_status_ui.js",
ts: Migrate `user_topics.js` to typescript.
2023-09-10 14:14:26 +02:00
"web/src/user_topics.ts",
user_topics: Rename 'muted_topics_ui' to 'user_topics_ui'. This commit renames the file 'muted_topics_ui.js' to 'user_topics_ui.js', as we also support visibility policies other than MUTED.
2023-06-24 07:57:58 +02:00
"web/src/user_topics_ui.js",
views: Write a common show and hide function. Fixes #26688
2023-09-23 08:20:22 +02:00
"web/src/views_util.js",
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
"web/src/webpack_public_path.js",
"web/src/zcommand.js",
"web/src/zform.js",
"web/src/zulip.js",
"web/src/zulip_test.js",
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
"web/tests/lib/mdiff.js",
compose: Move cursor to end of topic input after stream selection. Fixes #25321.
2023-05-01 23:17:55 +02:00
"web/tests/lib/zjquery_element.js",
node tests: Sort list of exempt files.
2021-12-18 21:49:09 +01:00
]
)
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
tools: Move registration of --force to test-scripts.py. This commit moves --force option used with various tests to test-scripts.py to have it alongside the logic that does provisioning status assertion. This is a step towards providing more clarity over use of this argument with tests as asked in issue #17455.
2021-03-03 05:00:15 +01:00
from tools.lib.test_script import add_provision_check_override_param, assert_provisioning_status_ok
test-js-with-node: Port from optparse to argparse.
2017-11-09 08:41:47 +01:00
parser = argparse.ArgumentParser(USAGE)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
parser.add_argument("--coverage", action="store_true", help="Get coverage report")
tools: Move registration of --force to test-scripts.py. This commit moves --force option used with various tests to test-scripts.py to have it alongside the logic that does provisioning status assertion. This is a step towards providing more clarity over use of this argument with tests as asked in issue #17455.
2021-03-03 05:00:15 +01:00
add_provision_check_override_param(parser)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
parser.add_argument("args", nargs=argparse.REMAINDER)
node_tests: Run node tests in parallel. Fixes #9471.
2021-08-04 18:19:54 +02:00
parser.add_argument(
"--parallel",
dest="parallel",
action="store",
type=int,
# Since process startup time is a significant portion of total
# runtime, so rather than doing os.cpu_count, we just do a fixed 4
# processes by default.
default=4,
help="Specify the number of processes to run the "
"tests in. Default is the number of logical CPUs",
)
test-js-with-node: Port from optparse to argparse.
2017-11-09 08:41:47 +01:00
options = parser.parse_args()
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
individual_files = options.args
node_tests: Run node tests in parallel. Fixes #9471.
2021-08-04 18:19:54 +02:00
parallel = options.parallel
if options.coverage and parallel > 1:
parallel = 1
print(
BOLDRED + "You cannot use --coverage with parallel tests. Running in serial mode.\n" + ENDC
)
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
tools: Rename force argument to skip-provision-check This commit renames --force argument used with various tests to --skip-provision-check. As a consequence of this name change all other files that set --force option for the test commands have been updated. This change is done in order to provide more clarity for using this option for runnning tests. This commit addresses issue #17455.
2021-03-02 20:59:19 +01:00
assert_provisioning_status_ok(options.skip_provision_check)
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
test-js-with-node: Show correct coverage link in color. We figure out the dev host using the same logic as dev_settings.py, so that we don't use wrong things like 127.0.0.1 for droplet users. And we display the link in cyan.
2020-04-11 12:24:10 +02:00
def get_dev_host() -> str:
# See similar code in dev_settings.py. We only use
# this to report where you can find coverage reports.
# We duplicate the code here to avoid depending on
# Django.
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
host = os.getenv("EXTERNAL_HOST")
test-js-with-node: Show correct coverage link in color. We figure out the dev host using the same logic as dev_settings.py, so that we don't use wrong things like 127.0.0.1 for droplet users. And we display the link in cyan.
2020-04-11 12:24:10 +02:00
if host is not None:
return host
user_id = os.getuid()
user_name = pwd.getpwuid(user_id).pw_name
if user_name == "zulipdev":
node tests: Report coverage url correctly. This small patch accounts for our new droplets dropping "zulipdev.org" from the host name.
2020-04-24 11:54:55 +02:00
hostname = os.uname()[1].lower()
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
if ".zulipdev.org" not in hostname:
hostname += ".zulipdev.org"
return hostname + ":9991"
test-js-with-node: Show correct coverage link in color. We figure out the dev host using the same logic as dev_settings.py, so that we don't use wrong things like 127.0.0.1 for droplet users. And we display the link in cyan.
2020-04-11 12:24:10 +02:00
else:
# For local development environments, we use localhost by
# default, via the "zulipdev.com" hostname.
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
return "zulipdev.com:9991"
test-js-with-node: Show correct coverage link in color. We figure out the dev host using the same logic as dev_settings.py, so that we don't use wrong things like 127.0.0.1 for droplet users. And we display the link in cyan.
2020-04-11 12:24:10 +02:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
node tests: Add some color to output.
2020-02-09 15:09:37 +01:00
def print_error(msg: str) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
print(BOLDRED + "ERROR:" + ENDC + " " + msg)
node tests: Add some color to output.
2020-02-09 15:09:37 +01:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
def clean_file(orig_fn: str) -> str:
fn = orig_fn
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
if not fn.endswith(".test.js"):
fn += ".test.js"
if "web/tests/" not in fn:
fn = os.path.join(ROOT_DIR, "web", "tests", fn)
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
fn = os.path.abspath(fn)
if not os.path.exists(fn):
print(f"Cannot find {orig_fn} ({fn})")
sys.exit(1)
return fn
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
def clean_files(fns: List[str]) -> List[str]:
cleaned_files = [clean_file(fn) for fn in fns]
return cleaned_files
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
def run_tests_via_node_js() -> int:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
os.environ["TZ"] = "UTC"
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
# The index.js test runner is the real "driver" here, and we launch
# with either nyc or node, depending on whether we want coverage
# reports. Running under nyc is slower and creates funny
# tracebacks, so you generally want to get coverage reports only
# after making sure tests will pass.
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
node_tests_cmd = ["node", "--stack-trace-limit=100", INDEX_JS]
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
if individual_files:
node_tests: Run node tests in parallel. Fixes #9471.
2021-08-04 18:19:54 +02:00
# If we passed a specific set of tests, run in serial mode.
global parallel
parallel = 1
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
files = individual_files
else:
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
files = sorted(glob.glob(os.path.join(ROOT_DIR, "web/tests/*.test.js")))
node tests: Find files in Python. The code to run single files was added in c15695e5146aa3285cd7c0632ca42958784cefeb, and it's just kinda strange code. We already do a lot of file logic in Python to check for line-coverage, so it's easier to just have all the logic in Python. This adds a new feature--you can now specify the actual file: ./tools/test-js-with-node frontend_tests/node_tests/people.js (This is helpful if you just want to use shell autocomplete.) Another minor change is that if you specify individual files, we won't sort them. This is important when you're trying to hunt down test leaks. Finally, we have a nicer message if we can't find the file.
2020-09-02 21:58:08 +02:00
node_tests: Run node tests in parallel. Fixes #9471.
2021-08-04 18:19:54 +02:00
test_files = clean_files(files)
print("Starting node tests...")
# If we got this far, we can run the tests!
ret = 0
if parallel > 1:
sub_tests = [test_files[i::parallel] for i in range(parallel)]
parallel_processes = [subprocess.Popen(node_tests_cmd + sub_test) for sub_test in sub_tests]
for process in parallel_processes:
status_code = process.wait()
if status_code != 0:
ret = status_code
return ret
node_tests_cmd += test_files
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
if options.coverage:
test-js-with-node: Simplify failures for --coverage. When you use nyc, its code instrumentation transforms the code so that line numbers and columns no longer make sense, and the long stack trace is likely to cause more confusion than convenience. We want to encourage a workflow where you debug your node tests using the normal (and much quicker mode) before running `--coverage`.
2022-01-07 20:40:15 +01:00
os.environ["USING_INSTRUMENTED_CODE"] = "TRUE"
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
coverage_dir = os.path.join(ROOT_DIR, "var/node-coverage")
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
node tests: Clean up nyc arguments. nyc was added in 29f04511c00faa97c919a9084707d539d5b11d41 All the stuff after "&&" was actually passed to node, because we didn't use shell=True, so the "nyc report" command didn't run, and the ugly finder.js code just skipped over all the final tokens.
2020-09-02 22:45:59 +02:00
nyc = os.path.join(ROOT_DIR, "node_modules/.bin/nyc")
command = [nyc, "--extension", ".hbs", "--extension", ".ts"]
command += ["--report-dir", coverage_dir]
command += ["--temp-directory", coverage_dir]
command += ["-r=lcov", "-r=json", "-r=text-summary"]
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
command += node_tests_cmd
else:
# Normal testing, no coverage analysis.
# Run the index.js test runner, which runs all the other tests.
command = node_tests_cmd
try:
ret = subprocess.check_call(command)
except OSError:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
print(f"Bad command: {command}")
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
raise
except subprocess.CalledProcessError:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
print("\n** Tests failed, PLEASE FIX! **\n")
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
sys.exit(1)
return ret
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
def check_line_coverage(
fn: str, line_coverage: Dict[Any, Any], line_mapping: Dict[Any, Any], log: bool = True
) -> bool:
test-js-with-node: Extract check_line_coverage function.
2017-06-23 11:53:25 +02:00
missing_lines = []
for line in line_coverage:
if line_coverage[line] == 0:
actual_line = line_mapping[line]
missing_lines.append(str(actual_line["start"]["line"]))
if missing_lines:
if log:
python: Convert percent formatting to Python 3.6 f-strings. Generated by pyupgrade --py36-plus. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-10 06:41:04 +02:00
print_error(f"{fn} no longer has complete node test coverage")
print(" Lines missing coverage: {}".format(", ".join(sorted(missing_lines, key=int))))
test-js-with-node: Extract check_line_coverage function.
2017-06-23 11:53:25 +02:00
print()
return False
return True
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
def read_coverage() -> Any:
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
coverage_json = None
try:
python: Replace ujson with orjson. Fixes #6507. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 01:09:47 +02:00
with open(NODE_COVERAGE_PATH, "rb") as f:
coverage_json = orjson.loads(f.read())
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
except OSError:
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
print(NODE_COVERAGE_PATH + " doesn't exist. Cannot enforce fully covered files.")
raise
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
return coverage_json
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
def enforce_proper_coverage(coverage_json: Any) -> bool:
node_tests: Enforce 100% coverage for test files. This makes it easier to find obsolete parts of the tests that should be cleaned up. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-09 23:44:38 +02:00
all_js_files = {
web: Move web app to ‘web’ directory. Ever since we started bundling the app with webpack, there’s been less and less overlap between our ‘static’ directory (files belonging to the frontend app) and Django’s interpretation of the ‘static’ directory (files served directly to the web). Split the app out to its own ‘web’ directory outside of ‘static’, and remove all the custom collectstatic --ignore rules. This makes it much clearer what’s actually being served to the web, and what’s being bundled by webpack. It also shrinks the release tarball by 3%. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:03:47 +01:00
*glob.glob("web/shared/src/*.js"),
*glob.glob("web/shared/src/*.ts"),
*glob.glob("web/src/*.js"),
*glob.glob("web/src/*.ts"),
*glob.glob("web/src/billing/*.js"),
node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-22 23:04:10 +01:00
*glob.glob("web/tests/*.js"),
*glob.glob("web/tests/lib/*.js"),
node_tests: Enforce 100% coverage for test files. This makes it easier to find obsolete parts of the tests that should be cleaned up. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-09 23:44:38 +02:00
}
enforce_fully_covered = sorted(all_js_files - EXEMPT_FILES)
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
coverage_lost = False
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
for relative_path in enforce_fully_covered:
path = ROOT_DIR + "/" + relative_path
python: Use ‘not in’ for more negated membership tests. Fixes “E713 Test for membership should be `not in`” found by ruff (now that I’ve fixed it not to ignore scripts lacking a .py extension). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-09-26 01:56:42 +02:00
if path not in coverage_json:
node tests: Fix bug with zero-coverage case. If a file that had 100% coverage somehow regressed to 0% coverage, we would report an error to the console, but we weren't treating it as an actual failure. We've probably always had this bug, but it probably rarely was an issue, since devs might have seen the error locally, or hopefully whatever crazy thing you did to totally remove coverage would have had other symptoms. If this was intentional, I suspect it might have had something to do with wanting to get coverage reports when you just run individual tests. But a while back we changed it so that when you run individual tests, we don't do the line coverage enforcement.
2020-02-09 15:11:49 +01:00
coverage_lost = True
python: Convert percent formatting to Python 3.6 f-strings. Generated by pyupgrade --py36-plus. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-10 06:41:04 +02:00
print_error(f"{relative_path} has no node test coverage")
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
continue
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
line_coverage = coverage_json[path]["s"]
line_mapping = coverage_json[path]["statementMap"]
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
if not check_line_coverage(relative_path, line_coverage, line_mapping):
coverage_lost = True
if coverage_lost:
tests: Clean up test-js-with-node output on success.
2018-03-25 08:53:40 +02:00
print()
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
print("It looks like your changes lost 100% test coverage in one or more files.")
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
print("Ideally, you should add some tests to restore coverage.")
print("A worse option is to update EXEMPT_FILES in `tools/test-js-with-node`.")
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
print("To run this check locally, use `test-js-with-node --coverage`.")
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
print()
node tests: Add support for enforcing 100% test coverage. Fixes #5178.
2017-06-07 04:24:39 +02:00
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
coverage_not_enforced = False
test-js-with-node: Add check for fully covered files that are not enforced.
2017-06-23 12:04:23 +02:00
for path in coverage_json:
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
relative_path = os.path.relpath(path, ROOT_DIR)
if relative_path in EXEMPT_FILES:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
line_coverage = coverage_json[path]["s"]
line_mapping = coverage_json[path]["statementMap"]
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
if check_line_coverage(relative_path, line_coverage, line_mapping, log=False):
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
coverage_not_enforced = True
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
print_error(f"{relative_path} unexpectedly has 100% line coverage.")
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
if coverage_not_enforced:
tests: Clean up test-js-with-node output on success.
2018-03-25 08:53:40 +02:00
print()
node tests: Use EXEMPT_FILES for line coverage. We now have 100% line coverage on 71 JS files. This is thanks to about 150 people who have contributed code to frontend/node_tests. And then 126 files are still short of 100% line coverage. We now enforce line coverage with a set called EXEMPT_FILES, which are the files for which we do NOT expect to have 100% coverage. Using an exemption list makes it so that adding a new JS file to the project without 100% line coverage will cause the build to fail. This will encourage folks to be intentional about their lack of test coverage.
2020-02-09 14:47:22 +01:00
print("One or more fully covered files are miscategorized.")
print("Remove the file(s) from EXEMPT_FILES in `tools/test-js-with-node`.")
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
problems_encountered = coverage_lost or coverage_not_enforced
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
return problems_encountered
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
test-js-with-node: Extract run_tests_via_node_js().
2020-01-26 15:57:47 +01:00
ret = run_tests_via_node_js()
node tests: Allow --coverage for individual files. We now allow you to run --coverage on individual files. This helps when you want to make sure a file is being covered directly and not just getting incidental coverage from higher level tests. Before this commit, we were conflating wanting coverage reports with wanting coverage checks. For individual files, we now solve that by simply eliminating the coverage checks. This required some minor refactoring to extract some functions.
2018-04-16 15:46:40 +02:00
if options.coverage and ret == 0:
if not individual_files:
coverage_json = read_coverage()
problems_encountered = enforce_proper_coverage(coverage_json)
if problems_encountered:
ret = 1
test-js-with-node: Add check for fully covered files that are not enforced.
2017-06-23 12:04:23 +02:00
node tests: Show coverage link when we regress coverage. In 6653e19e3aa5f8f9128a2507cf5b43c15b056d67 we added the convenient line to tell folks about the coverage report. But if we failed coverage checks, we didn't show the link. Arguably we should just always show this, even if tests fail, but that can also be potentially confusing.
2020-09-03 13:20:34 +02:00
reports_location = f"http://{get_dev_host()}/node-coverage/index.html"
print()
print("View coverage reports at " + CYAN + reports_location + ENDC)
tests: Clean up test-js-with-node output on success.
2018-03-25 08:53:40 +02:00
print()
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
if ret == 0:
node tests: Add some color to output.
2020-02-09 15:09:37 +01:00
print(GREEN + "Test(s) passed. SUCCESS!" + ENDC)
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
else:
node tests: Add some color to output.
2020-02-09 15:09:37 +01:00
print(BOLDRED + "FAIL - Test(s) failed" + ENDC)
tools: Convert test-js-with-node to Python. This is mostly a straight port from bash to Python, but we rename the coverage option to `--coverage` and we add checks for being in a venv and being correctly provisioned. Fixes #4009.
2017-04-05 17:47:13 +02:00
sys.exit(ret)