Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node tests: Show coverage link when we regress coverage. 

In 6653e19e3a we added
the convenient line to tell folks about the coverage
report.  But if we failed coverage checks, we didn't
show the link.

Arguably we should just always show this, even if
tests fail, but that can also be potentially confusing.
This commit is contained in:
Steve Howell 2020-09-03 11:20:34 +00:00 committed by Steve Howell
parent dc1795a3da
commit 81b6583d28
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/test-js-with-node
View File

@ -341,12 +341,12 @@ if options.coverage and ret == 0:
if problems_encountered:
ret = 1
reports_location = f"http://{get_dev_host()}/node-coverage/index.html"
print()
print("View coverage reports at " + CYAN + reports_location + ENDC)
print()
if ret == 0:
if options.coverage:
reports_location = f'http://{get_dev_host()}/node-coverage/index.html'
print('View coverage reports at ' + CYAN + reports_location + ENDC)
print(GREEN + "Test(s) passed. SUCCESS!" + ENDC)
else:
print(BOLDRED + "FAIL - Test(s) failed" + ENDC)