2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2021-03-25 22:35:45 +01:00
|
|
|
const {zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2020-08-20 21:24:06 +02:00
|
|
|
const people = zrequire("people");
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
const {Filter} = zrequire("../js/filter");
|
2021-02-10 04:53:22 +01:00
|
|
|
const stream_data = zrequire("stream_data");
|
|
|
|
const narrow_state = zrequire("narrow_state");
|
2017-06-01 20:45:32 +02:00
|
|
|
|
|
|
|
function set_filter(operators) {
|
2020-07-02 01:39:34 +02:00
|
|
|
operators = operators.map((op) => ({
|
js: Convert _.map(a, …) to a.map(…).
And convert the corresponding function expressions to arrow style
while we’re here.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitCallExpression(path) {
const { callee, arguments: args } = path.node;
if (
n.MemberExpression.check(callee) &&
!callee.computed &&
n.Identifier.check(callee.object) &&
callee.object.name === "_" &&
n.Identifier.check(callee.property) &&
callee.property.name === "map" &&
args.length === 2 &&
checkExpression(args[0]) &&
checkExpression(args[1])
) {
const [arr, fn] = args;
path.replace(
b.callExpression(b.memberExpression(arr, b.identifier("map")), [
n.FunctionExpression.check(fn) ||
n.ArrowFunctionExpression.check(fn)
? b.arrowFunctionExpression(
fn.params,
n.BlockStatement.check(fn.body) &&
fn.body.body.length === 1 &&
n.ReturnStatement.check(fn.body.body[0])
? fn.body.body[0].argument || b.identifier("undefined")
: fn.body
)
: fn,
])
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 02:43:49 +01:00
|
|
|
operator: op[0],
|
|
|
|
operand: op[1],
|
|
|
|
}));
|
2017-06-01 20:45:32 +02:00
|
|
|
narrow_state.set_current_filter(new Filter(operators));
|
|
|
|
}
|
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
function test(label, f) {
|
2021-06-16 14:38:37 +02:00
|
|
|
run_test(label, ({override}) => {
|
2021-03-09 14:50:26 +01:00
|
|
|
narrow_state.reset_current_filter();
|
|
|
|
stream_data.clear_subscriptions();
|
2021-06-16 14:38:37 +02:00
|
|
|
f({override});
|
2021-03-09 14:50:26 +01:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
test("stream", () => {
|
2017-06-01 20:57:17 +02:00
|
|
|
assert.equal(narrow_state.public_operators(), undefined);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.active());
|
2017-06-01 20:57:17 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
const test_stream = {name: "Test", stream_id: 15};
|
2020-02-09 22:02:55 +01:00
|
|
|
stream_data.add_sub(test_stream);
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.is_for_stream_id(test_stream.stream_id));
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2017-06-01 20:57:17 +02:00
|
|
|
set_filter([
|
2020-07-15 01:29:15 +02:00
|
|
|
["stream", "Test"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
["search", "yo"],
|
2017-06-01 20:57:17 +02:00
|
|
|
]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(narrow_state.active());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.stream(), "Test");
|
2020-09-23 02:22:47 +02:00
|
|
|
assert.equal(narrow_state.stream_sub().stream_id, test_stream.stream_id);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.topic(), "Bar");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(narrow_state.is_for_stream_id(test_stream.stream_id));
|
2017-06-01 20:57:17 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const expected_operators = [
|
2020-07-16 22:40:18 +02:00
|
|
|
{negated: false, operator: "stream", operand: "Test"},
|
|
|
|
{negated: false, operator: "topic", operand: "Bar"},
|
|
|
|
{negated: false, operator: "search", operand: "yo"},
|
2017-06-01 20:57:17 +02:00
|
|
|
];
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const public_operators = narrow_state.public_operators();
|
2017-06-01 20:57:17 +02:00
|
|
|
assert.deepEqual(public_operators, expected_operators);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.search_string(), "stream:Test topic:Bar yo");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("narrowed", () => {
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_stream_reply());
|
2020-09-23 02:22:47 +02:00
|
|
|
assert.equal(narrow_state.stream_sub(), undefined);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_starred());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["stream", "Foo"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(narrow_state.narrowed_by_stream_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_starred());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "steve@zulip.com"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_stream_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_starred());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "bar"],
|
|
|
|
]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_stream_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_starred());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["search", "grail"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_stream_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_starred());
|
2020-02-25 20:46:21 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "starred"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.narrowed_to_pms());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_pm_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_topic_reply());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_search());
|
|
|
|
assert.ok(!narrow_state.narrowed_to_topic());
|
|
|
|
assert.ok(!narrow_state.narrowed_by_stream_reply());
|
|
|
|
assert.ok(narrow_state.narrowed_to_starred());
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("operators", () => {
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
["search", "Yo"],
|
|
|
|
]);
|
2019-11-02 00:06:25 +01:00
|
|
|
let result = narrow_state.operators();
|
2017-06-01 20:45:32 +02:00
|
|
|
assert.equal(result.length, 3);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(result[0].operator, "stream");
|
|
|
|
assert.equal(result[0].operand, "Foo");
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(result[1].operator, "topic");
|
|
|
|
assert.equal(result[1].operand, "Bar");
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(result[2].operator, "search");
|
|
|
|
assert.equal(result[2].operand, "yo");
|
2017-12-02 03:18:05 +01:00
|
|
|
|
|
|
|
narrow_state.reset_current_filter();
|
|
|
|
result = narrow_state.operators();
|
|
|
|
assert.equal(result.length, 0);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("excludes_muted_topics", () => {
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["stream", "devel"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(narrow_state.excludes_muted_topics());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
|
|
|
narrow_state.reset_current_filter(); // not narrowed, basically
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(narrow_state.excludes_muted_topics());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "devel"],
|
|
|
|
["topic", "mac"],
|
|
|
|
]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.excludes_muted_topics());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["search", "whatever"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.excludes_muted_topics());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "private"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.excludes_muted_topics());
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "starred"]]);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!narrow_state.excludes_muted_topics());
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("set_compose_defaults", () => {
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
]);
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const stream_and_subject = narrow_state.set_compose_defaults();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(stream_and_subject.stream, "Foo");
|
|
|
|
assert.equal(stream_and_subject.topic, "Bar");
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "foo@bar.com"]]);
|
2019-11-02 00:06:25 +01:00
|
|
|
let pm_test = narrow_state.set_compose_defaults();
|
2018-05-28 11:44:28 +02:00
|
|
|
assert.equal(pm_test.private_message_recipient, undefined);
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const john = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "john@doe.com",
|
2018-05-28 11:44:28 +02:00
|
|
|
user_id: 57,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "John Doe",
|
2018-05-28 11:44:28 +02:00
|
|
|
};
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(john);
|
|
|
|
people.add_active_user(john);
|
2018-05-28 11:44:28 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "john@doe.com"]]);
|
2018-05-28 11:44:28 +02:00
|
|
|
pm_test = narrow_state.set_compose_defaults();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(pm_test.private_message_recipient, "john@doe.com");
|
2017-11-29 23:47:13 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["topic", "duplicate"],
|
|
|
|
["topic", "duplicate"],
|
|
|
|
]);
|
2017-12-02 23:10:09 +01:00
|
|
|
assert.deepEqual(narrow_state.set_compose_defaults(), {});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
stream_data.add_sub({name: "ROME", stream_id: 99});
|
|
|
|
set_filter([["stream", "rome"]]);
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const stream_test = narrow_state.set_compose_defaults();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(stream_test.stream, "ROME");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-06-01 20:45:32 +02:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("update_email", () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const steve = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "steve@foo.com",
|
2017-06-01 20:45:32 +02:00
|
|
|
user_id: 43,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Steve",
|
2017-06-01 20:45:32 +02:00
|
|
|
};
|
|
|
|
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(steve);
|
2017-06-01 20:45:32 +02:00
|
|
|
set_filter([
|
2020-07-15 01:29:15 +02:00
|
|
|
["pm-with", "steve@foo.com"],
|
|
|
|
["sender", "steve@foo.com"],
|
|
|
|
["stream", "steve@foo.com"], // try to be tricky
|
2017-06-01 20:45:32 +02:00
|
|
|
]);
|
2020-07-15 01:29:15 +02:00
|
|
|
narrow_state.update_email(steve.user_id, "showell@foo.com");
|
2019-11-02 00:06:25 +01:00
|
|
|
const filter = narrow_state.filter();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.deepEqual(filter.operands("pm-with"), ["showell@foo.com"]);
|
|
|
|
assert.deepEqual(filter.operands("sender"), ["showell@foo.com"]);
|
|
|
|
assert.deepEqual(filter.operands("stream"), ["steve@foo.com"]);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("topic", () => {
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
]);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.topic(), "Bar");
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "release"],
|
|
|
|
["topic", "@#$$^test"],
|
|
|
|
]);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.topic(), "@#$$^test");
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2020-02-08 01:27:04 +01:00
|
|
|
set_filter([]);
|
2017-11-29 17:32:25 +01:00
|
|
|
assert.equal(narrow_state.topic(), undefined);
|
|
|
|
|
|
|
|
set_filter([
|
2020-07-15 01:29:15 +02:00
|
|
|
["sender", "test@foo.com"],
|
|
|
|
["pm-with", "test@foo.com"],
|
2017-11-29 17:32:25 +01:00
|
|
|
]);
|
|
|
|
assert.equal(narrow_state.topic(), undefined);
|
2017-12-14 19:02:06 +01:00
|
|
|
|
|
|
|
narrow_state.set_current_filter(undefined);
|
|
|
|
assert.equal(narrow_state.topic(), undefined);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("stream_sub", () => {
|
2020-02-08 01:27:04 +01:00
|
|
|
set_filter([]);
|
2017-11-29 17:32:25 +01:00
|
|
|
assert.equal(narrow_state.stream(), undefined);
|
2020-09-23 02:22:47 +02:00
|
|
|
assert.equal(narrow_state.stream_sub(), undefined);
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
]);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(narrow_state.stream(), "Foo");
|
2018-05-02 13:51:02 +02:00
|
|
|
assert.equal(narrow_state.stream_sub(), undefined);
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
const sub = {name: "Foo", stream_id: 55};
|
2020-02-09 22:02:55 +01:00
|
|
|
stream_data.add_sub(sub);
|
2018-05-02 13:51:02 +02:00
|
|
|
assert.deepEqual(narrow_state.stream_sub(), sub);
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["sender", "someone"],
|
|
|
|
["topic", "random"],
|
|
|
|
]);
|
2017-11-29 17:32:25 +01:00
|
|
|
assert.equal(narrow_state.stream(), undefined);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-11-29 17:32:25 +01:00
|
|
|
|
2021-03-09 14:50:26 +01:00
|
|
|
test("pm_string", () => {
|
2018-02-09 22:26:45 +01:00
|
|
|
// This function will return undefined unless we're clearly
|
|
|
|
// narrowed to a specific PM (including huddles) with real
|
|
|
|
// users.
|
|
|
|
narrow_state.set_current_filter(undefined);
|
|
|
|
assert.equal(narrow_state.pm_string(), undefined);
|
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "Foo"],
|
|
|
|
["topic", "Bar"],
|
|
|
|
]);
|
2018-02-09 22:26:45 +01:00
|
|
|
assert.equal(narrow_state.pm_string(), undefined);
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", ""]]);
|
2018-02-09 22:26:45 +01:00
|
|
|
assert.equal(narrow_state.pm_string(), undefined);
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "bogus@foo.com"]]);
|
2018-02-09 22:26:45 +01:00
|
|
|
assert.equal(narrow_state.pm_string(), undefined);
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "alice@foo.com",
|
2018-02-09 22:26:45 +01:00
|
|
|
user_id: 444,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Alice",
|
2018-02-09 22:26:45 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const bob = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "bob@foo.com",
|
2018-02-09 22:26:45 +01:00
|
|
|
user_id: 555,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Bob",
|
2018-02-09 22:26:45 +01:00
|
|
|
};
|
|
|
|
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(alice);
|
|
|
|
people.add_active_user(bob);
|
2018-02-09 22:26:45 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "bob@foo.com,alice@foo.com"]]);
|
|
|
|
assert.equal(narrow_state.pm_string(), "444,555");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|