zjsunit: Deglobalize assert.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -361,7 +361,6 @@
         {
             "files": ["frontend_tests/**"],
             "globals": {
-                "assert": false,
                 "document": false,
                 "reset_module": false,
                 "set_global": false,

frontend_tests/node_tests/activity.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("to_$", () => window_stub);

frontend_tests/node_tests/alert_words.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const params = {
     alert_words: ["alertone", "alerttwo", "alertthree", "al*rt.*s", ".+", "emoji"],
 };

frontend_tests/node_tests/alert_words_ui.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 
 set_global("channel", {});

frontend_tests/node_tests/billing.js

@@ -1,10 +1,11 @@
 "use strict";
 
-const noop = () => {};
+const {strict: assert} = require("assert");
 const fs = require("fs");
 
 const {JSDOM} = require("jsdom");
 
+const noop = () => {};
 const template = fs.readFileSync("templates/corporate/billing.html", "utf-8");
 const dom = new JSDOM(template, {pretendToBeVisual: true});
 const document = dom.window.document;

frontend_tests/node_tests/billing_helpers.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const {strict: assert} = require("assert");
 const fs = require("fs");
 
 const JQuery = require("jquery");

frontend_tests/node_tests/blueslip_stacktrace.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const blueslip_stacktrace = zrequire("blueslip_stacktrace");
 
 run_test("clean_path", () => {

frontend_tests/node_tests/bot_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _settings_bots = {
     render_bots: () => {},
 };

frontend_tests/node_tests/buddy_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 const _page_params = {};

frontend_tests/node_tests/buddy_list.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/channel.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 set_global("$", {});

frontend_tests/node_tests/color_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("color_data");
 
 run_test("pick_color", () => {

frontend_tests/node_tests/colorspace.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("colorspace");
 
 run_test("sRGB_to_linear", () => {

frontend_tests/node_tests/common.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const noop = () => {};
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/components.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 zrequire("keydown_util");

frontend_tests/node_tests/compose.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const {JSDOM} = require("jsdom");
 const rewiremock = require("rewiremock/node");
 

frontend_tests/node_tests/compose_actions.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const noop = function () {};
 const return_false = function () {
     return false;

frontend_tests/node_tests/compose_fade.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("stream_data");
 const people = zrequire("people");
 zrequire("compose_fade");

frontend_tests/node_tests/compose_pm_pill.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 
 const people = zrequire("people");

frontend_tests/node_tests/compose_ui.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const autosize = require("autosize");
 
 zrequire("compose_ui");

frontend_tests/node_tests/composebox_typeahead.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const emoji = zrequire("emoji", "shared/js/emoji");
 const typeahead = zrequire("typeahead", "shared/js/typeahead");
 zrequire("compose_state");

frontend_tests/node_tests/copy_and_paste.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 global.stub_out_jquery();
 
 set_global("page_params", {

frontend_tests/node_tests/dispatch.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const noop = function () {};
 
 const events = require("./lib/events");

frontend_tests/node_tests/dispatch_subs.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const events = require("./lib/events");
 
 const event_fixtures = events.fixtures;

frontend_tests/node_tests/drafts.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const XDate = require("xdate");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/dropdown_list_widget.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("dropdown_list_widget");
 zrequire("scroll_util");
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/echo.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 set_global("markdown", {});
 set_global("local_message", {

frontend_tests/node_tests/emoji.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
 
 const events = require("./lib/events");

frontend_tests/node_tests/emoji_picker.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 const emoji = zrequire("emoji", "shared/js/emoji");

frontend_tests/node_tests/fenced_code.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const fenced_code = zrequire("fenced_code", "shared/js/fenced_code");
 
 run_test("get_unused_fence", () => {

frontend_tests/node_tests/fetch_status.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const FetchStatus = zrequire("fetch_status");
 set_global("message_scroll", {
     hide_loading_older: () => {},

frontend_tests/node_tests/filter.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("unread");
 zrequire("stream_data");
 const people = zrequire("people");

frontend_tests/node_tests/fold_dict.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const {FoldDict} = zrequire("fold_dict");
 
 run_test("basic", () => {

frontend_tests/node_tests/general.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 // This is a general tour of how to write node tests that
 // may also give you some quick insight on how the Zulip
 // browser app is constructed.  Let's start with testing

frontend_tests/node_tests/hash_util.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("hash_util");
 zrequire("stream_data");
 const people = zrequire("people");

frontend_tests/node_tests/hashchange.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("location", {

frontend_tests/node_tests/hotkey.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 // Important note on these tests:
 //
 // The way the Zulip hotkey tests work is as follows.  First, we set

frontend_tests/node_tests/i18n.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("templates");
 
 // We download our translations in `page_params` (which

frontend_tests/node_tests/input_pill.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 zrequire("input_pill");
 

frontend_tests/node_tests/lazy_set.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const {LazySet} = zrequire("lazy_set");
 
 /*

frontend_tests/node_tests/lightbox.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("rows");
 zrequire("lightbox");
 

frontend_tests/node_tests/list_cursor.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("list_cursor");
 
 run_test("config errors", () => {

frontend_tests/node_tests/list_render.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("list_render");
 
 // We need these stubs to get by instanceof checks.

frontend_tests/node_tests/markdown.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("hash_util");
 
 const emoji = zrequire("emoji", "shared/js/emoji");

frontend_tests/node_tests/message_edit.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("document", null);
 set_global("page_params", {
     realm_community_topic_editing_limit_seconds: 86400,

frontend_tests/node_tests/message_events.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("message_events");
 zrequire("message_store");
 zrequire("muting");

frontend_tests/node_tests/message_fetch.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/message_flags.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("unread");
 zrequire("unread_ops");
 zrequire("message_flags");

frontend_tests/node_tests/message_list.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const {strict: assert} = require("assert");
 // These unit tests for static/js/message_list.js emphasize the model-ish
 // aspects of the MessageList class.  We have to stub out a few functions
 // related to views and events to get the tests working.

frontend_tests/node_tests/message_list_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("unread");
 
 zrequire("Filter", "js/filter");

frontend_tests/node_tests/message_list_view.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/message_store.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const util = zrequire("util");
 zrequire("pm_conversations");
 const people = zrequire("people");

frontend_tests/node_tests/muting.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("timerender");
 zrequire("muting");
 zrequire("stream_data");

frontend_tests/node_tests/narrow.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 zrequire("hash_util");
 zrequire("hashchange");

frontend_tests/node_tests/narrow_activate.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const util = zrequire("util");
 set_global("$", global.make_zjquery());
 

frontend_tests/node_tests/narrow_local.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("Filter", "js/filter");
 zrequire("FetchStatus", "js/fetch_status");
 zrequire("MessageListData", "js/message_list_data");

frontend_tests/node_tests/narrow_state.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const people = zrequire("people");
 zrequire("Filter", "js/filter");
 zrequire("stream_data");

frontend_tests/node_tests/narrow_unread.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("Filter", "js/filter");
 const people = zrequire("people");
 zrequire("stream_data");

frontend_tests/node_tests/notifications.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rewiremock = require("rewiremock/node");
 
 // Dependencies

frontend_tests/node_tests/password.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("zxcvbn", zrequire("zxcvbn", "zxcvbn"));
 zrequire("common");
 

frontend_tests/node_tests/people.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 const moment = require("moment-timezone");
 const rewiremock = require("rewiremock/node");

frontend_tests/node_tests/people_errors.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const people = zrequire("people");
 
 const return_false = function () {

frontend_tests/node_tests/pm_conversations.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const pmc = zrequire("pm_conversations");
 
 run_test("partners", () => {

frontend_tests/node_tests/pm_list.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 
 set_global("narrow_state", {});

frontend_tests/node_tests/poll_widget.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("poll_widget");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/popovers.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rewiremock = require("rewiremock/node");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/presence.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const XDate = require("xdate");
 
 const people = zrequire("people");

frontend_tests/node_tests/reactions.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("document", "document-stub");
 set_global("$", global.make_zjquery());
 

frontend_tests/node_tests/recent_senders.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rs = zrequire("recent_senders");
 
 let next_id = 0;

frontend_tests/node_tests/recent_topics.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("message_util");
 
 const noop = () => {};

frontend_tests/node_tests/rendered_markdown.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rm = zrequire("rendered_markdown");
 const people = zrequire("people");
 zrequire("user_groups");

frontend_tests/node_tests/rtl.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rtl = zrequire("rtl");
 
 run_test("get_direction", () => {

frontend_tests/node_tests/schema.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("schema");
 
 run_test("basics", () => {

frontend_tests/node_tests/scroll_util.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("scroll_util");
 set_global("ui", {
     get_scroll_element: (element) => element,

frontend_tests/node_tests/search.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("page_params", {
     search_pills_enabled: true,
 });

frontend_tests/node_tests/search_legacy.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("page_params", {
     search_pills_enabled: false,
 });

frontend_tests/node_tests/search_pill.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("search_pill");
 zrequire("input_pill");
 zrequire("Filter", "js/filter");

frontend_tests/node_tests/search_suggestion.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("page_params", {
     search_pills_enabled: true,
 });

frontend_tests/node_tests/search_suggestion_legacy.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("page_params", {
     search_pills_enabled: false,
 });

frontend_tests/node_tests/server_events.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const noop = function () {};
 
 set_global("document", {});

frontend_tests/node_tests/settings_bots.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rewiremock = require("rewiremock/node");
 
 set_global("page_params", {

frontend_tests/node_tests/settings_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const settings_data = zrequire("settings_data");
 const settings_config = zrequire("settings_config");
 

frontend_tests/node_tests/settings_emoji.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 set_global("upload_widget", {});
 zrequire("settings_emoji");

frontend_tests/node_tests/settings_muting.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 set_global("XDate", zrequire("XDate", "xdate"));
 

frontend_tests/node_tests/settings_org.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rewiremock = require("rewiremock/node");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/settings_profile_fields.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const rewiremock = require("rewiremock/node");
 
 set_global("page_params", {});

frontend_tests/node_tests/settings_user_groups.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 zrequire("user_pill");

frontend_tests/node_tests/spoilers.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("$", global.make_zjquery());
 zrequire("spoilers");
 

frontend_tests/node_tests/stream_data.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const _ = require("lodash");
 
 set_global("page_params", {

frontend_tests/node_tests/stream_edit.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const {LazySet} = zrequire("lazy_set");
 
 const noop = () => {};

frontend_tests/node_tests/stream_events.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const noop = function () {};
 const return_true = function () {
     return true;

frontend_tests/node_tests/stream_list.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 set_global("document", "document-stub");
 set_global("$", global.make_zjquery());
 

frontend_tests/node_tests/stream_pill.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("stream_data");
 zrequire("stream_pill");
 

frontend_tests/node_tests/stream_search.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const {strict: assert} = require("assert");
 // This tests the stream searching functionality which currently
 // lives in stream_list.js.
 

frontend_tests/node_tests/stream_sort.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("stream_data");
 zrequire("stream_sort");
 

frontend_tests/node_tests/stream_topic_history.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("unread");
 zrequire("stream_data");
 zrequire("stream_topic_history");

frontend_tests/node_tests/submessage.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 zrequire("submessage");
 
 set_global("channel", {});

frontend_tests/node_tests/subs.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 global.stub_out_jquery();
 
 set_global("ui", {

frontend_tests/node_tests/support.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const {strict: assert} = require("assert");
 const fs = require("fs");
 
 const {JSDOM} = require("jsdom");

frontend_tests/node_tests/timerender.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const {strict: assert} = require("assert");
+
 const moment = require("moment");
 const XDate = require("xdate");