js: Purge people module from window.

.eslintrc.json

@@ -191,7 +191,6 @@
                 "page_params": false,
                 "panels": false,
                 "pill_typeahead": false,
-                "people": false,
                 "pm_list": false,
                 "pm_list_dom": false,
                 "pointer": false,

frontend_tests/node_tests/activity.js

@@ -81,7 +81,7 @@ zrequire("unread");
 zrequire("hash_util");
 zrequire("narrow");
 zrequire("presence");
-zrequire("people");
+const people = zrequire("people");
 zrequire("buddy_data");
 zrequire("buddy_list");
 zrequire("user_search");

frontend_tests/node_tests/alert_words.js

@@ -4,7 +4,7 @@ const params = {
     alert_words: ["alertone", "alerttwo", "alertthree", "al*rt.*s", ".+", "emoji"],
 };
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("alert_words");
 
 alert_words.initialize(params);

frontend_tests/node_tests/bot_data.js

@@ -7,7 +7,7 @@ const _settings_bots = {
 set_global("settings_bots", _settings_bots);
 
 zrequire("bot_data");
-zrequire("people");
+const people = zrequire("people");
 
 const me = {
     email: "me@zulip.com",

frontend_tests/node_tests/buddy_data.js

@@ -6,7 +6,7 @@ const _page_params = {};
 
 set_global("page_params", _page_params);
 set_global("$", global.make_zjquery());
-zrequire("people");
+const people = zrequire("people");
 zrequire("presence");
 zrequire("user_status");
 

frontend_tests/node_tests/buddy_list.js

@@ -3,7 +3,7 @@
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());
-zrequire("people");
+const people = zrequire("people");
 zrequire("buddy_data");
 zrequire("buddy_list");
 zrequire("ui");

frontend_tests/node_tests/compose.js

@@ -73,7 +73,7 @@ zrequire("rtl");
 zrequire("common");
 zrequire("stream_data");
 zrequire("compose_state");
-zrequire("people");
+const people = zrequire("people");
 zrequire("input_pill");
 zrequire("user_pill");
 zrequire("compose_pm_pill");

frontend_tests/node_tests/compose_actions.js

@@ -20,7 +20,7 @@ set_global("compose_pm_pill", {});
 
 set_global("hash_util", {});
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("compose_ui");
 zrequire("compose");
 zrequire("compose_state");

frontend_tests/node_tests/compose_fade.js

@@ -1,7 +1,7 @@
 "use strict";
 
 zrequire("stream_data");
-zrequire("people");
+const people = zrequire("people");
 zrequire("compose_fade");
 
 const me = {

frontend_tests/node_tests/compose_pm_pill.js

@@ -2,13 +2,7 @@
 
 set_global("$", global.make_zjquery());
 
-const _people = {
-    small_avatar_url_for_person() {
-        return "http://example.com/example.png";
-    },
-};
-
-set_global("people", _people);
+const people = zrequire("people");
 
 zrequire("compose_pm_pill");
 zrequire("input_pill");

frontend_tests/node_tests/compose_ui.js

@@ -1,7 +1,7 @@
 "use strict";
 
 zrequire("compose_ui");
-zrequire("people");
+const people = zrequire("people");
 zrequire("user_status");
 
 set_global("document", {

frontend_tests/node_tests/composebox_typeahead.js

@@ -6,7 +6,7 @@ zrequire("compose_state");
 zrequire("pm_conversations");
 zrequire("templates");
 zrequire("typeahead_helper");
-zrequire("people");
+const people = zrequire("people");
 zrequire("user_groups");
 zrequire("stream_data");
 zrequire("user_pill");

frontend_tests/node_tests/dispatch.js

@@ -75,7 +75,7 @@ zrequire("stream_topic_history");
 zrequire("stream_list");
 zrequire("message_flags");
 zrequire("message_store");
-zrequire("people");
+const people = zrequire("people");
 zrequire("starred_messages");
 zrequire("user_status");
 zrequire("subs");

frontend_tests/node_tests/dispatch_subs.js

@@ -9,7 +9,7 @@ set_global("compose_fade", {});
 set_global("stream_events", {});
 set_global("subs", {});
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("server_events_dispatch");
 

frontend_tests/node_tests/drafts.js

@@ -36,15 +36,6 @@ set_global("stream_data", {
         return "#FFFFFF";
     },
 });
-set_global("people", {
-    // Mocking get_by_email function, here we are
-    // just returning string before `@` in email
-    get_by_email(email) {
-        return {
-            full_name: email.split("@")[0],
-        };
-    },
-});
 set_global("markdown", {
     apply_markdown: noop,
 });
@@ -268,21 +259,21 @@ run_test("format_drafts", (override) => {
         {
             draft_id: "id2",
             is_stream: false,
-            recipients: "aaron",
+            recipients: "aaron@zulip.com",
             raw_content: "Test Private Message",
             time_stamp: "Jan 30",
         },
         {
             draft_id: "id5",
             is_stream: false,
-            recipients: "aaron",
+            recipients: "aaron@zulip.com",
             raw_content: "Test Private Message 3",
             time_stamp: "Jan 29",
         },
         {
             draft_id: "id4",
             is_stream: false,
-            recipients: "aaron",
+            recipients: "aaron@zulip.com",
             raw_content: "Test Private Message 2",
             time_stamp: "Jan 26",
         },

frontend_tests/node_tests/echo.js

@@ -8,7 +8,7 @@ set_global("local_message", {
 set_global("page_params", {});
 
 zrequire("echo");
-zrequire("people");
+const people = zrequire("people");
 
 let disparities = [];
 let messages_to_rerender = [];

frontend_tests/node_tests/filter.js

@@ -2,7 +2,7 @@
 
 zrequire("unread");
 zrequire("stream_data");
-zrequire("people");
+const people = zrequire("people");
 global.stub_out_jquery();
 set_global("$", global.make_zjquery());
 zrequire("message_util", "js/message_util");

frontend_tests/node_tests/general.js

@@ -17,7 +17,7 @@ assert(util.find_wildcard_mentions("mention @**everyone**"));
 //  * change the data
 //  * get a true value
 
-zrequire("people");
+const people = zrequire("people");
 const isaac = {
     email: "isaac@example.com",
     user_id: 30,

frontend_tests/node_tests/hash_util.js

@@ -2,7 +2,7 @@
 
 zrequire("hash_util");
 zrequire("stream_data");
-zrequire("people");
+const people = zrequire("people");
 zrequire("Filter", "js/filter");
 zrequire("narrow_state");
 

frontend_tests/node_tests/hashchange.js

@@ -8,7 +8,7 @@ set_global("location", {
 });
 set_global("to_$", () => window_stub);
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("hash_util");
 zrequire("hashchange");
 zrequire("stream_data");

frontend_tests/node_tests/markdown.js

@@ -10,7 +10,7 @@ const marked = zrequire("marked", "third/marked/lib/marked");
 
 zrequire("markdown");
 zrequire("message_store");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("user_groups");
 

frontend_tests/node_tests/message_events.js

@@ -3,7 +3,7 @@
 zrequire("message_events");
 zrequire("message_store");
 zrequire("muting");
-zrequire("people");
+const people = zrequire("people");
 zrequire("recent_senders");
 zrequire("stream_data");
 zrequire("stream_topic_history");

frontend_tests/node_tests/message_fetch.js

@@ -18,7 +18,7 @@ zrequire("FetchStatus", "js/fetch_status");
 zrequire("Filter", "js/filter");
 zrequire("MessageListData", "js/message_list_data");
 zrequire("message_list");
-zrequire("people");
+const people = zrequire("people");
 
 set_global("recent_topics", {
     process_messages: noop,

frontend_tests/node_tests/message_store.js

@@ -2,7 +2,7 @@
 
 const util = zrequire("util");
 zrequire("pm_conversations");
-zrequire("people");
+const people = zrequire("people");
 zrequire("message_store");
 
 const noop = function () {};

frontend_tests/node_tests/narrow.js

@@ -4,7 +4,7 @@ set_global("$", global.make_zjquery());
 zrequire("hash_util");
 zrequire("hashchange");
 zrequire("narrow_state");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("Filter", "js/filter");
 set_global("page_params", {

frontend_tests/node_tests/narrow_state.js

@@ -1,6 +1,6 @@
 "use strict";
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("Filter", "js/filter");
 zrequire("stream_data");
 zrequire("narrow_state");

frontend_tests/node_tests/narrow_unread.js

@@ -1,7 +1,7 @@
 "use strict";
 
 zrequire("Filter", "js/filter");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("unread");
 

frontend_tests/node_tests/people.js

@@ -4,9 +4,10 @@ const _ = require("lodash");
 const moment = require("moment-timezone");
 const rewiremock = require("rewiremock/node");
 
-rewiremock.proxy(() => zrequire("people"), {
+const people = rewiremock.proxy(() => zrequire("people"), {
     "moment-timezone": () => moment("20130208T080910"),
 });
+
 set_global("message_store", {});
 set_global("page_params", {});
 set_global("settings_data", {});

frontend_tests/node_tests/people_errors.js

@@ -1,6 +1,6 @@
 "use strict";
 
-zrequire("people");
+const people = zrequire("people");
 
 const return_false = function () {
     return false;

frontend_tests/node_tests/pm_conversations.js

@@ -15,7 +15,7 @@ run_test("partners", () => {
     assert.equal(pmc.is_partner(user3_id), true);
 });
 
-zrequire("people");
+const people = zrequire("people");
 
 run_test("insert_recent_private_message", () => {
     const params = {

frontend_tests/node_tests/pm_list.js

@@ -20,7 +20,7 @@ zrequire("user_status");
 zrequire("presence");
 zrequire("buddy_data");
 zrequire("hash_util");
-zrequire("people");
+const people = zrequire("people");
 const pm_conversations = zrequire("pm_conversations");
 zrequire("pm_list");
 

frontend_tests/node_tests/poll_widget.js

@@ -4,7 +4,7 @@ zrequire("poll_widget");
 
 set_global("$", global.make_zjquery());
 
-set_global("people", {});
+const people = zrequire("people");
 
 const return_false = () => false;
 const return_true = () => true;

frontend_tests/node_tests/popovers.js

@@ -7,7 +7,7 @@ set_global("$", global.make_zjquery());
 zrequire("hash_util");
 zrequire("narrow");
 zrequire("narrow_state");
-zrequire("people");
+const people = zrequire("people");
 zrequire("presence");
 zrequire("buddy_data");
 zrequire("user_status");

frontend_tests/node_tests/presence.js

@@ -2,7 +2,7 @@
 
 const XDate = require("xdate");
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("presence");
 
 const return_false = function () {

frontend_tests/node_tests/reactions.js

@@ -6,7 +6,7 @@ set_global("$", global.make_zjquery());
 const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
 const emoji = zrequire("emoji", "shared/js/emoji");
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("reactions");
 
 set_global("page_params", {

frontend_tests/node_tests/recent_topics.js

@@ -18,12 +18,11 @@ set_global("overlays", {
     },
     recent_topics_open: () => true,
 });
-set_global("people", {
-    is_my_user_id(id) {
-        return id === 1;
-    },
-    sender_info_with_small_avatar_urls_for_sender_ids: (ids) => ids,
-});
+
+const people = zrequire("people");
+people.is_my_user_id = (id) => id === 1;
+people.sender_info_with_small_avatar_urls_for_sender_ids = (ids) => ids;
+
 set_global("timerender", {
     last_seen_status_from_date: () => "Just now",
     get_full_datetime: () => ({

frontend_tests/node_tests/rendered_markdown.js

@@ -1,7 +1,7 @@
 "use strict";
 
 const rm = zrequire("rendered_markdown");
-zrequire("people");
+const people = zrequire("people");
 zrequire("user_groups");
 zrequire("stream_data");
 zrequire("timerender");

frontend_tests/node_tests/search_suggestion.js

@@ -19,7 +19,7 @@ zrequire("Filter", "js/filter");
 zrequire("narrow_state");
 zrequire("stream_data");
 zrequire("stream_topic_history");
-zrequire("people");
+const people = zrequire("people");
 zrequire("unread");
 zrequire("common");
 const search = zrequire("search_suggestion");

frontend_tests/node_tests/search_suggestion_legacy.js

@@ -18,7 +18,7 @@ zrequire("Filter", "js/filter");
 zrequire("narrow_state");
 zrequire("stream_data");
 zrequire("stream_topic_history");
-zrequire("people");
+const people = zrequire("people");
 zrequire("unread");
 zrequire("common");
 const search = zrequire("search_suggestion");

frontend_tests/node_tests/settings_user_groups.js

@@ -26,12 +26,9 @@ set_global("user_groups", {
     add: noop,
 });
 set_global("ui_report", {});
-set_global("people", {
-    my_current_user_id: noop,
-    small_avatar_url_for_person() {
-        return "http://example.com/example.png";
-    },
-});
+
+const people = zrequire("people");
+
 set_global("page_params", {});
 
 function reset_test_setup(pill_container_stub) {

frontend_tests/node_tests/stream_data.js

@@ -16,7 +16,7 @@ global.stub_out_jquery();
 zrequire("color_data");
 zrequire("hash_util");
 zrequire("stream_topic_history");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_color");
 zrequire("stream_data");
 zrequire("FetchStatus", "js/fetch_status");

frontend_tests/node_tests/stream_edit.js

@@ -31,7 +31,7 @@ set_global("ui", {
 set_global("$", global.make_zjquery());
 
 zrequire("input_pill");
-zrequire("people");
+const people = zrequire("people");
 zrequire("pill_typeahead");
 zrequire("subs");
 zrequire("stream_edit");

frontend_tests/node_tests/stream_events.js

@@ -18,7 +18,7 @@ set_global("stream_list", {});
 set_global("stream_muting", {});
 set_global("subs", {});
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("stream_events");
 zrequire("Filter", "js/filter");

frontend_tests/node_tests/top_left_corner.js

@@ -4,7 +4,7 @@ set_global("$", global.make_zjquery());
 
 zrequire("Filter", "js/filter");
 zrequire("unread_ui");
-zrequire("people");
+const people = zrequire("people");
 
 zrequire("top_left_corner");
 

frontend_tests/node_tests/transmit.js

@@ -12,7 +12,7 @@ set_global("sent_messages", {
     report_server_ack: noop,
 });
 
-zrequire("people");
+const people = zrequire("people");
 zrequire("transmit");
 
 run_test("transmit_message_ajax", () => {

frontend_tests/node_tests/typeahead_helper.js

@@ -10,7 +10,7 @@ page_params.realm_email_address_visibility =
     settings_config.email_address_visibility_values.admins_only.code;
 
 zrequire("recent_senders");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("narrow");
 zrequire("hash_util");

frontend_tests/node_tests/unread.js

@@ -3,7 +3,7 @@
 const _ = require("lodash");
 
 zrequire("muting");
-zrequire("people");
+const people = zrequire("people");
 zrequire("stream_data");
 zrequire("unread");
 

frontend_tests/node_tests/user_events.js

@@ -2,7 +2,7 @@
 
 set_global("$", global.make_zjquery());
 
-zrequire("people");
+const people = zrequire("people");
 const settings_config = zrequire("settings_config");
 zrequire("user_events");
 

frontend_tests/node_tests/user_pill.js

@@ -1,6 +1,6 @@
 "use strict";
 
-zrequire("people");
+const people = zrequire("people");
 set_global("md5", (s) => "md5-" + s);
 zrequire("user_pill");
 zrequire("pill_typeahead");

frontend_tests/puppeteer_lib/common.js

@@ -180,7 +180,10 @@ class CommonUtils {
         if (this.fullname[name] !== undefined) {
             name = this.fullname[name];
         }
-        return await page.evaluate((name) => people.get_user_id_from_name(name), name);
+        return await page.evaluate((name) => {
+            const people = require("./static/js/people");
+            return people.get_user_id_from_name(name);
+        }, name);
     }
 
     async get_internal_email_from_name(page, name) {
@@ -188,6 +191,7 @@ class CommonUtils {
             name = this.fullname[name];
         }
         return await page.evaluate((fullname) => {
+            const people = require("./static/js/people");
             const user_id = people.get_user_id_from_name(fullname);
             return people.get_by_user_id(user_id).email;
         }, name);

static/js/activity.js

@@ -1,6 +1,9 @@
 "use strict";
 
 const _ = require("lodash");
+
+const people = require("./people");
+
 /*
     Helpers for detecting user activity and managing user idle states
 */

static/js/alert_words.js

@@ -2,6 +2,8 @@
 
 const _ = require("lodash");
 
+const people = require("./people");
+
 // For simplicity, we use a list for our internal
 // data, since that matches what the server sends us.
 let my_alert_words = [];

static/js/bot_data.js

@@ -2,6 +2,8 @@
 
 const _ = require("lodash");
 
+const people = require("./people");
+
 const bots = new Map();
 
 const bot_fields = [

static/js/buddy_data.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const util = require("./util");
 /*
 

static/js/compose.js

@@ -8,6 +8,7 @@ const render_compose_invite_users = require("../templates/compose_invite_users.h
 const render_compose_not_subscribed = require("../templates/compose_not_subscribed.hbs");
 const render_compose_private_stream_alert = require("../templates/compose_private_stream_alert.hbs");
 
+const people = require("./people");
 const rendered_markdown = require("./rendered_markdown");
 const util = require("./util");
 

static/js/compose_actions.js

@@ -4,6 +4,8 @@ const autosize = require("autosize");
 
 const fenced_code = require("../shared/js/fenced_code");
 
+const people = require("./people");
+
 exports.blur_compose_inputs = function () {
     $(".message_comp").find("input, textarea, button, #private_message_recipient").trigger("blur");
 };

static/js/compose_fade.js

@@ -2,6 +2,7 @@
 
 const _ = require("lodash");
 
+const people = require("./people");
 const util = require("./util");
 
 let focused_recipient;

static/js/compose_pm_pill.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const util = require("./util");
 
 exports.initialize_pill = function () {

static/js/compose_ui.js

@@ -2,6 +2,8 @@
 
 const autosize = require("autosize");
 
+const people = require("./people");
+
 exports.autosize_textarea = function () {
     autosize.update($("#compose-textarea"));
 };

static/js/composebox_typeahead.js

@@ -8,6 +8,7 @@ const pygments_data = require("../generated/pygments_data.json");
 const emoji = require("../shared/js/emoji");
 const typeahead = require("../shared/js/typeahead");
 
+const people = require("./people");
 const settings_data = require("./settings_data");
 
 //************************************

static/js/drafts.js

@@ -5,6 +5,7 @@ const XDate = require("xdate");
 
 const render_draft_table_body = require("../templates/draft_table_body.hbs");
 
+const people = require("./people");
 const util = require("./util");
 
 function set_count(count) {

static/js/echo.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const util = require("./util");
 // Docs: https://zulip.readthedocs.io/en/latest/subsystems/sending-messages.html
 

static/js/filter.js

@@ -3,6 +3,7 @@
 const Handlebars = require("handlebars/runtime");
 const _ = require("lodash");
 
+const people = require("./people");
 const util = require("./util");
 
 function zephyr_stream_name_match(message, operand) {

static/js/global.d.ts

@@ -88,7 +88,6 @@ declare let overlays: any;
 declare let padded_widget: any;
 declare let page_params: any;
 declare let panels: any;
-declare let people: any;
 declare let pill_typeahead: any;
 declare let pm_list: any;
 declare let pointer: any;

static/js/hash_util.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const people = require("./people");
+
 exports.get_hash_category = function (hash) {
     // given "#streams/subscribed", returns "streams"
     return hash ? hash.replace(/^#/, "").split(/\//)[0] : "";

static/js/huddle_data.js

@@ -2,6 +2,8 @@
 
 const _ = require("lodash");
 
+const people = require("./people");
+
 const huddle_timestamps = new Map();
 
 exports.process_loaded_messages = function (messages) {

static/js/lightbox.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const people = require("./people");
+
 let is_open = false;
 // the asset map is a map of all retrieved images and YouTube videos that are
 // memoized instead of being looked up multiple times.

static/js/markdown_config.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const people = require("./people");
+
 /*
     This config is in a separate file for partly
     tactical reasons.  We want the webapp to

static/js/message_edit_history.js

@@ -4,6 +4,8 @@ const XDate = require("xdate");
 
 const render_message_edit_history = require("../templates/message_edit_history.hbs");
 
+const people = require("./people");
+
 exports.fetch_and_render_message_history = function (message) {
     channel.get({
         url: "/json/messages/" + message.id + "/history",

static/js/message_fetch.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const huddle_data = require("./huddle_data");
+const people = require("./people");
 
 const consts = {
     backfill_idle_time: 10 * 1000,

static/js/message_list_view.js

@@ -8,6 +8,7 @@ const render_message_group = require("../templates/message_group.hbs");
 const render_recipient_row = require("../templates/recipient_row.hbs");
 const render_single_message = require("../templates/single_message.hbs");
 
+const people = require("./people");
 const rendered_markdown = require("./rendered_markdown");
 const util = require("./util");
 

static/js/message_live_update.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const people = require("./people");
+
 function rerender_messages_view() {
     for (const list of [home_msg_list, message_list.narrowed, message_list.all]) {
         if (list === undefined) {

static/js/message_store.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const pm_conversations = require("./pm_conversations");
 const util = require("./util");
 

static/js/narrow.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const util = require("./util");
 
 let unnarrow_times;

static/js/narrow_state.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const people = require("./people");
+
 let current_filter;
 
 exports.reset_current_filter = function () {

static/js/notifications.js

@@ -5,6 +5,7 @@ const _ = require("lodash");
 const render_compose_notification = require("../templates/compose_notification.hbs");
 const render_notification = require("../templates/notification.hbs");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 
 const notice_memory = new Map();

static/js/people.js

@@ -1319,5 +1319,3 @@ exports.initialize = function (my_user_id, params) {
 
     exports.initialize_current_user(my_user_id);
 };
-
-window.people = exports;

static/js/pill_typeahead.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const settings_data = require("./settings_data");
 
 exports.set_up = function (input, pills, opts) {

static/js/pm_conversations.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const FoldDict = require("./fold_dict").FoldDict;
+const people = require("./people");
 
 const partners = new Set();
 

static/js/pm_list.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const people = require("./people");
 const pm_conversations = require("./pm_conversations");
 
 let prior_dom;

static/js/poll_widget.js

@@ -3,6 +3,8 @@
 const render_widgets_poll_widget = require("../templates/widgets/poll_widget.hbs");
 const render_widgets_poll_widget_results = require("../templates/widgets/poll_widget_results.hbs");
 
+const people = require("./people");
+
 class PollData {
     // This object just holds data for a poll, although it
     // works closely with the widget's concept of how data

static/js/popovers.js

@@ -15,6 +15,7 @@ const render_user_info_popover_content = require("../templates/user_info_popover
 const render_user_info_popover_title = require("../templates/user_info_popover_title.hbs");
 const render_user_profile_modal = require("../templates/user_profile_modal.hbs");
 
+const people = require("./people");
 const settings_data = require("./settings_data");
 const util = require("./util");
 

static/js/presence.js

@@ -2,6 +2,8 @@
 
 const XDate = require("xdate");
 
+const people = require("./people");
+
 // This module just manages data.  See activity.js for
 // the UI of our buddy list.
 

static/js/reactions.js

@@ -5,6 +5,8 @@ const _ = require("lodash");
 const emoji = require("../shared/js/emoji");
 const render_message_reaction = require("../templates/message_reaction.hbs");
 
+const people = require("./people");
+
 exports.view = {}; // function namespace
 
 exports.get_local_reaction_id = function (reaction_info) {

static/js/recent_topics.js

@@ -6,6 +6,8 @@ const render_recent_topic_row = require("../templates/recent_topic_row.hbs");
 const render_recent_topics_filters = require("../templates/recent_topics_filters.hbs");
 const render_recent_topics_body = require("../templates/recent_topics_table.hbs");
 
+const people = require("./people");
+
 const topics = new Map(); // Key is stream-id:topic.
 let topics_widget;
 // Sets the number of avatars to display.

static/js/reminder.js

@@ -2,6 +2,7 @@
 
 const moment = require("moment-timezone");
 
+const people = require("./people");
 const util = require("./util");
 
 const deferred_message_types = {

static/js/rendered_markdown.js

@@ -5,6 +5,8 @@ const moment = require("moment");
 
 const copy_code_button = require("../templates/copy_code_button.hbs");
 
+const people = require("./people");
+
 /*
     rendered_markdown
 

static/js/search_suggestion.js

@@ -3,6 +3,7 @@
 const Handlebars = require("handlebars/runtime");
 
 const huddle_data = require("./huddle_data");
+const people = require("./people");
 const settings_data = require("./settings_data");
 
 exports.max_num_of_search_results = 12;

static/js/server_events_dispatch.js

@@ -2,6 +2,7 @@
 
 const emoji = require("../shared/js/emoji");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 
 exports.dispatch_normal_event = function dispatch_normal_event(event) {

static/js/settings.js

@@ -4,6 +4,7 @@ const moment = require("moment-timezone");
 
 const render_settings_tab = require("../templates/settings_tab.hbs");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 
 $("body").ready(() => {

static/js/settings_account.js

@@ -6,6 +6,7 @@ const render_settings_api_key_modal = require("../templates/settings/api_key_mod
 const render_settings_custom_user_profile_field = require("../templates/settings/custom_user_profile_field.hbs");
 const render_settings_dev_env_email_access = require("../templates/settings/dev_env_email_access.hbs");
 
+const people = require("./people");
 const setup = require("./setup");
 
 exports.update_email = function (new_email) {

static/js/settings_bots.js

@@ -7,6 +7,8 @@ const render_edit_bot = require("../templates/edit_bot.hbs");
 const render_settings_edit_embedded_bot_service = require("../templates/settings/edit_embedded_bot_service.hbs");
 const render_settings_edit_outgoing_webhook_service = require("../templates/settings/edit_outgoing_webhook_service.hbs");
 
+const people = require("./people");
+
 exports.hide_errors = function () {
     $("#bot_table_error").hide();
     $(".bot_error").hide();

static/js/settings_emoji.js

@@ -4,6 +4,8 @@ const emoji = require("../shared/js/emoji");
 const render_admin_emoji_list = require("../templates/admin_emoji_list.hbs");
 const render_settings_emoji_settings_tip = require("../templates/settings/emoji_settings_tip.hbs");
 
+const people = require("./people");
+
 const meta = {
     loaded: false,
 };

static/js/settings_exports.js

@@ -4,6 +4,8 @@ const XDate = require("xdate");
 
 const render_admin_export_list = require("../templates/admin_export_list.hbs");
 
+const people = require("./people");
+
 const meta = {
     loaded: false,
 };

static/js/settings_invites.js

@@ -3,6 +3,7 @@
 const render_admin_invites_list = require("../templates/admin_invites_list.hbs");
 const render_settings_revoke_invite_modal = require("../templates/settings/revoke_invite_modal.hbs");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 const util = require("./util");
 

static/js/settings_user_groups.js

@@ -5,6 +5,8 @@ const _ = require("lodash");
 const render_admin_user_group_list = require("../templates/admin_user_group_list.hbs");
 const render_confirm_delete_user = require("../templates/confirm_delete_user.hbs");
 
+const people = require("./people");
+
 const meta = {
     loaded: false,
 };

static/js/settings_users.js

@@ -4,6 +4,7 @@ const render_admin_bot_form = require("../templates/admin_bot_form.hbs");
 const render_admin_human_form = require("../templates/admin_human_form.hbs");
 const render_admin_user_list = require("../templates/admin_user_list.hbs");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 const settings_data = require("./settings_data");
 

static/js/stream_create.js

@@ -4,6 +4,8 @@ const render_announce_stream_docs = require("../templates/announce_stream_docs.h
 const render_new_stream_users = require("../templates/new_stream_users.hbs");
 const render_subscription_invites_warning_modal = require("../templates/subscription_invites_warning_modal.hbs");
 
+const people = require("./people");
+
 let created_stream;
 
 exports.reset_created_stream = function () {

static/js/stream_data.js

@@ -2,6 +2,7 @@
 
 const FoldDict = require("./fold_dict").FoldDict;
 const LazySet = require("./lazy_set").LazySet;
+const people = require("./people");
 const settings_config = require("./settings_config");
 const util = require("./util");
 

static/js/stream_edit.js

@@ -5,6 +5,7 @@ const render_stream_member_list_entry = require("../templates/stream_member_list
 const render_subscription_settings = require("../templates/subscription_settings.hbs");
 const render_subscription_stream_privacy_modal = require("../templates/subscription_stream_privacy_modal.hbs");
 
+const people = require("./people");
 const settings_config = require("./settings_config");
 const settings_data = require("./settings_data");
 const util = require("./util");