2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2021-01-27 15:54:06 +01:00
|
|
|
const {set_global, zrequire} = require("../zjsunit/namespace");
|
2021-02-13 03:46:14 +01:00
|
|
|
const {make_stub} = require("../zjsunit/stub");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2020-08-29 04:08:14 +02:00
|
|
|
const events = require("./lib/events");
|
2020-07-24 06:02:07 +02:00
|
|
|
|
2020-06-12 22:27:49 +02:00
|
|
|
const event_fixtures = events.fixtures;
|
2020-06-12 23:05:06 +02:00
|
|
|
const test_user = events.test_user;
|
2020-06-12 22:27:49 +02:00
|
|
|
|
2021-02-11 01:23:23 +01:00
|
|
|
const compose_fade = set_global("compose_fade", {});
|
|
|
|
const stream_events = set_global("stream_events", {});
|
|
|
|
const subs = set_global("subs", {});
|
2020-07-26 14:06:28 +02:00
|
|
|
|
2021-01-12 21:38:01 +01:00
|
|
|
const peer_data = zrequire("peer_data");
|
2020-08-20 21:24:06 +02:00
|
|
|
const people = zrequire("people");
|
2021-02-10 04:53:22 +01:00
|
|
|
const stream_data = zrequire("stream_data");
|
2021-02-11 16:36:42 +01:00
|
|
|
|
|
|
|
set_global("current_msg_list", {});
|
|
|
|
const narrow_state = set_global("narrow_state", {});
|
|
|
|
const page_params = set_global("page_params", {});
|
|
|
|
const overlays = set_global("overlays", {});
|
|
|
|
const settings_org = set_global("settings_org", {});
|
|
|
|
const settings_streams = set_global("settings_streams", {});
|
|
|
|
const stream_list = set_global("stream_list", {});
|
|
|
|
|
2021-02-10 04:53:22 +01:00
|
|
|
const server_events_dispatch = zrequire("server_events_dispatch");
|
2020-06-12 22:27:49 +02:00
|
|
|
|
2021-02-11 16:36:42 +01:00
|
|
|
const noop = function () {};
|
|
|
|
|
2020-06-12 23:05:06 +02:00
|
|
|
people.add_active_user(test_user);
|
|
|
|
|
2021-02-11 16:36:42 +01:00
|
|
|
const me = {
|
|
|
|
email: "me@zulip.com",
|
|
|
|
full_name: "Me Myself",
|
|
|
|
user_id: 101,
|
|
|
|
};
|
|
|
|
people.add_active_user(me);
|
|
|
|
people.initialize_current_user(me.user_id);
|
|
|
|
|
2020-06-12 22:27:49 +02:00
|
|
|
const dispatch = server_events_dispatch.dispatch_normal_event;
|
|
|
|
|
|
|
|
function test(label, f) {
|
2020-06-12 23:05:06 +02:00
|
|
|
stream_data.clear_subscriptions();
|
|
|
|
|
2020-07-26 16:25:43 +02:00
|
|
|
run_test(label, (override) => {
|
|
|
|
f(override);
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
test("add", (override) => {
|
2020-06-12 22:27:49 +02:00
|
|
|
const event = event_fixtures.subscription__add;
|
2020-06-12 23:05:06 +02:00
|
|
|
|
|
|
|
const sub = event.subscriptions[0];
|
|
|
|
const stream_id = sub.stream_id;
|
|
|
|
|
|
|
|
stream_data.add_sub({
|
2020-07-20 22:18:43 +02:00
|
|
|
stream_id,
|
2020-06-12 23:05:06 +02:00
|
|
|
name: sub.name,
|
|
|
|
});
|
|
|
|
|
2021-02-13 03:46:14 +01:00
|
|
|
const subscription_stub = make_stub();
|
|
|
|
override(stream_events, "mark_subscribed", subscription_stub.f);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(subscription_stub.num_calls, 1);
|
|
|
|
const args = subscription_stub.get_args("sub", "subscribers");
|
|
|
|
assert.deepEqual(args.sub.stream_id, stream_id);
|
|
|
|
assert.deepEqual(args.subscribers, event.subscriptions[0].subscribers);
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
test("peer add/remove", (override) => {
|
2020-06-12 16:54:01 +02:00
|
|
|
let event = event_fixtures.subscription__peer_add;
|
|
|
|
|
2020-06-12 23:05:06 +02:00
|
|
|
stream_data.add_sub({
|
2020-07-15 01:29:15 +02:00
|
|
|
name: "devel",
|
2020-10-22 14:14:02 +02:00
|
|
|
stream_id: event.stream_ids[0],
|
2020-06-12 23:05:06 +02:00
|
|
|
});
|
|
|
|
|
2020-12-01 00:06:06 +01:00
|
|
|
const subs_stub = make_stub();
|
2021-02-11 01:23:23 +01:00
|
|
|
override(subs, "update_subscribers_ui", subs_stub.f);
|
2020-06-12 22:27:49 +02:00
|
|
|
|
2020-12-01 00:06:06 +01:00
|
|
|
const compose_fade_stub = make_stub();
|
2021-02-11 01:23:23 +01:00
|
|
|
override(compose_fade, "update_faded_users", compose_fade_stub.f);
|
2020-06-12 22:27:49 +02:00
|
|
|
|
2020-06-12 23:05:06 +02:00
|
|
|
dispatch(event);
|
2020-06-12 22:27:49 +02:00
|
|
|
assert.equal(compose_fade_stub.num_calls, 1);
|
2020-06-20 19:58:38 +02:00
|
|
|
assert.equal(subs_stub.num_calls, 1);
|
2020-06-12 22:27:49 +02:00
|
|
|
|
2021-01-22 18:40:00 +01:00
|
|
|
assert(peer_data.is_user_subscribed(event.stream_ids[0], event.user_ids[0]));
|
|
|
|
|
2020-06-12 22:27:49 +02:00
|
|
|
event = event_fixtures.subscription__peer_remove;
|
2020-06-12 23:05:06 +02:00
|
|
|
dispatch(event);
|
2020-06-12 22:27:49 +02:00
|
|
|
assert.equal(compose_fade_stub.num_calls, 2);
|
2020-06-20 19:58:38 +02:00
|
|
|
assert.equal(subs_stub.num_calls, 2);
|
2021-01-22 18:40:00 +01:00
|
|
|
|
|
|
|
assert(!peer_data.is_user_subscribed(event.stream_ids[0], event.user_ids[0]));
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
test("remove", (override) => {
|
2020-06-12 22:27:49 +02:00
|
|
|
const event = event_fixtures.subscription__remove;
|
2020-06-12 23:05:06 +02:00
|
|
|
const event_sub = event.subscriptions[0];
|
|
|
|
const stream_id = event_sub.stream_id;
|
|
|
|
|
|
|
|
const sub = {
|
2020-07-20 22:18:43 +02:00
|
|
|
stream_id,
|
2020-06-12 23:05:06 +02:00
|
|
|
name: event_sub.name,
|
|
|
|
};
|
|
|
|
|
|
|
|
stream_data.add_sub(sub);
|
|
|
|
|
2021-02-13 03:46:14 +01:00
|
|
|
const stub = make_stub();
|
|
|
|
override(stream_events, "mark_unsubscribed", stub.f);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
const args = stub.get_args("sub");
|
|
|
|
assert.deepEqual(args.sub, sub);
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
test("update", (override) => {
|
2020-06-12 22:27:49 +02:00
|
|
|
const event = event_fixtures.subscription__update;
|
2021-02-13 03:46:14 +01:00
|
|
|
|
|
|
|
const stub = make_stub();
|
|
|
|
override(stream_events, "update_property", stub.f);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
const args = stub.get_args("stream_id", "property", "value");
|
|
|
|
assert.deepEqual(args.stream_id, event.stream_id);
|
|
|
|
assert.deepEqual(args.property, event.property);
|
|
|
|
assert.deepEqual(args.value, event.value);
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
test("add error handling", (override) => {
|
2020-06-12 22:27:49 +02:00
|
|
|
// test blueslip errors/warns
|
|
|
|
const event = event_fixtures.subscription__add;
|
2021-02-13 03:46:14 +01:00
|
|
|
|
|
|
|
const stub = make_stub();
|
|
|
|
override(blueslip, "error", stub.f);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
assert.deepEqual(stub.get_args("param").param, "Subscribing to unknown stream with ID 101");
|
2020-06-12 22:27:49 +02:00
|
|
|
});
|
|
|
|
|
2021-01-27 15:54:06 +01:00
|
|
|
test("peer event error handling (bad stream_ids/user_ids)", (override) => {
|
2021-02-11 01:23:23 +01:00
|
|
|
override(compose_fade, "update_faded_users", () => {});
|
2020-10-22 14:14:02 +02:00
|
|
|
|
2020-06-12 23:05:06 +02:00
|
|
|
const add_event = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "subscription",
|
|
|
|
op: "peer_add",
|
2021-01-27 15:54:06 +01:00
|
|
|
stream_ids: [8888, 9999],
|
|
|
|
user_ids: [3333, 4444],
|
2020-06-12 16:54:01 +02:00
|
|
|
};
|
|
|
|
|
2021-01-27 15:54:06 +01:00
|
|
|
blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
|
|
|
|
blueslip.expect("warn", "We have untracked user_ids: 3333,4444");
|
2020-06-12 16:54:01 +02:00
|
|
|
dispatch(add_event);
|
|
|
|
blueslip.reset();
|
|
|
|
|
|
|
|
const remove_event = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "subscription",
|
|
|
|
op: "peer_remove",
|
2021-01-27 15:54:06 +01:00
|
|
|
stream_ids: [8888, 9999],
|
|
|
|
user_ids: [3333, 4444],
|
2020-06-12 16:54:01 +02:00
|
|
|
};
|
|
|
|
|
2021-01-27 15:54:06 +01:00
|
|
|
blueslip.expect("warn", "We have untracked stream_ids: 8888,9999");
|
|
|
|
blueslip.expect("warn", "We have untracked user_ids: 3333,4444");
|
2020-06-12 16:54:01 +02:00
|
|
|
dispatch(remove_event);
|
|
|
|
});
|
2021-02-11 16:36:42 +01:00
|
|
|
|
|
|
|
test("stream update", (override) => {
|
|
|
|
const event = event_fixtures.stream__update;
|
|
|
|
|
2021-02-13 03:46:14 +01:00
|
|
|
const stub = make_stub();
|
|
|
|
override(stream_events, "update_property", stub.f);
|
|
|
|
override(settings_streams, "update_default_streams_table", noop);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
const args = stub.get_args("stream_id", "property", "value");
|
|
|
|
assert.equal(args.stream_id, event.stream_id);
|
|
|
|
assert.equal(args.property, event.property);
|
|
|
|
assert.equal(args.value, event.value);
|
2021-02-11 16:36:42 +01:00
|
|
|
});
|
|
|
|
|
|
|
|
test("stream create", (override) => {
|
|
|
|
const event = event_fixtures.stream__create;
|
2021-02-13 03:46:14 +01:00
|
|
|
|
|
|
|
const stub = make_stub();
|
|
|
|
override(stream_data, "create_streams", stub.f);
|
|
|
|
override(stream_data, "get_sub_by_id", noop);
|
|
|
|
override(stream_data, "update_calculated_fields", noop);
|
|
|
|
override(subs, "add_sub_to_table", noop);
|
|
|
|
override(overlays, "streams_open", () => true);
|
|
|
|
dispatch(event);
|
|
|
|
assert.equal(stub.num_calls, 1);
|
|
|
|
const args = stub.get_args("streams");
|
|
|
|
assert.deepEqual(
|
|
|
|
args.streams.map((stream) => stream.stream_id),
|
|
|
|
[101, 102],
|
|
|
|
);
|
2021-02-11 16:36:42 +01:00
|
|
|
});
|
|
|
|
|
|
|
|
test("stream delete (normal)", (override) => {
|
|
|
|
const event = event_fixtures.stream__delete;
|
|
|
|
|
|
|
|
for (const stream of event.streams) {
|
|
|
|
stream_data.add_sub(stream);
|
|
|
|
}
|
|
|
|
|
|
|
|
stream_data.subscribe_myself(event.streams[0]);
|
|
|
|
|
|
|
|
override(stream_data, "delete_sub", noop);
|
|
|
|
override(settings_streams, "update_default_streams_table", noop);
|
|
|
|
|
|
|
|
narrow_state.is_for_stream_id = () => true;
|
|
|
|
|
|
|
|
let bookend_updates = 0;
|
|
|
|
override(current_msg_list, "update_trailing_bookend", () => {
|
|
|
|
bookend_updates += 1;
|
|
|
|
});
|
|
|
|
|
|
|
|
const removed_stream_ids = [];
|
|
|
|
|
|
|
|
override(subs, "remove_stream", (stream_id) => {
|
|
|
|
removed_stream_ids.push(stream_id);
|
|
|
|
});
|
|
|
|
|
|
|
|
let removed_sidebar_rows = 0;
|
|
|
|
override(stream_list, "remove_sidebar_row", () => {
|
|
|
|
removed_sidebar_rows += 1;
|
|
|
|
});
|
|
|
|
|
|
|
|
dispatch(event);
|
|
|
|
|
|
|
|
assert.deepEqual(removed_stream_ids, [event.streams[0].stream_id, event.streams[1].stream_id]);
|
|
|
|
|
|
|
|
// We should possibly be able to make a single call to
|
|
|
|
// update_trailing_bookend, but we currently do it for each stream.
|
|
|
|
assert.equal(bookend_updates, 2);
|
|
|
|
|
|
|
|
assert.equal(removed_sidebar_rows, 1);
|
|
|
|
});
|
|
|
|
|
|
|
|
test("stream delete (special streams)", (override) => {
|
|
|
|
const event = event_fixtures.stream__delete;
|
|
|
|
|
|
|
|
for (const stream of event.streams) {
|
|
|
|
stream_data.add_sub(stream);
|
|
|
|
}
|
|
|
|
|
|
|
|
// sanity check data
|
|
|
|
assert.equal(event.streams.length, 2);
|
|
|
|
page_params.realm_notifications_stream_id = event.streams[0].stream_id;
|
|
|
|
page_params.realm_signup_notifications_stream_id = event.streams[1].stream_id;
|
|
|
|
|
|
|
|
override(subs, "remove_stream", noop);
|
|
|
|
override(settings_org, "sync_realm_settings", noop);
|
|
|
|
override(settings_streams, "update_default_streams_table", noop);
|
|
|
|
override(current_msg_list, "update_trailing_bookend", noop);
|
|
|
|
override(stream_list, "remove_sidebar_row", noop);
|
|
|
|
|
|
|
|
dispatch(event);
|
|
|
|
|
|
|
|
assert.equal(page_params.realm_notifications_stream_id, -1);
|
|
|
|
assert.equal(page_params.realm_signup_notifications_stream_id, -1);
|
|
|
|
});
|