mirror of https://github.com/zulip/zulip.git
4df971c3c2
Along with this, we refactored settings_org.populate_auth_methods to use HTML function after rendering all auth methods rows rather than appending each row individually, which actually is a good practice. Also in this commit, to compare `current_val` and `changed_val` in `check_property_changed` function of the property `realm_authentication_methods`, which are objects, and we found here https://stackoverflow.com/a/1144249 that there is no easy way to do so. So I followed this approach, ```js JSON.stringify(obj1) === JSON.stringify(obj2) ``` but before converting them to string we want the same order of keys, so we used `sort_object_by_key` to sort `current_val` by keys and `get_auth_method_table_data` always return `changed_val` having keys sorted. Since these refactor were closely related we kept them as a single commit here. Fixes: #11954. |
||
|---|---|---|
| .. | ||
| account-settings.handlebars | ||
| admin-realm-domains-list.handlebars | ||
| admin-realm-dropdown-stream-list.handlebars | ||
| admin_auth_methods_list.handlebars | ||
| alert-word-settings.handlebars | ||
| attachments-settings.handlebars | ||
| auth-methods-settings-admin.handlebars | ||
| bot-list-admin.handlebars | ||
| bot-settings.handlebars | ||
| custom-user-profile-field.handlebars | ||
| deactivate-realm-modal.handlebars | ||
| deactivated-users-admin.handlebars | ||
| deactivation-stream-modal.handlebars | ||
| deactivation-user-modal.handlebars | ||
| default-streams-list-admin.handlebars | ||
| dev_env_email_access.handlebars | ||
| display-settings.handlebars | ||
| edit-embedded-bot-service.handlebars | ||
| edit-outgoing-webhook-service.handlebars | ||
| emoji-settings-admin.handlebars | ||
| emoji-settings-tip.handlebars | ||
| invites-list-admin.handlebars | ||
| linkifier-settings-admin.handlebars | ||
| muted-topics-settings.handlebars | ||
| notification-settings.handlebars | ||
| organization-permissions-admin.handlebars | ||
| organization-profile-admin.handlebars | ||
| organization-settings-admin.handlebars | ||
| organization-settings-tip.handlebars | ||
| profile-field-choice.handlebars | ||
| profile-field-settings-admin.handlebars | ||
| realm-domains-modal.handlebars | ||
| resend-invite-modal.handlebars | ||
| revoke-invite-modal.handlebars | ||
| settings-save-discard-widget.handlebars | ||
| settings_checkbox.handlebars | ||
| upload-space-stats.handlebars | ||
| user-list-admin.handlebars | ||