Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

org settings: Add generalised function for tip-box for org settings. 

This commit adds a `insert_tip_box` function and thus adds a
`organization-settings-tip` handlebars file to add a genaralised tip for
all organization settings pages. This further removes the code for tipbox
which was added in `populate_auth_methods` functions, as it wasn't making
sense there, making it more clear and readable.
This commit is contained in:
Pragati Agrawal 2019-04-07 22:02:42 +05:30 committed by Tim Abbott
parent 2277ee0c90
commit d0ba0c7409
2 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/settings_org.js
View File

@ -294,17 +294,19 @@ exports.populate_auth_methods = function (auth_methods) {
}));
});
loading.destroy_indicator($('#admin_page_auth_methods_loading_indicator'));
if (!page_params.is_admin) {
var tip_box = $("<div class='tip'></div>")
.text(i18n.t("Only organization administrators can edit these settings."));
// Don't prepend a tip to custom emoji settings page. We handle it separately.
$(".organization-box").find(".settings-section:not(.can-edit)")
.not("#emoji-settings")
.not("#user-groups-admin")
.prepend(tip_box);
}
};
function insert_tip_box() {
if (page_params.is_admin) {
return;
}
var tip_box = templates.render("organization-settings-tip", {is_admin: page_params.is_admin});
$(".organization-box").find(".settings-section:not(.can-edit)")
.not("#emoji-settings")
.not("#user-groups-admin")
.prepend(tip_box);
}
exports.render_notifications_stream_ui = function (stream_id, elem) {
@ -529,6 +531,7 @@ exports.build_page = function () {
// Populate authentication methods table
exports.populate_auth_methods(page_params.realm_authentication_methods);
insert_tip_box();
function populate_data_for_request(subsection) {
var data = {};

3
static/templates/settings/organization-settings-tip.handlebars Normal file
View File

@ -0,0 +1,3 @@
{{#unless is_admin}}
<div class='tip'>{{t "Only organization administrators can edit these settings."}}</div>
{{/unless}}