Commit Graph

59449 Commits

Author SHA1 Message Date
afeefuddin 2217eededc user_profile: Pass correct element to toggle_submit_button. 2024-07-05 15:14:24 -07:00
Aman Agrawal 8f0a0af588 server_events_dispatch: Fix stream archived booked not displayed.
Fixed by updating bookend after stream data is deleted.
When a stream is deleted and user is narrowed to the stream,
stream archived bookend is now displayed correctly.
2024-07-05 14:59:32 -07:00
Aman Agrawal 933195f7a5 stream_settings_ui: Fix stream privacy icon not updated in msg list.
We rerender message list to update the stream privacy icon in
recipient bar, bookends or any other places it might be displayed
as part of the message list.
2024-07-05 14:59:32 -07:00
Aman Agrawal 9b561212d3 message_list: Show `subscribed` bookend on subscribing a stream.
This fixes a bug where no bookend was displayed when user subscribed
to a stream but a bookend was displayed when a new message is sent
in the stream.
2024-07-05 14:59:32 -07:00
Aman Agrawal 6f0fdef80d message_list: Move condition to render update_trailing_bookend.
We move the condition to render `update_trailing_bookend` inside
the function to ensure we are only showing it when required.

This also fixes a bug where we render trailing bookend when
stream privacy is changed regardless of if the bookend is required.
2024-07-05 14:59:30 -07:00
N-Shar-ma 6099364183 compose: Fix flashing effect on trying to send message that's too long.
Due to a wrong CSS selector, the expected red outline flashing effect
was not being applied to the compose box when the user tried to send a
message that was longer than the maximum allowed length. Also, the
iteration count is set to 3 instead of relying on the duration the CSS
class is applied, to ensure exactly 3 flashes without any glitches.
2024-07-05 14:44:13 -07:00
Karl Stolley e42f9a1efd right_sidebar: Calculate margin-top on shortcuts. 2024-07-05 14:38:28 -07:00
Karl Stolley 97d401a0a1 left_sidebar: Calculate bottom scrolling buffer. 2024-07-05 14:38:28 -07:00
Aman Agrawal 41b431de70 info-overlay: Adjust width of overlay and columns.
Objectives are to make the width of overlay scale with font size and
reduce too much gap between text end of first column and
text start of the other column.
2024-07-05 11:36:35 -07:00
Aman Agrawal 676ddf8c30 information_overlays: Inline poll question and edit icon. 2024-07-05 11:36:35 -07:00
bedo db5c272f82 billing: Migrate to @typed_endpoint.
migrate update_plan(), update_plan_for_remote_realm(),
and update_plan_for_remote_server() to @typed_endpoint.
2024-07-05 10:32:57 -07:00
Karl Stolley 1410a0acb3 message_box: Ensure emoji display correctly on messages with senders. 2024-07-05 10:25:59 -07:00
Aman Agrawal 2b33a5af83 tippy: Add patch to avoid text Node as target in Firefox.
In Firefox, event targets can be pseudo elements like text
nodes which don't have .closest method. This results in error
when delegate tries to handle trigger for a text node target.

Since https://github.com/atomiks/tippyjs/pull/1166 has no
response from the developer, we decided to apply this patch
ourselves.
2024-07-05 10:15:45 -07:00
Sahil Batra d9da6d17e0 settings: Remove max-height for bots box container.
This helps us in avoiding the scrollbar inside the box
if the information density setting is set to 16/140 by
allowing the box to set its height as per the content.

There is no need for max-height since the height of the
box was anyways less than the max-height value set before
at normal font size and screen widths.

For narrow screens, the max-height property was set to unset,
so removing the max-height property does not have any effect
on how the bots are shown on narrow screens.

Fixes #30669.
2024-07-04 07:57:32 -07:00
roanster007 52692a6448 refactor: Rename `huddle` to `direct_message_group` in non API.
This commit performs a sweep on the first batch of non API
files to rename "huddle" to "direct_message_group`.

It also renames variables and methods of type -
"huddle_message" to "group_direct_message".

This is a part of #28640
2024-07-04 07:56:31 -07:00
N-Shar-ma fa2f86ff80 compose: Fix the calculation of the compose box's max height.
This is a follow up to #30396, to remove consideration of the text box's
margin after it's removal in #29953.
2024-07-03 18:54:15 -07:00
N-Shar-ma 085ee219eb docs: Update docs for 3 way compose box resizing. 2024-07-03 18:54:15 -07:00
Sayam Samal 3fda65c37d playground_popover: Update external code btn behavior on setting change.
This commit removes the `href` attribute from the external code button
when multiple code playground links are present for a language. This
prevents the bug where the external code button would always link to
the previously set code playground link, even when multiple links are
added and the expected behavior is to show the popover.
2024-07-03 17:01:46 -07:00
Sayam Samal 5191a80a3a playground_popover: Fix bug where the playground popover doesn't reopen.
This commit fixes a bug where the popover doesn't reopen after it's
closed. The bug was caused since `playground_links_popover_instance`
wasn't being set to `null` after the popover was closed, which led
the `is_open` function to return `true` even when the popover was
closed.
2024-07-03 17:01:46 -07:00
Sayam Samal fe1f8afb1b playground_popover: Redesign popover using the new "popover-menu" theme.
As part of the popover menu redesign, this redesigns the playground
links popover using the new "popover-menu" tippy theme and improves
accessibility by using appropriate ARIA attributes.

Fixes part of #28699.
2024-07-03 17:01:46 -07:00
Aman Agrawal 621ae91c70 settings: Use box buttons for download and delete.
Co-authored-by: Shashank Singh <shashanksingh@Shashanks-Air.mshome.net>
2024-07-03 16:53:39 -07:00
Alya Abbott cb1531b061 help: Don't link to the direct message feed.
We should teach users how to get there.
2024-07-03 16:30:52 -07:00
Lauryn Menard b05bab63c8 help: Document left sidebar actions.
Fixes #30411.
2024-07-03 16:30:52 -07:00
Kislay Verma 4bd9a8ce50 composebox_typeahead: Fix checking whether messages can be sent.
Before calling `on_enter_send`, we checked if the
`compose-send-button` is disabled, but never actually
set it to disabled, rather we updated its container
(.message-send-controls) with that state.

This commit fixes that by correctly checking the button's
container for the class .disabled-message-send-controls
which is set to indicate that the user cannot send messages
at the moment.

Fixes #30620
2024-07-03 16:24:10 -07:00
Karl Stolley 9fb6b4d016 left_sidebar: More carefully generate auto rows for expanded nav. 2024-07-03 16:18:45 -07:00
Karl Stolley 35642cb941 recent_view: Set a shared column for filter icons. 2024-07-03 16:15:46 -07:00
Aman Agrawal aed809dd7c 5xx: Remove duplicate `error_page` class applied on page.
We only want to apply this class on the actual content of the page.
2024-07-03 13:35:12 -07:00
Varun Singh 2823e732de user_group_edit_members: Remove redundant conditionals. 2024-07-03 12:34:30 -07:00
Varun Singh 8409a04c03 user_group_edit_members: Convert module to TypeScript. 2024-07-03 12:34:30 -07:00
Karl Stolley 2c7e264480 tippy: Ensure a normal font-weight on Tippies. 2024-07-03 10:43:25 -07:00
Karl Stolley 46f5854185 tippy: Initialize maxWidth in em units. 2024-07-03 10:43:25 -07:00
Karl Stolley cbdfdf06b4 tippy: Allow Tippy tooltips to scale with UI. 2024-07-03 10:43:25 -07:00
Aman Agrawal 59e9a1ac90 recipient_row: Remove extra whitespace around recipient full name.
Might fix the CI errors due to extra space between `You and` and
the user full name.
2024-07-03 10:38:35 -07:00
Aman Agrawal 4b091aafc2 makemessages: Allow excluding whitespace before `*inline` custom tag.
This otherwise throws capitalization error that handlebars are included
in the translated string when trying to use {{~#*inline}}.
2024-07-03 10:38:35 -07:00
Lauryn Menard 8bc873c18f help: Document "Unstar all messages in topic" feature.
Fixes #29512.
2024-07-03 09:21:21 -07:00
Aman Agrawal ef49c29ddf recent_view_ui: Update if all msgs in topic were deleted. 2024-07-02 23:01:16 -07:00
Aman Agrawal b99ff8f34c recent_view_ui: Do single update instead of doing multiple rerenders. 2024-07-02 23:01:16 -07:00
Vector73 b306233cab pm_conversation: Add new has_conversation helper.
Adds `has_conversation` function in
`pm_conversation.RecentDirectMessages` for checking whether we have in
cache evidence of previous messages in a direct message conversation.

Preparation for #28470.

Co-authored-by: Tim Abbott <tabbott@zulip.com>
2024-07-02 19:02:41 -07:00
evykassirer 9dd36b4727 filter: Add validation function for search pill terms. 2024-07-02 16:25:45 -07:00
Lauryn Menard c9c8bcad57 integration-docs: Update Front for new doc format.
Part of #29592.
2024-07-02 16:07:22 -07:00
Lauryn Menard 3ae09fe880 integration-docs: Update Freshstatus for new doc format.
Part of #29592.
2024-07-02 16:07:22 -07:00
Lauryn Menard 5c2b15d68f integration-docs: Update Freshping for new doc format.
Part of #29592.
2024-07-02 16:07:22 -07:00
Lauryn Menard dc28117384 integration-docs: Update Flock for new doc format.
Part of #29592.
2024-07-02 16:07:22 -07:00
Tim Abbott da6c2e0c3c settings: Rename Deactivated users settings subtab.
Includes help center updates to better link to the tab.

Fixes https://chat.zulip.org/#narrow/stream/9-issues/topic/deactivated.20users.20tab/near/1843114
2024-07-02 13:53:31 -07:00
Shubham Padia ba05e8eeac custom_profile_fields: Initialize typeahead for every pronoun field.
Fixes #29921.
Before this, we used to initialize only 1 typeahead resulting in the bug
of only the first field updating even when trying to change values in the
others.

Co-authored-by: Ngadou Yopa <ngadou.y@turing.com>
2024-07-02 13:30:40 -07:00
Sahil Batra 5ef14c3a8e users: Fix uploading user avatars.
Due to recent refactoring in 9fb03cb2c7, a user could not
upload avatar if the server uses local upload backend and there
was already an avatar file for that user.

This commit fixes it to just check if there exists a file only
when importing and not when the user is actually trying to
change the avatar.

Fixes #30676.
2024-07-02 13:26:21 -07:00
Karl Stolley 58b40fb6c7 privacy_icon: Raise lock icon throughout UI for better visual centering. 2024-07-02 13:24:16 -07:00
Shubham Padia e539d2226b stream_create: Move `Add all users` beside `Choose subscribers`.
Fixes part of #30690.
We also drop the `Do you want to add everyone?` text.
2024-07-02 12:54:52 -07:00
Lauryn Menard 250f68ad25 integration-docs: Update Beeminder for new doc format.
Part of #29592.
2024-07-02 12:50:25 -07:00
Lauryn Menard f442b8baaf integration-docs: Update Basecamp for new doc format.
Part of #29592.
2024-07-02 12:50:25 -07:00