When we will no longer clear cached data on moving messages in
later commits, we have to clear cached data for the new filter when
changing narrow to avoid the message list from being populated
from it since the cached msg data is not updated as per the moved
topic and needs to be updated.
We extend the existing logic that updates message events for
rendered message lists to apply for cached message list data
objects as well.
Manually tested for common message property narrows to test
update of the message property.
Earlier in navbar navigation, keyboard events only worked with `gear-
menu`, `personal-menu` and `help-menu`.
This commit introduces the ability to navigate to login in spectator
mode by adding `navbar-item` class and trigger focus to it.
Fixes: zulip#28037.
Earlier in navbar navigation, keyboard events only worked with `gear-
menu`, `personal-menu` and `help-menu`. Now that userlist-toggle is
introduced in navbar, we should make it navigable.
This commit introduces the ability to navigate from `help-menu` to
userlist button by adding `navbar-item` class and trigger focus to it.
Fixes: zulip#29465.
This commit introduces `navbar-item` class for each navbar menus and
`active-navbar-menu` class to indicate active navbar menu. Also
introduces new function `get_target_navbar_menu` to return target
navbar menu from keyboard event. `change_active_navbar_menu` uses target
menu to switch between navbar items.
This commit extracts menu switching logic from `handle_keyboard_events`
to separate `change_active_navbar_menu` to toggle between the current
active navbar menu and the adjacent navbar menu.
Previously, when resizing the window, the filters/buttons and the
header did not fit on the same row, the filters/buttons were pushed
onto the next row but not put directly below the heading. This
changes the settings_panel_list_header and
add_default_streams_button_container into flex containers and
properly aligns the items below the heading when changing window
size.
Fixes: #30353
Dropdown widget in compose box and in message move modal should
not show archived streams in dropdown as we do not allow sending
messages or moving messages to archived streams.
We need a more focused audit of code for fixing other things
where archived streams are shown.
Apparently `.data("category")` would be come back as a single-element
array for some French translations, rather than a string.
We fix this by using `.attr("data-category")` across this file, which
is our preferred coding pattern anyway.
This commit removes the `button-secondary`, `button-group` and
`bootstrap-btn-group` classes which don't have any corresponding styles
attached to them or are no longer in use in the codebase.
Since pressing `escape` key closes flatpickr and settings overlay
at the same time, we need to wait for the settings to be not
visible.
If we don't wait for the settings overlay to close, the next test
could think the settings overlay is already open and continue with
its tests which can easily become flaky.
This commit removes the final vestiges of `bootstrap-btn.css` from
portico, allowing us to move `bootstrap-btn.css` from `common.ts` bundle
to just `app.ts` bundle.
This commit includes the following changes:
- While inviting users for guest roles, we display an
empty channel list rather than the default channel list
and the default channels checkbox is unselected.
- While inviting users for non-guest roles we continue
to select the default channels checkbox.
- When switching between guest and non-guest roles, the
previous state of included channels for the guest role
is restored while inviting a user as a guest.
Fixes: #31988.
Co-authored-by: Aditya <113302312+userAdityaa@users.noreply.github.com>
This commit removes the final vestiges of `bootstrap-btn-default` class
from the codebase, by moving the relevant styles from the
`bootstrap-btn` and `bootstrap-btn-default` classes to the
`button-recent-filters` class.
Our user type field utilizes the contenteditable div which isn't a
labelable element, so clicking on its label doesn't do anything. Add
an event listener so that clicking on the label will focus on the input.
The cursor will always be placed at the start of the input if the field
is accessed in this way. This is the browser's default behavior.
Fixes part of #21769.
Flatpickr isn't a native input element, so clicking on its label
doesn't do anything. Add an event listener so that clicking on the
label will open the date picker.
Fixes part of #21769.
There is an case of flakiness in the test where we attempt to click on
an input field before it's even visible. Make sure the input field is
visible before attempting to click on it.
Currently, the labels are using the full width of the modal, which results
in a clickable area that is too large. This commit fixes the issue by
setting the width of the labels to just fit its content.
This commit changes refactors all the labels in stream settings and
corrects the attribute values to fix the interaction between labels and
select/button elements.
Fixes part of #21769.
This commit changes refactors all the labels in organzation settings and
corrects the attribute values to fix the interaction between labels and
select/button elements.
Fixes part of #21769.
This commit changes refactors all the labels in personal settings and
corrects the attribute values to fix the interaction between labels and
select/button elements.
Fixes part of #21769.
Aman Agrawal
Karl Stolley
Pratik Chanda
Nicklas Steen
Sahil Batra
evykassirer
Anders Kaseorg
Tim Abbott
Sayam Samal
Saubhagya Patel
Vector73
joseph