Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Refactor the labels in stream settings. 

This commit changes refactors all the labels in stream settings and
corrects the attribute values to fix the interaction between labels and
select/button elements.

Fixes part of #21769.
This commit is contained in:
joseph 2024-08-07 20:08:29 +00:00 committed by Tim Abbott
parent ee66488fbf
commit 8332c7d93b
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/templates/stream_settings/announce_stream_checkbox.hbs
View File

@ -1,5 +1,5 @@
<label class="checkbox">
<input type="checkbox" name="announce" value="announce" checked />
<label class="checkbox" for="id_should_announce_new_stream">
<input type="checkbox" name="announce" value="announce" checked id="id_should_announce_new_stream"/>
<span class="rendered-checkbox"></span>
{{t "Announce new channel in"}}
{{#if new_stream_announcements_stream_sub}}

2
web/templates/stream_settings/stream_creation_form.hbs
View File

@ -34,7 +34,7 @@
</div>
<div class="subscribers_container stream_creation_container">
<section class="stream_create_add_subscriber_container">
<label class="choose-subscribers-label" for="people_to_add">
<label class="choose-subscribers-label">
<h4 class="stream_setting_subsection_title">{{t "Choose subscribers" }}</h4>
</label>
<span class="add_all_users_to_stream_button_container">

6
web/templates/stream_settings/stream_types.hbs
View File

@ -54,7 +54,7 @@
<div class="advanced-configurations-collapase-view hide">
<div class="input-group">
<label class="dropdown-title">{{t 'Who can post to this channel'}}
<label class="dropdown-title" for="{{prefix}}stream_post_policy">{{t 'Who can post to this channel'}}
{{> ../help_link_widget link="/help/stream-sending-policy" }}
</label>
<select name="stream-post-policy" class="stream_post_policy_setting prop-element settings_select bootstrap-focus-style" id="{{prefix}}stream_post_policy" data-setting-widget-type="number">
@ -74,7 +74,7 @@
{{#if (or is_owner is_stream_edit)}}
<div>
<div class="input-group inline-block message-retention-setting-group time-limit-setting">
<label class="dropdown-title">{{t "Message retention period" }}
<label class="dropdown-title" for="{{prefix}}message_retention_days">{{t "Message retention period" }}
{{> ../help_link_widget link="/help/message-retention-policy" }}
</label>
@ -90,7 +90,7 @@
</select>
<div class="dependent-settings-block stream-message-retention-days-input">
<label class="inline-block">
<label class="inline-block" for="{{prefix}}stream_message_retention_custom_input">
{{t 'Retention period (days)' }}:
</label>
<input type="text" autocomplete="off"