fb42b58316
zerver/tests: Test emoji upload for local storage backend.
2018-05-15 10:50:39 -07:00
2dc13d6b50
zerver/tests: Test ensure_medium_avatar_url when the file exists.
2018-05-15 10:50:39 -07:00
398141268f
zerver/tests: Test get_emoji_url for S3.
2018-05-15 10:50:39 -07:00
dd19ed3972
zerver/tests: Test upload emoji to S3.
2018-05-15 10:50:39 -07:00
ff95c67197
zerver/tests: Test upload realm icon for S3.
2018-05-15 10:50:39 -07:00
25e91b289d
zerver/tests: Test delete message image from S3 when file is missing.
2018-05-15 10:50:39 -07:00
b3a6c0a253
zerver/tests: Test currently_used_upload_space function.
2018-05-15 10:50:38 -07:00
efc63d4ca0
zerver/tests: Test S3 file upload with undefined content type.
2018-05-15 10:42:10 -07:00
b9fff04f39
zerver/tests: Add test for resize_emoji for images that need resizing.
2018-05-15 10:42:10 -07:00
69a5ce102f
zerver/tests: Remove unecessary re-open on files in tests.
...
The get_test_image_file helper function returns a file handle so we can
call the read method on this directly.
2018-05-15 10:42:10 -07:00
f34d9dc910
zerver/tests: Test get_realm_for_filename when filename doesn't exist.
2018-05-15 10:42:10 -07:00
80beb51836
edit bot: Fix error on updating no-owner-bots name.
...
When org admin tries to change only bots name of no-owner-bot,
It update bots name but returns error, "No such bot owner".
Cause frontend pass `null` value in `bot-owner`.
2018-05-15 10:35:19 -07:00
0554e68528
static/templates/edit_bot.handlebars: Fix undefined bot_id.
...
Template was rendering undefined value of `bot_id` instead of
`user_id`.
Fix this by replacing `bot_id` with `user_id` and changing
template data variable to `data-user-id` to avoid
future confusion.
2018-05-15 10:35:19 -07:00
8a66b0b9a9
docker: Set has_appserver=0 correctly.
...
The docker installer configuration incorrectly had has_appserver set
to 0; this meant that (A) the docker-zulip code needed to copy the
block of code in the installer for the `has_appserver` case into the
Dockerfile (unnecessarily), and (B) one couldn't use `install` from a
Git ref (because the static asset compiler didn't end up in the right
place).
It appears that docker-zulip tried to set this flag in their `install`
command line, but the construction inside `install` meant that didn't
work.
2018-05-15 10:13:44 -07:00
52d53f4a81
test_subs: Ensure gather_subscriptions_helper excludes deleted streams.
2018-05-15 10:11:32 -07:00
bb5457c2f7
docs: Clarify need to provision from /srv/zulip when troubleshooting.
...
Text tweaked slightly by tabbott.
2018-05-15 09:43:09 -07:00
f0d874d51f
hashchange: Handle trailing slashes in narrowing URLs.
...
Fixes #9305 .
Empty operators are not allowed while parsing narrowing URLs.
`parse_narrow` stops parsing further if it encounters an empty string
operator.
2018-05-15 09:34:50 -07:00
83ee8211a8
third: Get sorttable package from npm.
...
We didn't have any local changes, so there's no need to have it
vendored in the repository.
2018-05-15 09:25:48 -07:00
bc403fc4c4
i18n: Tag missing strings for translation.
2018-05-15 09:06:56 -07:00
f0fa550001
docs: Rename rest_endpoints with dashes.
2018-05-15 09:06:56 -07:00
b656388ee2
check_send_receive_time: Fix mypy Optional issues.
...
These were not correctly interacting with the Zulip API, and improved
annotations in the API bindings are now actually being type-checked.
2018-05-15 09:06:56 -07:00
42435db492
Add run_test helper for individual tests.
...
This run_test helper sets up a convention that allows
us to give really short tracebacks for errors, and
eventually we can have more control over running
individual tests. (The latter goal has some
complications, since we often intentionally leak
setup in tests.)
2018-05-15 08:24:44 -07:00
4f0b3fc1b6
test-js-with-node: Exit more cleanly for errors.
...
We don't need a Python stack trace when the node
piece fails, so just give a non-distracting error
message.
2018-05-15 08:24:44 -07:00
0289794e5d
zjsunit: Give shorter tracebacks for failures.
2018-05-15 08:24:44 -07:00
3a68f998a7
integration-docs-guide: Add a more detailed writing style guide.
...
Most of the recommendations in this guide were written by Rishi
Gupta (rishig), with a few contributions from Eeshan Garg.
2018-05-15 10:06:08 -04:00
fa28ccb952
integration-docs-guide: Trim text documenting Markdown macros.
...
We were devoting too much space/text to documenting our Markdown
macro. It is much more concise to just have a description and a
link to an example doc for each major macro.
2018-05-14 20:14:08 -02:30
a2ed06314d
send_test_email: Throw an error if email not configured.
...
This should help minimize confusion when folks try to use this before
properly configuring outgoing email.
Thanks to Bruce Eckel for the report.
2018-05-14 12:02:36 -07:00
2cca5dc79f
zerver/tests: Test upload when mimetype is supplied as a query param.
2018-05-14 10:58:24 -07:00
df84e1d7eb
tests: Reach 100% coverage for zerver/liv/management.py.
...
Cleaned up add_user_list_args(). The "help" and
"all_users_help" have all default values. As noted in
an earlier commit, "all_users_help" is always passed in,
so we can get rid of "all_users_arg". We keep the default
for "all_users_help" so we don't have to change variable order
in function definition.
2018-05-14 10:46:21 -07:00
ef098d2223
management: Remove the parameter required from add_user_list_args.
...
We remove an unecessary "required" paramter from this function
because as seen in the get_users() function right below, you have
to pass either -u/--users or -a/--all-users, meaning there should
never be a reason to require --users.
2018-05-14 10:46:21 -07:00
231b487bca
tests: Cover check_config() in zerver/lib/management.py.
...
Add a comment to code to clarify what the config check does.
2018-05-14 10:46:21 -07:00
dc7f6c8a48
bots: Fix incorrect maximum lengths for outgoing webhook URLs.
...
2083 is the correct maximum length for a URL.
2018-05-14 10:42:23 -07:00
607cab2a53
tests: Add 100% test coverage to zerver/apps.py.
...
Tweaked by tabbott to rename to test_cache.py and remove the
sender_name argument (Since it was kinda confusing).
2018-05-14 10:36:10 -07:00
1f837340d1
api: Fix confusing documentation about services for botserver.
...
This fixes several super-confusing things in these docs. Bot services
aren't a user-facing concept, and also, you need the URL before
creating the bot users.
2018-05-14 09:21:45 -07:00
485d5b6335
api: Fix incorrectly coded bullet for zulip_botserver config.
2018-05-14 09:21:45 -07:00
b73603a97c
droplets: Do shutdown command along with clear history.
...
Otherwise shutdown command would be still present in the
history.
2018-05-14 08:12:43 -07:00
861001f7b3
droplets: Update snapshot id.
...
Upgraded zulip and python-zulip-api repos.
Installed flask in python-zulip-api.
2018-05-14 08:12:43 -07:00
f5ea661c1f
tools: Upgrade pycodestyle.
...
We have to add a few rules that we're ignoring for now.
2018-05-14 06:15:13 -07:00
e591668d60
bot-docs: Rewrite last section of "Running bots".
2018-05-14 04:27:36 -07:00
3952f94157
minor: Add missing period to bot-docs.
2018-05-14 04:27:36 -07:00
128aa8b7ee
bot-docs: Remove hint on "Running bots" doc.
...
We already explain testing bot output in
"Writing bots" doc, and the placement of
the hint itself doesn't make sense.
2018-05-14 04:27:36 -07:00
0b112cf5e9
bot-docs: Streamline introduction to 'Running a bot'.
2018-05-14 04:27:36 -07:00
2b06e1cec7
bot-docs: Renumber list to use all 1's.
2018-05-14 04:27:36 -07:00
726017f682
actions: Remove dead do_change_bot_type function.
...
This is a tiny fraction of a feature we don't support, so we should
just kill it.
2018-05-13 17:58:49 -07:00
8b09118009
actions: Rename pick_color_helper to pick_color.
...
Now that there's only one function here, it's weird to have the
unnecessary _helper suffix.
2018-05-13 17:52:36 -07:00
234b5fa21b
actions: Remove dead pick_color function.
...
We've been using pick_color_helper only for a long time.
2018-05-13 17:52:04 -07:00
60cfc210ce
address: Remove dead msg_type function.
...
This was never used; we instead use `.is_stream` and `.is_private`
instead.
2018-05-13 17:47:21 -07:00
e4131fb708
docs: Remove a bunch of content from mypy docs.
...
All of this content had become obsolete due to our successful adoption
of mypy.
2018-05-13 17:23:18 -07:00
64678b459c
linter: Add rule to lint against use of typing.Text and promote str.
...
This commit is the last in a series of commits which migrated our
entire codebase to use str instead of typing.Text.
Fixes : #9203 .
2018-05-13 17:17:32 -07:00
addfde7374
tools: Change use of typing.Text to str.
2018-05-13 17:17:32 -07:00
RobbieClarken
Yashashvi Dave
Tim Abbott
Baron Chandler
Hendy Irawan
Shubham Padia
Aman Ghebreweldi
Yago González
Steve Howell
Eeshan Garg
Joshua Pan
Darshan Markandaiah
Vishnu Ks
Aditya Bansal