Tim Abbott
f8bb55f9c1
auth: Refactor auth backend enabled checking code.
2016-11-06 16:16:12 -08:00
Tim Abbott
3a3cee411d
auth: Remove old password_auth_enabled hack.
...
This was used by an old configuration for zulip.com, which is no
longer in production use.
2016-11-06 14:50:15 -08:00
Tim Abbott
7c8d502c70
docs: Add details on our markdown change requirements.
2016-11-06 11:57:10 -08:00
Tim Abbott
1641d1952f
docs: Add a section on changing Zulip's markdown.
2016-11-06 11:49:37 -08:00
Tim Abbott
70c00038d9
docs: Clarify our markdown docs.
...
This is just a cleanup and reorganization of some of the text; no
changes are made to the actual content.
2016-11-06 11:37:22 -08:00
hackerkid
bb4eb213c1
docs: Add testing notes to markdown doc.
2016-11-06 11:22:34 -08:00
Tomasz Kolek
704ac5aa6c
Fix lint-all checker by adding "_" as a escape character before Github.
2016-11-05 22:12:25 -07:00
Steve Howell
debc06b449
Rename subject-name to topic-name and move CSS to left-sidebar.css.
2016-11-05 15:03:29 -07:00
Steve Howell
06fe4bc943
Rename subject_box to pm-box/topic-box.
...
I'm not crazy about the names pm-box and topic-box, but they
are less confusing now.
2016-11-05 15:03:29 -07:00
Steve Howell
43c372bfb6
css: Clean up styles for subject_box.
...
These styles are uniform for now, so we don't need a complicated
selector.
2016-11-05 15:03:29 -07:00
Steve Howell
e38b684eea
Simplify CSS for topic-sidebar-arrow.
2016-11-05 15:03:29 -07:00
Steve Howell
b1f288dddb
topic lists: Rename expanded_subject to topic-list-item.
2016-11-05 15:03:29 -07:00
Steve Howell
8b7e9101ca
topic lists: Rename expanded_subjects -> topic-list.
2016-11-05 15:03:29 -07:00
Steve Howell
6fe86adac8
node tests: Add newer stylesheets for HTML output.
2016-11-05 15:03:29 -07:00
Tim Abbott
ee361cbe30
js: Eliminate process_loaded_for_unread global.
2016-11-05 11:33:04 -07:00
Tim Abbott
d60ec24c1f
js: Move set_user_statuses to activity.js initialization.
2016-11-05 11:33:04 -07:00
Tim Abbott
6daf2b1e46
js: Move pointer initialization code out of zulip.js.
2016-11-05 11:33:04 -07:00
Tim Abbott
d76f9b09a3
unread: Move consider_bankruptcy into unread module.
2016-11-05 11:33:04 -07:00
Tim Abbott
be3e9e3a05
Fix regression breaking websocket message sending.
...
In fe1ba6f3eb
, we change our auth
decorators etc. to use request.POST/request.GET rather than the (now
removed request.REQUEST). This broke sending messages via our
websockets codepath, because we failed to update the artificial
requests we generate to use request._post as well.
2016-11-05 11:33:04 -07:00
Steve Howell
75dd822d8e
tests: Improve coverage of cross-realm bot limitations.
...
We recently made it so that a cross-realm bot can only send
messages to one realm at a time. (It can send to a realm
outside of its offical realm, but only one of them.) This
test adds coverage for that.
2016-11-05 10:39:32 -07:00
Steve Howell
165b6c1ff3
topic lists: Improve node test to show HTML correctly.
2016-11-05 10:38:37 -07:00
Steve Howell
1119a24ea3
node tests: Extract node_tests/topic_list.js
...
This moves one method over from stream_list.js. There's still a
lot of boilerplate here, unfortunately, as topic lists have a lot
of dependencies on other parts of the system--narrowing state,
muting state, jQuery, handlebars, etc.
2016-11-05 10:38:37 -07:00
Rishi Gupta
6544c756d6
forms.py: Reorder imports.
2016-11-05 10:37:15 -07:00
Rishi Gupta
5e6d4da8a8
realm creation flow: Prevent disposable email signups.
...
Check user's email address against a list of 2000 disposable email
domains. Does not affect the create_realm management command.
2016-11-05 10:37:15 -07:00
Rishi Gupta
2033381d24
realm creation flow: Restrict subdomains one can create via the web flow.
...
Disallow Realm.string_id's like "streams", "about", and several hundred
others. Also restrict string_id's to be at least 3 characters long, and only
use characters in [a-z0-9-].
Does not restrict realms created by the create_realm.py management command.
2016-11-05 10:37:15 -07:00
Tim Abbott
c6ceae868b
requirements: Upgrade twisted, adding incremental and constantly.
...
Twisted 16.5.0 has a couple new dependencies.
2016-11-05 09:13:35 -07:00
Tim Abbott
be506d63f6
requirements: Upgrade a bunch of minor Python package versions.
...
These are all minor versions and thus shouldn't have any impact.
2016-11-05 09:13:28 -07:00
Rishi Gupta
e3646f28bd
test_helpers.py: Fix default args for submit_reg_form_for_user.
...
Previously realm_name and realm_subdomain defalted to None, which when
posted to /accounts/register, are submitted as u'None'. "None" is an invalid
Realm.subdomain, since subdomains can't have capital letters.
2016-11-04 22:01:53 -07:00
Rishi Gupta
950831810b
test_signup.py: Refactor test_create_realm_with_subdomain.
...
Refactor test_create_realm_with_subdomain to match test_create_realm more
closely, so that it's easier to see their similarities and differences.
2016-11-04 22:01:53 -07:00
Rishi Gupta
4db10a05de
test_signup.py: Move test_create_realm_with_subdomain to correct place.
...
Before it was in UserSignUpTest, now it is in RealmCreationTest. The diff
makes it look like test_user_default_language is the target of the move,
but it isn't.
2016-11-04 22:01:53 -07:00
hackerkid
70223ef2da
[third] Update marked base to newer version 0.3.6.
...
This basically re-applies the Zulip changes to marked 0.3.6.
Fixes #2190 .
2016-11-04 21:56:53 -07:00
Tim Abbott
51fcf1fb7a
tests: Fix spelling of test_transifex.py.
2016-11-04 21:49:39 -07:00
sonali0901
df4b777b35
tests: Fix handling of subdirs and backup files in test-backend.
...
Fixes #1950 .
2016-11-04 21:49:23 -07:00
Mohsen Ibrahim
19b01d74fa
bug fix: Send stream notifications to all users for public streams.
...
If a stream is public, we now send notifications to all realm users
if the name or description of the stream changes. For private
streams, the behavior remains the same.
We do this by introducing a method called
can_access_stream_user_ids().
(showell helped with this fix)
Fixes #2195
2016-11-04 21:41:41 -07:00
Steve Howell
c405b67138
tests: Ignore SAVEPOINT queries in queries_captured().
...
We use the queries_captured() context manager in our tests
to capture queries that happen during certain actions. Usually
we use the list of queries to validate that we're not doing
too many database calls.
For most tests the database calls are fairly deterministic,
but SAVEPOINT-related things seem to be more random, and the
number of savepoints is usually not relevant to what the test
is trying to prevent, which is more serious problems like
O(N) database fetches.
2016-11-04 21:30:36 -07:00
Steve Howell
e17cb79701
node tests: Remove compile-settings code from templates.js.
2016-11-04 21:23:35 -07:00
Steve Howell
6a1b53a195
node tests: Remove compile-settings code from i18n.js.
2016-11-04 21:23:35 -07:00
Steve Howell
dae53573cb
node tests: Fix make_sure_all_templates_have_been_compiled().
...
This now searches subdirectories.
2016-11-04 21:23:35 -07:00
Steve Howell
3d0c0e2e81
node tests: Remove retry logic for compiling templates.
...
We can now use template_finder.get() to find the name we need.
2016-11-04 21:23:35 -07:00
Brock Whittaker
ee8d54db0f
Change content to rely on data-* attribute.
...
Content now relies on the data-no-description attribute which then
allows for it to be embedded in HTML and therefore translatable.
2016-11-04 17:26:53 -07:00
Brock Whittaker
4400665a6d
subs: Move stream settings into an independent overlay.
...
This replaces the scrolling stream settings feature with a stream
settings overlay.
2016-11-04 17:13:26 -07:00
Tim Abbott
78ec0341c4
subs: Fix color picker issue with subscribing.
2016-11-04 17:13:26 -07:00
Tim Abbott
73f020645f
subs: Remove unnecessary update_stream_color call.
...
The color was already being updated in the response from the server.
2016-11-04 16:37:29 -07:00
Tim Abbott
a70c5eb923
colorpicker: Migrate to use stream IDs to access things.
2016-11-04 16:37:29 -07:00
Tim Abbott
ab6fd87161
subs: Fix rename stream handling of email addresses.
2016-11-04 16:37:29 -07:00
Tim Abbott
e6734bfada
subs: Cleanup stream rename logic.
2016-11-04 16:37:29 -07:00
Tim Abbott
ee976a9bdc
subs: Use subscription_settings when changing descriptions.
2016-11-04 16:37:29 -07:00
Tim Abbott
45c7945818
subs: Use sub_settings in subscriber add/remove flow.
2016-11-04 16:37:29 -07:00
Tim Abbott
8e522cd933
subs: Convert stream_home_view_clicked to use sub_settings.
2016-11-04 16:37:29 -07:00
Tim Abbott
2467f765ad
subs: Stop using sub_row when rendering settings.
2016-11-04 16:37:29 -07:00