e9a4596ea9
integrations/hubot: Fix URL in example config.
...
tabbott checked the source and confirmed my suspicion
(in eb55a3a1b
2017-11-03 13:38:59 -07:00
9767029211
Allow generic bots to be mentioned.
...
The original PR to allow generic bots to be mentioned had
some merge issues that we detected about a week after the
fact. This commit restores the logic from the original PR.
The reason we didn't detect this bug earlier is that the
merge issues didn't break any existing behavior. Instead,
they made it so that only UserMessage rows got written for
bots, but no events were being set. The part of the commit
that got lost is restored here, so now events get sent as
well.
Thanks to @derAnfaenger for reporting this and being patient
as we tracked it down.
Fixes #7140
2017-11-03 07:45:18 -07:00
2155b255d6
service bot tests: Remove bot stream subscription.
...
Since service bots react to all @-mentions, the
stream subscription was redundant.
2017-11-02 14:44:11 -07:00
aaaed74c3d
webhooks: Import REQ, has_request_variables from zerver.lib.request.
...
We now import REQ and has_request_variables from zerver.lib.request,
which is where these methods are defined.
Fixes #7195 .
2017-11-02 14:40:55 -07:00
20f3e9b779
webhooks/gci: Support 'needswork' event_type.
...
This commit adds support for payloads that are generated when a
mentor submits a task for more work.
2017-11-02 16:46:11 -02:30
9969a3a40b
webhooks/gci: Replace 'type' -> 'event_type', 'uuid' -> 'id'.
2017-11-02 16:39:48 -02:30
839b427ea5
zerver/management: Remove u prefix from strings.
...
License: Apache-2.0
Signed-off-by: rht <rhtbot@protonmail.com>
2017-11-02 11:01:47 -07:00
dc37e3f72c
zerver/migrations: Remove u prefix from strings.
2017-11-02 11:01:47 -07:00
38acddee99
zproject: Remove u prefix from strings.
2017-11-02 11:01:47 -07:00
be2a720a04
refactor: Replace %r with %s in string representations of classes.
2017-11-02 11:01:47 -07:00
dcc831f767
refactor: Replace all __unicode__ method with __str__.
...
Close #6627 .
2017-11-02 11:01:47 -07:00
e51d98cd96
refactor: Remove usage of ModelReprMixin.
2017-11-02 11:01:47 -07:00
4af9e11115
left-sidebar: Add overflow ellipsis on long stream names.
...
On stream names that don’t quite fit, we’ll add overflow ellipsis to
them. It appears we already did this on mobile in a sub-optimal way so
we can remove that media query with preference to the new, better
styling.
2017-11-01 13:27:42 -07:00
c9af964357
list_render: Add sorting reversal.
...
This allows a user to reverse the sort order by clicking again on an
active tab, which changes from ascending to descending order.
Fixes : #7254 .
2017-11-01 13:26:40 -07:00
26dd785b2b
list_render: Use correct arrow for ascending.
...
Ascending files (as it currently is by default) should use an upwards
arrow.
2017-11-01 13:26:40 -07:00
fd19743098
settings: Fix scrolling on settings page in narrow height windows.
...
This allows a user to scroll all the way down on the sidebar and the
main panel in the settings page on narrow height windows by removing
the min-height specification and making the “Log out” line in the
sidebar become statically positioned at shorter heights.
Fixes : #7251 .
2017-11-01 13:25:27 -07:00
85f605a978
Fix bug with EmailLogBackend.send_messages.
...
The `logging.info` call was not properly using string interpolation.
2017-11-01 10:05:13 -07:00
ad374ad3c5
css: Fix improper indentation to fix Travis test failure.
2017-10-31 18:58:59 -07:00
6a4e7ad12e
user settings: Enhance Uploaded files sorting.
...
Fixes #7149
2017-10-31 18:33:41 -07:00
5d9327a25b
user settings: Improve Uploaded Files design.
...
* Prevent long file names from corrupting table display.
* Add sticky table header.
Fixes #7189 .
2017-10-31 18:33:41 -07:00
3ed707c225
docs: Add more detail on the apt upgrade process and postgres.
2017-10-31 18:11:54 -07:00
1432e9afb0
Revert "vagrant: Switch Virtualbox to use NFS for syncing files."
...
This reverts commit 4d7f1e7c88
2017-10-31 17:49:53 -07:00
44bff43c86
actions.py: Rename `do_remove_reaction()` to `do_remove_reaction_legacy()`.
2017-10-31 15:42:35 -07:00
233595b2f7
actions.py: Rename `do_add_reaction()` to `do_add_reaction_legacy()`.
2017-10-31 15:42:35 -07:00
636046aec9
user-groups: Add basic backend for UserGroup model.
...
This adds the data model and bugdown support for the new UserGroup
mention feature.
Before it'll be fully operational, we'll still need:
* A backend API for making these.
* A UI for interacting with that API.
* Typeahead on the frontend.
* CSS to make them look pretty and see who's in them.
2017-10-31 15:16:14 -07:00
5914afc018
cleanup: Use a single loop in do_send_messages.
2017-10-31 12:56:14 -07:00
9689168bf6
Simplify highlight_string logic.
...
This change avoids some complicated byte arithmetic by
extracting some local variables and being more explicit
about using bytes vs. using strings.
2017-10-31 12:45:58 -07:00
6df65abd50
team: Tweak some text.
2017-10-31 12:44:05 -07:00
d27002ba21
landing-page: Replace /about with /team and /history in links.
2017-10-31 12:44:05 -07:00
425738fa24
landing-page: Extract /team/ from /about/.
...
This extracts and creates a /team/ page using the existing
'team.html' template and applying the why-page styling to it.
2017-10-31 11:37:42 -07:00
4d7f1e7c88
vagrant: Switch Virtualbox to use NFS for syncing files.
...
This seems to help with frequent virtualbox guest crashes that we've
been having on Macs recently.
Thanks to Umair Khan for figuring this out.
2017-10-31 11:11:34 -07:00
d6df408a0e
search: Add tests for multiple unicode search operands.
2017-10-31 10:53:16 -07:00
04a79800b9
models: Fix typo in comment.
2017-10-31 10:46:38 -07:00
5e3ba1f20f
mypy: Fix an unnecessary duplicate type declaration.
2017-10-31 10:46:02 -07:00
ee61e1be2c
search: Fix misaligned highlights due to unicode characters.
...
tsearch_extras returns search offsets in bytes but our highlight
function treated them as character offsets. Added a check to subtract
extra bytes if the tsearch search backend is being used.
Fixes #4084 .
Fixes #7021 .
2017-10-31 09:06:46 -07:00
8f9463bd72
test_bugdown: Check for unknown keys in markdown_test_cases.json.
...
This should help protect us from typos.
2017-10-31 08:58:42 -07:00
6f029d487e
tests: Change test_content to text_content in markdown_test_cases.
...
docs: Fix error in markdown documentation.
2017-10-31 08:51:49 -07:00
aab0eeb5cc
popovers: Hide opened popover on navigating back.
...
Hides popover if it remains open and an overlay such as the settings
UI is opened via the browser back button.
Fixes : #7230 .
2017-10-31 08:47:00 -07:00
5ec855967d
mypy: Constrain return types to match in test_runner.py.
2017-10-31 00:03:35 -07:00
966d5f3760
mypy: Specify Callable parameter/return type for run decorator in tools/diagnose.
2017-10-31 00:03:35 -07:00
7d8de37299
mypy: Specify librato Callable type.
2017-10-31 00:03:35 -07:00
7288451329
mypy: Slightly clarify Callable parameter to WebsocketClient.__init__.
2017-10-31 00:03:35 -07:00
452802bf75
mypy: Add Callable parameters/returns to AsyncDjangoHandler in handlers.py,
2017-10-31 00:03:35 -07:00
5357c2e352
mypy: Reduce use of Any in UserPresence static methods.
...
Use str here since now using python3.
2017-10-31 00:03:35 -07:00
7f5b69bca8
mypy: Clarify Callable parameters & return type for get_timing.
2017-10-31 00:02:17 -07:00
304e411944
mypy: Remove unused FuncT TypeVar in cache.py.
2017-10-31 00:02:17 -07:00
48662a79a5
clean-venv-cache: Fix an exception with unusual deployment dirs.
2017-10-31 00:01:09 -07:00
9bf81b7fa9
api: Fix /api/endpoints/ javascript for now.
...
This was apparently completely broken for some time, and got a bit
worse with my recent changes (enough to fail a test).
Since the plan for this page likely involves dissecting and
eliminating it, I think it makes sense to just fix it hackishly and
move on.
2017-10-30 23:58:12 -07:00
8c9ea94878
scripts: Fix an issue in `purge-old-deployments` script.
...
We were not including the real path of the symlinks due to which we
were incorrectly deleting deployments pointed by last/current/next.
2017-10-30 23:09:51 -07:00
493529d981
compose: Fix node test failure from video link integration.
...
It's pretty annoying that we're seeing this several hours after the
original code was merged.
2017-10-30 23:06:04 -07:00
Greg Price
Steve Howell
derAnfaenger
Eeshan Garg
rht
Brock Whittaker
Cynthia Lin
Tim Abbott
Harshit Bansal
Umair Khan
Sampriti Panda
sandeepsajan0
Rhea Parekh
Shubham Dhama
neiljp (Neil Pilgrim)