dbc4798594
Be consistent about when we display search buttons
...
Show the buttons iff
- the search input is focused,
- the search input has non-empty contents, or
- we are narrowed.
(imported from commit f5c98471a2db4ab522160960dd1271471a9db555)
2013-01-08 12:18:31 -05:00
60f2d06736
search: Factor out show_buttons / hide_buttons
...
(imported from commit 776f066129e8cf4e298ae90fdd4f62341b36dcae)
2013-01-08 12:18:30 -05:00
f3e4b3bc31
search: Simplify event handler setup
...
(imported from commit b14c4bafb09fa5919e03aac24e968329778a01d6)
2013-01-08 12:18:30 -05:00
ddf75b64f7
Un-narrow whenever we clear the search box
...
(imported from commit 15533579bfbae1644cc76b33348c3cd21a829713)
2013-01-08 12:18:30 -05:00
4ddaf5a2ae
Use case-insensitive matching for all narrow operators
...
We don't require that the parsed form be lower case; that's handled by
narrow.activate. However we unparse as lower case, in order to give the user a
hint that matching is not case sensitive.
(imported from commit 2882b440deb59a049b095db7a13cfc18e047caec)
2013-01-08 12:18:30 -05:00
3619480673
Handle narrowing operators typed into the search box
...
(imported from commit 6f758091e2953d00d6a331210aa774b72ba889d5)
2013-01-08 12:18:30 -05:00
d2705ab913
Add narrow.describe
...
(imported from commit df123384754701108fe7597710cb0cf46cb86caf)
2013-01-08 12:18:30 -05:00
6d50e233ec
Add narrow.parse
...
(imported from commit 2275d02c2aee411d07645f7c3d81fdff7d188607)
2013-01-08 12:18:30 -05:00
121ba29abe
Simplify searchbox_sorter
...
(imported from commit cce3d2fd2e56801b43c668c849ef4664edc32a6c)
2013-01-08 12:18:30 -05:00
1fcc7a6185
Rework render_object_in_parts to use switch/case
...
And rename fields for conciseness.
(imported from commit 77d89085f0786ecdcbb2897e3d171c930b44137a)
2013-01-08 12:18:30 -05:00
e202638184
Rework narrow_or_search_for_term to use switch/case
...
(imported from commit a1296e79d9f6414113a475e407fbaccb54eadb14)
2013-01-08 12:18:30 -05:00
5ee6a9ebca
Rename narrow.show_all_messages to narrow.deactivate
...
(imported from commit 927374756e112abc1042b16caa315af8c1f0baec)
2013-01-08 12:18:29 -05:00
ba7ffcead4
narrow: Remove some unnecessary helpers
...
(imported from commit 307dfec262648bc1fc79d2fb46f8950c7a2f1e2e)
2013-01-08 12:18:29 -05:00
3c9b9227f8
Get rid of the narrowbar
...
(imported from commit 53335b8177561d4b103659a51704d6b2ce7ec367)
2013-01-08 12:18:29 -05:00
15f606a2ef
frontend/tests: Add a function to inject key presses
...
(imported from commit d2595482ec0bef8b2a4f819e6c29d6e84175a70e)
2013-01-08 12:18:29 -05:00
d4d4ea7a8d
Display narrowing operators in the search bar
...
(imported from commit d801128c5b961360939c9e3f3f6f89c8602f987b)
2013-01-08 12:18:29 -05:00
38ff2d9993
Use operators to express narrowing internally
...
This breaks server-side filtering, for the time being.
(imported from commit 58ec2d7aa593e1c71f835b186535a038faa63239)
2013-01-08 12:18:29 -05:00
78506acd20
Do not send the browser back on backspace when send button focused
...
Fixes Trac #585
(imported from commit 2b5a02db66cc09ae41da7e6921a31a14c49cf811)
2013-01-08 12:00:57 -05:00
e5ab18276e
Move sender gravatar inline in skinny windows
...
(imported from commit 570c1f6409213fd8a2b6dbb98372dbf2f62ec50c)
2013-01-08 11:28:49 -05:00
c5b4461ac6
Fix outdated comment in CSS
...
(imported from commit 198e3449b5396f6698b4fb7292ee4921ed326f18)
2013-01-08 11:28:49 -05:00
dbb63cb524
Don't continuously bug user if they dismiss the notifications box
...
Fixes Trac #514
(imported from commit 445af7cf458118be0394491aebbd9996817b08a4)
2013-01-08 11:04:16 -05:00
9730a65f59
nagios: revamp check_user_zephyr_mirror_liveness to monitor sudden drops in mirror use.
...
(imported from commit e92df66c40065584e84c049cfab8d82f71d6dddd)
2013-01-08 10:53:33 -05:00
0655397536
Give the NTP check the default number of retries.
...
It had a max_check_attempts of 1, which makes it susceptible to
network blips.
(imported from commit 20e51878d75bef36d02c5afaab78b8cdd701077f)
2013-01-08 10:53:33 -05:00
5cf5bcaed5
Add logging for the feedback bot.
...
(imported from commit 4beb3ec69330baf0305ff0509900a5039145f4f4)
2013-01-08 10:53:33 -05:00
8d0a17cbc3
puppet: fix installed packages typo in humbug_apache_base.
...
(imported from commit f503c767cadd9ce5f501233859faafd652f2c4e8)
2013-01-08 10:53:33 -05:00
c186e8ad96
puppet: Add a humbug_bots class with supervisord dependencies.
...
(imported from commit f5bdf6bccf10c7c7f21cc96c415014a26d04c019)
2013-01-08 10:53:32 -05:00
62284f39f4
nagios: monitor feedback bot liveness.
...
(imported from commit 64a97e74b8a44bf0a6faf97398f843d8209b8e36)
2013-01-08 10:53:32 -05:00
40a8ee48a5
Make stream_list only contain lowercase stream names.
...
(imported from commit 350f1b20987206c1e910fcc5c2926bd6e96baaeb)
2013-01-07 17:36:37 -05:00
baba72e3b8
Cause case to be respected when adding a subscription.
...
And have its colorpicker work.
(imported from commit 998c54153518bb94b7ce41e073078675767694c0)
2013-01-07 17:36:03 -05:00
5501558fa7
Only request background color for stream messages.
...
subs.get_color is expecting a string, and so if you do this on
a PM, it breaks.
(imported from commit acf6d51b84d7bbbe643466f1f72f90a8f6cf16f6)
2013-01-07 17:34:27 -05:00
b6e1024b69
Display composebox again upon server errors
...
Also removed .show()s for the alert on does-not-exist and not-subscribed, where
a blank error would display. This should fix the underlying issue with #166 :
that hiding the composebox before send_message() was called would hide server
errors.
(imported from commit a8a50cdf82ddf1d15f1e405432ff3bbfdb7a491a)
2013-01-07 17:03:34 -05:00
168ee1345c
Enforce 10000 char limit on message box
...
Add maxlength attribute to the textarea which displays a tool tip (in Chrome)
for the user, telling them they are over the limit, so that the error is caught
before the send_message step (which is too late for Create and Send).
Fixes trac ticket #166 .
(imported from commit 36b211a17f42dc8345e2235b4b4ca74c8f4e86c4)
2013-01-07 17:03:34 -05:00
c5d37572a7
Document ordering constraint on has_request_variables
...
(imported from commit efb42cc8478f968ac0dcd390d73bd3d161274fe1)
2013-01-07 16:09:23 -05:00
86862a8c0a
Fix running Django against postgres on Tim's laptop.
...
I'm not sure why this wasn't set before, but it's needed for this to work.
(imported from commit fd77c975a234ccd6a972a6f2c9bfac21fcbb2d25)
2013-01-07 15:06:28 -05:00
6cd49fbb14
populate_db: Add Humbug error bot.
...
This is needed to avoid exceptions trying to do internal_send_message
in any test against a simple populate_db database.
(imported from commit 36927f57cbbb7e30ae249b5f1a0549fb352827f5)
2013-01-07 15:06:28 -05:00
e2292d38b1
Add tests for mirroring of private messages.
...
(imported from commit 8599d233c98f48a205618f52752a6ce466100d9e)
2013-01-07 15:06:28 -05:00
dd843b3916
Fix buggy check for zmirror huddle sending to multiple recipients.
...
(imported from commit 2abc88338225a8a07c50aaf6eb54862885edcb9e)
2013-01-07 15:06:28 -05:00
9b3e4a8bed
Don't focus the new stream box after sucessfully subscribing or unsubscribing
...
If you have a lot of subscriptions that you're trying to modify,
jumping back up to the top of the page is very disruptive. We still
show the success message, which has the effect of scrolling the page
and is thus surprising, but that's better than the user completely
losing their place.
We do need a story for informing users about failures to subscribe or
unsubscribe, though. We currently jump back to the top so they can
see the error, but that's not optimal.
(imported from commit 48d938ddc47f286a72e2147f4459b91ca5684e36)
2013-01-07 13:48:19 -05:00
42bf93fb07
Add expandable settings panel for subscription entries
...
(imported from commit 3c07dcac7ec8086d417c2898a307ee67fc286704)
2013-01-07 13:48:19 -05:00
e1a3765644
Give each subscription an id for easier DOM manipulation
...
(imported from commit 976744174d06abf8bde651ca815d8fe17b8e64ff)
2013-01-07 13:48:19 -05:00
2b4b827715
Fix repeatedly clicking the subscribe/unsubscribe button
...
(imported from commit e85f2678a4ca896e5a9bd40d37c3713153825c4d)
2013-01-04 18:11:07 -05:00
aad09fc267
Merge stream_set and stream_color into a single data structure
...
(imported from commit 88324e0d296f192feac4f5ecf45f347712cc5914)
2013-01-04 18:11:07 -05:00
d9c41dd64f
Mention mobile apps in MIT welcome email.
...
(imported from commit 7f32f1e51511a8386a23a1c73cf08d57c052a58e)
2013-01-03 17:57:27 -05:00
73a8988df3
Fix tests which were sensitive to ordering of parameters
...
(imported from commit 87948bb8805a41382ba51152329b33b4f2f03937)
2013-01-03 17:22:21 -05:00
7f06681efa
Revert "Add "test" to names of test methods so they run"
...
This reverts commit a590bf6b8ee733893d3410ecb5eebe54141c48ea. This commit broke
the test suite because it was not tested after rebasing with Keegan's changes
to the tests.
(imported from commit 7248a55328609973c5303be6c85eeb5fbfc1475e)
2013-01-03 16:05:40 -05:00
c6929bbc9f
Allow PBKDF2 password hashes in dev mode
...
This fixes a problem where if you were 1) running in development
mode, 2) had populated the database from production data, and 3)
tried to log in with an account that had changed its password, you
wouldn't be able to. The problem was that the password change
created a password change record with a PBKDF2 hash, not a SHA1 hash.
This change lets the dev server accept PBKDF2 hashed passwords, but
still use SHA1 password hashes for creating test users for speed.
(imported from commit 2840d266f93add1edbba7f93a7f1491372fc8cf1)
2013-01-03 16:03:55 -05:00
5d7b64993b
nagios: Add monitoring for clock skew.
...
(imported from commit 1db47e7c6b28c9dd119e4c50309867d52d3c294b)
2013-01-03 10:21:16 -05:00
2cffb7e09b
Add test for missing params to ChangeSettingsTest
...
And add "test_" to the beginning of successful_change_settings.
(imported from commit f5c04517ae3b2140b0b3f7d5012a7044ef601cf0)
2013-01-02 18:46:09 -05:00
3763dca4a6
Return error if confirm_password is filled but not new_password
...
(imported from commit c58ca8d2f5592c4cf062b963f3cca6673242419e)
2013-01-02 18:46:09 -05:00
f276ad2dce
Add ChangeSettingsTest to test json_change_settings
...
(imported from commit 7e83dad9be4ffdfcb3631da6c63b18d85c5714eb)
2013-01-02 18:46:09 -05:00
Keegan McAllister
Jeff Arnold
Reid Barton
Jessica McKellar
Waseem Daher
Tyler Hallada
Tim Abbott
Zev Benjamin
Jacob Hurwitz