Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
36,729 Commits 28 Branches 142 Tags 769 MiB
Commit Graph

36729 Commits

Author SHA1 Message Date
Rohitt Vashishtha d870118f8f overlay: Mitigate issue with dropdown list widget getting clipped. 
This isn't a complete fix, but we move the widget's popup to be
on/below the button to open the widget. We also move the bot owner
field to be on the top of the page so that we can see most of the
widget before it is clipped by the parent overlay.

We have discussed some approaches for a permanent fix on:

https://chat.zulip.org/#narrow/stream/321-s/topic/DropdownListWidget/near/894674
 2020-06-04 16:44:19 -04:00
Clara Dantas e1e755c887 people.js: Change functions to return a list of ids instead of objects. 
The get_active_humans and get_non_active_humans functions used
to return a list of user objects. The get_active_humans is used
on settings_users.js and settings_bots.js, and in both places the
only attributes needed of the person object are the user_id and
full_name.

To make the function return smaller, instead of a list of active
humans, we are returning a list of active human ids, saving memory.
With the ids we can call the people API to get the full_name attribute.
 2020-06-04 14:23:52 -04:00
Priyank Patel 99bed7b702 circleci: Store puppeteer screenshots in artifacts. 2020-06-03 17:39:35 -07:00
Dinesh d429b7145e tests: Make puppeteer tests run in full suites and CircleCI. 2020-06-03 17:39:35 -07:00
Dinesh c8268865dc puppeteer_tests: Extract a common function to fill forms. 
Co-authored-by: Priyank Patel <priyankp390@gmail.com>
 2020-06-03 17:38:03 -07:00
Dinesh d9cc081b2d puppeteer_tests: Move `log_in` and `log_out` functions to `common.js`. 
Since `log_in` and `log_out` functions will also be used
in other tests, these are moved to `common.js`.
 2020-06-03 17:38:02 -07:00
Priyank Patel f91548ec02 puppeteer: Wait until DOMContentLoaded event for realm creation tests. 
This is done to avoid flakes where our code for focusing first input
interferes with puppeteer's typing. More details in comments.

Thanks Dinesh for testing this out earlier as part finding a solution
to this flake.

Co-authored-by: Dinesh <chdinesh1089@gmail.com>
 2020-06-03 17:33:04 -07:00
Anders Kaseorg e91050b674 migrations: Replace deprecated django.db.backends.postgresql_psycopg2. 
This has been a deprecated alias for django.db.backends.postgresql
since Django 1.9, removed in Django 3.0.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg 67dbb3b2a9 bugdown: Replace deprecated markdown members with md. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg f65af9cdb7 bugdown: Replace deprecated markdown.util.etree with ElementTree. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg 01ccb75259 bugdown: Replace deprecated cElementTree with ElementTree. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg aad0b8b2da bugdown: Add assert to work around type problem. 
url_to_a returns Union[Element, str], but str cannot be appended to
Element; that would raise TypeError at runtime.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg dd4d8968da custom_check: Use unconditional type imports. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg 789e612c70 requirements: Update Python requirements. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg 5ab1ddbad9 test_zulint_custom_rules: Fix open mock. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Anders Kaseorg 10805abd6e python: Fix errors from pycodestyle 2.6.0. 
zerver/lib/i18n.py:34:28: E741 ambiguous variable name 'l'
zerver/lib/webhooks/common.py:103:34: E225 missing whitespace around operator
zerver/tests/test_queue_worker.py:563:9: E306 expected 1 blank line before a nested definition, found 0

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-06-03 17:23:20 -07:00
Hemanth V. Alluri 9a9c1e0794 webhooks/stripe: Fix the invoice_created event. 
The previous code for this event was using a key that's not actually
a part of the payload. So here we simple remove the usage of that key
and add a (previously missing) test for this event.

Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
 2020-06-03 17:18:43 -07:00
Tim Abbott 7dbdfe9a97 models: Remove database columns from old Zoom integration. 2020-06-03 16:39:12 -07:00
Anders Kaseorg 4d04fa3118 compose: Rewrite Zoom video call integration to use OAuth. 
This reimplements our Zoom video call integration to use an OAuth
application.  In addition to providing a cleaner setup experience,
especially on zulipchat.com where the server administrators can have
done the app registration already, it also fixes the limitation of the
previous integration that it could only have one call active at a time
when set up with typical Zoom API keys.

Fixes #11672.

Co-authored-by: Marco Burstein <marco@marco.how>
Co-authored-by: Tim Abbott <tabbott@zulipchat.com>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
 2020-06-03 16:39:12 -07:00
Anders Kaseorg 7a53da7526 capitalization: Fix OAuth capitalization. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-06-03 16:39:12 -07:00
Anders Kaseorg fa9bddcfb2 emoji: Add workaround for collectstatic step of build-release-tarball. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-06-03 16:39:12 -07:00
Tim Abbott 8d9d36cbc7 api docs: Fix whitespace in changelog articles. 2020-06-03 14:30:32 -07:00
Tim Abbott 999554734c docs: Clarify that linkifiers are Python 3 regular expressions. 
Also tone down the "contact support" text; we've fixed most of the
issues that led to folks needing to do that.
 2020-06-03 14:05:39 -07:00
Rohitt Vashishtha 4b47d219db settings: Use correct label for signup notifications stream. 
When migrating to dropdown list widget, we incorrectly used the same label
for both realm_notifications_stream and realm_signup_notifications_stream.

This was introduced in b580baf682.
 2020-06-03 12:19:08 -07:00
SiddharthVarshney ecd383b53c css: Use SCSS nesting for `nav`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney ff75ea838f css: Reorder `nav .content` and `nav ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 3435396479 css: Reorder `nav .hamburger`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney dcbc4f8630 css: Reorder `nav.white`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney f57a512ab3 css: Use SCSS nesting for `nav li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 2130c3018e css: Use SCSS nesting for `nav li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney d4d326c827 css: Use SCSS nesting for `nav ul li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney de4396661b css: Use SCSS nesting for `nav ul li.active`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney dcc658264c css: Reorder css related to `nav ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 948b54e519 css: Use SCSS nesting for `nav .logo`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney d21d13698e css: Reorder css for `nav .logo span`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 756722616e css: Use SCSS nesting for `nav .content`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 5009bedba4 css: Remove redundant css for `nav .logo span`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney e5c1be0584 css: Use SCSS nesting for `nav.white`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 3a81099972 css: Use SCSS nesting for `nav.white ul`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney f4f99e7ca6 css: Use SCSS nesting for `nav.white li`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 96db3fa650 css: Use SCSS nesting for `nav.white .brand.logo`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney 70a025d08d css: Reorder `nav.white .hamburder`. 2020-06-02 17:26:45 -07:00
SiddharthVarshney bfad22d128 css: Remove duplicate style. 2020-06-02 17:26:45 -07:00
Siddharth Varshney 1ac597c77e css: Use SCSS nesting for `.silver`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney a10a78736d css: Reorder styles related to `.silver`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney b29b7b8da1 css: Use SCSS nesting for `.float`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney 8317bde30f css: Reorder css related to `h1` and `h2`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney ea704c8c91 css: Use SCSS nesting for `a`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney e520e82b04 css: Use scss nesting for `a.arrow`. 2020-06-02 17:26:45 -07:00
Siddharth Varshney cc71533b21 css: Reorder css for `a` tag. 2020-06-02 17:26:45 -07:00