252b0f193e
password_quality: Convert .data("minLength") et al. to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
7a5e68161a
list_widget: Convert .data("sort"), .data("sort-prop") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
382eec17e2
list_widget: Convert .data("empty") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
72688c26b5
invite: Convert .data("loading-text") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
64c2d442ac
web: Convert .data("user-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
455f8a9c53
web: Convert .data("stream-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
bc9a7ef274
components: Convert .data("tab-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
153847d617
web: Convert .data("search-results-empty") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
ebea1eed18
sidebar_ui: Convert .data("animated-url"), .data("still-url") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
5950093ae0
settings_components: Convert .data("method") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
64c8262eaf
settings_components: Convert .data("setting-widget-type") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
abee323c77
web: Convert .data("code-language") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
c2bae4c9d9
message_list_tooltips: Convert .data("is-bot") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
87ea4313cd
web: Convert .data("message-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
c97f6c6c71
loading: Remove dead data-spinner_obj access.
...
As of commit 7b00bd6f7e
2024-05-03 12:45:46 -07:00
518daff9db
lightbox: Set data-filename as an attribute, not an invalid property.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
f07ed8b6b3
hashchange: Restore narrow state on `escape` keypress to `feed`.
...
If user goes to combined feed view on escape keypress, then
we restore their narrow pointer and offset by restoring it from
browser history if the their last narrow was the combined feed view.
2024-05-03 12:42:22 -07:00
240f7b53b2
message_lists: Remove `save_pre_narrow_offset_for_reload`.
...
This is no longer required since narrow state is restored by
`reload` library and narrow history restores the narrow pointer
and offset when going back to a view.
Only regression here is we will no longer restore the pointer when
user navigates to the combined feed view without using browser back
button and combined feed view is the default view. This is fixed
in the next commit.
2024-05-03 12:42:22 -07:00
2eb216f1da
message_list: Only update selected id and banner for current list.
2024-05-03 12:42:22 -07:00
439091998d
hashchange: Restore pointer state for combined feed view.
...
Now, user can use browser back button to go their last selected
message in combined feed view.
2024-05-03 12:42:22 -07:00
24f47e8993
narrow_history: Use a more accurate way to check hashchange status.
...
`hash_util.search_terms_to_hash` doesn't work correctly for all
hashes, main one being the combined feed view.
2024-05-03 12:42:22 -07:00
f786c2c5d7
hash_util: Fix wrong type specified for `hash` parameter.
2024-05-03 12:42:22 -07:00
478a4a59bc
hash_util: Make it clear that the function doesn't work for all views.
2024-05-03 12:42:22 -07:00
fb9acf8911
message_row: Establish clarifying messagebox-includes-sender class.
2024-05-03 12:34:27 -07:00
6c5085b827
message_header: Bring over control hover selectors.
2024-05-03 12:34:08 -07:00
a001f58c92
help: Document self-serve Cloud Plus upgrades.
2024-05-03 12:33:42 -07:00
8b6534722e
help: Consolidate upgrade steps for self-hosted and cloud billing.
2024-05-03 12:33:42 -07:00
15d5b57d19
help: Reduce duplication on self-hosted billing instructions.
2024-05-03 12:33:42 -07:00
50c744db48
left_sidebar: Apply grid to 'more conversations' DM row.
2024-05-03 12:21:59 -07:00
6c9484e0be
drafts_overlay_ui: Remove incorrect $ prefix from non-jQuery variable.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 11:42:43 -07:00
7e2811d633
message_view_header: Extract styles to own file.
...
This has the added value of being named in parallel with
web/src/message_view_header.ts
2024-05-03 11:12:55 -07:00
a37deb9fbc
settings: Use settings-field-label class in language widget label.
...
We now use "settings-field-label" class in the label of language
selection widget instead of "title" class to add the bottom margin.
2024-05-03 09:51:36 -07:00
62d2b93079
settings: Remove dropdown-title class.
...
We now use "settings-field-label" and "modal-field-label"
class on label elements in settings and modals respectively
to add the bottom margin which was previously done by
"dropdown-title" class as it is better to have more
generic names to use on label for all type of inputs.
2024-05-03 09:51:36 -07:00
040486776c
modals: Add bottom margin to label elements.
...
This commit adds bottom margin to label elements of
different inputs by adding "modal-field-label" class
to the label elements. Some of them already have the
margin due to having dropdown-title class.
2024-05-03 09:51:36 -07:00
8c6e71a195
settings: Add bottom margin to label elements.
...
This commit adds bottom margin to label elements of
settings inputs in personal, organization, stream
and group settings using the recently added
"settings-field-label" class.
Most of the settings are dropdown settings, so the
label for them already had a margin as they use
"dropdown-title" class.
2024-05-03 09:51:36 -07:00
e7a4790d33
settings: Remove extraneous hr element below "Field choices".
...
There is no need to have hr element below the "Field choices"
heading in custom profile edit form and this also makes it
consistent with the new custom profile field form.
2024-05-03 09:51:36 -07:00
916ea58aaf
settings: Remove unused classes from label elements.
...
This commit removes classes like "title", "input-label"
and "emoji-theme" from label elements in settings and
modals as these are classes are neither used in JS
nor to apply any CSS.
2024-05-03 09:51:36 -07:00
6f4a58fe71
settings: Place and style .settings-field-label on Profile.
2024-05-03 09:51:36 -07:00
10df1c414f
settings: Simplify field-hint selector.
2024-05-03 09:51:36 -07:00
8512ea124d
settings: Add variable for field/hint bottom margin.
2024-05-03 09:51:36 -07:00
29508e54b0
settings: Extend use of settings-profile-user-field-hint class.
2024-05-03 09:51:36 -07:00
38f51683a4
settings: Improve settings-profile-user-field-hint class.
...
This slight transposition makes it read closer to the adjacent
`settings-profile-user-field` class.
2024-05-03 09:51:36 -07:00
5d468ddef8
left_sidebar: Add colon `:` to the list of stream word separators.
2024-05-03 09:20:53 -07:00
65febced00
help: Remove description of transition from self-hosted billing page.
2024-05-03 09:18:42 -07:00
519c520c32
tippyjs: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
38f040ad79
search: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
33430f06c3
list_widget: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
f44d343511
invite: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7cd3a99aad
user_group_popover: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
57c6bfadf6
stream_list: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
Anders Kaseorg
Aman Agrawal
Karl Stolley
Alya Abbott
Sahil Batra
N-Shar-ma