Umair Khan
bccd2caacb
testing: Fix search key.
...
The problem this commit solves is related to how we search for
testcases in the test files. We use a simple 'search_key' in file_data.
This will return a false positive if there is a 'longer_search_key' in
file_data.
While searching for TestCases we should use a longer key to remove the
possibility of collision. Using 'class TestCase(' should be precise
enough.
Fixes #4983
2017-06-20 08:35:07 -04:00
neiljp
f1b3e943c6
Extend message parameters passed in check_expected_responses
2017-06-20 07:19:12 -04:00
Cynthia Lin
9777496046
repository: Update information with Codecov migration.
2017-06-20 07:17:39 -04:00
sinwar
e9ec59c45d
requirements: Upgrade requests to latest version.
...
Fixes #5455
2017-06-20 06:59:18 -04:00
Aditya Bansal
b19134d4c2
travis: Remove docker-engine from held package list in production.
...
We are doing this in order to avoid facing troubles when travis
updates its trusty images. Here is a link to the blog post.
https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2
2017-06-20 06:45:40 -04:00
Cory Lynch
387f37c15e
popovers.js: Fix keyboard shortcuts with copying link.
...
Fixes #5374 .
2017-06-20 06:28:25 -04:00
Cory Lynch
d5bcfc415d
emoji_picker.js: Fix popover icon that persists after exit.
...
Another manifestation of #4329 , as this bug
also applied to the emoji popover.
2017-06-20 06:28:25 -04:00
Cory Lynch
801e4f6f6e
popovers.js: Fix chevron that persists when exiting.
...
Fixes #4329 .
2017-06-20 06:28:25 -04:00
Cory Lynch
005d06eb38
message_store.js: Add tests for message id change.
...
This gets message_store.js to 100% line coverage.
2017-06-20 06:24:27 -04:00
Cory Lynch
55917b6761
message_store.js: Remove obsolete clear() function.
2017-06-20 06:24:27 -04:00
Cory Lynch
10b86da128
message_store.js: Add tests for erorrs/edge cases.
2017-06-20 06:24:27 -04:00
Cory Lynch
24b9108d09
message_store.js: Increase coverage for add_message.
2017-06-20 06:24:27 -04:00
Steve Howell
6c722843ef
node tests: Fix namespace leaks related to require().
...
The node tests have purged modules from cache that were
included via things like set_global(), but calling require
directly would leak modules into the next test, which made
a couple tests only work when you ran the whole suite. I
fixed those tests to work standalone. And then I now make
dependencies explicitly clear the require cache before we
require them in namespace.js.
2017-06-19 22:36:58 -04:00
Vishnu Ks
9b16835c99
user_popover: Handle the case when user presence is unknown.
...
For bots and users who have not logged in for a long time the presence information is not known. For the these users make the presence indicator hidden.
2017-06-19 17:25:06 -04:00
Harshit Bansal
dfbf8b8086
bugdown: Remove shortname mention syntax.
...
We used shortnames for mentioning users before we had autocomplete
feature. Since we now have autocomplete typeahead, this syntax is
no more useful and just causes problems. This commit removes the
shortname mention syntax.
Fixes : #4189 .
2017-06-19 16:57:59 -04:00
Jack Zhang
af3b7d4c98
message-edit: Patch html tags after edits on new lines.
2017-06-19 16:43:11 -04:00
Aditya Bansal
cf503017d2
Use requirements file for pip/setuptools/wheels in venv setup.
...
Fixes : #5158 .
2017-06-19 16:37:50 -04:00
Aditya Bansal
7980462010
setup-backend: Add wrapper to retry provisioning in case it fails.
...
In this commit we add a wrapper around the provisioning inside
setup-backend to trigger another try at provisioning if it fails
in hopes of it will run this time fine if it was interuppted by a
network issue the first time.
Fixes : #2034 .
2017-06-19 16:14:11 -04:00
Aditya Bansal
924d8266c0
setup-production: Add a wrapper to retry provisioning when it fails.
...
In this commit we basically add a wrapper around provisioning
inside setup-production to trigger a retry in case of failure.
2017-06-19 16:14:11 -04:00
Aditya Bansal
fab4a30cce
production-helper: Add wrapper to retry apt-get dist-upgrade.
...
In this commit we add a conditional inside production helper to just
re run apt-get dist-upgrade in case it fails the first time.
2017-06-19 16:14:11 -04:00
vaibhav
33c0c00cd6
Outgoing webhook System: first Iteration of outgoing webhook UI.
2017-06-19 16:05:54 -04:00
Aditya Bansal
f32c1892ff
preview.py: Fix error raised on uploading file with unicode filename.
2017-06-19 14:58:44 -04:00
Vishnu Ks
61e74be61d
requirements: Add service_identity to scrapy.txt.
2017-06-19 13:01:41 -04:00
Steve Howell
2d06a280b6
Fix broken IIFE link.
...
(We now just point the user to a Google search.)
2017-06-19 09:46:06 -04:00
Joshua Pan
23dc32a0f3
node tests: Enforce 100% coverage in markdown.js and presence.js.
2017-06-19 08:00:55 -04:00
Joshua Pan
ecaf628d76
node tests: Add test_set_user_status().
2017-06-19 08:00:55 -04:00
Joshua Pan
a71a8d2343
node tests: Fully cover status_from_timestamp in presence.js.
2017-06-19 08:00:55 -04:00
Joshua Pan
8011212384
node tests: Fully cover update_info_for_small_realm in presence.js.
2017-06-19 08:00:55 -04:00
Joshua Pan
65c68d385e
node tests: Add test_last_active_date().
2017-06-19 08:00:55 -04:00
Joshua Pan
71dab26c84
node tests: Fully cover test_set_info in presence.js.
2017-06-19 08:00:55 -04:00
Joshua Pan
d1408125b2
tools: Make sure missing lines in node test coverage are correct.
2017-06-19 07:59:50 -04:00
Aditya Bansal
c4d38c1344
travis: Start using npm cache cleanup tooling.
2017-06-19 07:55:23 -04:00
Aditya Bansal
7de4c340f6
tooling: Add tool to clean unused NPM cache.
2017-06-19 07:55:23 -04:00
Aditya Bansal
e4af0caddb
node_cache.py: Refactor to seperate out sha1sum generation.
...
Basically we just seperate out the sha1sum generation for the
node modules so that it can be reused later for cache clearance
logic. This is achieved by adding a function which returns the
sha1sum based HEX digest.
2017-06-19 07:55:23 -04:00
Vaida Plankyte
52c351aa27
docs: Fix trailing whitespace in git-guide.md.
2017-06-19 07:52:07 -04:00
Vaida Plankyte
b02b49ca4e
docs: Add screenshot-and-gif-software.md and link to it.
2017-06-19 07:52:07 -04:00
Robert Hönig
d91691be2f
bots: Update yoda bot to use get_config_info().
2017-06-19 07:11:08 -04:00
Robert Hönig
a48da1e6ca
bots: Update weather bot to use get_config_info().
2017-06-19 07:11:08 -04:00
Robert Hönig
651a21810d
bots: Update foursquare bot to use get_config_info().
2017-06-19 07:11:08 -04:00
Robert Hönig
c0f820e459
bots: Update commute bot to use get_config_info().
2017-06-19 07:11:08 -04:00
Robert Hönig
bc183b8e61
bots: tests: Remove superfluous sys.path insertion.
2017-06-19 07:11:08 -04:00
Robert Hönig
a869cab2db
bots: Correctly set paths to bot modules for testing.
2017-06-19 07:11:08 -04:00
Tommy Ip
e9fd41bb66
lint: Check if the first word of a commit message is imperative.
...
Only check the first word using a black list approach to reduce
force positive as shown in the current implementation.
2017-06-19 07:01:52 -04:00
Cory Lynch
552c39a036
fenced_code.py: Improve test coverage for special chars.
2017-06-19 06:53:25 -04:00
Cory Lynch
7f8ecb62c9
fenced_code.js: Improve coverage to 100%.
2017-06-19 06:53:25 -04:00
Cory Lynch
6255636923
Support special characters for code block languages.
...
Fixes #5412
2017-06-19 06:53:25 -04:00
Cory Lynch
472e788ee0
Add user documentation for is:unread.
2017-06-19 06:51:13 -04:00
Cory Lynch
58a2ffbe1d
Add search suggestion support for is:unread.
2017-06-19 06:51:13 -04:00
Cory Lynch
86d3e00bd0
Add search support for is:unread.
...
Fixes #1423 .
2017-06-19 06:51:13 -04:00
Cory Lynch
b4419528f7
Update narrow.py, messages.py to support is:unread.
2017-06-19 06:51:13 -04:00