Prabhakar Gupta
bc6421fbfb
tools: Remove empty wrapper script build_emoji.
...
This renames the old `emoji_dump.py` to `build_emoji`, removing the
old shell essentially empty shell script. `emoji_dump.py` was always
a weird name, and this makes it a bit easier to read the code for this
system.
2016-10-20 22:57:45 -07:00
Sumana Harihareswara
2083ffa7a6
docs: Improve export documentation.
...
Added user and realm export guidance in production maintenance docs,
linked to conversion guide, and revamped the introduction and styled
the text that Steve wrote.
2016-10-20 22:52:32 -07:00
Sumana Harihareswara
d9d389f64f
docs: Add an initial code review document.
...
A first pass at a code review guide. Mostly Tim's draft; I added
polish and links.
Fixes : #758 .
2016-10-20 22:41:38 -07:00
Tim Abbott
f9f8b18e2f
lint: Ban use of json_success({}) instead of json_success().
2016-10-20 22:34:04 -07:00
Amy Liu
3ee777a11a
Add UI for deactivating your own Zulip account.
...
Fixes #1009 .
2016-10-20 22:29:30 -07:00
Tim Abbott
3d183ffe23
text_fixtures: Fix case where source_hash_file doesn't exist.
...
We unfortunately just broke provisioning because we didn't correctly
handle the case where the source_hash_file didn't exist.
2016-10-20 22:21:45 -07:00
Steve Howell
409a84698c
Handle peer_remove events correctly for subscriptions.
...
We now send peer_remove events to folks who have never subscribed
to the streams (except for private streams and zephyr).
We also use logic that is more similar to how
bulk_add_subscriptions() works.
2016-10-20 22:05:19 -07:00
Steve Howell
68ae4da626
Extract query_all_subs_by_stream().
...
This code was in bulk_add_subscriptions, but we want the same logic
to eventually happen in bulk_remove_subscriptions.
2016-10-20 22:05:19 -07:00
Steve Howell
d13b0554b3
Remove emails_by_stream in bulk_add_subscription().
...
There are so many collections in this function, it's hard to keep
them all straight. This one is fairly redundant, so it was easy
to remove.
2016-10-20 22:05:19 -07:00
Steve Howell
d706bfa69f
Move some code from notify_subscriptions_removed().
...
There are two reasons for this change. First, we want to be
consistent with notify_subscriptions_added(), which doesn't
handle "peer" events. Second, we want to fix this code in a
subsequent commit not to do one user at a time, which is
inefficient.
2016-10-20 22:05:19 -07:00
Steve Howell
dda4c61f2a
Remove do_remove_subscription().
2016-10-20 22:05:19 -07:00
Steve Howell
cba8be6bbb
Use bulk_remove_subscriptions() in remove_users_from_stream.
...
We are deprecating do_remove_subscription.
2016-10-20 22:05:19 -07:00
Steve Howell
4ae117ed14
Use bulk_remove_subscriptions() in do_deactivate_stream().
...
We are deprecating do_remove_subscription().
2016-10-20 22:05:19 -07:00
Steve Howell
77c75df284
Remove do_remove_subscription() calls in test_events.
2016-10-20 22:05:19 -07:00
Steve Howell
44bbece5a6
Remove do_remove_subscription() calls in tests.py.
2016-10-20 22:05:19 -07:00
Steve Howell
b2d06fad42
Extract get_peer_user_ids_for_stream_change().
2016-10-20 22:05:19 -07:00
Steve Howell
5eee77fe81
Remove do_add_subcription().
2016-10-20 22:05:19 -07:00
Steve Howell
76acab36b2
Remove do_add_subscription from Django testing docs.
2016-10-20 22:05:19 -07:00
Steve Howell
98e4452e07
Replace do_add_subscription() in add_users_to_streams.
2016-10-20 22:05:19 -07:00
Steve Howell
bea8ba620b
Replace do_add_subscription() in tests/tests.py.
2016-10-20 22:05:19 -07:00
Steve Howell
9408ba7ca8
Replace do_add_subscription() in test_subs.
2016-10-20 22:05:19 -07:00
Steve Howell
45790264c2
Replace do_add_subscription() in test_signup.
2016-10-20 22:05:19 -07:00
Steve Howell
f4fc8455de
Replace do_add_subscription() in test_narrow.
2016-10-20 22:05:19 -07:00
Steve Howell
d18e286131
Replace do_add_subscription() in test_messages.
2016-10-20 22:05:19 -07:00
Steve Howell
78b73a0c91
Replace do_add_subscription() in test_helpers.
2016-10-20 22:05:19 -07:00
Umair Khan
041cd6c787
Add --force argument to provision.py.
...
Fixes : #2026
2016-10-20 22:04:52 -07:00
Umair Khan
35dea5246c
Regenerate test DB only when template DB has changed.
2016-10-20 22:04:52 -07:00
Umair Khan
45166cb39c
is_template_database_current: Check populate_db and postgres-init-test-db.
...
Compare the hash of 'zilencer/management/commands/populate_db' with
'var/populate_db_hash' and 'tools/setup/postgres-init-test-db' with
'var/postgres_init_test_db_hash' and if any comparison fails rebuild
the database.
With fixes from tabbott.
2016-10-20 22:04:47 -07:00
sonali0901
1bc7990327
Extract people.filter_people_by_search_terms()
...
This code used to be in subs.js, but now it's in people.js and has
some unit tests.
I did this w/showell as part of live coding on Zulip.
2016-10-20 21:44:26 -07:00
hackerkid
bca1953aa4
Add support for !gravatar syntax in echo.js.
2016-10-20 14:40:45 -07:00
hackerkid
95b5ac1d5d
Add support for !avatar syntax in echo.js.
2016-10-20 14:40:33 -07:00
Tomasz Kolek
67adf570e7
Remove @-mentions from jira integration.
...
Because of a lot of annoying notifcations we decided to remove
all @-mentions in jira. We replaced it by just login (without @).
2016-10-20 11:55:12 -07:00
Sumana Harihareswara
c3d3288b63
docs: Style & link text in prod maintenance guide.
...
Also fix line wrapping and some capitalization.
2016-10-20 11:53:46 -07:00
Sumana Harihareswara
a4516bda7d
docs: Fix security bug email address.
2016-10-20 11:53:46 -07:00
Tim Abbott
31b245eaea
bugdown: Add tests for avatar/gravatar syntax.
2016-10-20 11:18:41 -07:00
K.Kanakhin
7bc0c7f0d5
bugdown: Fix patterns ordering in Markdown extension.
...
- Put 'modal_link' and 'link' inline patterns after avatar inline pattern
to correct applying them to parsed text.
Fixes: #1654
2016-10-20 11:18:41 -07:00
Tim Abbott
8f6a58f741
docs: Expand translating documentation a bit.
2016-10-19 15:34:31 -07:00
Tim Abbott
92b8ce32fc
docs: Clean up translation resources discussion.
2016-10-19 15:32:28 -07:00
Sumana Harihareswara
8d4b32a13a
Fix style and linewrapping & add links in translation doc.
2016-10-19 15:30:35 -07:00
Sumana Harihareswara
8d1e87cfff
Add translations stream link to translation doc.
2016-10-19 15:30:35 -07:00
Brock Whittaker
e463577f30
Fix language alert to display language name.
...
If you chose the same language as was already selected, the alert would
say “is now the default language!” where it omits the language name.
This is the fix so that the language name appears all the time.
2016-10-19 15:17:16 -07:00
Tim Abbott
50356cc325
event_queue: Eliminate buggy need_timeout heartbeat code.
...
As best I can tell, this option was completely confused in two ways:
* The name is confusing; it actually controls whether we _clear_ the
timeout associated with the current handler
* It's not clear why one would not want it to be unconditionally true.
From reading the history, I'm pretty sure I had just misread the code
when I created this.
And this caused a real bug; a later refactoring caused us to basically
never cancel the timeouts, which in turn resulted in 90% of all events
traffic being hearbeats with a much lower frequency (~5s) than the
intended 45s. Removing this code fixes that nasty bug.
2016-10-19 14:32:49 -07:00
Tim Abbott
a6e779a56c
events: Add event types to logging.
...
This should make it a lot easier to analyze our events traffic and
debug potential issues with it.
2016-10-19 14:32:16 -07:00
Sumana Harihareswara
fe711208fb
docs: Capitalize GitHub properly.
2016-10-19 12:36:20 -07:00
Vikas Parashar
e962704c71
Add installation troubleshooting instructions in case of pip failure.
...
Add help for pip install failure during provisioning step of
initial vagrant up during developer environment installation.
Fixes : #1333 .
2016-10-19 12:34:08 -07:00
Tim Abbott
08729d35ad
README.md: Add mention of our blog and tweak intro.
2016-10-19 12:19:57 -07:00
Sumana Harihareswara
3b74ed20fa
Add GSoC mailing list link to README.md.
2016-10-19 12:14:51 -07:00
Umair Khan
e428f3feda
Run apt-get update only if sources.list has changed.
...
Fixes : #2025
2016-10-19 16:23:21 +05:00
Rishi Gupta
83f902953a
newsletter signup: Update merge_vars.
...
merge_vars is the user meta data we store in mailchimp. This commit changes
what we store from realm.domain to realm.id, since realm.domain is being
deprecated, and changes the OPTIN_TIME to a nicer format.
2016-10-18 19:29:12 -07:00
Steve Howell
4073ae09a1
streams: Use page_params.neversubbed_info client-side.
2016-10-18 17:33:58 -07:00