Because there's no guarantee that Hamlet has message IDs 1 and 2, and
the update_unread_counts function didn't return an error in the event
that you passed it a message that the user never received (it instead
silently succeeded), this test was mostly useless.
I just dumped the test_initial_counts function, because it didn't seem
to be doing anything useful.
(imported from commit 4d76104eb9f3b947727a1a030afc0b57054d0daf)
That commit intended to fix a bug where it jumps to the wrong scroll position
(offset by the difference in height from uncollapsed to collapsed) if you load
collapsed messages at the top, either by scrolling up or when it automatically
fetches more 10s after page load, because before, it updated the scroll
position before processing collapsing, which changes the height of messages.
Updating collapsing needs to happen before the viewport is adjusted, but also
needs to happen after the new messages get appended/prepended to the document
because they need to be attached to the document for getClientBoundingRect to
work.
(imported from commit 44d6a6135524e658084ffcf7d880ba898b577e6d)
We already have one for faded messages (which this commit simplifies),
but we also need one on unfaded messages to facilitate styling
experiments.
(imported from commit 41a6e2ef136ce73ce8c24de1e35199244ce56d37)
Trac #1540
* Make edit content box the same width as normal content
* Scroll to compensate for the added padding and "Topic" field.
* Restore the scroll position when exiting edit
It's off by 1px on Firefox 22, but Firefox is simply wrong.
(imported from commit 49154f51b538c648934a41a4a7a217198186ede2)
The code now unminifies all calls in the stack, including those outside
of app.js.
This requires the Python package sourcemap, recently added as a
dependency.
(imported from commit 550c73ad5bfe78a2c7169c11da0c95cbaac238d7)
This will allow you to always get Home from the search box,
as well as easily backing out narrows.
(imported from commit 68bcfc83ce0428645f4e734ae46f9589cb562a86)
Until now, we would reset the search string when you aborted
a search, but only if you are in the home view. Now, we reset
it always. This makes the search box an accurate reflection of
your narrow.
(imported from commit bed6adce54a55648165c84118d430c44abb5949f)
The naturalSearch option immediately updates the search box with
the underlying value of a search suggestion when the user moves to
it.
(imported from commit ad5cb5c2591ef4f71a6d648c8839f288cc125cf7)
If you are narrowed to "Private messages", we show you suggestions
of people. If you are narrows to pm-with, we show you a suggestion
to get back to is:private.
(imported from commit 18405beb1e194514618365d9f913972121c64d12)
(They will show up for empty queries or queries that are prefixes
of either the operator syntax or the label used in the sidebar.)
(imported from commit 3765896e3bc1fc95caf987194e22d89d649ba5ae)
We cap the number of overall suggestions at 50, but we don't
limit within category, since any limit is arbitrary and can
confuse users.
(imported from commit 3b18e9ad4b89e5a5485a058a2c0cd5fcca61ed35)
It allows us to provide suggestions when the user types '' in
a searchbox (e.g. by hitting delete when text is selected).
(imported from commit dc27ef86db2b6ec40039e4e9668b8ccc288c6134)
This is a heavily adapted version of Allen's commit that did the
same.
Some gotchas:
* Because the unread count indicator is not in the message content,
we can't center it in the middle of the message content (we'd
need to put it inside the div to do so).
* Awesome Gecko bug surrounding tables makes this also somewhat
annoying, so watch out for this if you're making changes here.
> In Gecko, if you have a positioned <table> element inside a
> positioned block element, such as a <div>, a position: absolute;
> styled element inside the table would be positioned relative to the
> outer <div> rather than the table, which is the nearest positioned
> ancestor. This is a bug, and has not been fixed.
(imported from commit 45c00c37f3721c211331b228e84d46283e1cc9ba)
We already had provisions for the common case, but this code fixes
the situation where the user explicitly types topic:foo stream:yo.
(imported from commit 4dfa4cc8337acd4f0daed25a5b82a556804b3c18)
Before this fix, if you used the "Narrow to stream foo bar" suggestion,
it would search for "bar" within stream foo. Now it goes to the "foo bar"
stream.
(imported from commit 0be5f259842c119936d678a292a1a79af58defa2)
If you have smartSpaceBar turned on and hit space, the code
now calls lookup(), so that the app code can reload new
suggestions.
(imported from commit 6776babba0a2c9b8a954a4640aa7b81a970ed88e)
Tim Abbott
Waseem Daher
Steve Howell
Kevin Mehall
Jessica McKellar
Scott Feeney
Jeff Arnold
Leo Franchi