ba228b75b1
zilencer: Use Realm.string_id for get_deployment_from_domain.
...
This is dead code. Getting rid of realm__domain since we're about to remove
that field from Realm.
2017-03-14 17:17:42 -07:00
8fecd454aa
forms.py: Remove unused function get_registration_string(domain).
2017-03-14 17:17:42 -07:00
ddd0b854f9
Remove references to page_params.domain.
...
Continuation of 098797c
2017-03-14 17:17:42 -07:00
e7b3ea8fab
coverage: Require 100% coverage in analytics.
2017-03-14 17:11:25 -07:00
85fe53f5e3
coverage: Don't require test coverage for __unicode__ methods.
...
These are usually just used for manual debugging, and so aren't super
important to make sure we have tests for always.
2017-03-14 17:07:18 -07:00
7c6f0033ed
analytics: Add test for do_drop_all_analytics_tables.
2017-03-14 16:59:54 -07:00
87981a2bf1
analytics: Fix direct import of models in migrations.
2017-03-14 16:59:54 -07:00
ebebd04587
analytics: Fix ValueErrors affecting test coverage.
...
Pathways that only catch internal code errors should use AssertionError so
that they are not included when computing test coverage.
2017-03-14 16:59:54 -07:00
b18bfe6771
analytics: Standardize format of zerver count queries.
...
count_message_type_by_user_query is in a different format (no WHERE clause)
from the rest since I'm having a hard time reasoning about how that would
interact with the LEFT JOIN, especially given that there are %(join_args)s.
2017-03-14 16:59:54 -07:00
e33ef1c788
analytics/models: Remove extended_id and key_model.
...
They are unused / were part of a previous design.
2017-03-14 16:59:54 -07:00
b648c06009
hotkeys/refactor: Extract tab key handlers.
...
This extracts process_tab_key() and process_shift_tab_key().
It also removes some dead code related to alert words tabbing.
2017-03-14 16:42:40 -07:00
bdbaa5d386
hotkeys: Simplify navigation checks for page up/down.
...
We remove an unnecessary conditional that always returned true
due to checks that happen earlier in the function.
2017-03-14 16:42:40 -07:00
58c057a024
node tests: Add test_motion_keys().
2017-03-14 16:42:40 -07:00
2a3e74427b
Export hotkey.tab_up_down() for testing.
2017-03-14 16:42:40 -07:00
7a804de485
user docs: Update *Send a private message*.
...
Add keyboard shortcut info to user doc. Fixes #156
2017-03-14 15:54:20 -07:00
d764f0e0f1
user docs: Update *Send a stream message*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
6deee116dc
user docs: Update *Enable or disable pressing enter to send*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
f510ada67a
templates: Add insert new line shortcut to *Keyboard shortcuts* modal.
2017-03-14 15:54:20 -07:00
87dd0c225a
keyboard_shortcuts: Move @ near more similar keys.
2017-03-14 15:54:03 -07:00
8a408a6cbc
popovers: Fix actions popover menu positioning.
...
The main issue is that it wasn't doing the correct comparison; the old
logic that subtracted the viewport.scrollTop() was incorrect for how
our popovers seem to work.
Partially fixes #3741 .
2017-03-14 15:37:37 -07:00
e3fa42f833
edit: Hide emoji reactions when in message edit or view source mode.
...
This also entails displaying them when the editing mode ends.
Fixes #3870 .
2017-03-14 14:55:16 -07:00
dd52291fa5
linter: Add support for automatic checking for 4 space indents in HTML.
2017-03-14 14:50:16 -07:00
11c7bb49d4
Restyle "invite" modal.
...
This restyles the invite modal to have the same header as the rest of
the overlays.
2017-03-14 14:47:12 -07:00
4c4208ac86
Make all modal exit "x" sizes uniform.
...
This makes all exit “x”’s uniformly 1.5rem in size and font-weight: 600.
2017-03-14 14:47:12 -07:00
b0e2c4ffee
settings: refactor code to hide "Email Change" button.
...
Previously, the code to hide "Change email" button on page load when
email changes are disabled was present in settings.js using jquery to
hide the button. Now, the show/hide is handled in the account-settings handlebars.
2017-03-14 14:43:35 -07:00
1b2cbb0b85
casper: Fix incorrect wait condition for realm icons.
...
This wait condition was correct for uploading, but not for deleting.
2017-03-14 14:40:52 -07:00
1c2f82f7fd
help: Remove now-unnecessary warning about old messages.
2017-03-14 14:10:08 -07:00
d21f446083
help: Add user docs for "Prevent change of name" settings.
2017-03-14 14:10:08 -07:00
ef7e15ee00
admin: Add realm option to prevent users from changing their name.
...
A realm option to prevent users from changing their name is added.
Fixes #3950 .
2017-03-14 14:10:08 -07:00
dc48b87765
home.py: Fix bug associated with email_changes_disabled.
...
On reloading the page after disabling email changes does not check
the "Prevent users from changing their email address".
Adding realm_email_changes_disabled to page_params_core_fields fixes the problem.
2017-03-14 14:10:08 -07:00
c921736db2
contrib bots: Better error handling response in thesaurus.
2017-03-14 13:29:19 -07:00
36bbad3c14
contrib bots: john bot can reply back in the same chat.
...
No need to create an extra "VirtualHelp" stream.
2017-03-14 13:29:19 -07:00
d90906c521
contrib bots: Edit code for uniformity.
...
Add one function (get_bot_botname_response()) that generates response
from the given input and replies back to the handle_message with the final
content of response to be sent. Also add code to bots(except followup) to
reply to private messages along with stream messages.
2017-03-14 13:29:19 -07:00
57d026f4c9
contrib bots: Rename bots to follow a consistent pattern.
...
Files renamed with few changes to accomodate the change in
path name of files. Fix few "at-mention bot" errors in docs.
2017-03-14 13:29:19 -07:00
6e28bc20c6
contrib bots: Rename bots to follow a consistent pattern.
...
Files renamed without any changes.
2017-03-14 13:29:19 -07:00
1a23b218e0
contrib-bots: Update .gitignore to ignore database file.
2017-03-14 13:29:19 -07:00
f066e3e8d6
git integrations: Change the limit of shown commits from 10 to 20.
2017-03-14 13:24:45 -07:00
cdb07c7005
Fix test_get_old_messages_with_narrow_pm_with.
...
Fixes #3940 .
2017-03-14 09:38:24 -07:00
7b1742fdef
send_message: Allow message to be sent to a huddle.
2017-03-14 09:35:08 -07:00
1e5ec689b7
tools/css: Trim whitespace around CSS values.
2017-03-14 09:29:56 -07:00
2ffea94bd8
tools/css: Require semicolons after CSS declarations.
2017-03-14 09:29:56 -07:00
a1d7e1b5f6
css: Tweak padding around code blocks to look nicer.
...
It makes sense to a bit tighter padding around code blocks in a chat context.
2017-03-13 22:35:00 -07:00
a9db9eb389
css: Improve code block styling.
...
Change pygments for prettier syntax highlighting with white
backgrounds for both inline and multi-line code blocks.
2017-03-13 22:34:11 -07:00
c6cf025ee9
node_tests/dispatch.js: Stub blueslip module.
...
Stub the blueslip module to print a nicely formatted traceback.
Earlier the traceback used to be only a `ReferenceError` because
blueslip was not stubbed.
Fixes : #4021 .
2017-03-13 22:20:59 -07:00
b13b660709
zerver: Replace log_event with RealmAuditLog in do_change_user_email.
...
This replaces the ancient file logging approach for the auditable
password change event with the database audit log.
2017-03-13 22:08:12 -07:00
fc35982b87
zerver: Replace log_event with RealmAuditLog in do_change_password.
...
This replaces the ancient file logging approach for the auditable
password change event with the database audit log.
2017-03-13 22:07:14 -07:00
dae5366949
tests: Raise zerver/views/registration.py test coverage.
2017-03-13 21:59:04 -07:00
11ad666397
tests: Fix docstring for test_signup_invalid_name.
2017-03-13 21:59:04 -07:00
a1b5f91c1a
hotkeys: Remove wasteful resize calls for keydown events.
...
This fix prevents us from calling the resize library for nearly
every single keydown event in the app (ouch!). Realistically,
this performance improvement only impacts folks who turned on
the autoscroll_forever feature, but it should be a significant
speed-up for them. We should go further with this fix, but the
main damage is undone.
2017-03-13 21:38:23 -07:00
c88c69db2e
bug fixes: Clean up hotkey mappings.
...
We simplify hotkey mappings by using different hashes for
keydown and keypress events. There are browser bugs (iOS, for
example) where keypress events have the wrong keyCode values.
This led us, under iOS, to interpret "!" as "page up."
This fix also helps us disinguish escape from shift-escape.
Brock Whittaker helped on figuring out the keypress/keydown
issues that are addressed in this commit.
Fixes #4019
2017-03-13 21:38:23 -07:00
Rishi Gupta
Tim Abbott
Steve Howell
Cynthia Lin
Abhishek Bhattacharya
Philip Skomorokhov
adnrs96
Brock Whittaker
Raghav Jajodia
Abhijeet Kaur
wizsid11
Umair Khan
Harshit Bansal
Maxim Averin
Elliott Jin