b57289aacd
py3: Remove all `from __future__ import print_function.
...
Except for these files:
- tools/linter_lib/*
- tools/lib
- tools/lister.py
2017-10-18 12:07:19 -07:00
02f50680cf
test_messages.py: Switch misordered send_message parameters.
2017-10-18 11:55:11 -07:00
9090d6b12f
streams: Re-render subscriber list on sub/unsub.
...
This re-renders the subscriber list on sub/unsub as long as that is the
current active stream settings.
Fixes : #6955 .
2017-10-18 11:45:07 -07:00
586369296c
/subs/: Refactor to create a "get_safe_hash" method.
...
This returns a string always, checks if the “location” variable exists
inside of window, and will trim the first character (“#”) on hashes.
2017-10-18 11:45:07 -07:00
a93bedc8e6
streams: Re-highlight row after re-subscribing.
...
When re-subscribing by way of the "Subscribe" button in the right
side settings panel, the row will now be marked as active to
highlight that the row is still selected and being looked at.
Fixes : #6955 .
2017-10-18 11:45:07 -07:00
c8090aafa4
lint: Remove several unused imports.
2017-10-18 10:56:11 -07:00
fe3a8084d8
mypy: Fix annotations for linter.
2017-10-18 10:50:25 -07:00
2bc14d256f
lint: Ban two spaces after comma in JS code.
...
We exclude the frontend tests, mostly because the lint rule isn't that
precise, and the test code has some sample user input that's a bit
funny.
2017-10-18 10:22:18 -07:00
8afe9835f6
lint: Ban two spaces after comma in prose.
2017-10-18 10:12:41 -07:00
b634d9f38b
lint: Ban two spaces after comma in CSS.
2017-10-18 10:11:33 -07:00
194e102077
linter: Add rule against multiple whitespaces after comma.
2017-10-18 10:04:23 -07:00
cfadb43b93
codebase: Remove multiple whitespaces after comma.
2017-10-18 10:04:23 -07:00
cc8cc8d9ae
travis: Work around broken riak repository in Travis base image.
...
This is a work around for
https://github.com/travis-ci/travis-ci/issues/8607 .
2017-10-18 09:44:09 -07:00
a967ac5fa7
docs: Simplify install instruction for production environment.
2017-10-18 09:21:16 -07:00
51c5fec0e4
embedded bots: Add BotUserStateData model.
2017-10-18 09:15:53 -07:00
f998550fb4
reactions: Add missing mypy import for Message.
2017-10-18 08:59:29 -07:00
05b9316d5f
i18n: Fix missing translation tags on deactivated notice.
2017-10-18 00:09:11 -07:00
4f088292ee
popovers: Hide user email and PM feature for deactivated users.
...
This hides the emails of deactivated users from the popovers along
with the link to send a PM to them.
2017-10-18 00:06:12 -07:00
773f8fcb05
stream_events: Fix exceptions when subscribed by another client.
...
We were getting several exceptions in mark_subscribed if the streams
overlay wasn't open, basically because we'd try to filter the
right-side stream list when it wasn't present in the DOM.
2017-10-17 23:42:29 -07:00
691598a88b
py3: Remove "from six.moves import range".
...
This is no longer required, since in Python 3, this is what the range
built-in does.
2017-10-17 23:28:14 -07:00
2f3ae84e5a
py3: Remove all `__future__ import division`.
2017-10-17 23:09:12 -07:00
b2ad8fd747
py3: Remove all `from __future__ import unicode_literals`.
...
This was mostly used in migrations, so it's a pretty safe change.
2017-10-17 23:07:42 -07:00
a603a4f9f5
Remove `from __future__ import absolute_import`.
...
Except in:
- docs/writing-bots-guide.md, because bots are supposed to be Python 2
compatible
- puppet/zulip_ops/files/zulip-ec2-configure-interfaces, because this
script is still on python2.7
- tools/lint
- tools/linter_lib
- tools/lister.py
For the latter two, because they might be yanked away to a separate repo
for general use with other FLOSS projects.
2017-10-17 22:59:42 -07:00
64cd0c2c5a
notifications: Add failing test for push notifications on muted topics.
...
This is some pre-work as part of #7059 .
2017-10-17 22:49:33 -07:00
024c27dd3e
notifications: Fix sending push notifications on muted streams.
...
Apparently, the stream muting feature did not take priority over the
stream_push_notify feature. This fixes that gap.
Fixes zulip/zulip-mobile#1314 .
2017-10-17 22:38:54 -07:00
31ce96ff2a
views/reactions.py: Extract `create_historical_message()` function.
2017-10-17 22:24:34 -07:00
bcca964548
test-js-with-node: Fix doing too many imports before sanity_check.
...
This wasn't benefitting from the nice error message.
2017-10-17 22:22:00 -07:00
9c5e0971f4
sanity_check: Check a few packages.
...
This just makes our check for whether we're actually in a Zulip
development environment better.
2017-10-17 22:21:33 -07:00
88325c7e85
docs: Simplify discussion of sha256sums.
2017-10-17 22:16:37 -07:00
dceaa1d19a
Add sha256sum integrity check to the release tarball.
...
This stems from the discussion at
https://chat.zulip.org/#narrow/stream/general/topic/signing.20the.20release
2017-10-17 22:15:14 -07:00
c13d2cb00a
user docs: Update create-a-stream to point to the org guide on streams.
...
Also cleans up the intro a bit.
2017-10-17 22:13:29 -07:00
d37820f39f
tests: Fix test_message_edit_notifications.
...
This was broken in a minor way by my fix to #7031 .
2017-10-17 22:12:32 -07:00
1d503ad60c
urls: Move the API URLs above the random other endpoints.
...
This should make it a lot easier for folks to find the Zulip API when
reading our urls.py file.
2017-10-17 22:09:22 -07:00
5515a075ec
urls: Move the report endpoints to be API-style routes.
2017-10-17 22:05:56 -07:00
9234abbd59
notifications: Fix realm emojis not appearing in desktop notifications.
2017-10-17 22:03:33 -07:00
513b6d624f
notifications: Fix double-sending in missedmessage_hook.
...
While the missedmessage_hook logic originally did a reasonably good
job of avoiding double-sending notifications, there was a corner case
it didn't handle, namely a user who had been presence-idle when a
message was sent and became also event-queue-idle as well within the
next 10 minutes. For those users, they got a notification at message
send time, and the missedmessage_hook would deliver it a second time.
We fix this by just checking the conveniently available push_notified
and email_notified variables that indicate whether the message already
had a notification triggered.
Fixes #7031 .
2017-10-17 21:54:03 -07:00
2648d595c1
Revert "docs: Fix broken anchor links in troubleshooting guide."
...
This reverts commit fa71f64adb
2017-10-17 21:37:26 -07:00
1da3c400e3
realm import: Convert the authentication_methods from list to bitfield.
...
This properly reflects how this is stored in the DB.
Tweaked by tabbott to use a proper function.
2017-10-17 21:32:20 -07:00
508686bed4
provision: Fix buggy bash_profile management code.
...
Apparently, the previous version would just append to .bash_profile
every single time :(.
2017-10-17 21:22:32 -07:00
3fed995a41
provision_version: Move to under UUID_VAR_PATH.
2017-10-17 21:15:58 -07:00
3983ebce9a
test_fixtures: Move test_db_status state under UUID_VAR_PATH.
...
This should mean that maintaining two Zulip development environments
using the same Git checkout no longer has caching problems keeping
track of the migration status.
2017-10-17 21:15:58 -07:00
b7c3b4df0c
migration_status: Switch to passing the path in Python.
...
This is an important prerequisite to changing these paths used in
provisioning.
2017-10-17 21:15:58 -07:00
a7c639cff7
provision: Use UUID in path to compilemessages hash.
2017-10-17 21:15:58 -07:00
2ae2a94444
provision: Stop using shared var/ for caching apt state.
...
This didn't work at all when one did a `vagrant destroy` and then
`vagrant up`, because the cache state would be preserved even though
the machine is gone.
Fixes #5981 .
2017-10-17 21:15:58 -07:00
c69c38b14e
export: Fix importing/exporting of user avatars.
...
We apparently failed to update the export code for handling what
directories avatar files should live in during the earlier process.
Fixes #7052 .
2017-10-17 21:15:58 -07:00
15c0380a33
export: Fix exporting with an output file at a relative path.
...
Fixes #7051 .
2017-10-17 20:47:29 -07:00
fa71f64adb
docs: Fix broken anchor links in troubleshooting guide.
...
Fixes #7056 .
2017-10-17 20:38:59 -07:00
c77c2f084c
upgrade-zulip-from-git: Fix rerun script and script description.
2017-10-18 04:41:22 +02:00
5a77a4d122
Inline muting_ui.mute_topic and unmute_topic.
...
These methods were only called by similarly named methods, so
it was kind of a confusing API, and they didn't really
encapsulate anything useful.
2017-10-17 17:41:21 -07:00
dea1888022
Fix muting_ui.persist_and_rerender() bug.
...
We were calling muting_ui.persist_and_rerender(), but
that function no longer exists. Now we use the simpler
API.
2017-10-17 17:41:21 -07:00
rht
derAnfaenger
Brock Whittaker
Tim Abbott
Harshit Bansal
Rishi Gupta
Alena Volkova
Steve Howell