This change also adds comments to make it clear what the function does
and why it's used.
(imported from commit 68382abaf2d7c41c7de7d92cbf6e7583003aaf2a)
When you return to Home, we normally restore your last
position when in Home, which might have been before the
first unread message. This is cumbersome for sidebar readers,
so now we keep track of messages that you visit while on a
tour away from Home, and when you return Home, we skip forward
any messages that were in the tour, landing on the last visited
message. This all happens before rendering.
(imported from commit 9124a231d94f153e283e5ea95e40c50a58406275)
The goal here is to make it so that we can do other stuff with
the range of messages between two subsequent selections, besides
marking them as read.
(imported from commit f6eb07844fb2ccda195c9d4dfcdf1c15f3f40aff)
When hover over a typeahead menu item, the semantics have always been
to make it active, and now we also respect the naturalSearch option
there, which will set the text of the search box to the suggestion
immediately upon hover.
(imported from commit 02318d3d830e7e28d638efee0ef27023a73f52f7)
See https://github.com/twitter/bootstrap/issues/7392. I seem to
have fixed it with just the CSS part of their suggested patch.
To repro the bug prior to this fix, enter search, hover over a
typeahead, and then hit the up arrow key. You'll see two items
appear to be selected.
(imported from commit 383d60a606d7c19344a326208312a1555d060877)
This commit broke unread dots, since they're in the .messagebox
but absolutely positioned outside of it (so they got clipped.)
This reverts commit e0071851d2dc7d99c9acd93a1fc6fa1ce0c3b70e.
(imported from commit b3181b3a02cef905cc8f400f8c1cc3c92b5f0e15)
The total duration of this animation is the exact same, but
it starts immediately - let's see if this feels any better.
(imported from commit de86c259a25adb64514613579476480bdac29cb2)
There was some misguided code that eliminated the suggestion when
the user typed out the full topic, and since then there is more
generalized protection against duplicate suggestions.
(imported from commit 857e74458d10995170d312b77d99d839706ae680)
I'd encourage you all to review this diff thoroughly, since I am not
very familiar with this code. However, it seems to me that, prior to
this commit, if respond_to_cursor is true and page_params.staging is
true, compose.start gets called twice! (once by `respond_to_message`
and once by the "if (page_params.staging)" under the else, after it
returns.)
I eliminate the second call by sticking it inside the first else; now,
as far as I can tell, we call compose.start once and only once.
(imported from commit 319f51392541def358a138c104dd21722b4f8ba8)
Just before this is pushed to prod, we need to rename the Humbug feedback
bot in the database using:
./manage.py change_user_email feedback@humbughq.comfeedback@zulip.com
/etc/init.d/memcached restart
and we also need to update and restart feedback-bot in its deployed
location.
No action is required on pushing this to staging, but in between when
this is pushed to staging and when it is pushed to prod (and that
transition performed), feedback will not work on staging.
(imported from commit 73fc36f680b978f3aebae5df1822918ae4d4e952)
Before we'd autocomplete d to [stream:design, stream:devel].
Now we also autocomplete stream:d to [stream:design, stream:devel].
(imported from commit d7ecbd032a3414828bf649698d741f0d6a6e3af2)
This helps mitigate the damage caused by hilarious vertical
names like "Puerco (((((())))))" with the vertical parentheses.
(imported from commit e0071851d2dc7d99c9acd93a1fc6fa1ce0c3b70e)
Created up, down, page_up, page_down, to_home, and to_home pretty
mechanically from the old hotkey.code.
(imported from commit 5956b91c2e0122c6440f70db9b92f918c9b599aa)
That commit intended to fix a bug where it jumps to the wrong scroll position
(offset by the difference in height from uncollapsed to collapsed) if you load
collapsed messages at the top, either by scrolling up or when it automatically
fetches more 10s after page load, because before, it updated the scroll
position before processing collapsing, which changes the height of messages.
Updating collapsing needs to happen before the viewport is adjusted, but also
needs to happen after the new messages get appended/prepended to the document
because they need to be attached to the document for getClientBoundingRect to
work.
(imported from commit 44d6a6135524e658084ffcf7d880ba898b577e6d)
We already have one for faded messages (which this commit simplifies),
but we also need one on unfaded messages to facilitate styling
experiments.
(imported from commit 41a6e2ef136ce73ce8c24de1e35199244ce56d37)
Trac #1540
* Make edit content box the same width as normal content
* Scroll to compensate for the added padding and "Topic" field.
* Restore the scroll position when exiting edit
It's off by 1px on Firefox 22, but Firefox is simply wrong.
(imported from commit 49154f51b538c648934a41a4a7a217198186ede2)
This will allow you to always get Home from the search box,
as well as easily backing out narrows.
(imported from commit 68bcfc83ce0428645f4e734ae46f9589cb562a86)
Until now, we would reset the search string when you aborted
a search, but only if you are in the home view. Now, we reset
it always. This makes the search box an accurate reflection of
your narrow.
(imported from commit bed6adce54a55648165c84118d430c44abb5949f)
The naturalSearch option immediately updates the search box with
the underlying value of a search suggestion when the user moves to
it.
(imported from commit ad5cb5c2591ef4f71a6d648c8839f288cc125cf7)
Scott Feeney
Steve Howell
Waseem Daher
Zev Benjamin
Waseem Daher
Tim Abbott
Kevin Mehall
Jessica McKellar
Jeff Arnold