Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
17,940 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

17940 Commits

Author SHA1 Message Date
rht a1f82e02d6 python: Replace os.system with subprocess.call. 
Generally, we avoid os.system, since it shells out and thus can be
a cause of security issues.
 2017-05-26 15:03:16 -07:00
Sarah bb329b4020 zerver/lib/events: Refactor using UserProfile prop_types and notifications 
Refactor fetch_initial_state_data to use the UserProfile.property_types
and notifications dictionaries.
 2017-05-26 14:55:54 -07:00
derAnfaenger 024101be6b bots: Add mypy annotations for bots framework. 
This commit adds mypy annotations for both the main
bots and the bots testing runner. It involves a change
to the BotHandlerApi send_message and update_message
funtions, which is compatible with every bot.

Tweaked by tabbott to use more expressive annotations.
 2017-05-26 10:25:06 -07:00
Tim Abbott c12023840d contrib_bots: Fix python 3 lint errors. 2017-05-26 10:18:40 -07:00
Nathan Miller 2311e169ec mypy: Various strict-optional fixes in zerver. 2017-05-26 10:10:20 -07:00
Reid Barton 004ff1ae4d bots: Remove githook-post-receive link. 
Based on commits cdedb8593 and 58a8934a8 it seems to be unused.
 2017-05-25 18:05:35 -07:00
Tim Abbott f5373c46f2 lint: Fix trailing newlines in outgoing webhook tests. 2017-05-25 16:28:11 -07:00
Reid Barton 461856dd56 rss-bot: Add --unwrap, --math options. 
These are for processing arXiv API results.
 2017-05-25 16:24:07 -07:00
Tim Abbott 8e978df957 mypy: Fix missing import from recent mypy merge. 2017-05-25 16:22:19 -07:00
Pweaver (Paul Weaver) cb311e99d8 Change backend tests to use a webpack stats stub file. 2017-05-25 16:15:32 -07:00
Pweaver (Paul Weaver) de98dd127d Remove webpack dependency from tools/minify-js. 2017-05-25 16:15:32 -07:00
Pweaver (Paul Weaver) fb0d2d6a8e webpack: Move assets to a separate JSON file so we can process in python. 2017-05-25 16:15:32 -07:00
Mehanig 2d5097868a webpack: Skip compilation for minified 3rd party libs. 2017-05-25 16:15:32 -07:00
Jeremy Bowman 5436f872f7 Provide alt text for validation check mark 
The check mark which appears for valid input in assorted forms
(such as login and registration) didn't have alternative text
for better accessibility.  Added "Valid" as the alt text in all
places it's used.

Fixes #4876.
 2017-05-25 16:06:47 -07:00
Ethan d4d689532d mypy: serve_local return type to FileResponse. 2017-05-25 15:41:52 -07:00
Ethan d2e72b0082 mypy: correct process response type. 2017-05-25 15:41:51 -07:00
Ethan b6e7e36c86 mypy: correct from int to str in rate limiting. 2017-05-25 15:41:49 -07:00
Ethan d1bd19a1b8 mypy: correct user_passes_test first argument. 2017-05-25 15:41:48 -07:00
Ethan c284d913cc mypy: request.body is bytes, should be str. 2017-05-25 15:41:46 -07:00
Ethan 1477a9102d mypy: Fix return annotation; json_method_not_allowed. 2017-05-25 15:41:44 -07:00
Tim Abbott 944935dbe3 docs: Update Git tips blog post in reading list. 2017-05-25 15:29:37 -07:00
Elliott Jin 4907f24603 bots: Add additional service bot tests. 2017-05-25 15:00:51 -07:00
Elliott Jin af49a23013 bots: Generalize service bot tests to also test embedded bots. 2017-05-25 15:00:51 -07:00
Elliott Jin cd8c77bf91 bots: Clean up order and naming of service bot tests. 2017-05-25 15:00:51 -07:00
Elliott Jin 49adeee8c8 bots: Move service bot tests into separate file. 2017-05-25 15:00:51 -07:00
Elliott Jin 8b98b79646 bots: Generate queue events for embedded bots. 2017-05-25 15:00:51 -07:00
Elliott Jin 0ec9e54954 bots: Add queue and QueueProcessingWorker for embedded bots. 2017-05-25 15:00:51 -07:00
Elliott Jin f7b124145b bots: Add __init__.py so bot modules can be imported. 2017-05-25 15:00:51 -07:00
Elliott Jin d0c0031b0b bots: Add comments about embedded bots to Service model. 2017-05-25 15:00:51 -07:00
Elliott Jin 824b315284 bots: Introduce "service_bot" concept in UserProfile model. 2017-05-25 15:00:51 -07:00
Elliott Jin 120b7b4caf bots: Add bot_type for embedded bots in UserProfile model. 2017-05-25 15:00:51 -07:00
Tim Abbott 33c8488cf6 deps: Update PROVISION_VERSION for webpack upgrade. 2017-05-25 14:23:41 -07:00
Sarah e304c47970 settings_org: Split out separate forms for orgs settings/permissions/auth. 
Steve Howell also contributed to this PR.
 2017-05-25 14:18:04 -07:00
Jeremy Bowman 7053103896 Fix registration email field label association 
The label element for the registration form's email field was
missing a "for" attribute to link it to the input field.  Added
the missing attribute.

Fixes #4896.
 2017-05-25 13:36:27 -07:00
Reid Barton 96dff66743 katek: Make tex errors gray. 
Red is too visually loud for a medium where tex errors are not fatal
(readers will be still able to understand the tex source).
 2017-05-25 10:57:10 -07:00
Reid Barton f1eb8545b8 katex: Fix line height of inline math. 
24cbd6113 changed the line height of katex HTML to avoid overlapping
lines in wrapped math displays. But the change also applied to inline
math, resulting in large vertical gaps in a multi-line paragraph
containing inline math elements.
 2017-05-25 10:49:56 -07:00
Jeremy Bowman 64721abac3 Correctly associate bot name field label 
The label element for the bot name editing field was trying to use
a "for" attribute to link it to the input field, but the field had
no ID for it to associate with.  Added the ID value which it
was trying to use.

Fixes #4999.
 2017-05-25 10:46:01 -07:00
Yago González d7ecb252df node tests: Add tests for colorspace.js. 2017-05-25 10:09:39 -07:00
Yago González f25c16b573 node tests: Add coverage for get_all_bots_for_current_user. 2017-05-25 09:54:05 -07:00
Yago González 115b2f6b6b node tests: Fix indentation. 2017-05-25 09:54:05 -07:00
Elliott Jin 5b4d2832fc bots: Add management command for making outgoing webhook bot. 2017-05-25 09:45:54 -07:00
umkay 9ab0a8be6a mypy: Fix strict optional in zerver/views. 2017-05-25 09:30:41 -07:00
Yago González 55b4a3792d lint: Fix violation in the GitHub webhook view. 2017-05-24 22:09:14 -07:00
umkay f4617d0408 mypy: Fix a few webhook tests to work with strict-optional. 2017-05-24 20:31:21 -07:00
Reid Barton d7db7aa84f api-docs: Fix line break in API keys section. 2017-05-24 20:30:35 -07:00
Tim Abbott 47c8da28ff bots: Simplify automated testing library. 2017-05-24 20:13:25 -07:00
Tim Abbott 74ad90533d node: Fix missing bot_data initialization. 
This was making the frontend tests fail.
 2017-05-24 19:59:40 -07:00
derAnfaenger 4ec13d3693 bots: Simplify define bot test. 2017-05-24 19:44:22 -07:00
derAnfaenger c3c7874e3f bots: Fix unit tests not running in Vagrant. 
`test-bots` would not run in Vagrant, displaying
the error "ValueError: no such test method in <class
'bots_test_lib.BotTestCase'>: runTest" This was due to
the `BotTestCase` class inheriting from the TestCase
class, even though it was not a unit test on its own.

This commit removes the inheritance of TestCase and
specifies `test_define` as the `runTest` method in
`TestDefineBot`.
 2017-05-24 19:44:22 -07:00
Vishnu Ks bb98e35aa0 Replace othello@zulip.com with example_email('othello'). 2017-05-24 19:37:36 -07:00