a1ce1aca3b
queue: Update comment to be more accurate about import errors.
2020-10-09 20:40:32 -07:00
2d71ca1fb8
email: Remove unused `log_digest_event` function.
...
Its last callsite was removed in e46cbaffa2#6786 .
2020-10-08 20:35:53 -07:00
f0ae2a88f2
activity: Show server time rather than browser time.
...
This gets rid of an inline <script> that was blocking #16451 .
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-08 19:17:35 -07:00
264bf1fc2a
css: Hide bottom-right resizable box in view-source textarea.
2020-10-08 17:13:50 -07:00
adfe4cacc6
css: Add vertical scrollbar styling for view-source textarea.
...
This styles the vertical scrollbar similar to the horizontal
one for <pre/> (which can be seen in narrow windows). Strictly
speaking, this change shouldn't go in rendered_markdown.scss, but
placing it there helps unify the two scrollbar stylings rather than
duplicating them.
2020-10-08 17:13:50 -07:00
ab9a011f89
css: Modify button styling to adjust for svg size change.
...
This builds on the previous commit and adds final touches to
both the button positioning and style.
2020-10-08 17:13:50 -07:00
b0c37713e5
templates: Extract and tweak copy_to_clipboard_svg from both buttons.
...
Since both the original button svg's have their own individual height
and width, this commit tweaks it to values height=20 and width=16 which
works well for both buttons.
2020-10-08 17:13:50 -07:00
413df1881e
templates: Extract and tweak copy_message_button from message_edit_form.
...
Small tweak in the extracted text which adds aria-lable to the button.
2020-10-08 17:13:50 -07:00
792029cbb8
css: Refactor copy_message button to use copy_button_base class styling.
...
Z-index is added to the base class. This doesn't affect copy_code_button
in any way.
Attributes dropped/changed:
- background-color
- Base class on-hover property is now used.
- height, width, padding is now the base classes.
We can also remove the TODO now.
2020-10-08 17:13:50 -07:00
26ff6db751
css: Extract copy_button_base from copy_codeblock class.
...
The base class will contain common styling which is used by both
copy_codeblock and copy_message buttons. This sets us up nicely
for following commit(s) which aims to unify the two button styling.
2020-10-08 17:13:50 -07:00
4e8f5b5b31
streams: Change access_stream_for_delete_or_update to also return sub.
...
We modify access_stream_for_delete_or_update function to return
Subscription object also along with stream. This change will be
helpful in avoiding an extra query to get subscription object in
code for updating subscription role.
2020-10-08 17:07:30 -07:00
623fb63406
recent_topics: Go to topic if user clicks anywhere in topic col.
2020-10-08 17:05:06 -07:00
d3f4f64b0e
timerender: Extract func to calculate days_old from time.
2020-10-08 17:05:06 -07:00
c7d66421f9
sidebars: Fill search boxes to full width.
...
After our bootstrap upgrade, search boxes were not full width on
when sidebars acted as popovers on small widths.
2020-10-08 17:03:56 -07:00
8b419c93e4
message_send: Fix old guests being treated as full members.
...
For streams in which only full members are allowed to post,
we block guest users from posting there.
Guests users were blocked from posting to admin only streams
already. So now, guest users can only post to
STREAM_POST_POLICY_EVERYONE streams.
This is not a new feature but a bugfix which should have
happened when implementing full member stream policy / guest users.
2020-10-08 11:30:11 -07:00
6fe82620df
login: Fix alignment of error message in login form.
2020-10-07 16:18:54 -07:00
f81a5e87ed
run-dev: Wait for children to exit on Ctrl+C after killing them.
...
In addition to being generally more correct, this works around a bug
in Node.js that causes webpack-dev-server to corrupt the terminal
state when exiting as a background process.
https://github.com/nodejs/node/issues/35536
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:15:19 -07:00
1c7db528bd
test_server: Wait for run-dev after terminating it.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:15:19 -07:00
e1a3aa9c1a
deliver_scheduled_messages: Exit cleanly on Ctrl+C.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:15:19 -07:00
363374346c
management: Use signal.pause to sleep forever.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:15:19 -07:00
81d21068b5
eslint: Fix no-useless-concat.
...
https://eslint.org/docs/rules/no-useless-concat
And add some escaping to static/js/markdown.js while I’m here.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
043c34d944
eslint: Fix no-throw-literal.
...
https://eslint.org/docs/rules/no-throw-literal
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
5c8117a426
eslint: Fix no-implicit-coercion.
...
https://eslint.org/docs/rules/no-implicit-coercion
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
4fe06a141e
eslint: Enable eslint-plugin-unicorn.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
0042cf51c1
eslint: Fix unicorn/better-regex.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/better-regex.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
a37616e8c6
eslint: Fix unicorn/import-style.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/import-style.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
65f86274b2
eslint: Fix unicorn/prefer-dataset.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-dataset.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
e68595a3fc
eslint: Fix unicorn/no-reduce.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-reduce.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
24d4ab327c
eslint: Fix unicorn/prefer-negative-index.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-negative-index.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
62dfee4930
eslint: Fix unicorn/prefer-node-append and unicorn/prefer-node-remove.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-append.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-node-remove.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
8098acb63c
eslint: Fix unicorn/prefer-trim-start-end.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-trim-start-end.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
78ccb15d9e
eslint: Fix unicorn/no-zero-fractions.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-zero-fractions.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
0d4af4f8e7
eslint: Fix unicorn/prefer-type-error.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-type-error.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
e0b1daa96d
eslint: Fix unicorn/prefer-add-event-listener.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
2694f5caed
eslint: Fix unicorn/prefer-array-find.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-array-find.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
72cc78dfa3
js: Optimize out unnecessary jQuery filter calls.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
fd11c9c666
eslint: Fix unicorn/prefer-includes.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-includes.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
b178fc6069
eslint: Fix unicorn/prefer-set-has.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-set-has.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
de791b82b6
eslint: Fix unicorn/no-for-loop.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
73a14bee6f
eslint: Fix unicorn/escape-case and unicorn/no-hex-escape.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/escape-case.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-hex-escape.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
f92224c744
eslint: Fix unicorn/catch-error-name.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
d654992164
eslint: Fix unicorn/prefer-optional-catch-binding.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-optional-catch-binding.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
70a0260ac1
eslint: Fix unicorn/prefer-text-content.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
bd05f1c9f8
eslint: Fix unicorn/prefer-query-selector.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-query-selector.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
c7cbdba257
eslint: Fix unicorn/{new-for-builtins,throw-new-error,error-message}.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/new-for-builtins.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/throw-new-error.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/error-message.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
48f5e5179a
eslint: Fix unicorn/prefer-string-slice.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-string-slice.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
fb233bd994
eslint: Fix unicorn/prefer-number-properties.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md
MDN says these were added to Number for modularization of globals.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
9bfbb29763
queue_processors: Use try…finally to prevent leaking an alarm.
...
Otherwise, if consume_func raised an exception for any reason *other*
than the alarm being fired, the still-pending alarm would have fired
later at some arbitrary point in the calling code.
We need two try…finally blocks in case the signal arrives just before
signal.alarm(0).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 15:37:46 -07:00
52c411df8a
emoji: Add padding around the gif on GIF emoji upload.
...
Replaced ImageOps.fit by ImageOps.pad, in zerver/lib/upload.py, which
returns a sized and padded version of the image, expanded to fill the
requested aspect ratio and size.
Fixes part of #16370 .
2020-10-06 17:28:02 -07:00
150d782d6b
production-verify: Fix puppet path.
2020-10-06 17:26:14 -07:00
Alex Vandiver
Anders Kaseorg
Sumanth V Rao
sahil839
Aman Agrawal
akshatdalton