Harshit Bansal
8e41bbe2b0
node_cache.py: Modify `generate_sha1sum_node_modules()`.
...
Modify `generate_sha1sum_node_modules()` such that it can calculate
the hash for a particular installation.
Tweaked by tabbott to use os.path.realpath in the setup_dir
calculation, to ensure it's consistent.
2017-08-27 17:51:24 -07:00
Harshit Bansal
8aadbc258d
clean-venv-cache: Don't remove the currently active cache in dev.
...
In dev always include the currently active cache in order not to break
current installation in case dependencies are updated with bumping the
provision version.
2017-08-27 17:51:24 -07:00
Harshit Bansal
5e2b54446f
clean-venv-cache: Directly import functions from 'hash_reqs.py'.
...
Instead of running the 'hash_reqs.py' as a script, directly import
functions from it to calculate the hash. This will speed up the
script.
2017-08-27 17:51:24 -07:00
Harshit Bansal
ecbc75e00f
clean-venv-cache: Migrate to use `purge_unused_caches()` function.
2017-08-27 17:51:23 -07:00
Harshit Bansal
36420ab636
zulip_tools.py: Add `purge_caches()` function.
...
This function can be used for purging unused cache directories.
2017-08-27 17:37:08 -07:00
Tim Abbott
5d974b7f57
emoji: Remove :s from emoji popover title attributes.
2017-08-27 17:34:44 -07:00
Harshit Bansal
90d8b0f520
emoji_picker: Fix the two different titles appearing for each emoji.
...
Fixes : #6286 .
2017-08-27 17:22:44 -07:00
Harshit Bansal
923fb7be16
emoji: Fix mis-alignment of realm emoji div with other div in emoji picker.
...
Tweaked by tabbott to fix the CSS to not break the emoji typeahead.
Fixes : #5229 .
2017-08-27 17:21:08 -07:00
Tim Abbott
36fa6fe548
css: Remove duplicate emoji height CSS.
2017-08-27 17:20:37 -07:00
Tim Abbott
e68de7ac8d
user popover: Don't throw an exception for deactivated target users.
...
Ideally, we'd fix this at the root cause, via #4322 , but this will at
least suppress the exception for now.
2017-08-27 16:41:28 -07:00
Tim Abbott
3e1bf86ced
hotkey: Make enter checks more strict.
...
This should hopefully fix an obscure traceback we were seeing.
2017-08-27 16:35:17 -07:00
Tim Abbott
478f691792
settings: Remove useless map_initialized.
2017-08-27 16:35:17 -07:00
Tim Abbott
70e16da81c
decorator: Fix request.user handling of remote servers.
...
The refactor in b46af40bd3
didn't
correctly translate the code for managing request.user and
request._email, resulting in requests for the push notification
bouncer being rejected with this exception:
AttributeError: 'AnonymousUser' object has no attribute 'rate_limits'
2017-08-27 16:35:17 -07:00
Tim Abbott
a1885c6ffb
message_edit: Add debug logging for missing messages.
...
This is an attempt to more easily debug a traceback we've seen a few
times. The issue likely has to do with local echo, which would be
confirmed if this reports a local-echo-style message ID.
2017-08-27 16:11:42 -07:00
Tim Abbott
90012f8109
find_add_class: Don't check frontend tests.
2017-08-27 14:04:46 -07:00
Tim Abbott
ce1a8bf5b2
find_add_class: Include full path names in error messages.
2017-08-27 14:04:46 -07:00
Tim Abbott
b1d98c1d0f
lint: Only run find_add_class when JS files change.
2017-08-27 13:51:06 -07:00
Tim Abbott
79ae262463
lint: Only run check-urls after python files change.
2017-08-27 13:51:06 -07:00
Robert Hönig
3f01907d3b
travis: Distribute linting over frontend and backend suites.
2017-08-27 13:51:06 -07:00
Robert Hönig
c5da0ada31
linter: Replace --pep8 with new --frontend/--backend options.
...
Adds the --frontend and --backend options to replace
--pep8.
Significantly modified by tabbott to use a cleaner framework.
2017-08-27 13:50:53 -07:00
Robert Hönig
2186d53cf5
linter: Migrate lint from optparse to argparse.
2017-08-27 13:18:55 -07:00
Preston Hansen
5a501784f2
digest emails: Add unit tests for digest email management.
...
Fixes #6266 .
2017-08-27 13:10:14 -07:00
Vishnu Ks
8fc8ac0799
management: Override CommandError to mention --entire-server argument.
2017-08-27 12:34:23 -07:00
Vishnu Ks
dc63f838d7
backend-tests: Add tests for get_users with all-users argument enabled.
2017-08-27 12:34:23 -07:00
Vishnu Ks
23b63238c4
management: Handle the invalid user arguments cases separately.
2017-08-27 12:34:23 -07:00
Harshit Bansal
cd2f41dbb1
popovers: Extend the `compute_placement()` function.
...
This commit extends the `compute_placement()` function in
`popovers.js` to take into account height/width of popover as well as
positioning preference. If vertical positioning is desired and the
popover fits in either 'top/bottom' positions then we don't check for
`left/right' positions. Earlier the behavior was to prefer
'left/right'positions over 'top/bottom' positions, which resulted in
the emoji picker popping incorrectly to the left.
2017-08-27 12:27:53 -07:00
Harshit Bansal
f24582576a
emoji_picker: Further improve emoji picker navigation.
...
This further improves the emoji picker by introducing two new behaviors:
1: If the cursor is at the end of the input box then pressing `right_arrow`
moves the focus down into `emoji_catalog.
2: If the currently focused emoji is the first emoji in the `emoji_catalog`
then pressing `left_arrow` moves focus back to search filter.
2017-08-27 12:04:10 -07:00
Tim Abbott
1560646144
renumber-migrations: Fix construction of new number.
2017-08-27 12:01:06 -07:00
Tim Abbott
96dcb8f745
renumber-migrations: Fix unnecessary prompt.
...
The tool already knows the answer anyway.
Fixes #6157 .
2017-08-27 12:01:06 -07:00
Sarah
e280a5f8e8
docs: Update new feature tutorial.
...
Update new feature tutorial to describe recent changes
to the backend and front end processes based on
refactoring.
2017-08-27 11:37:43 -07:00
Aditya Bansal
b232563e12
soft-deactivation: Add cron job for weekly soft deactivating users.
2017-08-27 11:33:06 -07:00
Aditya Bansal
9d7e23c100
softdeactivation/management: Make specifying realm an optional arg.
2017-08-27 11:33:06 -07:00
Tim Abbott
ed31a5988c
models: fix badly line-wrapped type annotation.
...
Fixes #6290 .
2017-08-27 11:27:07 -07:00
Preston Hansen
e8a608f733
management: Move enqueue_digest_email handler to digest.
2017-08-27 10:13:11 -07:00
Preston Hansen
9a4b17cf9b
management: Move queue_digest_recipient to digest.
2017-08-27 10:13:11 -07:00
Preston Hansen
2aabf4fc67
management: Move should_process_digest to digest.
2017-08-27 10:13:11 -07:00
Preston Hansen
25a40806df
management: Move inactive_since to digest.
2017-08-27 10:13:11 -07:00
Tim Abbott
f1648af607
migrations: Update UserMessage model for is_me_message removal.
...
And while we're at it, document the related migration we need to do.
2017-08-27 10:11:43 -07:00
Tim Abbott
8c5525c5c6
requirements: Upgrade versions of Zulip API libraries.
2017-08-27 10:05:45 -07:00
Tim Abbott
1c8c5cc36f
test_messages: Fix deactivation tests for new /me behavior.
2017-08-27 09:58:02 -07:00
Tim Abbott
eb4635804f
compose: Fix previews of /me messages.
...
Previously, we didn't do anything special when previewing /me messages.
Fixes #2115 .
2017-08-27 09:48:27 -07:00
Tim Abbott
e80f93dc42
markdown: Set is_me_message in apply_markdown.
...
This should make the variable available to things like drafts and
previews.
2017-08-27 09:34:24 -07:00
Tim Abbott
133f005530
markdown: Remove is_me_message UserMessage flags.
...
This never made sense to be a flag on the UserMessage table, since
it's not per-user state. And in fact it doesn't need to be in a
database at all, since it's easily computed from content anyway.
Fixes #1099 .
2017-08-27 09:34:24 -07:00
Tim Abbott
0f1768d0d1
compose: Fix confusing variable name in preview code path.
...
This seems to be the root cause of the bug fixed in the last commit.
2017-08-27 09:34:06 -07:00
Tim Abbott
eb6d736df3
compose: Fix local rendering of previews.
...
Apparently, local rendering of previews had broken sometime in the
last few months in a refactoring that resulted in us passing a string,
rather than an object, into markdown.js.
2017-08-27 09:33:52 -07:00
Tim Abbott
e5da9966c2
bugdown: Remove now-unnecessary short_names.
...
This field hasn't been used since we removed the related mention
syntax.
2017-08-27 08:45:02 -07:00
Tim Abbott
92efe94a27
tests: Remove unnecessary apns mock.
2017-08-26 15:00:08 -07:00
Tim Abbott
f0637cb01a
push_notifications: Fix one last lint error.
2017-08-26 14:34:17 -07:00
Tim Abbott
00036ac8db
push_notifications: Fix mypy error.
2017-08-26 14:33:43 -07:00
Rishi Gupta
1215757217
send_email: Remove confusing comment.
2017-08-26 14:24:32 -07:00