Commit Graph

20714 Commits

Author SHA1 Message Date
Steve Howell 97c5f085e7 minor: Extract locals in do_send_messages().
This is a prepartory commit for another refactoring.
2017-09-07 06:59:44 -07:00
Steve Howell 981f557422 Extract receiver_is_off_zulip().
We are splitting out this logic from the more complicated
UserPresence-related logic, so that we can simplify the latter.
2017-09-07 06:59:44 -07:00
Steve Howell 776bdc59db Avoid unnecessary steps in process_message_event().
There is no reason to compute receiver_is_idle() unless a user
is actually PM'ed or mentioned.
2017-09-07 06:59:44 -07:00
Tommy Ip b2fe5c6005 Remove duplicate field in .eslintrc.json.
'narrow_state' is already present in line 107.
2017-09-07 06:30:09 -07:00
Robert Hönig 34e3329919 linter: Add rule against misspelled "Terms of Service". 2017-09-07 06:29:33 -07:00
Greg Price 0986fe700d i18n: Keep markup out of a translated string where we easily can.
Use jQuery DOM construction methods, rather than string concatenation,
to keep things structured and to stay clear of the lint rules introduced
in ee6235d71.
2017-09-07 13:00:54 +09:00
Steve Howell 99f4d420a5 Reduce the font size for search.
Until we get search bubbles, the search text is kind of a
distracting detail for most users.  This just makes the
height 2px smaller for now.  This will also make more text
show up on mobile web.
2017-09-06 18:49:54 -07:00
Steve Howell 8e2d9b8f68 Make recipient bar styling more compact and clean. 2017-09-06 18:49:54 -07:00
Steve Howell ad52ef27ee Make tab styling more compact and clean. 2017-09-06 18:49:54 -07:00
Umair Khan bd43c447c3 travis: Log the Python version.
This allows us to ascertain the Python version under which we ran the
tests.
2017-09-06 13:48:50 -07:00
Umair Khan a27eda1994 travis: Run backend tests in Python 3.5. 2017-09-06 13:48:50 -07:00
Umair Khan c039f73656 setup_venv: Link to the correct Python interpreter.
Travis enables different Python versions through virtual environments,
but it seems that there is a little caveat when we try to create Zulip's
virtual environment by referring Travis' virtual environment; Zulip's
virtual environment refers the system Python. We encountered this
behaviour when we tried to run our backend test suite under Python 3.5
in Travis. 'python3 --version' command before activating Zulip's
virtualenv showed 'Python 3.5.3' and after it showed 'Python 3.4.3'.
This happened when we created the virtual environment using
'virtualenv -p python3'.

The solution seems to be to explicitly give the path of the Python
interpreter in the Travis' virtual environment using 'which python3'.
2017-09-06 13:48:50 -07:00
Aditya Bansal d7f10bf3a1 profiling: Add snakeviz to dev tools.
This adds snakeviz to dev tools and also updates the message displayed
upon running `test-backend` with `--profile` option to say how to run
snakeviz correctly when using vagrant development environment.
2017-09-06 13:46:24 -07:00
Robert Hönig 910f04af29 bot settings: Properly hide bot_table_error. 2017-09-06 13:44:02 -07:00
Cynthia Lin 23e8582bfd message view: Change PM flag to match PM compose flag.
Fixes #6413
2017-09-06 10:12:13 -07:00
Robert Hönig 25742c1199 Capitalize s in Terms of service.
A few strings used `Terms of service`
instead of `Terms of Service`. This change
makes the latter form consistent over the repo.
2017-09-06 09:49:19 -07:00
Robert Hönig 6120841876 docs: Update bots_guide.md.
This include various small changes to adapt
this document to the latest repo changes.
2017-09-06 09:48:04 -07:00
Cynthia Lin ec36382857 settings: Prevent backdrop leak when clicking outside of modal.
Fixes #3791 and closes #3794
2017-09-06 09:35:16 -07:00
Cynthia Lin f697e6bb0e modals: Implement new modal methods. 2017-09-06 09:35:16 -07:00
Cynthia Lin aa21b2bce6 overlays: Create modal helper methods to manage display status. 2017-09-06 09:35:16 -07:00
Cynthia Lin 915419e089 templates: Add links to user docs for empty starred/mentioned msg feeds.
Fixes #6376
2017-09-06 09:13:33 -07:00
Shubham Dhama dc49f563eb message view: Fix line-wrapping of empty conversation/feed message. 2017-09-06 09:13:33 -07:00
Shubham Dhama 67abd9d1f7 message view: Center-align text of an empty conversation/feed message.
Fixes: #6150
2017-09-06 09:13:33 -07:00
Cynthia Lin 8bfc11bb98 hotkeys: Add uncondense/collapse/uncollapse message functionality.
Fixes #5914
2017-09-06 08:53:39 -07:00
Umair Khan f7d8db792c makemessages: Allow whitespaces after comma in i18n.
We allow such patterns:

```
i18n.t('Test __variable__',
        {variable: "script"})
```
2017-09-06 07:01:43 -07:00
Umair Khan ee6235d716 lint: Add regex to disallow i18n string concatenation.
Fixes #6398
2017-09-06 07:01:43 -07:00
Umair Khan d52760d2ef i18n: Don't span i18n strings on multiple lines.
If we use string concatenation to span i18n strings across multiple
lines then we end with such strings to be translated by the translators:

```
"This is the first line"\n + "This is the second line"
```
2017-09-06 07:01:43 -07:00
Umair Khan 95fe984de5 i18n: Do not concatenate i18n strings.
We should use variables in i18n strings to give proper context to the
translators. If the pattern is this:

```
i18n.t("Count " + count + " items")
```

Then it will be captured like this:

```
{"Count" + count + "items": ""}
```

Which is not good for the translators.
2017-09-06 07:01:43 -07:00
Greg Price 5045e53d63 i18n: Update Japanese translations.
This comes from, in the dev environment:
  ./manage.py makemessages -l en -l ja
  tx push -s -l ja
  tx pull -f -l ja --mode=developer

The makemessages and `tx push` provide Transifex with the updated set
of strings and metadata.  I'm not entirely sure why that's necessary,
but without it a lone `tx pull` left the server crashing with numerous
zerver.models.DoesNotExist exceptions.

(So to be precise, there was another `tx pull` at the start, just like
the final one.  That shouldn't matter for the result, though.)
2017-09-04 13:29:55 +09:00
Steve Howell 0721115c64 model: Remove user_profile.muted_topics.
(We now track muted topics in the MutedTopic model.
2017-09-02 09:19:51 -07:00
Steve Howell 4ac6bc46c7 Add MutedTopic model.
This commit completely switches us over to using a
dedicated model called MutedTopic to track which topics
a user has muted.

This includes the necessary migrations to create the
table and populate it from legacy data in UserProfile.

A subsequent commit will actually remove the old field
in UserProfile.
2017-09-02 09:19:51 -07:00
Brock Whittaker a3bdde3155 /hello/: Hide the last single row of testimonials.
This responsively hides the last row of testimonials that only has a
single one it the row at certain widths in which the grid is a [4, 4,
1] layout, making it simply [4, 4].
2017-09-02 07:48:44 -07:00
Brock Whittaker 72a7e00986 /hello/: Make gradients extend further on mobile.
This makes the gradients extend further on mobile so that the white
text does not display on an almost-white background.
2017-09-02 07:48:44 -07:00
Eeshan Garg 0d2bb41f91 requirements: Upgrade versions of Zulip API libraries. 2017-09-02 07:48:13 -07:00
Brock Whittaker d0128e052e landing-page: Remove underline from logo text on :hover.
This removes the underline on the logo text on :hover on the
product pages.
2017-08-31 18:53:54 -07:00
Brock Whittaker 0737f57ccf Remove question marks from FAQ.
This removes the question mark ::before element and then removes
the margin that pushed over the body text for the answer.
2017-08-30 16:04:30 -07:00
Brock Whittaker 47334aac6b Add /plans/ to the nav bar. 2017-08-30 16:04:30 -07:00
Brock Whittaker 0fb137cfce /help/: Remove unnecessary padding on mobile.
This removes padding that just becomes blank space that pushes the page
over on mobile.
2017-08-30 16:04:30 -07:00
Brock Whittaker c399543d4c Fix odd responsive issue between 720px - 768px.
Not sure what this margin was doing here but it appears to look better
not existing.
2017-08-30 16:04:30 -07:00
Brock Whittaker 4ad3f713db Fix copy with plan billing to be less confusing. 2017-08-30 16:04:30 -07:00
Brock Whittaker d7f5f31f6a Change the link to not have the default fade action. 2017-08-30 16:04:30 -07:00
Brock Whittaker 44ace3e062 Remove link :hover animation & remove negating class.
This removes the link :hover underline animation and then also removes
all instances of `.no-style` that negated the effect.
2017-08-30 16:04:30 -07:00
Brock Whittaker 5c637b6452 Remove the scaling and box shadow on hovered price options.
This removes the scaling feature where a plan that a user
hovers over would increase in size and have a box shadow.

This used to be here because there was a clickable region that
would pop open an overlay that would have more plan information,
but that feature no longer exists.
2017-08-30 16:04:30 -07:00
Brock Whittaker 75a011e432 Change the second plans block label to dark grey.
This changes the second plans block label to dark grey responsively
when the width is less than 1390px because the white text does not
appear on that portion of the white background when the block collapses
down a line.
2017-08-30 16:04:30 -07:00
Brock Whittaker a1a4af096f Make responsive on mobile devices.
This makes the page responsive down to widths of 300px.
2017-08-30 16:04:30 -07:00
Brock Whittaker 6ac0e75005 /hello/: Make company logos larger in responsive situations.
The logos would get really small around 1000px wide, so this reduces
the number of columns and makes the logos around 50% larger
horizontally.
2017-08-30 15:56:11 -07:00
Brock Whittaker 841ab828e8 Change `.testimonials` section to be white. 2017-08-30 15:56:11 -07:00
Brock Whittaker 38dc3a28b5 Change "Open Source" to be shorter and lighter.
This changes the background color from dark blue to a light steel blue,
while also removing the unnecessary min-height enforcement.
2017-08-30 15:56:10 -07:00
Brock Whittaker 93b4d8a3f2 Change .testimonials section to green. 2017-08-30 14:16:20 -07:00
Brock Whittaker 64a629fc77 Move .call-to-action-bottom out of .testimonials.
It should be its own first level element.
2017-08-30 14:15:06 -07:00