Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
45,643 Commits 28 Branches 143 Tags 627 MiB
Commit Graph

86 Commits

Author SHA1 Message Date
Aman Agrawal 25ee6a795e compose: Never hide send button. 
`Press Enter to send` used to hide `Send` button, we remove that
behaviour.

We show the current state of `Enter` hotkey action via text below
`Send` button which can toggle behaviour on click.
 2021-12-02 15:11:15 -08:00
Ganesh Pawar 1e8bfa710e dialog_widget: Migrate modal to Micromodal. 
Also removed the `danger_submit_button` config option
from the dialog_widget since it isn't needed in the new modals.
 2021-10-26 18:20:17 -07:00
Anders Kaseorg abee9258c6 js: Fix @typescript-eslint/restrict-template-expressions. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-22 18:06:06 -07:00
Anders Kaseorg ba610440ab js: Fix @typescript-eslint/no-floating-promises. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-22 18:06:06 -07:00
Anders Kaseorg dadacc38a8 dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-13 10:12:43 -07:00
Riken Shah 49193231aa puppeteer_test: Improve how we select the typeahead element. 
Our typeahead system is very sensitive, a simple internal
focus can hide it. This leads to occasional failure on the
puppeteer test.

This commit tries to solve it by clicking via javascript
instead of manual puppeteer click.
 2021-08-01 23:20:13 -07:00
Riken Shah f95c539122 custom_check: Avoid use of assert to avoid confusion with assert.equal. 
This commit bans the use of `assert` and replaces it
with `assert.ok` to avoid confusion with `assert.equal`.

Fixes #18687.
 2021-06-10 09:15:57 -07:00
Anders Kaseorg c446435f54 puppeteer_tests: Use assert.match. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-06-08 10:16:53 -07:00
Riken Shah 7ae5e7287b puppeteer_test: Add `wait_for_modal_to_close` method to `CommonUtils`. 
This commit adds the `wait_for_modal_to_close` method
and replaces all the instances where we are using jQuery
to check if the modal is closed.
 2021-06-03 09:23:54 -07:00
Riken Shah 13562222fa dependency: Upgrade puppeteer to 9.1.1. 2021-06-02 15:47:34 -07:00
Anders Kaseorg 42abc1b635 dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-10 18:07:13 -07:00
Arun Sankar 146b32d63a test users: Add an escape char to a test username. 
Changed the name of the test-user cordelia from `Cordelia Lear` to
`Cordelia, Lear's daughter`.

This change will enable us to test users with escape characters in
their names.

I also updated the Node, Puppeteer, Backend tests and Fixtures to
support this change.
 2021-04-13 11:42:06 -07:00
Riken Shah a527d196d7 puppeteer_tests: Use more stable selectors. 
This commit changes some fragile selectors (like
`a[href=#link]`) to more stable selectors because they
are more prone to break from doing something normal
like adding another link in the app.

It also solves an inconsistency in `07-navigation.ts`,
where the subscription overlay was opened by clicking
on the header stream instead of the menu list.

It also fixes a rare flake (in `07-navigation.ts`), where
the close button of subscription overlay was not clicked
due to a delay in the opening. The delay was caused by
clicking the header stream to open subscription overlay
which caused unnecessary loading of the stream
setting(Verona).
 2021-03-31 09:00:51 -04:00
Riken Shah e61f73c239 refactor: Lift out log-out call from individual tests to `common.ts`. 
We recently added the commit to add the log-out call
after each test (52706908b).

This commit cleans that approach by using
just one log-out call after the test is executed at
`common.ts`
 2021-03-31 08:57:18 -04:00
Anders Kaseorg d43ac7357a js: Move current_msg_list, home_msg_list to ES6 module message_lists. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-29 18:23:47 -07:00
Anders Kaseorg e62b0d6b5f puppeteer_tests: Translate logged traces and errors with source maps. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-25 02:05:19 -07:00
Anders Kaseorg da9783fd10 puppeteer_tests: Log page errors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-25 02:05:19 -07:00
Anders Kaseorg ed8c4fec98 puppeteer_tests: Log browser console output. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-25 02:05:19 -07:00
Anders Kaseorg 0d218a4b76 eslint: Enable @typescript-eslint/consistent-type-imports. 
TypeScript type-only imports will probably become important eventually
for reducing our circular import problem.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-18 17:26:19 -07:00
Anders Kaseorg e0f0b7f4a7 puppeteer_lib: Remove jQuery dependency from select_item_via_typeahead. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-13 07:02:00 -05:00
Anders Kaseorg 812adba5a3 puppeteer_lib: Remove jQuery dependency from get_rendered_messages. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-13 07:02:00 -05:00
Anders Kaseorg 73ca1afc53 puppeteer_lib: Remove wait_for_text. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-13 07:02:00 -05:00
Anders Kaseorg 054f8f8151 puppeteer_lib: Remove jQuery dependency from get_text_from_selector. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-13 07:02:00 -05:00
Anders Kaseorg 4434e2c687 puppeteer_lib: Remove jQuery dependency from pm_recipient.set. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-13 07:02:00 -05:00
Riken Shah 5e98f80dc3 puppeteer_test: Transform jQuery to puppeteer functions for Firefox. 
This commit converts some jQuery code
to builtins puppeteer functions because
it was not working with Firefox.
 2021-03-12 12:14:37 -08:00
Riken Shah d12257e2c1 puppeteer_test: Add missing `await` checking compose content. 
assert_compose_box_content should always be called with await.
 2021-03-04 09:41:49 -08:00
Riken Shah de96aeb822 puppeteer_test: Fix `page.url()` for Firefox. 
This commit works around an issue with Puppeteer tests on Firefox
where `page.url()` does not show the URL fragment, by adding a
temporary function that solves the issue.
 2021-03-04 09:40:14 -08:00
Riken Shah a6c1f02df0 puppeteer_test: Add `is_firefox` option to enable/disable some tests. 
This commit introduces the `is_firefox`
option in CommonUtils to identify if a browser
is Firefox or not.

This helps us to avoid calling some tests
that is yet not compatible with Firefox.
 2021-03-03 22:04:16 -08:00
Riken Shah 6676aa2f90 puppeteer_test: Change browser default viewport to allow Firefox. 
When we run puppeteer with Firefox,
the `--window-size` option does not work,
which makes the bottom part of
the page cut off.

This commit fixes this issue
by setting the screen default viewport
to the maximum size of the window.
 2021-03-03 22:01:36 -08:00
Anders Kaseorg 79ac5c25b5 zulip_test: Re-export internal functions used by Puppeteer tests. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-02 17:06:35 -08:00
Aman Agrawal 39d123e355 recent_topics: Make it the default view. 
Go to Recent Topics on "#", no hash and "#recent_topics".
Go to Recent Topics as the last destination for escape key.
Map `a` key to All messages and change its hash to
`#all_messages`.
 2021-02-25 17:31:32 -08:00
Anders Kaseorg 279c4b0e24 puppeteer_tests: Port to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Anders Kaseorg 8dec7b9270 puppeteer_lib: Use class fields. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Anders Kaseorg 912c5a28f2 puppeteer_tests: Replace deprecated jQuery event trigger shorthand. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Anders Kaseorg ad540dac3a puppeteer_lib: Supply missing $eval arugment. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Anders Kaseorg 72142273c0 puppeteer_tests: Remove buggy assert_selector_doesnt_exist helper. 
It was checking whether the selector string is itself null, not
whether it selects anything!

Use page.waitForSelector(…, {hidden: true}) instead.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-22 16:03:10 -08:00
Anders Kaseorg 34e37cea1c puppeteer_tests: Don’t read from most deprecated global variables. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-10 07:35:11 -08:00
Anders Kaseorg aa650a4c88 js: Escape strings interpolated into CSS selectors with CSS.escape. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-04 11:00:06 -08:00
Anders Kaseorg 2e501c8667 eslint: Fix unicorn/consistent-destructuring. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 14:53:19 -08:00
Anders Kaseorg 6cd694b8e3 eslint: Fix unicorn/no-array-callback-reference. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 14:53:19 -08:00
Riken Shah 5da304d902 puppeteer_test: Replace textContent to value for the compose box. 
This commit fixes the broken assertions for checking if compose box
is empty.

Fixes: #17088
 2021-01-20 11:45:41 -05:00
Anders Kaseorg 2c5e9f65f8 eslint: Fix new-cap errors. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-10 19:52:22 -08:00
Anders Kaseorg de791b82b6 eslint: Fix unicorn/no-for-loop. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg f92224c744 eslint: Fix unicorn/catch-error-name. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg 70a0260ac1 eslint: Fix unicorn/prefer-text-content. 
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-10-07 16:00:33 -07:00
Anders Kaseorg f033d5c3c5 puppeteer_tests: Migrate deprecated waitFor call to waitForFunction. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-28 10:54:14 -07:00
Anders Kaseorg 9238813135 js: Use destructuring for require statements. 
This allows import/order to auto-fix blocks including these
statements.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-23 09:06:07 -04:00
Priyank Patel b7998d3160 js: Purge people module from window. 2020-09-01 19:55:58 -07:00
Anders Kaseorg 279e4b819e js: Elide .js and .ts extensions from imports and requires. 
This will be required for TypeScript.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-01 16:43:02 -07:00
Priyank Patel 78774e5f1b minor: Remove unused url argument. 
This is not required anymore after we moved to run_test model
to save screenshots.
 2020-08-30 23:38:30 -07:00