Commit Graph

61752 Commits

Author SHA1 Message Date
Nicklas Steen 90e42ca8ed settings: Fix filter alignment under headings in all settings panels.
Previously, when resizing the window, the filters/buttons and the
header did not fit on the same row, the filters/buttons were pushed
onto the next row but not put directly below the heading. This
changes the settings_panel_list_header and
add_default_streams_button_container into flex containers and
properly aligns the items below the heading when changing window
size.
Fixes: #30353
2024-11-22 10:46:39 -08:00
Prakhar Pratyush ded6bfd3f2 add_new_user_history: Remove the RECENT_MESSAGES_TIMEDELTA limit.
We give the new users some messages in their feed.

Earlier, we were including upto 1000 messages which were sent
within the last 12 weeks.

For realms with low-traffic it results in very few messages
being included in the new user's feed.

This commit removes the 12 week limit.
Now, we simply include upto 1000 recent messages.
2024-11-22 10:41:27 -08:00
Sahil Batra 7a6159eee2 streams: Do not show archived streams in dropdown.
Dropdown widget in compose box and in message move modal should
not show archived streams in dropdown as we do not allow sending
messages or moving messages to archived streams.

We need a more focused audit of code for fixing other things
where archived streams are shown.
2024-11-22 10:40:59 -08:00
Harsh c570194ff2 tests: Add assertion for database queries count.
This commit extends the test for the `/api/v1/register` endpoint
for spectator users by adding an assertion to check the number
of database queries.

Fixes: #32409
2024-11-21 19:02:09 -08:00
evykassirer 28376bf353 buddy_list: Center toggle arrow. 2024-11-21 19:01:48 -08:00
evykassirer 17de265116 buddy_list: Redesign view user links.
As discussed here:
https://chat.zulip.org/#narrow/channel/101-design/topic/.22View.20all.22.20links.20in.20right.20sidebar/near/1976275
2024-11-21 15:17:44 -08:00
evykassirer d43e3c31ea right_sidebar: Redesign invite users link.
Fixes #32266 (second half).
2024-11-21 15:16:45 -08:00
evykassirer d168ff2a0f left_sidebar: Redesign create a channel link.
Fixes part of #32266.
2024-11-21 15:16:45 -08:00
Prakhar Pratyush c5b3d2e434 custom_check: Add rule to avoid creating savepoints.
This commit adds a custom rule to check python files
and raise lint error if they have transaction.atomic used
without any argument or savepoint=True is used.

It helps to avoid creating unintended savepoints in the future.
2024-11-21 14:55:15 -08:00
Prakhar Pratyush 62b3e49075 transaction: Add 'savepoint=True' explicitly in tests, if used.
We create savepoint at a couple of places in backend tests
to avoid rollback due to error raised within test's transaction.

This commit explicitly adds 'savepoint=True' at those places.
2024-11-21 14:55:15 -08:00
Prakhar Pratyush fdcd518e26 test_user_groups: Add `durable=True` to the independent transaction.
This commit adds `durable=True` to the short independent db transaction
in `UserGroupRaceConditionTestCase.tearDown` method.

This is as a part of our plan to explicitly mark all the
transaction.atomic calls with either 'savepoint=False' or
'durable=True' as required.
2024-11-21 14:55:15 -08:00
Prakhar Pratyush b369177341 embed_links: Add `savepoint=False` to avoid creating savepoints.
It helps to avoid creating unintended savepoints in the future.

This is as a part of our plan to explicitly mark all the
transaction.atomic calls with either 'savepoint=False' or
'durable=True' as required.
2024-11-21 14:55:15 -08:00
Prakhar Pratyush 175104ea01 streams: Add 'ChannelEmailAddress' model.
This commit removes the 'email_token' field from the
'Stream' model, introduces a new model 'ChannelEmailAddress',
and backfills it.

This is a prep work towards our plan to generate unique
channel emails for different users, which can be used
to check post permissions at message send time.
2024-11-21 14:53:28 -08:00
Anders Kaseorg 801e267e00 integrations: Properly pass data-categories as a JSON array.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-11-21 14:41:36 -08:00
Tim Abbott 77cac403ee integrations: Fix jQuery .data mishandling translated category names.
Apparently `.data("category")` would be come back as a single-element
array for some French translations, rather than a string.

We fix this by using `.attr("data-category")` across this file, which
is our preferred coding pattern anyway.
2024-11-21 14:41:36 -08:00
Sahil Batra b6f895f61c streams: Optimize DB queries for computing permission setting values.
This commit updates code to use union so that we can compute values
for permission settings using a single DB query.
2024-11-21 11:28:54 -08:00
Sahil Batra 90ae342af2 stream-settings: Add info to can_remove_subscribers_group label.
Mention that admins can unsubscribe others from any channel
in the setting label.
2024-11-21 11:28:54 -08:00
Sahil Batra d1e76a9281 streams: Allow admins to unsubscribe others irrespective of setting. 2024-11-21 11:28:54 -08:00
Niloth P 02049fbbf3 tools/screenshots: Create integration bots using display_name.
Will be adding the updated screenshots of affected integrations as soon
as the PR with the new logos and example screenshots gets merged.
2024-11-21 11:10:12 -08:00
Niloth P 29ef4a05fe tools/screenshots: Fix custom headers crash when using custom options. 2024-11-21 11:10:12 -08:00
Niloth P 619ada36ed integrations: Refine Mention example screenshot. 2024-11-21 11:09:40 -08:00
Niloth P 5de2a7115c integrations: Refine Gitea example screenshot. 2024-11-21 11:09:40 -08:00
Niloth P e1f256c905 integrations: Refine Basecamp example screenshot. 2024-11-21 11:09:40 -08:00
Niloth P 8e17ef3507 integrations: Refine CircleCI example screenshots.
- Removed the extra screenshot.
- Updated the fixture used to generate the screenshot to use a more
suitable topic name and commit message description.
2024-11-21 11:09:40 -08:00
Niloth P ab7d5ceacc integrations: Refine Zendesk example screenshot. 2024-11-21 11:09:40 -08:00
Niloth P 8582e78f02 integrations: Refine Front example screenshot. 2024-11-21 11:09:40 -08:00
Niloth P 1a89357394 integrations: Update Front logo. 2024-11-21 11:09:40 -08:00
Niloth P 42a4aa86b0 integrations: Update Raygun logo. 2024-11-21 11:09:40 -08:00
Niloth P 2c04159bfd integrations: Update Zendesk logo. 2024-11-21 11:09:40 -08:00
Niloth P f078ca86c2 integrations: Update Radarr logo. 2024-11-21 11:09:40 -08:00
Niloth P 2c94506cb5 integrations: Update Patreon logo. 2024-11-21 11:09:40 -08:00
Niloth P 80fcf9d92b integrations: Update Pagerduty logo. 2024-11-21 11:09:40 -08:00
Niloth P b3f5500364 integrations: Update Netlify logo. 2024-11-21 11:09:40 -08:00
Niloth P 0cfa4fcf7a integrations: Update IFTTT logo. 2024-11-21 11:09:40 -08:00
Niloth P 6e36f0488e integrations: Update Jotform logo. 2024-11-21 11:09:40 -08:00
Niloth P 38d5b0885e integrations: Update Greenhouse logo. 2024-11-21 11:09:40 -08:00
Niloth P d8d0b9c754 optimize-svg: Add an optional argument to optimize single files.
Do not call `generate_integration_bots_avatars.py` for single files.
2024-11-21 10:49:05 -08:00
Niloth P ef3fbcf954 optimize-svg: The --check flag does not modify files anymore.
The `svgo` command needs to write to a file to process it.
So, create and use a mktemp path, and delete it after the svgo command.
2024-11-21 10:49:05 -08:00
Niloth P 5b3d2a9e59 optimize-svg: Use a constant FILE_PATH, remove path from echo output. 2024-11-21 10:49:05 -08:00
Niloth P 7ada56c8e2 optimize-svg: Invoke svgo only via PNPM. 2024-11-21 10:49:05 -08:00
Lauryn Menard cd55488487 billing: Link customer stripe ID for manual fixed-price plan invoices.
For cases where a customer is created in Stripe first for the manual
invoice, we want to connect that customer information to our Customer
object in the database. That way the customer can access the billing
page once the invoice is paid.
2024-11-21 10:34:33 -08:00
Sayam Samal d619ffa9c4 bootstrap: Remove unused bootstrap button classes.
This commit removes the `button-secondary`, `button-group` and
`bootstrap-btn-group` classes which don't have any corresponding styles
attached to them or are no longer in use in the codebase.
2024-11-21 10:14:26 -08:00
Aman Agrawal 11153eb2c8 settings: Wait for settings overlay to close.
Since pressing `escape` key closes flatpickr and settings overlay
at the same time, we need to wait for the settings to be not
visible.

If we don't wait for the settings overlay to close, the next test
could think the settings overlay is already open and continue with
its tests which can easily become flaky.
2024-11-21 21:34:04 +05:30
Sayam Samal d4aebccd62 portico: Remove `bootstrap-btn.css` dependency from portico.
This commit removes the final vestiges of `bootstrap-btn.css` from
portico, allowing us to move `bootstrap-btn.css` from `common.ts` bundle
to just `app.ts` bundle.
2024-11-21 06:44:05 -08:00
Saubhagya Patel 65f05794ee invitations: Default to empty channel list when inviting guest users.
This commit includes the following changes:
 - While inviting users for guest roles, we display an
   empty channel list rather than the default channel list
   and the default channels checkbox is unselected.
 - While inviting users for non-guest roles we continue
   to select the default channels checkbox.
 - When switching between guest and non-guest roles, the
   previous state of included channels for the guest role
   is restored while inviting a user as a guest.

Fixes: #31988.
Co-authored-by: Aditya <113302312+userAdityaa@users.noreply.github.com>
2024-11-20 16:21:13 -08:00
Vector73 de44eb6a1b settings: Remove `invite_to_realm_policy` setting.
Removed `invite_to_realm_policy` property, as the permission
to invite other users to the organization is now controlled by
`can_invite_users_group` setting.
2024-11-20 13:35:05 -08:00
Vector73 4e89b4a88c settings: Add `can_invite_users_group` realm setting.
Added `can_invite_users_group` realm setting to replace
`invite_to_realm_policy`.
2024-11-20 13:35:05 -08:00
Karl Stolley 4e6d098cda right_sidebar: Suppress empty circle over user avatars. 2024-11-20 13:26:07 -08:00
Karl Stolley 60ce314c87 left_sidebar: Clamp topics to two lines, breaking words as needed. 2024-11-20 12:37:27 -08:00
Karl Stolley 6465c494e5 left_sidebar: Present multi-line topics. 2024-11-20 12:37:27 -08:00