858bcca713
eslint: Enable no-restricted-globals with confusing-browser-globals.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 16:10:39 -07:00
a4042d8a5a
dependencies: Add confusing-browser-globals.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 16:10:39 -07:00
ebc39137e2
eslint: Migrate JSON config to JavaScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 16:10:39 -07:00
fa91a4493c
web: Qualify global uses of location and history.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 16:10:39 -07:00
97fd5b8c6f
openapi: Improve deprecation error messages.
2024-06-07 14:28:54 -07:00
d60150d39d
api_docs: Document "/users/me/presence" endpoint.
...
Co-authored-by: Tim Abbott <tabbott@zulip.com>
Co-authored-by: Mateusz Mandera <mateusz.mandera@zulip.com>
2024-06-07 14:28:54 -07:00
f0ec4f5732
presence: Return last_update_id=-1 on zephyr mirror realm.
...
This was a bug, where in the realm.presence_disabled (synonymous to
being a zephyr mirror realm) case we would return None. We have decided
on the convention of using only integers here, and -1 representing lack
of data.
2024-06-07 13:57:40 -07:00
45118180bb
presence: Don't send slim_presence in the webapp when querying presence.
...
Sending last_update_id implies using slim_presence=true, so sending the
extra param is redundant now.
2024-06-07 13:57:40 -07:00
3ded4c2a7d
presence: Frontend implementation of the last_update_id API.
...
Note: This involves adding presence info of unknown users to the
presence data.
With some small tweaks, we can just add the info to the presence data
structures, just making sure the buddy list correctly skips those
entries and that we redraw the user in the case where the user creation
event arrives after the presence polling loop.
2024-06-07 13:57:40 -07:00
3a680763bd
docs: Update section on Go to conversation button with new icon, etc.
2024-06-07 13:01:38 -07:00
407655b84f
portico header: Remove unnecessary type assertion.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 12:12:39 -07:00
6fd27ce892
list_widget: Reduce TypeScript wreckage.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 11:54:37 -07:00
4ed51fd06b
right_sidebar: Uniformly group user name and status emoji.
...
This fixes the presentation of emoji in the compact view, where the
flexbox for properly aligning emoji was not set.
2024-06-07 11:53:26 -07:00
835bda9634
navbar: Express font and icon sizes in ems.
2024-06-07 11:28:39 -07:00
7e1a5e7e45
navbar: Remove unused fa-hashtag CSS.
2024-06-07 11:28:39 -07:00
dc60317dad
info_density: Set calculated font-size on body.
2024-06-07 11:18:52 -07:00
346dc7d79d
compose: Auto-close unchanged auto-opened drafts on narrow change.
...
Fixes #30104 .
2024-06-07 10:38:20 -07:00
4cbcd66753
compose_recipient: Set flag that recipient was changed when stream is selected.
...
This was missed when moving to a stream dropdown instead of input field.
2024-06-07 10:38:20 -07:00
371cd0da6c
recent_view: Use html as scroll container.
...
Fixes #17933 , #27517
Instead of `recent_view_table`, we make `html` as our scroll container.
This fixes an important bug for us where filters sometimes disappear
due to them scrolling under navbar which is unexpected. Since we are
now using separate containers to display rows and
filter (while includes table headers), where filters use sticky
positioning, this bug will be fixed.
2024-06-07 10:17:10 -07:00
4750f84ba8
recent_view_ui: Fix first row being focused after scrolling to bottom.
...
If recent view load more banner is at the center as a result of
`document.elementFromPoint(topic_center_x, topic_center_y)`,
there is no `tr` to focus, resulting in first row to be focused
as the closest element as per previous logic.
To fix it, we just focus the last row which is just above the
load more banner and is visible.
2024-06-07 10:09:30 -07:00
3cc7613841
css: Remove no longer used `required-text` class.
...
Since we moved to use standard empty view handlebars everywhere,
this became stale.
2024-06-07 10:09:30 -07:00
c9e822f7ad
custom_profile_fields_ui: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 09:49:40 -07:00
e6bfaed782
pill_typeahead: Separate user-only typeahead to specialized function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-07 09:49:40 -07:00
512f4d1476
presence: Backend implementation of the last_update_id API.
...
This builds on top of 016880f54d
2024-06-06 17:25:54 -07:00
a83dc572df
overlay: Blur focused element while overlay is open.
...
We blur the focused element when an overlay opens, and refocus
it when the overlay is closed, to prevent side effects.
What motivated this change was that opening a lightbox overlay
from preview content while editing a message caused the escape
key to close the message edit form instead of closing the overlay.
2024-06-06 17:13:11 -07:00
1d7e0367b8
right_sidebar: Establish inner grid on selectable_sidebar_block.
2024-06-06 17:08:13 -07:00
55e0b99670
right_sidebar: Establish outer grid on user rows.
2024-06-06 17:08:13 -07:00
74800ba69a
right_sidebar: Set user rows to normalized em-based line-height.
2024-06-06 17:08:13 -07:00
9b7107ab08
user_circles: Specify colors as CSS variables.
2024-06-06 17:08:13 -07:00
0b728e1b34
copy_and_paste: Let uppy handle pasted single images.
...
This fixes the bug where an image copied from sites like Twitter / X did
not paste as expected.
2024-06-06 17:03:44 -07:00
731c940654
user_topics: Migrate to typed_endpoint.
2024-06-06 16:50:56 -07:00
428ca713d0
users: Migrate to typed_endpoint.
2024-06-06 16:50:56 -07:00
aaf90a1da0
typeahead: Nest User inside UserPillData, UserOrMention.
...
Commit 33484e7ac3#29200 ) added a cache
for remove_diacritics, but this caching was rendered ineffective by
commit 45e9c046d8#29650 ) because it
relied on mutating a direct reference to the User object. Fix the
cache by rearranging the types to preserve that direct reference.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-06 15:24:54 -07:00
2340855851
typeahead: Remove delay when opening / closing typeahead.
...
This default delay comes off as the typeahead being laggy to the user.
2024-06-06 12:10:16 -07:00
4ac12022ca
navigate: Convert module to TypeScript.
2024-06-06 11:10:05 -07:00
fe162290f1
portico: Remove extra margin on help page.
...
Likely an effect of recent error pages refactoring.
Tested /help and /api page on desktop and mobile width.
2024-06-06 11:06:08 -07:00
51b7a2fb23
zilencer: Do not error on old stats which we no longer have.
2024-06-06 13:26:21 -04:00
53c1c4d98f
widgets: Improve structure and layout of headers.
2024-06-05 17:49:21 -07:00
81d9eb4a54
widgets: Present poll options as flexboxes.
2024-06-05 17:49:21 -07:00
ae90258942
widgets: Extend flexbox to widget inputs, buttons.
2024-06-05 17:49:21 -07:00
da6f69f8b2
widgets: Present to-do items with flexboxes.
2024-06-05 17:49:21 -07:00
f78fef699e
widgets: Set margin only on widget bottom.
2024-06-05 17:49:21 -07:00
7820c5e15e
widgets: Add classes to todo-widget div and span tags.
2024-06-05 17:49:21 -07:00
9b8e8bf0d3
widgets: Remove unnecessary styles.
2024-06-05 17:49:21 -07:00
72b6c97042
i18n: Allow get_language_name to return undefined again.
...
This can happen when the user’s configured language is less than 5%
translated. Fixes an assertion failure introduced by commit
6a429603ad#30261 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-05 12:25:15 -07:00
f58c586bee
narrow: Rename to `message_view`.
...
This brings it in sync with other libraries like `message_list`
and `message_list_data`.
2024-06-05 12:03:59 -07:00
48cdfd25f7
narrow: Rename `by_topic` to `narrow_by_topic`.
2024-06-05 12:03:59 -07:00
fecb9afa94
narrow: Rename `activate` to `show`.
...
This make the main call which displays message list sound similar
to `recent_view.show` and `inbox_ui.show`.
2024-06-05 12:03:59 -07:00
69cd263312
narrow: Rename by_recipient to narrow_by_recipient.
...
This would make the call `message_view.narrow_by_recipient` sound
better than `message_view.by_recipient`.
2024-06-05 12:03:59 -07:00
9374195418
narrow: Migrate uses of `by` function to `activate` function.
...
This is part of renaming effort of `narrow` to `message_view`.
2024-06-05 12:03:59 -07:00
Anders Kaseorg
Tim Abbott
Vector73
Mateusz Mandera
N-Shar-ma
Karl Stolley
evykassirer
Aman Agrawal
Kislay Verma
Kenneth Rodrigues
Varun Singh
Alex Vandiver