Commit Graph

5106 Commits

Author SHA1 Message Date
Vector73 e699825296 compose_typeahead: Fix position of unsubscribed icon.
Fixes position of unsubscribed icon so that it appears in the same line
as the list item of the typeahead and prevent typeahead to increase in
width when the icon is shown.
2024-07-05 15:26:36 -07:00
Vector73 67d85508be compose_typeahead: Show emojis in stream description typeahead.
Uses markdown rendered version of description instead of plain description
text in stream typeahead.
2024-07-05 15:26:36 -07:00
N-Shar-ma b85e41df47 compose: Make compose close cross button smaller and add active state.
The background color's opacity is reduced for the button's active state.
2024-07-05 15:21:34 -07:00
N-Shar-ma 29be4236d0 compose: Rework paddings for the compose content for more symmetry.
The space above and to the left of the recipient area is now matched
to the space below it, and this is also the space above and on the sides
of a collapsed compose row.
2024-07-05 15:21:34 -07:00
afeefuddin 2217eededc user_profile: Pass correct element to toggle_submit_button. 2024-07-05 15:14:24 -07:00
Aman Agrawal 8f0a0af588 server_events_dispatch: Fix stream archived booked not displayed.
Fixed by updating bookend after stream data is deleted.
When a stream is deleted and user is narrowed to the stream,
stream archived bookend is now displayed correctly.
2024-07-05 14:59:32 -07:00
Aman Agrawal 933195f7a5 stream_settings_ui: Fix stream privacy icon not updated in msg list.
We rerender message list to update the stream privacy icon in
recipient bar, bookends or any other places it might be displayed
as part of the message list.
2024-07-05 14:59:32 -07:00
Aman Agrawal 9b561212d3 message_list: Show `subscribed` bookend on subscribing a stream.
This fixes a bug where no bookend was displayed when user subscribed
to a stream but a bookend was displayed when a new message is sent
in the stream.
2024-07-05 14:59:32 -07:00
Aman Agrawal 6f0fdef80d message_list: Move condition to render update_trailing_bookend.
We move the condition to render `update_trailing_bookend` inside
the function to ensure we are only showing it when required.

This also fixes a bug where we render trailing bookend when
stream privacy is changed regardless of if the bookend is required.
2024-07-05 14:59:30 -07:00
N-Shar-ma 6099364183 compose: Fix flashing effect on trying to send message that's too long.
Due to a wrong CSS selector, the expected red outline flashing effect
was not being applied to the compose box when the user tried to send a
message that was longer than the maximum allowed length. Also, the
iteration count is set to 3 instead of relying on the duration the CSS
class is applied, to ensure exactly 3 flashes without any glitches.
2024-07-05 14:44:13 -07:00
Karl Stolley e42f9a1efd right_sidebar: Calculate margin-top on shortcuts. 2024-07-05 14:38:28 -07:00
Karl Stolley 97d401a0a1 left_sidebar: Calculate bottom scrolling buffer. 2024-07-05 14:38:28 -07:00
Aman Agrawal 41b431de70 info-overlay: Adjust width of overlay and columns.
Objectives are to make the width of overlay scale with font size and
reduce too much gap between text end of first column and
text start of the other column.
2024-07-05 11:36:35 -07:00
Aman Agrawal 676ddf8c30 information_overlays: Inline poll question and edit icon. 2024-07-05 11:36:35 -07:00
Karl Stolley 1410a0acb3 message_box: Ensure emoji display correctly on messages with senders. 2024-07-05 10:25:59 -07:00
Sahil Batra d9da6d17e0 settings: Remove max-height for bots box container.
This helps us in avoiding the scrollbar inside the box
if the information density setting is set to 16/140 by
allowing the box to set its height as per the content.

There is no need for max-height since the height of the
box was anyways less than the max-height value set before
at normal font size and screen widths.

For narrow screens, the max-height property was set to unset,
so removing the max-height property does not have any effect
on how the bots are shown on narrow screens.

Fixes #30669.
2024-07-04 07:57:32 -07:00
N-Shar-ma fa2f86ff80 compose: Fix the calculation of the compose box's max height.
This is a follow up to #30396, to remove consideration of the text box's
margin after it's removal in #29953.
2024-07-03 18:54:15 -07:00
Sayam Samal 3fda65c37d playground_popover: Update external code btn behavior on setting change.
This commit removes the `href` attribute from the external code button
when multiple code playground links are present for a language. This
prevents the bug where the external code button would always link to
the previously set code playground link, even when multiple links are
added and the expected behavior is to show the popover.
2024-07-03 17:01:46 -07:00
Sayam Samal 5191a80a3a playground_popover: Fix bug where the playground popover doesn't reopen.
This commit fixes a bug where the popover doesn't reopen after it's
closed. The bug was caused since `playground_links_popover_instance`
wasn't being set to `null` after the popover was closed, which led
the `is_open` function to return `true` even when the popover was
closed.
2024-07-03 17:01:46 -07:00
Sayam Samal fe1f8afb1b playground_popover: Redesign popover using the new "popover-menu" theme.
As part of the popover menu redesign, this redesigns the playground
links popover using the new "popover-menu" tippy theme and improves
accessibility by using appropriate ARIA attributes.

Fixes part of #28699.
2024-07-03 17:01:46 -07:00
Aman Agrawal 621ae91c70 settings: Use box buttons for download and delete.
Co-authored-by: Shashank Singh <shashanksingh@Shashanks-Air.mshome.net>
2024-07-03 16:53:39 -07:00
Kislay Verma 4bd9a8ce50 composebox_typeahead: Fix checking whether messages can be sent.
Before calling `on_enter_send`, we checked if the
`compose-send-button` is disabled, but never actually
set it to disabled, rather we updated its container
(.message-send-controls) with that state.

This commit fixes that by correctly checking the button's
container for the class .disabled-message-send-controls
which is set to indicate that the user cannot send messages
at the moment.

Fixes #30620
2024-07-03 16:24:10 -07:00
Karl Stolley 9fb6b4d016 left_sidebar: More carefully generate auto rows for expanded nav. 2024-07-03 16:18:45 -07:00
Karl Stolley 35642cb941 recent_view: Set a shared column for filter icons. 2024-07-03 16:15:46 -07:00
Aman Agrawal aed809dd7c 5xx: Remove duplicate `error_page` class applied on page.
We only want to apply this class on the actual content of the page.
2024-07-03 13:35:12 -07:00
Varun Singh 2823e732de user_group_edit_members: Remove redundant conditionals. 2024-07-03 12:34:30 -07:00
Varun Singh 8409a04c03 user_group_edit_members: Convert module to TypeScript. 2024-07-03 12:34:30 -07:00
Karl Stolley 2c7e264480 tippy: Ensure a normal font-weight on Tippies. 2024-07-03 10:43:25 -07:00
Karl Stolley 46f5854185 tippy: Initialize maxWidth in em units. 2024-07-03 10:43:25 -07:00
Karl Stolley cbdfdf06b4 tippy: Allow Tippy tooltips to scale with UI. 2024-07-03 10:43:25 -07:00
Aman Agrawal 59e9a1ac90 recipient_row: Remove extra whitespace around recipient full name.
Might fix the CI errors due to extra space between `You and` and
the user full name.
2024-07-03 10:38:35 -07:00
Aman Agrawal ef49c29ddf recent_view_ui: Update if all msgs in topic were deleted. 2024-07-02 23:01:16 -07:00
Aman Agrawal b99ff8f34c recent_view_ui: Do single update instead of doing multiple rerenders. 2024-07-02 23:01:16 -07:00
Vector73 b306233cab pm_conversation: Add new has_conversation helper.
Adds `has_conversation` function in
`pm_conversation.RecentDirectMessages` for checking whether we have in
cache evidence of previous messages in a direct message conversation.

Preparation for #28470.

Co-authored-by: Tim Abbott <tabbott@zulip.com>
2024-07-02 19:02:41 -07:00
evykassirer 9dd36b4727 filter: Add validation function for search pill terms. 2024-07-02 16:25:45 -07:00
Tim Abbott da6c2e0c3c settings: Rename Deactivated users settings subtab.
Includes help center updates to better link to the tab.

Fixes https://chat.zulip.org/#narrow/stream/9-issues/topic/deactivated.20users.20tab/near/1843114
2024-07-02 13:53:31 -07:00
Shubham Padia ba05e8eeac custom_profile_fields: Initialize typeahead for every pronoun field.
Fixes #29921.
Before this, we used to initialize only 1 typeahead resulting in the bug
of only the first field updating even when trying to change values in the
others.

Co-authored-by: Ngadou Yopa <ngadou.y@turing.com>
2024-07-02 13:30:40 -07:00
Karl Stolley 58b40fb6c7 privacy_icon: Raise lock icon throughout UI for better visual centering. 2024-07-02 13:24:16 -07:00
Shubham Padia e539d2226b stream_create: Move `Add all users` beside `Choose subscribers`.
Fixes part of #30690.
We also drop the `Do you want to add everyone?` text.
2024-07-02 12:54:52 -07:00
Shubham Padia 49f6fc5a40 scroll: Set outline as none for `.simplebar-content-wrapper`.
We're reverting removing `outline: none` from commit
fe11f3be7c. While we set tabIndex to -1 in
that commit, which makes sure that it does not get focus when navigating
via a keyboard. But it does not prevent us from programmatically focusing
on the element. In this case, we don't want to see the outline.

Fixes https://chat.zulip.org/#narrow/stream/9-issues/topic/.F0.9F.8E.AF.20weird.20left.20sidebar.20outline/near/1834137
2024-07-02 12:47:44 -07:00
Kenneth Rodrigues 57167b2e2e reactions view: Add narrow title.
Earlier the narrow title for `sender:me` was being displayed.
Instead, display the narrow title for `has:reaction sender:me`.
2024-07-02 12:18:55 -07:00
nikhil singh b75bdc129b
emoji: Change event trigger for emoji_picker.js.
Previously the `maybe_change_focus_emoji` was being triggered
on `mouseenter` event instead of `mousemove` event. 

Because `mouseenter` events occur when a popover opens underneath
the mouse, without the mouse actually moving, this could result in 
the wrong emoji being picked when user tried to choose emoji
through the keyboard. 

Fixes #30559.
2024-07-02 12:09:55 -07:00
Karl Stolley 51d25bad09 message_row: Only set bottom margin on avatar for me-messages. 2024-07-02 11:45:30 -07:00
Karl Stolley 47430ac719 message_row: Allow user avatar to scale with UI. 2024-07-02 11:45:30 -07:00
Karl Stolley 0f05c67c88 message_box: Set same vertical space below reactions, length toggles. 2024-07-02 11:45:30 -07:00
Karl Stolley 8697c0c63e message_box: Base sender line-height on single-line message. 2024-07-02 11:45:30 -07:00
Karl Stolley 8556e098fb message_box: Set vertical margin to interelement space. 2024-07-02 11:45:30 -07:00
PieterCK b2515e8214 subscription css: Add new app variable for bottom border color.
This commit add a new css variable for subscription lists bottom
border color.

Fixes #30677.
2024-07-02 11:16:51 -07:00
PieterCK 7556414337 subscription css: Refactor subscriber list bottom border.
This commit refactors the css for subscriber list in channel
settings and group settings by moving the css rules that were
initially used to format the bottom border of the table to
the wrapper div (.subscriber_list_container) around the table.

On specific screen height, this wrapper div will overlap the
actual bottom border of the table and make it look like it's
cut-off. This commit makes it look like the table have consistent
bottom border accross all screen sizes.
2024-07-02 11:16:51 -07:00
Karl Stolley 3cb4bb830a left_sidebar: Refactor nav rows for low-resolution screens. 2024-07-02 10:24:20 -07:00