Rishi Gupta
7cc8992d1e
message feed: Update wording for narrow to non-existent stream.
2017-12-10 22:53:11 -08:00
Shreyansh Dwivedi
4a262713e6
Better errror message for narrow to a nonexistent stream. Fixes #6862
2017-12-10 06:00:14 -08:00
cPhost
63e8248933
node tests: Cover stream_data.canonicalized_name.
2017-12-10 04:20:29 -08:00
cPhost
0b9e678d4d
node test: Cover stream_data.render_stream_description.
2017-12-10 04:20:29 -08:00
cPhost
d2a2d0b362
node tests: Cover stream_data.get_subscriber_count.
2017-12-10 04:19:33 -08:00
Steve Howell
36ade63d84
compose: Fix bug in undo operation
...
This fixes compose.test_video_link_compose_clicked to just
use a stub for compose_ui.insert_syntax_and_focus.
It also adds direct tests for compose_ui.insert_syntax_and_focus.
Fixes #6362
2017-12-10 04:10:18 -08:00
Arseny Chekanov
e5c05f128a
mypy: Use Python 3 type syntax in zerver/views/realm_filters.py.
2017-12-09 16:50:12 -08:00
Arseny Chekanov
c2c023f0cf
mypy: Use Python 3 type syntax in zerver/tornado/websocket_client.py.
2017-12-09 16:50:12 -08:00
Arseny Chekanov
1f34300006
mypy: Use Python 3 type syntax in zerver/webhooks/trello/tests.py.
2017-12-09 16:50:12 -08:00
Steve Howell
738c73f08e
lint: Prevent `self: Any` annotations.
...
We should omit these for mypy. For most class definitions,
mypy doesn't need `Any`, and it provides no real useful info.
For clever monkeypatches, you should provide a more specific
type than `Any`.
2017-12-08 19:00:18 -08:00
Steve Howell
ac48772907
mypy: Improve typing for ManifestStaticFilesStorage monkeypatch.
2017-12-08 19:00:18 -08:00
Steve Howell
f83a73c763
mypy: Use more specific type for _replacement_destroy_test_db.
2017-12-08 19:00:18 -08:00
Steve Howell
78041a5846
mypy: Use more specific type for instrument_url wrapper.
2017-12-08 19:00:18 -08:00
Xavier Cooney
aa37b50d1e
mypy: User Python 3 syntax for typing in realm.py.
2017-12-08 18:34:26 -08:00
Xavier Cooney
a6465e8e35
mypy: Use Python 3 syntax in zapier/view.py.
2017-12-08 18:34:26 -08:00
Xavier Cooney
1262d14d39
mypy: Use Python 3 syntax in gci/view.py.
2017-12-08 18:34:26 -08:00
Xavier Cooney
38e65570ae
mypy: Use Python 3 syntax for typing in heroku/view.py.
2017-12-08 18:34:26 -08:00
Xavier Cooney
a831acd97f
mypy: Use Python 3 type syntax in bugdown/__init__.py.
2017-12-08 18:34:26 -08:00
Xavier Cooney
63e793a8d1
mypy: Use Python 3 syntax for typing in views/tutorial.py.
2017-12-08 18:34:26 -08:00
Cynthia Lin
9bf0c96e9f
modals: Make settings page selectors more specific.
...
The `#settings_page .right.show` selector was breaking the Emoji style inputs in Display settings on mobile responsive view.
Fixes #7624 .
2017-12-08 18:22:30 -08:00
Cynthia Lin
799e4adf42
compose: Align Press Enter to send checkbox with label.
...
Fixes #7604 .
2017-12-08 18:21:32 -08:00
Rohitt Vashishtha
eb2bdb706a
sidebar: Narrow to latest topic if not in stream.
...
We now narrow to the latest topic in stream if we are narrowing from
outside the stream, and show all topics grouped together (previous
default) if we are already narrowed to the stream.
Fixes #7555 .
2017-12-08 05:53:49 -08:00
Rohitt Vashishtha
6d9273819c
tests: Cover new composebox typeahead terminal symbols.
2017-12-08 01:00:38 -08:00
AlloulDorian
39dc41f40b
user docs: Add doc for video calls.
2017-12-07 16:57:50 -08:00
cPhost
c6985e2eee
eslint: add --cache flag for faster linting
2017-12-07 15:14:51 -08:00
Brock Whittaker
59b0776c53
left-sidebar: Lighten global filter icons.
...
This lightens them to a half-opaque base text color so they stand out
less than they currently do.
2017-12-07 15:10:07 -08:00
Brock Whittaker
aebf63c288
sidebars: Change to more muted hover/active colors.
...
The active streams and users should be more muted grey tones than the
greens and blues that they currently are.
2017-12-07 15:10:07 -08:00
Brock Whittaker
60e018e972
sidebars: Add 1px of vertical margin to all <li>.
...
This makes the list slightly less dense (9%) and ensures that the
borders of hovered items and active items don’t touch each other.
2017-12-07 15:10:07 -08:00
Brock Whittaker
953ee778f3
sidebars: Remove link underlines on hover.
...
This removes the underlines on the stream names and user names when
hovered over for a cleaner look. This is acceptable due to the fact
that hover is signified already by a light grey background.
2017-12-07 15:10:07 -08:00
cPhost
7504d01066
node tests: Cover stream_data.remove_default_stream.
2017-12-07 15:05:44 -08:00
Jerry Zhang
48ebec3a29
node tests: Cover exports.get_default_status.
2017-12-07 15:02:12 -08:00
Jerry Zhang
e134fd610e
node tests: Cover exports.is_for_stream_id.
2017-12-07 14:58:27 -08:00
Jerry Zhang
806e9bb742
node tests: Cover exports.remove_subscriber.
2017-12-07 14:57:15 -08:00
Jerry Zhang
b874693242
node tests: Cover exports.user_is_subscribed.
2017-12-07 14:57:15 -08:00
Vishnu Ks
a30152cb94
models: Use is_cross_realm_bot_email whenever possible.
...
Fixes #7557
2017-12-07 14:55:06 -08:00
Vishnu Ks
ff43443ac7
models: Create is_cross_realm_bot_email function.
2017-12-07 14:55:06 -08:00
Cynthia Lin
c90faca875
portico: Modify docs sidebar to a light shade of green.
2017-12-07 14:40:17 -08:00
Cynthia Lin
b7fb86b9ea
user docs: Modify sidebar and index page styling.
2017-12-07 14:40:17 -08:00
Cynthia Lin
eddf3a722a
components: Change cursor to pointer for checkbox labels.
...
Lets users know that they can toggle the checkbox by clicking the corresponding label.
2017-12-07 14:37:23 -08:00
Cynthia Lin
5f480495f8
invitations: Make stream labels click targets.
...
Label tags can't be nested in each other.
Fixes #7582 .
2017-12-07 14:37:23 -08:00
Vishnu Ks
6e85122724
integrations: Fix broken ifttt link.
2017-12-07 10:28:53 -08:00
Rohitt Vashishtha
9c2a28b6df
invitations: Fix lint errors in test_queue_workers.
2017-12-06 22:15:25 -08:00
Rishi Gupta
6787fbd547
invitations: Change rate limiting to use invites_sent::day.
...
[greg: small tweaks]
2017-12-06 20:35:50 -08:00
Rishi Gupta
fbd8dde1f8
invitations: Add LoggingCountStat to keep track of sent invitations.
2017-12-06 20:35:50 -08:00
Rishi Gupta
100167fcf8
invitations: Change error messages for resend/revoke views.
...
We don't have a concept of invitation ID on the frontend (or backend).
2017-12-06 20:35:50 -08:00
Rishi Gupta
cb5eb47470
invitations: Move resend/revoke error handling out of actions.py.
2017-12-06 20:35:50 -08:00
Rishi Gupta
968aae167b
invitations: Remove get_prereg_user_by_email.
...
The original logic is buggy now that emails can belong to (and be
invited to) multiple realms.
The new logic in the `invites` queue worker also avoids the bug where
when the PreregistrationUser was gone by the time the queue worker got
to the invite (e.g., because it'd been revoked), we threw an exception.
[greg: fix upgrade-compatibility logic; add test; explain
revoked-invite race above]
2017-12-06 20:35:50 -08:00
Greg Price
cab5c418f1
invitations: Add tests for queue worker.
2017-12-06 20:30:42 -08:00
Rishi Gupta
8baadc6b15
invitations: Add check for invite limit to resend invite pathway.
2017-12-06 20:30:42 -08:00
Greg Price
b3482429f1
invitations: Adjust a few blank lines for clarity and compactness.
2017-12-06 20:30:42 -08:00