777b6de689
org settings: Add setting to prevent users from adding bots.
...
Fixes : #7908 .
2018-03-09 13:21:55 -08:00
7c830c5767
webhooks/beeminder: Mock time.time() to avoid race.
...
Rewritten in significant part by tabbott to actually be correct.
One particularly nasty thing the original webhook integration did is
do `current_time = time.time()` at the top of the `view.py` function
-- that means that code ran at import time, not runtime.
2018-03-09 11:12:40 -08:00
713ca1e5f2
yarn: Update yarn.lock for moment and moment-timezone upgrade.
2018-03-09 11:05:18 -08:00
7bbdf79b78
Rename functions to show_loading_older/hide_loading_older.
2018-03-09 11:04:29 -08:00
389421d9c2
Rename reset_load_more_status to reset_for_new_narrow.
...
We are about to make this logic a little more specific to
what happens when you make a new narrow.
2018-03-09 11:04:29 -08:00
ae84908eca
Rename load_more_messages to maybe_load_older_messages.
...
We will soon have maybe_load_newer_messages as well.
2018-03-09 11:04:29 -08:00
68d3441de1
Rename load_old_messages to load_messages.
...
This function will eventually sometimes load messages that
are "new" relative to the messages that have already been
loaded.
2018-03-09 11:04:29 -08:00
077475c563
compose: Don't warn if mentioned stream members form a superset.
...
Fixes #8634 .
Suppress private stream warning if you're to a stream whose
membership is a subset of #mentioned-stream-name.
2018-03-09 10:46:41 -08:00
617aea7507
Fix clipping of stream and topic name in left sidebar
...
Changed a little bit the rule for line-height and now it does not clip "g" letter in of stream and topic name in the left sidebar
Fixes #8209 .
2018-03-09 10:40:27 -05:00
a598befc9e
pills: Show data-some-recipients placeholder text only on focus.
...
Show data-some-recipients placeholder text only when input
element to add recipients is focused.
Fixes #8622
2018-03-08 15:11:01 -08:00
c035acce6c
pills: Show data-no-recipients text only if no recipients selected.
...
Currently, we shows data-no-recipients placeholder text even if
there are recipients selected. It's not visible cause it's value
is override by data-some-recipients helper text in case if there
are recipients selected.
Show data-no-recipients placeholder text only when `input` element
is first child of `pill-container`, which means there are no `pills`
selected by user yet.
2018-03-08 15:11:01 -08:00
e1ab6ceccc
docs: Clarify description by changing 'disrupting' to 'disturbing'.
2018-03-08 15:10:23 -08:00
649e76e932
Display error when creating embedded bot with incorrect config data.
...
"incorrect" here means rejected by a bot's validate_config() method.
A common scenario for this is validating API keys before the bot is
created. If validate_config() fails, the bot will not be created.
2018-03-08 15:05:42 -08:00
194b2fd8c0
Upgrade the zulip_bots dependency to python-zulip-api:192e9e1.
...
192e9e1 introduces bot-specific validate_config()
methods that are used in subsequent commits.
2018-03-08 15:05:38 -08:00
35c7428490
frontend: Add create-bot loading indicator.
...
The former "the-bot-is-being-created" indicator was useless,
since it only edited the value attribute of the "create-bot" button;
that attribute only sets the text of a button when it is initially created.
This commit replaces the old code with a spinning loading indicator,
like the one used for editing bots.
2018-03-08 15:05:00 -08:00
47f3af9e50
refactor: Extract constants in message_fetch.js.
...
Having constants at the top is particularly convenient
for tweaking things while testing the fetch code.
2018-03-08 15:03:47 -08:00
571773564f
minor: Use message_viewport.at_top() in scroll_finished.
...
This effectively changes a condition from `=== 0` to `<= 0`,
but that probably doesn't matter (and would only help). More
importantly, it just makes the code more consistent.
2018-03-08 15:03:47 -08:00
b8f39b2ff1
refactor: Early-exit in message_scroll.scroll_finished.
...
This is just cosmetic to flatten the function a bit.
2018-03-08 15:03:47 -08:00
8063f73f6d
Extract message_scroll.js.
...
This mostly moves code from ui.js.
We change the arguments to `message_fetch.load_more_messages()`
to be `opts` with callbacks for `show_loading` and `hide_loading`.
We also defer starting the scroll handler until `message_fetch.js`
has been initialized.
2018-03-08 15:03:47 -08:00
7819319695
minor: Remove unused `ui.have_scrolled_away_from_top`.
2018-03-08 15:03:47 -08:00
254548d093
package.json: Upgrade moment-timezone to 0.5.14.
2018-03-08 14:57:28 -08:00
8d8c102192
package.json: Upgrade moment to 2.21.0.
2018-03-08 14:57:28 -08:00
fa8525c862
webhooks/hellosign: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f3590dc2f5
webhooks/gosquared: Update text to conform to doc style guide.
...
Note that the 5th step cannot be reached unless a webhook has been
configured first, which is why it is the last step.
2018-03-08 08:19:32 -08:00
12396dd39b
webhooks/gogs: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
88a198041a
webhooks/gitlab: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f7a21b18dc
webhooks/github_webhook: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
b6fc33e1da
webhooks/gci: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
fa1583bf45
webhooks/dropbox: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
4f039e4536
webhooks/delighted: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
18c6cd9dd2
webhooks/codeship: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
1c44a9c4c0
webhooks/bitbucket2: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f551f3a9b8
webhooks/beanstalk: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
9de90645f3
webhooks/basecamp: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
7ee7d4a4d1
webhooks/appfollow: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
a78024f53d
bots: Delete bot from bot_data set on realm_bot delete event.
...
Fixes #8577 .
2018-03-08 07:54:19 -08:00
32e38d36aa
bots: Send add/delete event on bot ownership change.
...
Adds realm_bot delete event. On bot ownership change, add event is
sent to the bot_owner(if not admin) and delete event to the
previous bot owner(if not admin). For admin, update event is sent.
2018-03-08 07:54:19 -08:00
d4374880d5
slack importer: Clear 'output_dir' at the beginning of test.
...
if the test fails, the 'output_dir' would not be deleted and
hence it would give an error when we run the tests next time,
as 'do_convert_data' expects an empty 'output_dir'.
Also the unzipped data file should be removed if the test fails
at 'do_convert_data'.
2018-03-08 07:53:09 -08:00
a0ab87bef2
notifications: Clean and automate global notifications update handler.
...
To prevent specifying notifications individually for global
updates, automate handle_global_notification_updates using
settings_notifications.notification_settings where we have
the keys of all the types of notifications.
2018-03-08 07:19:48 -08:00
c0f5ac801d
team: Fix ugly line-wrapping when showing total.
...
Eventually, we'll want a slightly different design for this section of
the page, for for now, "Total" is both clearer and fits better.
2018-03-07 17:25:42 -08:00
6bed6ccdcf
team page: Remove duplicate contribution counts.
...
It removes duplicate contribution count from zulip-server.
Fixes #7836 .
2018-03-07 17:25:41 -08:00
c3964dff6e
i18n: Fix a last few strings mentioning realms.
2018-03-07 17:15:29 -08:00
c47403b024
i18n: Fix message-send error messages using 'realm'.
...
We also do some small quality improvements to these strings, while
we're at it.
2018-03-07 17:15:29 -08:00
798fbb687c
i18n: Rename 'Closed Realm' to 'Private organization'.
...
This is a clearer explanation for what the organization is like, anyway.
2018-03-07 17:15:29 -08:00
e2a6541133
i18n: Fix use of 'realm administrator' in translated strings.
...
These are user-facing and thus should refer to being an "organization
administrator".
2018-03-07 17:15:29 -08:00
8fba40fdd5
emoji: Clean up strings for emoji errors.
...
The main goal here is to remove the use of the term "realm", but we
also make these strings more consistent and using better English.
2018-03-07 17:15:29 -08:00
342d8cd4e0
i18n: Fix use of realm to refer to an organization.
2018-03-07 17:15:29 -08:00
158697c41c
dev environment: Properly close triple quotes in fixture messages.
2018-03-07 16:26:30 -08:00
3186b09e43
i18n: Remove unnecessary string.
2018-03-07 16:19:44 -08:00
fb3293a24a
node tests: Add tests for input_pill.js.
...
This gets us coverage on most of the core "data" code, but it
doesn't get deep into the key handlers.
2018-03-07 15:53:11 -08:00
Shubham Dhama
Ricky
Vishnu Ks
Steve Howell
Shubham Padia
retsediv
YJDave
cg-cnu
Robert Hönig
Eeshan Garg
Rhea Parekh
Tim Abbott
sinwar
Rishi Gupta
Yago González