76d6c71595
tests: Move zerver/fixtures to zerver/tests/fixtures for clarity.
...
Fixes #9153 .
2018-04-19 21:50:17 -07:00
d0801dd602
settings: Make saving spinner visible in night mode.
...
Fixes : #9154 .
2018-04-19 21:47:04 -07:00
9aa9ed9472
org settings: Refactor code for get_property_value.
...
This just makes the code for getting the property value more readable
and less confusing.
2018-04-19 21:47:04 -07:00
a06c7bc247
puppet: Allow manual configuration of postfix_mailname.
...
This allows users to configure a mailname for postfix in
/etc/zulip/zulip.conf
2018-04-19 14:41:05 -07:00
62b12e0c34
zulip_ops: Add missing dependency on dhcpcd.
2018-04-19 14:27:48 -07:00
e53c0fe273
docs: Further clarify privacy details for push notifications.
2018-04-19 14:20:57 -07:00
3f94a62309
portico: Add contact info to FAQ.
2018-04-19 12:48:27 -07:00
bc7c3df621
drafts: Fix confusing disconnect between focused element and enter hotkey.
...
The enter hotkey targets the focused message, not the one the user is
hovering over.
Fixes #9093 .
2018-04-19 12:44:03 -07:00
ba21afe9a6
zblueslip: Convert node_tests/people_errors.js to zblueslip.
2018-04-19 15:02:00 -04:00
a836473746
zblueslip: Convert node_tests/compose.js to zblueslip.
2018-04-19 15:02:00 -04:00
25c75b66d3
zblueslip: Convert node_tests/emoji.js to zblueslip.
2018-04-19 15:02:00 -04:00
4738644339
zblueslip: Create zblueslip.js for improved error handling.
...
Adds a basic API for controlling the allowed error messages and
documents the usage in the form of unit tests, similar to zjquery.
Fixes #8675 .
2018-04-19 15:02:00 -04:00
55f830c345
server_events_dispatch: Add node coverage for user groups.
2018-04-19 14:59:08 -04:00
deab3ac541
hash_util: Add 100% node-coverage for hash_util.js.
2018-04-19 14:59:08 -04:00
9c096840be
node tests: Increase coverage for settings_org.
2018-04-19 14:58:12 -04:00
b41a204dbb
org settings: Remove redundant property type from org_permissions object.
...
`add_emoji_by_admins_only` is already covered in
`get_complete_data_for_subsection` function.
2018-04-19 14:58:12 -04:00
48fe77c61e
node tests: Remove repeated zjquery code in settings_org tests.
2018-04-19 14:58:12 -04:00
99f07fe2e2
tests: Fully cover top_left_corner.js.
2018-04-19 14:56:55 -04:00
09469026c6
zjquery: Allow removeClass() to remove multiple classes simultaneously.
...
removeClass() now splits class_names by spaces to get multiple
class names. Then removes each individual class name.
2018-04-19 14:56:55 -04:00
e539e966c9
profile field settings: Disable autocomplete.
2018-04-19 11:37:15 -07:00
79ff89ed8b
profile: Add hint field in the settings UI.
...
We still don't actually display it in the "Edit your profile" UI.
2018-04-19 11:32:45 -07:00
0420b89468
profile: Add hint attribute to custom profile fields.
...
This is the model for #8876 .
2018-04-19 11:32:35 -07:00
00ffa808da
check_capped_string: Return a validator.
...
This allows us to create custom validators.
2018-04-19 11:21:50 -07:00
f34b72b830
docs: Fix command for accessibility label.
2018-04-19 11:13:09 -07:00
e8be968250
install: Expand error message for missing SSL cert slightly.
...
It wasn't obvious reading this message that you can perfectly well
bring your own SSL/TLS certificate; unless you read quite a bit
between the lines where we say "could not find", or followed the link
to the detailed docs, the message sounded like you had to either use
--certbot or --self-signed-cert.
So, explicitly mention the BYO option. Because the "complete chain"
requirement is a bit tricky, don't try to give instructions for it
in this message; just refer the reader to the docs.
Also, drop the logic to identify which of the files is missing; it
certainly makes the code more complex, and I think even the error
message is actually clearer when it just gives the complete list of
required files -- it's much more likely that the reader doesn't know
what's required than that they do and have missed one, and even then
it's easy for them to look for themselves.
2018-04-19 11:08:22 -07:00
6a11ff5b28
settings: Deduplicate the template code for checkboxes.
2018-04-19 11:02:30 -07:00
a3ba484c99
settings: Wrap subsections into seperate divs.
...
Following templates are affected: display-settings.handlebars and
ui-settings.handlebars.
There will be no UI change, it is just to make code more readable.
2018-04-19 11:02:30 -07:00
19177a4aff
webhooks: Move github_webhook/ to github/.
2018-04-19 11:00:55 -07:00
48b8558c02
webhooks: Move github/ to github_legacy/ and remove docs.
2018-04-19 11:00:55 -07:00
2cc3fb7564
slack import: Fix documentation on path to run manage.py.
2018-04-19 10:32:58 -07:00
71e6b93277
night-mode: Add borders to input pill containers.
2018-04-19 10:03:37 -07:00
20f14508ff
compose: Fix styling of PM recipient input pill.
...
Fixes #9128 .
2018-04-19 10:03:37 -07:00
ea23297d79
left sidebar: Fix line-height causing clipping.
...
Fixes #8209 .
2018-04-19 09:57:32 -07:00
cf40aa4763
portico: Add export advertisement to FAQ.
2018-04-19 09:40:11 -07:00
9d9d84ffd2
portico: Minor UI fix in plans page.
...
Renamed zulip-cloud class to responsive-title so that
we can re-use this class in other sections also.
Fixes : #9133 .
2018-04-19 03:05:57 +05:30
aa4b067e68
avatars: Fix 500 with the /avatar/ URL to be a 404.
...
Apparently, we had a somewhat sloppy regular expression for the URL
for this endpoint.
2018-04-18 12:43:57 -07:00
bad04c761f
docs: Recommend upgrading when doing Slack import.
2018-04-18 12:28:52 -07:00
7dfa0edfa6
slack import: Don't try to import pinned/unpinned items.
...
There isn't a corresponding Zulip concept, and they don't have a
"text" attribute, so there's no message content to import.
2018-04-18 11:36:31 -07:00
acd3a364e1
slack import: Refactor handling of dropped messages.
...
This is a more coherent ordering, because some messages we skip lack a
"text" attribute.
2018-04-18 11:35:59 -07:00
e759fd9be4
slack import: Improve error handling for invalid messages.
2018-04-18 11:29:40 -07:00
03a2a9c792
activity: Add realm stats link to "realm activtiy table".
2018-04-18 11:07:00 -07:00
b26c38bc47
analytics: Make stats of all realms accessible to server admins.
...
In this commit:
Two new URLs are added, to make all realms accessible for server
admins. One is for the stats page itself and another for getting
chart data i.e. chart data API requests.
For the above two new URLs corresponding two view functions are
added.
2018-04-18 11:06:50 -07:00
40dc48a033
decorator: Add decorator for checking whether user is server admin.
...
This is just variabnt of `require_server_admin` for JSON/api views.
2018-04-18 11:01:46 -07:00
3e117fba21
footer: Add a link to the blog.
...
This doesn't look amazing, but it's better than not linking to the
blog, and adding a 6th line both makes the footer excessive and also
breaks some styling in pages like /login that assume a fixed footer
height.
2018-04-18 10:44:18 -07:00
63ca175991
hello: Fix link to legacy GitHub integration.
2018-04-18 10:40:35 -07:00
1410a1e460
slack import: Remove unnecessary zerver_realm_skeleton.json.
...
This was stored as a fixture file under zerver/fixtures, which caused
problems, since we don't show that directory under production (as its
part of the test system).
The simplest emergency fix here would be to just move the file, but
when looking at it, it's clear that we don't need or want a fixture
file here; we want a Python object, so we just do that.
A valuable follow-up improvement to this block would be to create an
actual new Realm object (not saved to the database), and dump it the
same code we use in the export tool; that should handle the vast
majority of these correctly.
Fixes #9123 .
2018-04-18 10:33:53 -07:00
77ca9e7eca
hotspots: Tag strings for translation.
2018-04-18 09:33:09 -07:00
e78158bcc3
activity: Refactor code for getting chart data.
...
This simply refactored the repetitive code for getting stats chart
data.
(commit message tweaked by shubhamdhama)
2018-04-17 17:58:01 -07:00
6c4f02218e
node tests: Add some coverage to list_render.js.
2018-04-17 17:52:19 -07:00
6b44cdb286
zjquery: Extract make_event_store().
...
This pushes some of the most complex code of zjquery into its own
object.
2018-04-17 17:52:19 -07:00
Preston Hansen
Shubham Dhama
Tim Abbott
Rishi Gupta
Natalie Totonchy
Rohitt Vashishtha
Tarun Kumar
Joshua Pan
Umair Khan
Greg Price
Eeshan Garg
Cynthia Lin
Akash Nimare
Steve Howell