7222dbd99b
refactor: Simplify narrow_state.is_for_stream_id().
...
This takes advantage of the new function narrow_state.stream_id().
We now assume the incoming stream_id is a valid stream_id, so we
no longer need to test some of the error checking. (It's possible that
the incoming stream_id may no longer be for a stream you subscribe
to, but the nice benefit of working more in "id space" is that if
it doesn't match the narrow's stream id, we know false is a safe
return value.)
2018-05-02 09:16:24 -07:00
a62c85c015
Add narrow_state.stream_sub() and narrow_state.stream_id().
2018-05-02 09:16:24 -07:00
0232e92038
Add filter.is_pm_with_only().
2018-05-02 09:16:24 -07:00
2a70f0dba4
Add filter.is_stream_topic_only().
2018-05-02 09:16:24 -07:00
08307c0e87
Add filter.is_stream_only().
2018-05-02 09:16:24 -07:00
861cb16c3e
minor: Remove redundant function names in Filter class.
...
We no longer use the style of giving a function name to a
function that already has a name from the object it gets
attached to.
2018-05-02 09:16:24 -07:00
0150c01027
Add unread.get_msg_ids_for_person().
2018-05-02 09:16:24 -07:00
2b35f26b88
Add unread.get_msg_ids_for_stream().
2018-05-02 09:16:24 -07:00
c432acb436
Add unread.get_msg_ids_for_topic().
...
This will be useful for some narrowing related changes.
2018-05-02 09:16:24 -07:00
76b97d8b54
refactor: Add util.sorted_ids().
...
We borrowed this from typing_data.js and gave it a slightly
different name (sorted -> sorted_ids).
2018-05-02 09:16:24 -07:00
a0e8a37e7f
topics: Fix get_topics_backend logic for zephyr realms.
...
This removes a check on invite_only, that should have been a check on
history_public_to_subscribers. In addition to fixing a bug for zephyr
realms, it also makes "more topics" work correctly for realms using
the new settings for stream history being public to subscribers.
2018-05-02 09:02:57 -07:00
4df886f36f
populate_db: Fix initialization of history_public_to_subscribers.
...
This was being incorrectly not initialized properly in the test suite,
because we neglected to update the bulk_create code path for creating
streams.
2018-05-02 09:02:57 -07:00
866cb38270
test_classes: Compute history_public_to_subscribers correctly.
...
We apparently missed updating this when we split out this database field.
2018-05-02 09:02:57 -07:00
2f6da2661f
push_notifications: Format blockquotes properly in text_output.
...
New output is of the format:
Hamlet said:
> Polonius said:
> > This is the.
> > Second layer of nesting.
> First layer of nesting.
Fixes #9251 .
2018-05-02 08:57:17 -07:00
a8830ec8da
hello.html: Add testimonial carousel.
...
Replaces single testimonial and replaces it with multi-testimonial
slider.
Quote added by Tim Abbott with permission from Jacinda.
2018-05-01 16:45:52 -07:00
8705ac1091
portico: Add noindex tags for non root realms.
...
There may be further work required for the /integrations pages.
2018-05-01 15:28:30 -07:00
77e57dd033
index.html: Clean up indentation and whitespace in HEAD.
...
This is mostly to make our linter happy after removing the conditional
in the previous commit.
2018-05-01 09:49:28 -07:00
d92edb8ea5
css: Remove support for legacy desktop app.
...
We haven't seen significant traffic from the legacy desktop app in
over a year, and users using it get a warning to upgrade since last
summer, so it's probably OK to stop providing special fonts for it.
2018-05-01 09:49:28 -07:00
19b228bca4
sidebars: Disable autocomplete for user and stream search inputs.
...
Fixes #9269 .
2018-05-01 09:24:40 -07:00
6c96ba79e0
test_bugdown: Fix ignore-testcase feature for markdown_test_cases.
...
We accidentally were 'return'ing on encountering an ignored case, and thus
exiting the loop, not running further testcases.
2018-05-01 09:24:15 -07:00
c1432d9dfc
slack import: Reformat UserProfile to one-line-per-field.
...
This should be more readable and convenient for future editing.
2018-05-01 09:16:12 -07:00
a2f49b425b
slack import: Fix some erroneous UserProfile field values.
...
* tutorial_status was the invalid value 'T'; should be the default of 'W'.
* last_reminder can be just the default None
* enable_desktop_notifications was just the model default of True.
2018-05-01 09:14:47 -07:00
f00b80058d
slack import: Remove unwanted comments.
2018-05-01 09:09:36 -07:00
e579bef8fd
slack import: Improve how we construct user_profile objects.
...
Fixes #9260
2018-05-01 09:09:36 -07:00
c80babdf95
provision: Increment version for generating email templates.
...
Email source files were modified for adding translation tags
but version was not incremented.
2018-05-01 17:57:46 +05:30
f4f64243dd
custom_profile_fields: Support changing the sort order of the fields.
...
Tweaked by tabbott for variable naming and the URL.
Closes #8879 .
2018-04-30 18:17:41 -07:00
acf00c1130
why-zulip: Include cartoon of Julia Evans.
2018-04-30 17:46:02 -07:00
a4ff917789
emails: Fix spelling of "Unknown IP" and tag for translation.
2018-04-30 12:04:39 -07:00
b72874226f
enails: Pass new login details as separate variables.
...
Refactored by tabbott to eliminate some unnecessary complexity.
2018-04-30 12:03:10 -07:00
363d17f2bb
emails: Add translation tags to notify_change_in_email.
2018-05-01 00:11:44 +05:30
69b0783b35
emails: Pass realm_name instead of realm in notify_change_in_email context.
2018-05-01 00:11:44 +05:30
23e82315b5
stream-settings: Remove redundant actually_filter_streams function call.
...
After adding a newly created stream to the top of the stream list,
call to actually_filter_streams in stream_events.mark_subscribed
rerendered the filter_table and the stream list was refreshed. The
call to actually_filter streams was introduced to rerender the
subscriber list but stream_edit.rerender_subscribers_list takes care
of it already.
Fixes #9033 .
2018-04-30 11:38:47 -07:00
dbd24c5c93
create stream: Fix preview btn not showing on private stream creation.
...
Fixes #9028
2018-04-30 11:15:07 -07:00
86eddd79bc
stream settings: Fix scrollbar bug on unsubscribing themselves.
...
Fix scrollbar not updating when user unsubscribe themselves
from "Stream members" list, by clicking "Unsubscribe" button.
Fixes #9029
2018-04-30 11:15:07 -07:00
de30474ddd
test_custom_profile_data: Don't do a database query on import.
...
This is a general code cleanlyness improvement.
While we're at it, we combine together two test classes that didn't
have a particularly good reason for existing.
2018-04-30 10:57:23 -07:00
0a9fbe2ce6
zerver/tests/test_custom_profile_data.py: Refactor tests.
...
Refactor tests to include generic function for invalid
assertion and remove repetitive assertion code.
2018-04-30 10:53:23 -07:00
a97a00a4c6
custom fields: Replace field id with field name in error message.
2018-04-30 10:53:23 -07:00
0d7d94d0db
custom fields: Add support for custom URL field type.
2018-04-30 10:53:23 -07:00
d2128105dd
custom fields: Fix bug in real time sync for user settings.
...
Currently when admin add/remove/update custom fields, changes
are not reflected in user settings page, if settings tab
is already open. This might be rare case, but it looks like
an error when admin go to user settings page just after
updating custom fields in org settings.
Fix this by re-rendering custom fields in user settings
on custom_profile_fields event.
2018-04-30 23:04:25 +05:30
4033f210af
custom fields: Add support for custom date field type.
2018-04-30 23:04:25 +05:30
94d787aa2e
zerver/test/test_custom_profile_data.py: Remove hard-coded field no's.
2018-04-30 23:04:25 +05:30
576920bf8c
custom fields: Add frontend validations in textual custom fields.
...
Add validations for short and long textual custom fields in
frontend.
2018-04-30 23:04:25 +05:30
50b13219a3
webpack: Combine both js and css into one portico bundle.
...
Combines, both portico js and css into one bundle. This for now solve
the issue of an empty js bundle being generated by webpack for the
portico-styles stylesheet.
2018-04-30 10:23:39 -07:00
5e63e6061b
custom fields: Add UI for custom field hint.
...
Fixes #8876
2018-04-30 10:14:50 -07:00
639fa0db77
zblueslip: Convert node_tests/narrow_state.js to zblueslip.
2018-04-30 10:12:55 -07:00
a87123ec23
zblueslip: Convert node_tests/input_pill.js to zblueslip.
2018-04-30 10:12:55 -07:00
aa0c9a1a2a
zblueslip: Convert node_tests/dict.js to zblueslip.
2018-04-30 10:12:55 -07:00
65bb2f3c40
zblueslip: Convert node_tests/channel.js to zblueslip.
2018-04-30 10:12:55 -07:00
66759358e2
create stream: Add maxlength restriction on name and description.
2018-04-30 10:11:25 -07:00
a28adb0ba3
stream settings: Reset stream description on error.
...
Reset old value of stream description on error. This commit
also update the error message on updating stream name and
description.
2018-04-30 10:11:25 -07:00
Steve Howell
Tim Abbott
Rohitt Vashishtha
gooca
Vishnu Ks
Rhea Parekh
Angelika Serwa
Shubham Padia
Yashashvi Dave
Priyank Patel