Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
32,473 Commits 28 Branches 143 Tags 623 MiB
Commit Graph

8288 Commits

Author SHA1 Message Date
Anders Kaseorg 3c3471b720 templates: Rename *.handlebars ↦ *.hbs and - ↦ _. 
Tweaked by tabbott to avoid accidentally disabling the linter for
handlebars templates.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-12 21:11:03 -07:00
Cynthia Lin e5d0448505 user settings: Improve accessibility for new delete profile picture button. 2019-07-12 16:53:25 -07:00
Cynthia Lin ffaa0ee120 styles: Refactor #user-settings-avatar elements to use SCSS nesting feature. 2019-07-12 16:53:25 -07:00
Cynthia Lin 886deaf48d styles: Remove superflous .white-color class. 
Class was only used in one location, rendering it unnecessary.
 2019-07-12 16:53:25 -07:00
Cynthia Lin faa556ab5e user settings: Change delete profile picture button into a x icon. 
Fixes part of #10255.
 2019-07-12 16:53:25 -07:00
Cynthia Lin c4f510b724 styles: Refactor #user_presences li selectors to use SCSS nesting. 2019-07-12 16:34:06 -07:00
Cynthia Lin 2694dd7e24 styles: Reorder #user_presences li selectors for SCSS nesting. 2019-07-12 16:25:40 -07:00
Cynthia Lin ff2db8cf93 styles: Eliminiate duplicate selector for user/group PM circles. 2019-07-12 16:25:40 -07:00
Tim Abbott e8e420bbd9 markdown: Fix marked generation of unnecessarily absolute URLs. 
The new versions should exactly match the HTML we generate in the
backend unit test suite.
 2019-07-11 15:09:38 -07:00
Rohitt Vashishtha e68f90db9c topic-mention: Support updating old renders on stream rename. 2019-07-11 14:53:10 -07:00
Rohitt Vashishtha 3698cdcc58 topic-mention: Add Marked implementation as HandleStreamTopic. 2019-07-11 14:53:10 -07:00
Yashashvi Dave ff75c77f7a account settings: Replace logic with existing functions. 
Replace settings api calls with existing function
`settings_ui.do_settings_change()`. This commit also
adds a ui element for save alert notificaiton.
 2019-07-11 13:29:08 -07:00
Yashashvi Dave e2e7d288a5 user settings: Fix garbage full name in change-full-name modal. 
We should set full name evertime we open the modal. Otherwise
it will show garbage value which user has entered before but
did not save.
 2019-07-11 13:17:59 -07:00
Yashashvi Dave ecddc10272 user setting: Fix error message style in change user info modals. 
This commit fixes style of error message in update-user-info
modals. Commit adds error message element in modal body and
fixes margin.
 2019-07-11 13:17:42 -07:00
Yashashvi Dave da2b80c173 custom field: Make external-custom-field URL input wider. 2019-07-11 12:52:21 -07:00
Yashashvi Dave 27ead227c0 custom fields: Add separate alert-save widget for create field. 
Add separate alert-notification widget for create-custom-field
in admin view.

Fixes part of #12748
 2019-07-11 12:52:21 -07:00
Vaibhav 81a7467441 css: Nest `.subscriber-list` inside `.subscriber_list_container`. 2019-07-11 12:23:42 -07:00
Vaibhav 52027af52a css: Nest `.subscriber_list_container` inside `.subscriber-list-box`. 2019-07-11 12:23:42 -07:00
Vaibhav 57aedf0a46 css: Use SCSS nesting for `.subscriber_list_container`. 2019-07-11 12:23:42 -07:00
Vaibhav f27031925a css: Use SCSS nesting for `.subscriber-list`. 2019-07-11 12:23:42 -07:00
Vaibhav 39f6d0a71b css: Reorder subscriptions.scss so `.subscriber-list` are in same place. 2019-07-11 12:23:42 -07:00
Tim Abbott 4aeb399315 apps: Fix buggy toggling with version_info.show_instructions. 
We were doing the seemingly innocent
.toggle(version_info.show_instructions) to show the instructions if
and only if show_instructions was true.  However, our data structures
that should have been false didn't set a value, and `.toggle` with no
arguments just flips the state, rather than unconditionally hiding.
 2019-07-11 11:48:24 -07:00
Rishi Gupta 8b729cc5fb portico: Add links from /features to /help. 
I left out the top section ("Beautiful messaging") because the styling would
have to be different.
 2019-07-10 17:39:27 -07:00
Yashashvi Dave a8bdbcab04 settings: Fix bug setting-save-alert-notification don't fade out. 
Fix but by fixing parameters passed to function.
 2019-07-10 14:41:26 -07:00
Rohitt Vashishtha f507a1a1d9 portico: Remove scroll-to attribute support. 
This feature was added in 3b55519b11
without any uses of it in the markup, and we do not appear to use
scroll-to anywhere in our portico pages.
 2019-07-10 13:12:07 -07:00
Rohitt Vashishtha d649dce468 portico: Remove event handler on anchor tags. 
We added custom event handlers on anchor tags to show transitions
when switching between pages, a behaviour we have since removes in
commit a0dacea811.

Our approach didn't respect the target attribute for links and other
defaults that browsers offer with links.

We can now safely remove the event handler and restore the default
behavior of anchor tags.
 2019-07-10 13:12:00 -07:00
Rishi Gupta 90ff757f78 settings: Add some clarification around user groups. 2019-07-10 12:26:38 -07:00
Rishi Gupta 5ecfcb0651 settings: Add a few (?) links to /help articles. 2019-07-10 12:26:38 -07:00
Rishi Gupta c8d6cfa9b0 settings: Note that alert words are not case sensitive. 
Hopefully people translating to languages that don't have case will know to
ignore this second sentence.
 2019-07-10 12:26:38 -07:00
Vaibhav 239278ed90 css: Use SCSS nesting for `.stream-row`. 2019-07-10 11:30:56 -07:00
Vaibhav 95dbe28aeb css: Use SCSS nesting for `.stream-row .sub-info-box`. 2019-07-10 11:30:42 -07:00
Vaibhav b5bd0fd4f4 css: Reorder subscriptions.scss to group `sub-info-box *`. 2019-07-10 11:30:36 -07:00
Anders Kaseorg 218c60ae86 third: Upgrade spectrum-colorpicker to 1.8.0 from NPM. 
We had several patches to spectrum, but the only essential one 
(0ea770fc18) had already been fixed upstream,
and another was just handling jQuery deprecation warnings for not yet removed features.

See #12749 for details.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-10 10:07:34 -07:00
Tim Abbott 5c32e2ff49 popovers: Fix migration to popovers.hide_all_except_sidebars(). 
I'm not really sure how I missed this in the original commit.
 2019-07-09 23:03:41 -07:00
Yashashvi Dave 9c35b864fd input pills: Update style for non editable pills. 
For non editable input pills, add background color
to be transparent and padding to 0px.
 2019-07-09 17:21:54 -07:00
Yashashvi Dave 5be2207bf8 user settings: Fix custom URL field style in profile form. 
Type of input element in profile form was not defined for
URL type custom fields. Because type was not passed to
template.
 2019-07-09 17:21:54 -07:00
Yashashvi Dave d7ee2aced1 models: Add `external_account` in custom profile field types. 
Add new custom profile field type, External account.
External account field links user's social media
profile with account. e.g. GitHub, Twitter, etc.

Fixes part of #12302
 2019-07-09 17:21:54 -07:00
Yashashvi Dave 3368589df2 settings_profile_fields: Refactor function `read_field_data_from_form`. 2019-07-09 17:21:54 -07:00
Anders Kaseorg bbf45593cb blueslip: Ignore error events with null error. 
Chrome generates these to report things like “ResizeObserver loop
limit exceeded” (which is harmless).

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-09 17:18:32 -07:00
Tim Abbott f5b1081c93 popovers: Fix name for stream_popover.hide_streamlist_sidebar(). 
The previous name was super confusing; this function is analogous to
hide_userlist_sidebar() and should be named appropriately for that role.
 2019-07-09 16:57:10 -07:00
Tim Abbott 01bc4674e3 popovers: Fix closing of the left sidebar with "more topics". 
This was another case of incorrect logic due to treating the sidebars
as popovers for the purposes of .hide_all().

Fixes #12274.
 2019-07-09 16:54:39 -07:00
vinitS101 f86a41da4b left_sidebar: Fix click target of links in the top left sidebar. 
Fixes the click targets for the four links in the top left side bar
(All messages, Private messages, Mentions and Starred messages).
The click target now cover the whole row for these links.

Fixes #12449
 2019-07-09 13:12:10 -07:00
Yashashvi Dave ecad54e9f1 org settings: Add `wrapped-table` class in deactivated user table. 
Fix style of deactivated user table list in org setting,
by adding `wrapped-table` class style to table.
 2019-07-09 13:07:35 -07:00
Yashashvi Dave fa5d6bb2d6 org settings: Display deactivated-user section to all. 
Fixes #12290
 2019-07-09 13:07:35 -07:00
Yashashvi Dave 6fddc86cf2 org settings: Remove strikethrough from deactivated-user setting. 
Remove strickethrough and append text to user role.
 2019-07-09 13:07:35 -07:00
Yashashvi Dave 1880075f81 static/js/settings_users: Remove unnecessary function from page load. 2019-07-09 13:07:35 -07:00
Yashashvi Dave 5a3f1e20ec static/js/settings_users: Replace logic with existing function. 2019-07-09 13:07:35 -07:00
Vaibhav f9d9eca295 css: Nest `.colorpicker-container` inside `.streams_popover`. 2019-07-09 11:43:04 -07:00
Vaibhav d68fcfdb88 css: Nest `sp-container` in `.colorpicker-container` for `.streams_popover`. 2019-07-09 11:43:04 -07:00
Vaibhav 84489a8d80 css: Nest `.sp-palette-container` in `.sp-container` for `.streams_popover`. 2019-07-09 11:43:04 -07:00