Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

portico: Remove event handler on anchor tags. 

We added custom event handlers on anchor tags to show transitions
when switching between pages, a behaviour we have since removes in
commit a0dacea811.

Our approach didn't respect the target attribute for links and other
defaults that browsers offer with links.

We can now safely remove the event handler and restore the default
behavior of anchor tags.
This commit is contained in:
Rohitt Vashishtha 2019-07-10 18:49:00 +00:00 committed by Tim Abbott
parent 52a8de0898
commit d649dce468
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/portico/landing-page.js
View File

@ -154,27 +154,6 @@ var apps_events = function () {
var events = function () {
ScrollTo();
$("a").click(function (e) {
// if a user is holding the CMD/CTRL key while clicking a link, they
// want to open the link in another browser tab which means that we
// should preserve the state of this one. Return out, and don't fade
// the page.
if (e.metaKey || e.ctrlKey) {
return;
}
// if the pathname is different than what we are already on, run the
// custom transition function.
if (window.location.pathname !== this.pathname && !this.hasAttribute("download") &&
!/no-action/.test(this.className)) {
e.preventDefault();
setTimeout(function () {
window.location.href = $(this).attr("href");
}.bind(this), 500);
}
});
// get the location url like `zulipchat.com/features/`, cut off the trailing
// `/` and then split by `/` to get ["zulipchat.com", "features"], then
// pop the last element to get the current section (eg. `features`).