Tim Abbott
bdc95b5d72
slack webhooks: Eliminate unnecessary use of Service model.
...
The user ID of the bot user is a much more useful value to be sending
to the third-party API here.
2018-07-23 08:12:08 -07:00
Rhea Parekh
b6ce93e029
outgoing webhooks: Fix sample values for slack outgoing webhooks.
...
This switches us to use the correct timestamp, service_id and token
formats. The 'service_id' should be the ID of the bot user. The token
should be a sample token generated from 'random_api_key()'.
2018-07-23 08:07:56 -07:00
Harshit Bansal
bf70955c0c
emoji: Update `emoji-datasource` packages.
...
This commit updates the `emoji-datasource` packages to version 4.0.4.
This update brings following changes to emoji infra:
1: Fix for the bleeding sprite sheets.
2: The category of some emojis has been changed. Categorywise breakup of
net gain or loss is as follows:
Travel & Places: 58 (gain)
Symbols: 47 (loss)
Smileys & People: 52 (gain)
Objects: 11 (loss)
Food & Drink: 3 (gain)
Animals and Nature: 46 (gain)
Activities: 9 (loss)
3: There were some changes in the image farm of the package which were
breaking our old emoji farm. I fixed them by modifying the remapped
emoji map.
Fixes : #8235 .
2018-07-23 08:04:58 -07:00
Harshit Bansal
6c28a60db0
emoji: Hardcode octopus emoji.
...
Google emojiset's octopus is really cute and whole Zulip community
loves it. So using a CSS hack, we hardcode octopus emoji to use image
from Google's emojiset only irrespective of the choosen emojiset.
2018-07-23 08:04:58 -07:00
Harshit Bansal
3f73826ffa
emoji: Extract `get_emoji_code()`.
2018-07-23 08:04:58 -07:00
Harshit Bansal
69eaa2de67
emoji: Move `remapped_emojis` list to emoji_setup_utils.py.
2018-07-23 08:04:58 -07:00
Joshua Pan
015bc8b01e
tests: Reach 100% coverage for keydown_util.
...
This commit pretty much just gets line coverage.
2018-07-23 08:42:11 -04:00
Akash Nimare
5f4895f780
user-groups: Centre align popover content.
2018-07-22 20:14:29 -07:00
Shubham Padia
3125fab756
right-sidebar: Add title attribute to `userlist-toggle`.
...
Fixes #9785 .
The userlist-toggle icon is visible for smaller screens and was
missing a title attribute.
2018-07-22 20:01:45 -07:00
Shubham Padia
f574790b09
left-sidebar: Add title attribute to `streamlist-toggle`.
...
The streamlist-toggle icon is visible for smaller screens and was
missing a title attribute.
2018-07-22 20:01:45 -07:00
Vishnu Ks
2b28042ddf
models: Rename remaining audit log event types to past tense.
...
This makes the realm audit event type log entries more consistent.
2018-07-22 20:00:28 -07:00
Vishnu Ks
28167585b1
models: Rename several RealmAuditlog event types to past tense.
...
These event types haven't been used in production yet, and thus are
save to change without a migration.
2018-07-22 20:00:05 -07:00
amanagr
2d5ef27874
message-model: Add `zulipterminal` to sent_by_human clients.
...
Tweaked by tabbott to also more fully document this feature.
2018-07-22 12:32:55 -07:00
Cynthia Lin
84a977967b
subs: Fix regression in Filter streams input focus during modal opening.
...
This behavior was originally implemented in commit 6993f89
, but due to not
specifying a toggle option, the Subscribed/All streams switcher tab was
focused after the input was focused, leading to the input's loss of focus.
Fixes #9981 .
2018-07-22 10:20:44 -04:00
Joshua Pan
0596632457
lint: Exclude frontend_tests/node_tests from $().text rule.
2018-07-20 12:13:56 -07:00
Lyla Fischer
ccba727919
user docs: Update mute-a-topic.md.
2018-07-20 10:10:17 -07:00
Lyla Fischer
e07bf51fc9
user docs: Update the message-actions template.
2018-07-20 10:10:17 -07:00
Steve Howell
b9c9dd9b5a
lint: Turn off the CSS checker (officially).
...
Our CSS checker globs for .css files. Since the
SCSS cutover, it has been a no-op, so there's no
sense launching it. See #8894 for details on
future plans.
2018-07-20 10:03:28 -04:00
Lyla Fischer
010dbcc49f
user docs: Trim language in mute-a-stream.
2018-07-20 07:59:29 +05:30
Lyla Fischer
5a588353c1
user docs: Fix some wording in desktop notifications doc.
2018-07-20 07:24:49 +05:30
Abhigyan Khaund
29a95f3cbf
desktop: Update app version to v2.3.3.
2018-07-19 10:54:58 -07:00
Anders Kaseorg
a0293e8a86
zerver/lib/import_realm.py: Avoid shelling out for mkdir.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
195cc78470
zerver/lib/cache.py: Avoid shelling out for mkdir.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
8698198452
tools/update-authors-json: Avoid shelling out for cp.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
6a8f0165ee
tools/test-help-documentation: Avoid shelling out for mkdir.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
f01942e510
tools/test-emoji-name-scripts: Avoid shelling out for cp.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
07f5b81406
tools/minify-js: Avoid shelling out for mkdir, cp.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
2d12b5b3d9
tools/diagnose: Avoid shelling out for pwd.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
09b8ccd510
scripts/nagios/check-rabbitmq-consumers: Avoid shelling out for mv.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
dbe65231fc
puppet/zulip/files/nagios_plugins/zulip_app_frontend/check_send_receive_time: Avoid shelling out for mv.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
f15cef27db
frontend_tests/run-casper: Avoid shelling out for mkdir, rm.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Anders Kaseorg
8d52f0e0c0
analytics/management/commands/check_analytics_state.py: Avoid shelling out for mv.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-19 10:43:37 -07:00
Lyla Fischer
f3b0b8edc8
user docs: Remove the admin.md macro.
2018-07-19 22:30:51 +05:30
Rishi Gupta
b6d1b956f2
user docs: Rename restrict-editing-of-old-messages-and-topics.
2018-07-19 22:30:51 +05:30
Rishi Gupta
5ab373f714
user docs: Update article on configuring message editing and deletion.
2018-07-19 22:30:51 +05:30
Lyla Fischer
efe22d339a
user docs: Update disable-message-edit-history.
2018-07-19 22:30:51 +05:30
Lyla Fischer
ad5f7a912e
user docs: Update deactivate-or-reactivate-a-user.
2018-07-19 22:30:51 +05:30
Rishi Gupta
b514cf66a1
user docs: Remove only-allow-admins-to-invite-new-users.
...
The information here was recently added to
manage-who-can-join-and-invite.md.
2018-07-19 22:25:58 +05:30
Rishi Gupta
72c0b57aa3
user docs: Remove allow-anyone-to-join-without-an-invitation.
...
The information here was recently added to manage-who-can-join-and-invite.
Arguably this is one we should save, since it is a distinctive feature not
offered by all of our competitors, and it gets some additional visibility by
being in the left sidebar. The model of having multiple things in the
sidebar pointing to the same article is getting messy though, and as our
feature count increases the cost of having stuff in the left sidebar is
increasing as well.
2018-07-19 22:25:58 +05:30
Rishi Gupta
eab1142200
user docs: Remove restrict-user-email-addresses-to-certain-domains.
...
The information from this doc was recently added to
manage-who-can-join-and-invite.md.
2018-07-19 22:25:58 +05:30
Rishi Gupta
ce1875533e
user docs: Add manage-who-can-join-and-invite.md.
...
As we add more and more features, we'll want to consolidate articles into
feature bundles.
2018-07-19 22:25:58 +05:30
Lyla Fischer
c301148e5a
user docs: Update join-zulip-chat-badge.
2018-07-19 22:20:53 +05:30
Steve Howell
5d0a113634
minor: Add assertion to assert_realm_values() helper.
2018-07-19 12:07:11 -04:00
Tim Abbott
f228eabd90
install: Make sure the en_US.UTF-8 locale is available.
...
We need to make sure the en_US.UTF-8 locale has been generated before
setting the locale via the environment.
Fixes part of #9946 .
2018-07-18 15:05:27 -07:00
Anders Kaseorg
f5d44e7355
Fork django-bitfield to save a few hundred ms of startup time
...
See #9953 , https://github.com/zulip/django-bitfield/pull/1 .
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2018-07-18 15:24:15 -04:00
Marco Burstein
11cbe2bf6a
lightbox: Fix a "Pan & Zoom" causing an error with thumbnailed images.
...
Images on the new thumbnailing system generate an error when
"Pan & Zoom" is enabled:
Browser Error: Lightbox for unknown message undefined
39648: http://localhost:9991/webpack/app.js
| Object.blueslip_error [as error]
50743: http://localhost:9991/webpack/app.js
| Object../static/js/lightbox.js.exports.open
50897: http://localhost:9991/webpack/app.js
| HTMLDivElement.
39474: http://localhost:9991/webpack/app.js
| HTMLDivElement.blueslip_wrapper
16299: http://localhost:9991/webpack/app.js
| HTMLDivElement.dispatch
16107: http://localhost:9991/webpack/app.js
| HTMLDivElement.elemData.handle
To fix this, instead of using the `src` attribute as the key for
`asset_map`, which can be either the original or thumbnailed version
depending on the situation, always use the original version.
Also, create `frontend_tests/node_tests/lightbox.js` to test this
functionality.
Fix #9955 .
2018-07-18 10:19:56 -07:00
Marco Burstein
a6939a5078
lightbox: Fix lightbox not showing new thumbnails as selected.
...
The current code for detecting which image to add the `selected` class
to is `preview_source.match(src)`. With the new thumbnails, this no
longer works because thumbnail URLs include a `?`, which has its own
RegEx significance. To solve this, check for equality instead of using
RegExes.
2018-07-18 10:19:56 -07:00
Lyla Fischer
9149ac1cf4
user docs: Update default language doc.
2018-07-18 20:21:37 +05:30
Joshua Pan
2ccc7711ae
tests: Test adding alert words ui.
2018-07-18 08:35:42 -04:00
Joshua Pan
c485bdf05d
tests: Cover render_alert_words_ui().
2018-07-18 08:35:42 -04:00