Commit Graph

5721 Commits

Author SHA1 Message Date
Steve Howell c15c7d7633 Fix whitespace in CSS code
(imported from commit 4b323781a0ef9ef63cd57ada3df8d50985b3f71c)
2013-07-25 12:27:21 -04:00
Steve Howell 3430bc8ff3 Remove unused parameter in get_topic_suggestions()
(imported from commit d32cf560376d2b96b1b974a27158aba5ac6401d3)
2013-07-25 12:17:14 -04:00
Steve Howell 6e0b6dfc24 Organize navigation events in hotkey.js
(imported from commit 2bff0eb8bf7f8f310a5823bc4a569a7b298608c9)
2013-07-24 23:39:35 -04:00
Steve Howell 432f9794cb Extract go_to_row() helper in navigate.js
(imported from commit a2e991c4df4df36a3f1df311a0cc6829eb1c3db2)
2013-07-24 23:39:35 -04:00
Steve Howell fad259d75d Move code from hotkey.js -> navigate.js.
Created up, down, page_up, page_down, to_home, and to_home pretty
mechanically from the old hotkey.code.

(imported from commit 5956b91c2e0122c6440f70db9b92f918c9b599aa)
2013-07-24 23:39:35 -04:00
Waseem Daher c0c63d3506 Some /integrations language tweaks.
(imported from commit 3f647dd6d5f72301036da7e1f75756fd19b8b8cb)
2013-07-24 17:47:56 -04:00
Kevin Mehall eb6bc91c22 New Relic integration
(imported from commit a108f4c6e90d857263453036f6d5f09279302b7e)
2013-07-24 17:19:36 -04:00
Waseem Daher 04ad610263 Restore old mix-protection mechanism.
This is the moral equivalent of reverting
25ac8c557978a3867eba90d93857d9bd728149e2

(imported from commit dc9ac79c2bed46b836bf666d3718f3bcac11099e)
2013-07-24 17:09:36 -04:00
Tim Abbott 4e1434b28d Use update_fields more consistently when modifying model objects.
(imported from commit a3f0c308b621b5ff85c55654f187e25749192b19)
2013-07-24 17:04:39 -04:00
Luke Faraone f800e6cebb Document message and subject length requirements
LENGTH LIMIT RULES
    This limit is non-refundable unless issued at a fully refundable fare.
    Some fares may not allow changes. If allowed, any change to your
    itinerary may require payment of a change fee and increased fare.
    Failure to appear for any personal message without notice to Zulip will
    result in cancellation of your remaining reservation.

(imported from commit 75d5843677ce959d60d4015779efa9c2cf8f9a1c)
2013-07-24 16:38:17 -04:00
Leo Franchi e8a56a22e6 Use new key for git.hhq.com in install-server, and typo fixes
(imported from commit 23b69d23be24f2d995b70e03e1e7e6e604407877)
2013-07-24 16:06:34 -04:00
Leo Franchi bb2df13bfd Unset -e flag during humbug.pem login to preserve idempotency of install-server
(imported from commit d65b635a48ce33908b2888319a7c109d5d126b54)
2013-07-24 16:06:34 -04:00
Tim Abbott b5eab2bde5 Fix UnreadCountTests to not be checking empty sets.
Because there's no guarantee that Hamlet has message IDs 1 and 2, and
the update_unread_counts function didn't return an error in the event
that you passed it a message that the user never received (it instead
silently succeeded), this test was mostly useless.

I just dumped the test_initial_counts function, because it didn't seem
to be doing anything useful.

(imported from commit 4d76104eb9f3b947727a1a030afc0b57054d0daf)
2013-07-24 15:43:44 -04:00
Tim Abbott 508332da0d tests: Return more than a radius of 1 in get_old_messages.
Otherwise everything breaks if we happen to have more than
approximately 2 messages.

(imported from commit 94c5bda1f69daac437c685e8f19c8a10dbd68e52)
2013-07-24 15:43:44 -04:00
Tim Abbott afb952ae99 tests: Return the message object in send_message.
(imported from commit baa26b8b2ab16f5e533b8f1606ceff5e50f275f5)
2013-07-24 15:43:44 -04:00
Tim Abbott 270110d8a4 check-all: Fix output for jslint failures.
(imported from commit 1398eea533e4b8b273d3984d9872ef3706c1102e)
2013-07-24 15:43:44 -04:00
Waseem Daher 1303327e0c Fix settings dropdown on mobile devices.
Issue reported by user1@customer34.invalid

(imported from commit b3efa08ac7b4249652a6cd0376aa21217c0435fc)
2013-07-24 15:08:40 -04:00
Steve Howell 312452f174 Show 'subset' search suggestions last
(imported from commit 849e151cfeb56b288419e12621d122327e619023)
2013-07-24 13:39:21 -04:00
Steve Howell 782e2d43bf Reverse order of 'subset' search suggestions
(imported from commit 1e5f84e8ea3c5a1ec27eaeaada60db720ccd58cd)
2013-07-24 13:39:21 -04:00
Kevin Mehall f88571f482 Comments documenting the ordering requirements of MessageList._render steps.
(imported from commit 16a493a957e166ee529b9dd8d630cc1717e93456)
2013-07-24 11:48:39 -04:00
Kevin Mehall dfda1d3137 Fix collapse issue introduced by ca50035 while keeping the effect of its fix.
That commit intended to fix a bug where it jumps to the wrong scroll position
(offset by the difference in height from uncollapsed to collapsed) if you load
collapsed messages at the top, either by scrolling up or when it automatically
fetches more 10s after page load, because before, it updated the scroll
position before processing collapsing, which changes the height of messages.

Updating collapsing needs to happen before the viewport is adjusted, but also
needs to happen after the new messages get appended/prepended to the document
because they need to be attached to the document for getClientBoundingRect to
work.

(imported from commit 44d6a6135524e658084ffcf7d880ba898b577e6d)
2013-07-24 11:06:18 -04:00
Jessica McKellar f647596cbb Add a CSS class to unfaded messages.
We already have one for faded messages (which this commit simplifies),
but we also need one on unfaded messages to facilitate styling
experiments.

(imported from commit 41a6e2ef136ce73ce8c24de1e35199244ce56d37)
2013-07-23 21:45:07 -04:00
Kevin Mehall 5f3dcfd104 Make the edit form keep the text in the same place as the normal message.
Trac #1540

    * Make edit content box the same width as normal content
    * Scroll to compensate for the added padding and "Topic" field.
    * Restore the scroll position when exiting edit

It's off by 1px on Firefox 22, but Firefox is simply wrong.

(imported from commit 49154f51b538c648934a41a4a7a217198186ede2)
2013-07-23 18:09:05 -04:00
Scott Feeney c234190bc0 Make stack trace annotation work
The code now unminifies all calls in the stack, including those outside
of app.js.

This requires the Python package sourcemap, recently added as a
dependency.

(imported from commit 550c73ad5bfe78a2c7169c11da0c95cbaac238d7)
2013-07-23 16:34:26 -04:00
Scott Feeney 4b9c82fb97 Insert static_header.txt as a Closure input file
This way its presence doesn't throw off the generated source map.

(imported from commit 4d7cbb7cb3a9ce103a836ea9baa990c88fe5c804)
2013-07-23 16:18:00 -04:00
Scott Feeney e539d6b2ac [manual] Add python-sourcemap dependency
(imported from commit 784cfa09ecea58f479adb0b17906a4d0ec10f618)
2013-07-23 15:57:07 -04:00
Scott Feeney 0a3d24826e Zulipify the review script
* CC to code-review@zulip.com
* If domains are omitted, assume @zulip.com
* Don't set email or site explicitly, instead relying on ~/.humbugrc

(imported from commit 9700a0e3d6aac97c8030dcbaba7790018173929a)
2013-07-23 14:53:34 -04:00
Scott Feeney 1e8881d21a Accept zulip.com emails in post-commit hook
(imported from commit 783aec2bf0613ef962afa48614d56d3f81d54e38)
2013-07-23 14:50:39 -04:00
Tim Abbott 9dbbdb1cdf Avoid get_updates failing to update following bugged update_person events.
(imported from commit 7785277ab967a67135e1bd4aa226a0d64adccaba)
2013-07-23 14:26:33 -04:00
Tim Abbott 9132baacc2 Update settings.py for our current app server hostnames.
(imported from commit a8f72faf2c0204c2e86d641da5eb81b57e935183)
2013-07-23 14:26:33 -04:00
Waseem Daher 32fd11c74c Restore "Font Awesome" inclusion in the portico.
(imported from commit 0e49205a995d4b52ab1170eaf96b49d4cab47515)
2013-07-23 13:38:20 -04:00
Steve Howell ffa178cf7a Suggest "widening" searches in search autocomplete.
This will allow you to always get Home from the search box,
as well as easily backing out narrows.

(imported from commit 68bcfc83ce0428645f4e734ae46f9589cb562a86)
2013-07-23 13:18:33 -04:00
Jeff Arnold 4b69094ffd For <= 1 message selections, convert emoji into text
<= 1 message selections previously were not being handled
by copy_handler at all

(imported from commit 031ab4ce6db4b1aae4ea202611d09066c87f0faa)
2013-07-23 12:29:52 -04:00
Jeff Arnold ee3806ef5b In the desktop app, paste emoji as text to work around webkit bug
See Trac #1060

(imported from commit 860f16c5a9db626a4fd2d55bcb0dd137e5196560)
2013-07-23 12:25:59 -04:00
Waseem Daher 6cd0b0468d Document Trello integration.
(imported from commit ac28965d1bd0de49a9902c4650e4f5d7835f65cc)
2013-07-23 11:50:31 -04:00
Tim Abbott 508ddca539 puppet: Specify commands for restarting supervisord.
(imported from commit e1a6322fd9ecf1655ec4325d0fcaf0ad160202ae)
2013-07-23 11:30:46 -04:00
Kevin Mehall 1acc865d19 Don't save the pointer position in the reload after bankruptcy.
(imported from commit b09550d44c0264d7754c47cfd80f1a3639b04b5d)
2013-07-23 11:14:50 -04:00
Steve Howell ba35a7118c Reset search string in ALL cases when you blur the search box.
Until now, we would reset the search string when you aborted
a search, but only if you are in the home view.  Now, we reset
it always.  This makes the search box an accurate reflection of
your narrow.

(imported from commit bed6adce54a55648165c84118d430c44abb5949f)
2013-07-23 10:35:09 -04:00
Steve Howell 65101816d3 Use naturalSearch option for search typeaheads
(imported from commit 0e0b71fbcdb590d40c843ca310100f9fd72e758e)
2013-07-23 10:35:09 -04:00
Steve Howell dc85fa7cf2 Support naturalSearch option in typeahead.
The naturalSearch option immediately updates the search box with
the underlying value of a search suggestion when the user moves to
it.

(imported from commit ad5cb5c2591ef4f71a6d648c8839f288cc125cf7)
2013-07-23 10:35:09 -04:00
Waseem Daher 49619a85dc Give "faded out" messages transparent backgrounds.
This hopefully makes them look less active while still preserving
their readability.

(imported from commit 25ac8c557978a3867eba90d93857d9bd728149e2)
2013-07-22 18:05:40 -04:00
Steve Howell 35c3488bbe Suggest a max of 10 topics in search
(imported from commit 10a70d20edf4f0fe74a1597f46c50e4445cf3da3)
2013-07-22 18:01:27 -04:00
Steve Howell ce4393ef0f Put people-specific search suggestions first
(imported from commit 0daf24af2f91860556dedda9a21f476d1bb3c855)
2013-07-22 17:49:12 -04:00
Steve Howell 369bc02f45 Limit people in search suggestions
(imported from commit 655201100b3a9c39ffd053fd744938b5c5eb75dd)
2013-07-22 17:36:03 -04:00
Steve Howell 8c4982de82 Limit search suggestions to 30
(imported from commit f6c6e6dce11f39fc3fc69d85bd41fbadd78013a0)
2013-07-22 17:36:03 -04:00
Tim Abbott 776f46edd7 Send a Tornado notification when activating users.
(imported from commit d51655979b3fb3929b3b4cb5e616c93016e7dc83)
2013-07-22 17:24:48 -04:00
Jeff Arnold e35cebd821 Include emoji as plain text in desktop notifications
(imported from commit 26c76ae3420c02b677bcacc4dd0a05797f4f8541)
2013-07-22 16:33:27 -04:00
Jeff Arnold 5190a9692a Hide text for the > icon so that copy paste captures it
Addresses Trac #1296

(imported from commit 650672b971f18b4e1bfb185987768b55504ee1e8)
2013-07-22 16:33:27 -04:00
Steve Howell 6998d0c427 search autocomplete: Show pm-with suggestions when in a PM context.
If you are narrowed to "Private messages", we show you suggestions
of people.  If you are narrows to pm-with, we show you a suggestion
to get back to is:private.

(imported from commit 18405beb1e194514618365d9f913972121c64d12)
2013-07-22 16:05:37 -04:00
Steve Howell 62ad1a86e4 Suggest 'Sent by me' in searches.
(imported from commit 66867191fcc1073fda974c26411cdbb2f00e4efe)
2013-07-22 16:05:37 -04:00