9492bd37b4
docs-test: Fix documentation links.
...
- Fix internal documentation links and anchors according last project documentation version.
Fixes #1492
2016-10-22 19:30:24 -07:00
a32eaf28c0
docs: Remove broken indices and tables index section.
...
None of these links worked properly.
2016-10-22 19:23:11 -07:00
4352790795
docs: Fix broken link in node testing docs.
2016-10-22 19:21:19 -07:00
87d22c9e4d
analytics: Fix count_stream_by_realm.
...
Add a join clause on zerver_message in count_stream_by_realm,
otherwise we only output the final total streamcount for a realm
for every time entry.
2016-10-22 19:10:36 -07:00
49b23ea84a
frontend: Allow users to see the source of messages they can't edit.
...
Previously we showed an "Edit" item in the actions popover menu when a user
could edit the content or topic of a message, and nothing otherwise. We now
show "Edit", "Edit Topic", or "View Source" in the popover menu for every
message, depending on the editability of the message, and present an
appropriate version of message_edit_form when the menu item is clicked.
Finishes #1604 and #1761 .
2016-10-22 18:53:59 -07:00
879f2a1e2e
message editing: Refactor editability computation to use editability_types.
...
We compute the editability of messages in several places around the
frontend; standardize the definitions and store in
message_edit.get_editability. This commit should not change app behavior.
2016-10-22 18:52:49 -07:00
c2c389e949
message_edit.js: Refactor edit_message.
...
Cleanup and re-organize edit_message in preparation for the view source
changes. There are no behavior or logic changes in this commit.
2016-10-22 18:52:49 -07:00
bd416c0425
message_edit: Cleanup unnecessary 2-layer nesting.
2016-10-22 18:52:49 -07:00
5b3caa4d18
message_edit: Fix tooltip with multiple messages being edited.
...
This fixes an issue where if there were multiple messages being
edited, all of them would have the same tooltip content.
2016-10-22 18:52:49 -07:00
5b656db303
message_edit: Clean up tooltip creation code.
...
This contains no functional changes.
2016-10-22 18:52:49 -07:00
0ccf8b162e
message_edit: Move topic-editing-only warning.
...
This makes no functional change, because
`page_params.realm_message_content_edit_limit_seconds === 0` means
can_edit_content is always true.
2016-10-22 18:52:49 -07:00
d5c3ad8eb5
message_edit: Only initialize composebox_typeahead if needed.
2016-10-22 18:52:49 -07:00
76d49300b3
message_edit: Move original_topic variable to a better spot.
2016-10-22 18:52:49 -07:00
0acfcbe247
message_edit: Update currently_editing_messages in clearer place.
2016-10-22 18:52:49 -07:00
d2501396cf
message_edit: Reindent form definition.
2016-10-22 18:52:45 -07:00
2b58fa0a19
message_edit: Move some setup code closer to where it's used.
...
This has no functional changes.
2016-10-22 18:40:44 -07:00
ebc8bfa6ca
javascript: Change all message.is_stream to (message.type === "stream").
...
We need message.is_stream for some handlebars template code, but
message.is_stream should be thought of as a private variable for that
template.
2016-10-22 18:11:08 -07:00
c21fe60430
Add make_stream() to django testing docs.
2016-10-22 18:09:34 -07:00
4d6af33bad
Use make_stream() in test_subs.py.
2016-10-22 18:09:34 -07:00
2a739318b9
Use make_stream() in test_signup.py.
2016-10-22 18:09:34 -07:00
8410159af2
Use make_stream() in test_narrow.py.
2016-10-22 18:09:34 -07:00
b1ebb09c96
Use make_stream() in test_messages.py.
2016-10-22 18:09:34 -07:00
0861421912
Use make_stream() in test_events.py.
2016-10-22 18:09:34 -07:00
79b6f3d39d
Create ZulipTestCase.make_stream().
2016-10-22 18:09:34 -07:00
be903382f8
lint: Add rule to check for misspellings of 'GitHub'.
2016-10-22 17:09:55 -07:00
16c3da6db5
tests: Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER=False.
...
- Add tests for SEND_MISSED_MESSAGE_EMAILS_AS_USER is False (the
default!).
- Reorganized test case code by removing repeated parts of code,
improving code style and moving common parts to separate class
methods.
Fixes #1697 .
2016-10-21 08:47:24 -07:00
8891731d7d
is_template_database_current: Open file in write mode.
2016-10-21 08:35:30 -07:00
b894135fae
Check postgres-init-dev-db in is_template_database_current.
2016-10-21 08:35:30 -07:00
176825d335
Refactor is_template_database_current.
...
Now all the files whose hash is to be checked are passed as a list
argument.
2016-10-21 08:35:30 -07:00
bf4e0800e3
is_template_database_current: Create hashes in var/test_db_status.
2016-10-21 08:35:30 -07:00
a2c57db630
Use argparse in provision.py
2016-10-21 08:35:30 -07:00
8ade9e2408
Add tests to check subdomains with auth decorators.
...
Fixes : #1870
2016-10-21 12:21:47 +05:00
6e1674aca5
Normalize github issue or PR comment event's subject and content.
2016-10-20 23:15:51 -07:00
56dd1a9b90
Normalize gitlab issue event's subject and content.
2016-10-20 23:15:30 -07:00
a8da46db92
Normalize bitbucket issue event's subject and content.
2016-10-20 23:15:30 -07:00
171a4861cc
Normalize github issue event's subject and content.
2016-10-20 23:15:30 -07:00
89d53a0640
Change name of PR subject template to be applicable for issues.
2016-10-20 23:15:30 -07:00
289f400c8c
Add git integrations method to build message for issues events.
2016-10-20 23:15:30 -07:00
ee97ba04fe
Add an API endpoint to send typing notification events.
...
POST to /typing creates a typing event
Required parameters are 'op' ('start' or 'stop') and 'to' (recipient
emails). If there are multiple recipients, the 'to' parameter
should be a JSON string of the list of recipient emails.
The event created looks like:
{
'type': 'typing',
'op': 'start',
'sender': 'hamlet@zulip.com',
'recipients': [{
'id': 1,
'email': 'othello@zulip.com'
}]
}
2016-10-20 23:05:18 -07:00
bc6421fbfb
tools: Remove empty wrapper script build_emoji.
...
This renames the old `emoji_dump.py` to `build_emoji`, removing the
old shell essentially empty shell script. `emoji_dump.py` was always
a weird name, and this makes it a bit easier to read the code for this
system.
2016-10-20 22:57:45 -07:00
2083ffa7a6
docs: Improve export documentation.
...
Added user and realm export guidance in production maintenance docs,
linked to conversion guide, and revamped the introduction and styled
the text that Steve wrote.
2016-10-20 22:52:32 -07:00
d9d389f64f
docs: Add an initial code review document.
...
A first pass at a code review guide. Mostly Tim's draft; I added
polish and links.
Fixes : #758 .
2016-10-20 22:41:38 -07:00
f9f8b18e2f
lint: Ban use of json_success({}) instead of json_success().
2016-10-20 22:34:04 -07:00
3ee777a11a
Add UI for deactivating your own Zulip account.
...
Fixes #1009 .
2016-10-20 22:29:30 -07:00
3d183ffe23
text_fixtures: Fix case where source_hash_file doesn't exist.
...
We unfortunately just broke provisioning because we didn't correctly
handle the case where the source_hash_file didn't exist.
2016-10-20 22:21:45 -07:00
409a84698c
Handle peer_remove events correctly for subscriptions.
...
We now send peer_remove events to folks who have never subscribed
to the streams (except for private streams and zephyr).
We also use logic that is more similar to how
bulk_add_subscriptions() works.
2016-10-20 22:05:19 -07:00
68ae4da626
Extract query_all_subs_by_stream().
...
This code was in bulk_add_subscriptions, but we want the same logic
to eventually happen in bulk_remove_subscriptions.
2016-10-20 22:05:19 -07:00
d13b0554b3
Remove emails_by_stream in bulk_add_subscription().
...
There are so many collections in this function, it's hard to keep
them all straight. This one is fairly redundant, so it was easy
to remove.
2016-10-20 22:05:19 -07:00
d706bfa69f
Move some code from notify_subscriptions_removed().
...
There are two reasons for this change. First, we want to be
consistent with notify_subscriptions_added(), which doesn't
handle "peer" events. Second, we want to fix this code in a
subsequent commit not to do one user at a time, which is
inefficient.
2016-10-20 22:05:19 -07:00
dda4c61f2a
Remove do_remove_subscription().
2016-10-20 22:05:19 -07:00
K.Kanakhin
Tim Abbott
umkay
Rishi Gupta
Steve Howell
deekshaarul
Umair Khan
Tomasz Kolek
Arpith Siromoney
Prabhakar Gupta
Sumana Harihareswara
Amy Liu