916ea58aaf
settings: Remove unused classes from label elements.
...
This commit removes classes like "title", "input-label"
and "emoji-theme" from label elements in settings and
modals as these are classes are neither used in JS
nor to apply any CSS.
2024-05-03 09:51:36 -07:00
6f4a58fe71
settings: Place and style .settings-field-label on Profile.
2024-05-03 09:51:36 -07:00
10df1c414f
settings: Simplify field-hint selector.
2024-05-03 09:51:36 -07:00
8512ea124d
settings: Add variable for field/hint bottom margin.
2024-05-03 09:51:36 -07:00
29508e54b0
settings: Extend use of settings-profile-user-field-hint class.
2024-05-03 09:51:36 -07:00
38f51683a4
settings: Improve settings-profile-user-field-hint class.
...
This slight transposition makes it read closer to the adjacent
`settings-profile-user-field` class.
2024-05-03 09:51:36 -07:00
5d468ddef8
left_sidebar: Add colon `:` to the list of stream word separators.
2024-05-03 09:20:53 -07:00
65febced00
help: Remove description of transition from self-hosted billing page.
2024-05-03 09:18:42 -07:00
519c520c32
tippyjs: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
38f040ad79
search: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
33430f06c3
list_widget: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
f44d343511
invite: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7cd3a99aad
user_group_popover: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
57c6bfadf6
stream_list: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
ba7fd860b1
spoilers: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
43d83105c6
settings_invites: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
51f929d032
settings_emoji: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
343e80c6fa
recent_senders: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
6f18551b7a
signup: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
3e1736c776
narrow_state: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
89af74f420
message_viewport: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
a3507b8a11
message_util: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
52a992d858
message_edit_history: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
189865f427
localstorage: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
279d911420
lightbox: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
d235675a06
integration_url_modal: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
2642f521c1
hotspots: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
75eb9fb852
flatpickr: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
2e9b313333
dialog_widget: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
e9d0e43668
condense: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
9c6c09b6e0
compose_call: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
d1a2d42403
buddy_list: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7651a00566
blueslip: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
3c2fae1171
poll_data: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7f131b880d
billing: Document how to test different billing states.
2024-05-02 18:31:23 -07:00
23f0d6d93b
help: Mention SCIM has also been tested with EntraID.
...
With some edits from tabbott to show more confidence.
2024-05-02 18:12:21 -07:00
c31edca9cf
help: Tweak syntax in the instruction about API token in Okta doc.
...
The administrator fills out the API token field as e.g.
Bearer secret123
So let's write that as Bearer <token> to make it clear which part of
that expression is to be replaced.
2024-05-02 18:12:21 -07:00
eed98edb9d
help: Document configuration of SCIM with Microsoft Entra ID.
2024-05-02 18:12:21 -07:00
1ba3cda229
compose: Refactor recipient area to use grid layout instead of flexbox.
...
This is a prep commit for moving the narrow to compose recipients button
before the input, and also aids in the overall compose area redesign.
2024-05-02 14:28:04 -07:00
0a756c652c
push_notifications: Shard mobile push notifications.
2024-05-02 14:25:10 -07:00
572fbfe114
queue_processors: Pass the worker_num down into the class.
2024-05-02 14:25:10 -07:00
952291e712
migrations: Clean up non one-to-one confirmations/invites.
...
These models should be one-to-one. Various bugs in the past have
leaked violations in both directions; we clean them up such that every
PreregistrationUser which is not a multi-use invite has exactly one
Confirmation object associated with it.
Fixes : #22025
2024-05-02 14:23:04 -07:00
594e2823a7
invites: Use transactions more consistently.
2024-05-02 14:23:04 -07:00
9dfaa83aa8
invites: Remove invites worker, make confirmation object in-process.
...
The "invites" worker exists to do two things -- make a Confirmation
object, and send the outgoing email. Making the Confirmation object
in a background process from where the PreregistrationUser is created
temporarily leaves the PreregistrationUser in invalid state, and
results in 500's, and the user not immediately seeing the sent
invitation. That the "invites" worker also wants to create the
Confirmation object means that "resending" an invite invalidates the
URL in the previous email, which can be confusing to the user.
Moving the Confirmation creation to the same transaction solves both
of these issues, and leaves the "invites" worker with nothing to do
but send the email; as such, we remove it entirely, and use the
existing "email_senders" worker to send the invites. The volume of
invites is small enough that this will not affect other uses of that
worker.
Fixes : #21306
Fixes : #24275
2024-05-02 14:23:04 -07:00
512d53d01a
invites: Stop adjusting invited_at on resends.
2024-05-02 14:23:04 -07:00
d863aa56de
invites: Lock the realm when determining invitation counts.
...
This prevents users from hammering the invitation endpoint, causing
races, and inviting more users than they should otherwise be allowed
to.
Doing this requires that we not raise InvitationError when we have
partially succeeded; that behaviour is left to the one callsite of
do_invite_users.
Reported by Lakshit Agarwal (@chiekosec).
2024-05-02 14:23:04 -07:00
eef5d22944
invites: Make notify_invites_changed transaction-safe.
2024-05-02 14:23:04 -07:00
e48d5e4ad2
invites: Split out some functions from zerver.actions.invites.
...
This will avoid a circular dependency in future commits.
2024-05-02 14:23:04 -07:00
afafd04bf9
message_fetch: Increase message history fetching numbers.
...
Now that we've greatly reduced unnecessary data fetches, we have
greater freedom to increase these values while still having good
performance.
2024-05-02 13:59:19 -07:00
a7a89dcc72
message_fetch: Remove on-idle backfill behavior.
...
This only every did a single extra fetch, and now that this fetch is
in the same direction as our main fetching sequence, no longer is
meaningfully different from just specifying a different value of
consts.maximum_initial_backfill_size.
2024-05-02 13:55:17 -07:00
Sahil Batra
Karl Stolley
N-Shar-ma
Alya Abbott
Anders Kaseorg
Aman Agrawal
Mateusz Mandera
Tim Abbott
Alex Vandiver