zulip

Commit Graph

Author	SHA1	Message	Date
Greg Price	f686d55fa0	push-to-pull-request: Broaden one error message. I discovered this case just now while testing other changes.	2018-06-01 16:52:18 -07:00
Greg Price	954c71e90c	push-to-pull-request: Use `jq -r` to simplify a test slightly. This option (aka `--raw-output`) prints a string as itself, rather than JSON-encoded; which makes it fit a bit better in a shell script, saving us a layer of quoting.	2018-06-01 16:52:18 -07:00
Greg Price	8e81ca0fb2	push-to-pull-request: Fix regex usage in parsing remote. This replaces `ad4617c95` with a different fix for the same issue: instead of stripping the `.git` off separately, we can just correct the regex, using `+?` to fix our stepping in a classic regex pitfall.	2018-06-01 16:52:18 -07:00
Tim Abbott	60eae53327	push-to-pull-request: Provide better output for invalid PR. Previously, we were very confusingly showing the error message for permissions when the issue was a not-found error.	2018-06-01 16:00:27 -07:00
Tim Abbott	ad4617c953	push_to_pull_request: Fix handling of .git. This was throwing the "you can't access the repo" error for this reason.	2018-06-01 16:00:27 -07:00
Greg Price	5e89c33e7f	tools: Add push-to-pull-request tool. I've often done this by hand -- basically typed out the last line, with the variables found from looking at the PR page in a browser. Seems nicer for both us maintainers and the contributor, in particular because the PR gets marked as merged, instead of closed. But it's a bit of a pain, and I do it maybe half the time or less; plus it's kind of a subtle GitHub feature, and as a result I think other maintainers of Zulip repos do this approximately never. I've always figured this couldn't be hard to automate; today I decided to take the 45 minutes to look up how, write out the script, QA it, write up a nice usage message and some comments, and commit it. :)	2018-05-22 18:33:51 -07:00

6 Commits