push-to-pull-request: Provide better output for invalid PR.

Previously, we were very confusingly showing the error message for
permissions when the issue was a not-found error.
This commit is contained in:
Tim Abbott 2018-06-01 15:59:36 -07:00
parent ad4617c953
commit 60eae53327
1 changed files with 6 additions and 1 deletions

View File

@ -44,11 +44,16 @@ fi
# This is the old REST API; the new GraphQL API does look neat, but it
# seems to require authentication even for simple lookups of public data,
# and that'd be a pain for a simple script like this.
pr_details="$(curl -s https://api.github.com/repos/"$repo_fq"/pulls/"$pr_id")"
pr_url=https://api.github.com/repos/"${repo_fq}"/pulls/"${pr_id}"
pr_details="$(curl -s "$pr_url")"
pr_jq () {
echo "$pr_details" | jq "$@"
}
if [ "$(pr_jq .message)" = '"Not Found"' ]; then
echo "Invalid PR URL: $pr_url"
exit 1
fi
if [ "$(pr_jq .maintainer_can_modify)" != "true" ]; then
# This seems to be rare (in Greg's experience doing the manual