Arpith Siromoney
497c7702cc
Run eslint in tools/lint-all with npm run --silent lint
...
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.
To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.
npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.
Fixes #535 .
2016-11-18 16:15:45 -08:00
Tim Abbott
2d81813145
roadmap: Add buddy list scalability to agenda.
2016-11-18 15:58:08 -08:00
Tim Abbott
e302e2148b
docs: Update incorrect links to issues in roadmap docs.
2016-11-18 15:55:02 -08:00
Tim Abbott
fe837e58b4
test_realm_filters: Fix missing mypy annotation.
2016-11-17 20:29:06 -08:00
Tim Abbott
bbdd0ec08d
roadmap: The realm filters feature is merged.
2016-11-17 17:15:17 -08:00
Vladislav Manchev
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00
Steve Howell
8f96853fcb
presence: Convert presence_info to use user IDs.
...
When we filtered buddy lists, a recent change introduced some
bugs related to case-insensitive emails. We now circumvent the
bug by indexing presence_info with user_ids.
2016-11-17 13:27:28 -08:00
Tim Abbott
9c3d448fe4
compose: Clarify @-all errors are about mentions.
...
Every message to that stream goes to that number of users :).
2016-11-17 12:35:35 -08:00
paxapy
012ec2beda
test-backend: Use a fixed whitelist of shallow-tested templates.
...
This enforces the requirement that all templates not on this list are
tested. Part of #1677 .
2016-11-17 11:34:50 -08:00
Brock Whittaker
5d2b81358c
Code Simplification and Emoji Drag Fix.
...
There’s no need for four separate `$(sel).is()` statements, one will
do. This also added .drag to the list to ignore.
2016-11-17 11:21:15 -08:00
Brock Whittaker
2663215625
Do not close message compose box on drag.
...
On the drag to resize emoji box action, do not close the message
compose box.
2016-11-17 11:21:15 -08:00
bungeye
87c62a6937
Update twitter-bot to use latest python-twitter API.
2016-11-17 11:17:58 -08:00
Steve Howell
ca43cbc654
logging: Reducing logging in run-dev.py for queue workers.
...
In dev, we no longer log that individual queue workers were launched.
Instead, in dev (and prod as well), we log a message with the total
count.
2016-11-17 11:12:02 -08:00
hackerkid
cdb716aa63
bugdown: Add explanation for unicode-emoji JS regex.
2016-11-17 10:44:07 -08:00
Steve Howell
3a8282ff44
Add test coverage for /notify_tornado.
...
We now have test coverage for all of our endpoints.
2016-11-17 10:11:46 -08:00
Pweaver (Paul Weaver)
059cd1e7aa
tests: enable the pep8 linter in travis CI.
2016-11-17 00:11:00 -08:00
Pweaver (Paul Weaver)
8f05ea877d
lint: Fix pep8 linter error regressions.
...
Since `lint-all --pep8` wasn't running in CI, a few errors have leaked
in.
2016-11-17 00:09:21 -08:00
Steve Howell
82a497ec08
Remove spurious blueslip error for topic lists.
...
If we update an unread count for a topic that is not part of
our truncated list, we don't need to complain.
2016-11-16 22:01:30 -08:00
Tim Abbott
9fec519b3d
Zephyr: Remove obsolete mit.html template.
2016-11-16 17:33:42 -08:00
Tim Abbott
dde6452638
Zephyr: Fix links to the old zulip.com service.
2016-11-16 17:33:13 -08:00
Brock Whittaker
9582079cd9
edit: Fix "View source" icon being orphaned post-hover.
...
It turns out it wasn’t a one-liner, it was actually a -2-liner. :)
2016-11-16 14:03:54 -08:00
Steve Howell
3b594a6efa
bug fix: Keep old, active, upper-case topics in the topic list.
...
If you narrowed to a topic that was not one of the most recent 5
topics and had uppercase characters, it would disappear from the
topic list as soon as all of its messages were read.
2016-11-16 12:17:31 -08:00
Steve Howell
f4bf154981
bug fix: Fix topic unread counts for upper-case streams.
...
If stream names weren't entirely lowercase, then our function
topic_list.is_for_stream() was improperly reporting false and
failing to update unread counts for the active topic widget.
This regression was probably introduced in the fairly recent
53eea250d0
commit.
Fixes #2330 .
2016-11-16 10:08:44 -08:00
Tim Abbott
61816f6151
populate_db: Remove replay_old_messages code.
...
Now that we have the data import/export tool, that's a better
mechanism for importing data than this old and likely buggy code was.
2016-11-15 22:34:44 -08:00
Tim Abbott
6d4075cef9
docs: Extend our documentation of our documentation.
...
The main purpose of this effort is to document our new /help/ docs,
but we update a bunch of other stuff while we're at it.
2016-11-15 22:01:44 -08:00
Tim Abbott
e6f4cb2635
attachment: Remove DB limit on length of filenames.
...
This fixes an issue where we threw on error on files with long names.
2016-11-15 21:12:05 -08:00
Christie Koehler
391ff638d5
build_emoji: Add nice error message for symlink errors.
2016-11-15 21:10:39 -08:00
Christie Koehler
2488698430
provision: Add symlink creation check.
...
This helps automatically detect a common issue where users try to use
the Vagrant development environment on windows without administrator
permissions, which results in errors trying to create symlinks.
2016-11-15 21:10:39 -08:00
Feorlen
d56272a162
docs: Explain how the HTML webhook documentation is used.
...
Part of #1998 .
2016-11-15 21:00:16 -08:00
Feorlen
e45c10884e
docs: Fix typo and whitespace.
2016-11-15 21:00:16 -08:00
Feorlen
d8afc306ee
docs: Clarify that HelloWorldHookTests is subclassing WebhookTestCase.
...
Part of #1998 .
2016-11-15 21:00:15 -08:00
Feorlen
ed61d3086d
docs: Describe what an API key is and how to get one.
...
Part of #1998 .
2016-11-15 20:59:43 -08:00
Feorlen
113b2b39fb
docs: Describe what a test fixture is.
...
Part of #1998 .
2016-11-15 20:59:39 -08:00
Feorlen
4725a7b7de
docs: Describe what a webhook is.
...
Part of #1998 .
2016-11-15 20:58:39 -08:00
Tim Abbott
fa8480bb62
subdomains: Add option to make subdomains homepage not a login form.
2016-11-15 19:05:06 -08:00
Steve Howell
9eb825fff5
Refactor PM unread counts to use user_ids as keys.
...
We now use comma-delimited lists of user_ids for the following
data structures in unread.js:
- unread_privates[<user_ids_string>]
- get_counts.pm_count[<user_ids_string>]
2016-11-15 18:31:59 -08:00
Steve Howell
1783879108
people.js: Add methods for user_ids_string/emails_string.
...
Added:
* people.user_ids_string_to_emails_string
* people.emails_strings_to_user_ids_string
2016-11-15 18:31:59 -08:00
Steve Howell
7750d43d23
Simplify finding elements in pm_list.js.
...
We no longer need iterate_to_find, and we just use simpler
selectors.
2016-11-15 18:31:59 -08:00
Steve Howell
f5e1dcd11d
buddy list: Sidebar menu now uses user_id, not email.
2016-11-15 18:31:59 -08:00
paxapy
b90057d557
render_messages.py: render first version of edited messages.
...
This decreases the number of spurious differences in rendered content
significantly.
2016-11-15 13:39:11 -08:00
reyha
9f8630fed8
tests: Access realms by string_id.
...
Replaces get_realm() function by get_realm_by_string_id() function
in zerver/tests.
Fixes #2226 .
2016-11-15 13:32:20 -08:00
Tim Abbott
49d24cee2a
subs: Fix clearing filter table on subscribe.
2016-11-15 12:49:40 -08:00
Tim Abbott
86fbc415b9
docs: Fix typo in roadmap reactions item.
2016-11-15 12:27:27 -08:00
Brock Whittaker
3d8ed7b55f
subs: Rewrite Stream Filter Function.
...
This is more performant, along with accepting a parameter for
filtering only streams that are subscribed to if the toggle is set to
subscribed only.
Also, it now does substring matches, rather than just matching if an
entire word matches the search query.
Fixes #2141 .
2016-11-15 12:21:43 -08:00
Brock Whittaker
1def0b6701
hashchange: Add hashchange ignore mechanism for overlays.
...
This will make it possible to do hash changes in soon-to-be-overlay
pages like the /#subscriptions and /#settings page.
2016-11-15 11:53:38 -08:00
Tomasz Kolek
074571dddc
Fix English grammar in push/remove tag message.
2016-11-15 10:48:12 -08:00
Tomasz Kolek
1feedbe346
Add github webhook integration.
2016-11-15 10:48:12 -08:00
Tomasz Kolek
2335e1b8b9
Add escaping charactes (=,>,<) by checking correct spelling of GitHub word
2016-11-15 10:48:12 -08:00
Brock Whittaker
75db036733
Add toggle component.
...
This adds the toggle component which removes the necessity to have HTML.
2016-11-15 10:20:37 -08:00
Tim Abbott
a960ff6773
requirements: Update cryptography packages.
2016-11-15 10:13:51 -08:00